D19534: [i18n] compile without foreach

sh-zam reopened this revision. sh-zam added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > CMakeLists.txt:74 > add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x050d00) > +add_definitions(-DQT_NO_FOREACH) > Removing this line is doesn't allow build to succe

D19534: [i18n] compile without foreach

sh-zam added inline comments. INLINE COMMENTS > sh-zam wrote in CMakeLists.txt:74 > Removing this line is doesn't allow build to succeed, I had to comment this > line to make it successful. > > My build log: F6659392: build.log > I am using build_kf5.sh >

D19534: [i18n] compile without foreach

sh-zam added a comment. The latest commit is working now. Thanks for helping REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D19534 To: mlaurent, dfaure Cc: kossebau, sh-zam, kde-frameworks-devel, michaelh, ngraham, bruns

D19697: Fixes the build failure when using ECM Android toolchain

sh-zam created this revision. Herald added a project: Frameworks. sh-zam requested review of this revision. REVISION SUMMARY ECM Android toolchain: https://phabricator.kde.org/source/extra-cmake-modules/browse/master/toolchain/Android.cmake Build failure log: https://paste.ubuntu.com/p/NBjfYX

D19697: Fixes the build failure when using ECM Android toolchain

sh-zam added a comment. Removing them doesn't help either. We could use conditionals, but then I was using API 21 and it failed with that. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabr

D19697: Fixes the build failure when using ECM Android toolchain

sh-zam added a comment. Yes, that is confusing. I tried recreating the CI system, but it still doesn't compile. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19697 To: sh-zam Cc: vkrause, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D19697: Fixes the build failure when using ECM Android toolchain

sh-zam added a comment. When using `API >= 26`, it doesn't find the enclosed functions, so we will have to make them non-static in that case. PS: Making them non-static doesn't break tests. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19697 To: sh-zam C

D19697: Fixes the build failure when using ECM Android toolchain

sh-zam added a comment. I tested it against Android NDK's toolchain and it built fine. So, probably an issue with `ECM/toolchain/Android.cmake` REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19697 To: sh-zam Cc: vkrause, apol, kde-frameworks-devel, michaelh, ng

D19697: Fixes the build failure when using ECM Android toolchain

sh-zam abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19697 To: sh-zam Cc: vkrause, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

sh-zam created this revision. Herald added projects: Frameworks, Build System. Herald added a subscriber: kde-buildsystem. sh-zam requested review of this revision. REVISION SUMMARY Don't include same dependency twice, one which was found from `readelf` in `specifydependencies.cmake` and other

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

sh-zam updated this revision to Diff 56151. sh-zam added a comment. minor typo fixed REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20509?vs=56146&id=56151 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20509 AFFECTED FILES

D20558: Bug fix: find c++ stl using regex

sh-zam created this revision. sh-zam added a reviewer: apol. Herald added projects: Frameworks, Build System. Herald added a subscriber: kde-buildsystem. sh-zam requested review of this revision. REVISION SUMMARY Find C++ shared lib path using regex. This change makes finding path independent

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

sh-zam updated this revision to Diff 56244. sh-zam added a comment. improved name and code flow REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20509?vs=56151&id=56244 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20509 AFFECT

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

sh-zam marked 2 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20509 To: sh-zam, apol, vkrause Cc: kde-buildsystem, kde-frameworks-devel, bencreasy, michaelh, ngraham, bruns

D20558: Bug fix: find c++ stl using regex

sh-zam added a comment. Can we add a `cmake_minimum_required` to `3.7`? Regex fails to compile on older versions, when run outside of `Android.cmake`. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20558 To: sh-zam, apol Cc: kde-buildsystem, kde-framewo

D20509: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

This revision was automatically updated to reflect the committed changes. Closed by commit R240:24538afeaf61: Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix (authored by sh-zam). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20509?vs=56244&

D20558: Bug fix: find c++ stl using regex

sh-zam added a comment. > Why are you using it without Android.cmake? I am building Krita and to add `create-apk` target I am using `include (ECMAndroidDeployQt.cmake)`, I can't use `Android.cmake` because of some variables as it expects to run as a toolchain. Later today, I will su

D20558: Bug fix: find c++ stl using regex

sh-zam updated this revision to Diff 56257. sh-zam added a comment. - disallow whitespaces in path REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20558?vs=56243&id=56257 BRANCH arcpatch-D20558 REVISION DETAIL https://phabricator.kde.org/D2

D20558: Bug fix: find c++ stl using regex

sh-zam updated this revision to Diff 56311. sh-zam added a comment. - disallow whitespaces in path REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20558?vs=56257&id=56311 BRANCH arcpatch-D20558 REVISION DETAIL https://phabricator.kde.org/D2

D20558: Bug fix: find c++ stl using regex

sh-zam added inline comments. INLINE COMMENTS > apol wrote in ECMAndroidDeployQt.cmake:43 > This looks quite awful. Why do you prefer using regex to string(FIND)? It > could be something like > `string(FIND "${VALUE}" "c++.so\"" OUT)` if you want to be more specific. Because `string (FIND ..)`

D20558: Bug fix: find c++ stl using regex

sh-zam added a comment. > What does it mean that "it expects to run as a toolchain"? Sorry, I didn't notice this. On this line get_filename_component(_CMAKE_ANDROID_DIR "${CMAKE_

D20558: Bug fix: find c++ stl using regex

This revision was automatically updated to reflect the committed changes. Closed by commit R240:307b36662ec9: Bug fix: find c++ stl using regex (authored by sh-zam). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20558?vs=56311&id=56445 REVISION D

D20558: Bug fix: find c++ stl using regex

sh-zam added a comment. well.. I couldn't get it running as a toolchain and kept running into errors. I can give it another hit, though. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D20558 To: sh-zam, apol Cc: kde-buildsystem, kde-frameworks-devel,