shubham updated this revision to Diff 35683.
shubham added a comment.
I believe this is the final patch.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13365?vs=35643=35683
REVISION DETAIL
https://phabricator.kde.org/D13365
AFFECTED FILES
src
shubham added a comment.
In D13365#274589 <https://phabricator.kde.org/D13365#274589>, @brauch wrote:
> The change is good now but you screwed up the patch: you need to submit the
full set of changes you want to do as a patch, not only the last iteration. Can
you fix th
shubham added a comment.
Thank you Brauch for your quick reply.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13365
To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh,
kevinapavew, bruns
shubham added a comment.
And about the column thing, does it have any importance rather than just
telling the number of characters in the current line?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham
shubham added a comment.
Cullman , I just got intimidated by what and all is to be added, but no
problem I will do it anf if doubt arises will ask it to you
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc
shubham added a comment.
Can I make "show word count" checkbox as "show word count and total lines"?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel,
shubham updated this revision to Diff 35886.
shubham added a comment.
hopefully this is the final patch.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13442?vs=35881=35886
REVISION DETAIL
https://phabricator.kde.org/D13442
AFFECTED FILES
src/view
shubham added a comment.
Cullman I didnt get you, do u want a display for max column, isnt the maximum
column same as opposed to line.Is it req?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham
shubham added a comment.
Should I display it as a fraction or leave it, having mixed reactions
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh
shubham added a comment.
I'm finding it difficult to implement it , can you help?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh,
kevinapavew
shubham added a comment.
Now I understood,since i,m a novice can you tell how can that configuration
option be implemented?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde
shubham added a comment.
Thank you cullman, will try to finish it.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh,
kevinapavew, bruns, demsking
shubham added a comment.
I'm unable to apply this patch, dont know why
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh,
kevinapavew, bruns
shubham added a comment.
I think the "of .." part is so small it wont bother anyone ,
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel
shubham added a comment.
How can the self toggling be done based on the space available?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel
shubham added a comment.
The "of " is mere couple of alphabets, does this takes space on the bar and
annoys, I dont think so, in my view
it should be by default,what u say cullmann?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
T
shubham added a comment.
Oh, didnt come to me that of part when translated to other languages may
result in longer texts, so this configure option is to be received and context
menu is to be added?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
shubham added a comment.
In D13442#277786 <https://phabricator.kde.org/D13442#277786>, @ngraham wrote:
> I'm not sure how to do that, and I realize it might be a lot of work.
>
> In D13442#277600 <https://phabricator.kde.org/D13442#277600>, @shubham
wrote:
>
shubham added a comment.
Since the word count option is similar to line count in the config options,
can't I just show word count and line count with a single button option?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor
shubham updated this revision to Diff 36019.
shubham added a comment.
This patch implements the config option for the display of total lines in a
document.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13442?vs=35886=36019
REVISION DETAIL
https
shubham edited reviewers, added: cullmann; removed: KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, cullmann, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsking, head7, cullmann, kfunk
shubham created this revision.
shubham added a reviewer: KTextEditor.
shubham created this object with visibility "All Users".
shubham added a project: KTextEditor.
Restricted Application added projects: Kate, Frameworks.
Restricted Application added subscribers: kde-frameworks-devel, kw
shubham edited reviewers, added: KTextEditor; removed: cullmann.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsking, head7, cullmann, kfunk, sars
shubham added reviewers: cullmann, ngraham.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, ngraham
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsking, head7, cullmann, kfunk, sars
shubham edited reviewers, added: brauch; removed: ngraham.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsking, head7, cullmann
shubham added a comment.
As you wish , will implement in the next patch
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsking
shubham updated this revision to Diff 35881.
shubham added a comment.
This should be fine?
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13442?vs=35872=35881
REVISION DETAIL
https://phabricator.kde.org/D13442
AFFECTED FILES
src/view
shubham added a comment.
In D13442#276202 <https://phabricator.kde.org/D13442#276202>, @brauch wrote:
> Since the other two number displays use QLocale().toString(), probaly this
should too ...
Is it mandatory?
REPOSITORY
R39 KTextEditor
REVISION DETAI
shubham added a comment.
Will change that too
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsking, head7, cullmann, kfunk, sars
shubham created this revision.
shubham created this object with visibility "All Users".
shubham added a project: Kate.
Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel.
Restricted Application added a project: Frameworks.
shubham requested review of thi
shubham added a comment.
This patch will fix the Bug:391518
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13365
To: shubham, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsking, cullmann, sars, dhaumann
shubham added a reviewer: KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13365
To: shubham, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,
demsking, cullmann, sars, dhaumann
shubham added a comment.
In D13365#274370 <https://phabricator.kde.org/D13365#274370>, @brauch wrote:
> Good find (annoyed me too) and sounds plausible to me. Thanks!
>
> Just one thing, do you call setRenderHint() inside the save() / restore()
pair of the painter
shubham retitled this revision from "BUG:391518 Fixed the cursor(caret) width
in kate" to "Fixed the cursor(caret) width in kate".
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13365
To: shubham, #ktexteditor
Cc: ngraham, brauch, kwrite-devel,
shubham updated this revision to Diff 35643.
shubham added a comment.
In this updated diff, setRenderHint() is called in between the pair of save()
and restore() functions so as to save painter's previous state and achieve
better painting quality.
REPOSITORY
R39 KTextEditor
CHANGES SINCE
shubham added a comment.
In D13365#274453 <https://phabricator.kde.org/D13365#274453>, @brauch wrote:
> Yep, with that, it looks good to me. Do you have commit access?
Thank you for committing it on my behalf
REPOSITORY
R39 KTextEditor
REVISION DETAI
shubham added a comment.
In D13365#274460 <https://phabricator.kde.org/D13365#274460>, @cullmann wrote:
> Yep, looks nice!
Thank you for accepting the patch.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13365
To: shubham, #ktextedito
shubham added a comment.
In D13365#275130 <https://phabricator.kde.org/D13365#275130>, @brauch wrote:
> I'm sorry I am so annoying, but iirc KDE's commit hooks will not accept
commits with only one name fragment. Something equivalent to the western
first/last name pair is
shubham added a comment.
Thank you Brauch for committing it on my behalf.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13365
To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh,
kevinapavew
shubham added a comment.
In D13365#274965 <https://phabricator.kde.org/D13365#274965>, @brauch wrote:
> To submit the change with your name on it, I'd need a full name and email
address, can you provide that? Thanks!
Name: Shubham
Mail: aryan100jan...@gmail.com
R
shubham added a comment.
Cullman,brauch,dhaumann : can you please tell how to have a context menu?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel
shubham added a comment.
You want a context menu which opens when right clicked on the status bar or
the editor?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann
shubham added a comment.
Okay fine
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D13442
To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel,
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking
shubham added a comment.
pino, I understood your idea of having a helper class function, but the
condition for editing the icon will remain the same ( based on its scheme),
what can be the other condition?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
shubham removed a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
To: shubham, ngraham, broulik, #dolphin, #frameworks, pino, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham added a comment.
indirectly you mean to transfer all the logic to helper function
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham updated this revision to Diff 38637.
shubham added a comment.
Add getter for icon's editability
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14360?vs=38633=38637
REVISION DETAIL
https://phabricator.kde.org/D14360
AFFECTED FILES
src/filewidgets
shubham added a comment.
pino: suppose this function is created(canEditIcon()),then this function must
also be called when we are creating the m_iconButton at line 123 so as to
generalize it's creation ( as you had said to take into account other entries
also if they are also
shubham updated this revision to Diff 38633.
shubham added a comment.
Check before getting the icon, whether it's editable or not
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14360?vs=38524=38633
REVISION DETAIL
https://phabricator.kde.org/D14360
shubham added a comment.
okay, then it's fine
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham updated this revision to Diff 38784.
shubham added a comment.
Remove unintentional " "(that was silly)
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14449?vs=38740=38784
REVISION DETAIL
https://phabricator.kde.org/D14449
AFFECTED F
shubham added a comment.
In D14449#300841 <https://phabricator.kde.org/D14449#300841>, @dhaumann wrote:
> I think it looks visually distracting that one progress bar line ends up in
two lines of text - this should be avoided.
>
> To behonest, the suggestion by @ngr
shubham created this revision.
shubham added reviewers: elvisangelaccio, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.
REVISION SUMMARY
BUG: 334263
TEST PLAN
1. Goto
shubham added a comment.
F6159605: Screenshot_20180729_112335.png
<https://phabricator.kde.org/F6159605>: SS
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14449
To: shubham, elvisangelaccio, ngraham
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
shubham added a comment.
no problem
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14449
To: shubham, elvisangelaccio, ngraham, #frameworks
Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
shubham added a comment.
In D14449#300147 <https://phabricator.kde.org/D14449#300147>, @rkflx wrote:
> In D14449#300086 <https://phabricator.kde.org/D14449#300086>, @ngraham
wrote:
>
> > Device capacity: 94.4 Gib
> > Device usage:==-- 24%
shubham updated this revision to Diff 38824.
shubham added a comment.
made above requested changes
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14360?vs=38637=38824
REVISION DETAIL
https://phabricator.kde.org/D14360
AFFECTED FILES
src/filewidgets
shubham updated this revision to Diff 38524.
shubham added a comment.
Creating m_iconButton only for entries other than TRASH
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14360?vs=38468=38524
REVISION DETAIL
https://phabricator.kde.org/D14360
AFFECTED
shubham added a comment.
pino: I mean the very same m_iconButton is common to all other places entries
like root,home etc, we are just creating it depending on whether it is trash or
not
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
To: shubham, ngraham
shubham updated this revision to Diff 38468.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14360?vs=38452=38468
REVISION DETAIL
https://phabricator.kde.org/D14360
AFFECTED FILES
src/filewidgets/kfileplaceeditdialog.cpp
To: shubham, ngraham, broulik
shubham added a comment.
pino: I don't why m_iconButton isn't needed(because it is being used by other
entries also ), am I right?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
To: shubham, ngraham, broulik, #dolphin, #frameworks
Cc: pino, kde-frameworks-devel
shubham added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
To: shubham, ngraham, broulik, #dolphin, #frameworks, dfaure
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham added a comment.
@cfeck agree with you(it's just a helper)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
To: shubham, ngraham, broulik, #dolphin, #frameworks, pino
Cc: cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham added a comment.
In D14360#301252 <https://phabricator.kde.org/D14360#301252>, @ngraham wrote:
> Almost there! Please implement cfeck's suggestion for additional
documentation for this function in the header file, in particular describing
why come icons might not be
shubham updated this revision to Diff 38868.
shubham added a comment.
revert back
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14360?vs=38852=38868
REVISION DETAIL
https://phabricator.kde.org/D14360
AFFECTED FILES
src/filewidgets
shubham updated this revision to Diff 38852.
shubham added a comment.
Remove helper function isIconEditable() (wasn't required), the check can
directly be carried out in if clause for dialog->m_iconButton
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14
shubham created this revision.
shubham added reviewers: rkflx, dfaure, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.
REVISION SUMMARY
T9297 <https://phabricator.kde.
shubham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14610
To: shubham, rkflx, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
shubham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14610
To: shubham, rkflx, dfaure, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
shubham retitled this revision from "Use KLineEdit if folder has write access,
else use QLabel" to "Use KLineEdit for folder name if folder has write access,
else use QLabel".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14610
To: shubham, rkflx
shubham created this revision.
shubham added reviewers: ngraham, cfeck.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.
REVISION SUMMARY
Can not return a reference in private API
shubham updated this revision to Diff 39082.
shubham retitled this revision from "Make KLineEdit read only if write access
is denied" to "Use KLineEdit if folder has write access, else use QLabel".
shubham edited the summary of this revision.
shubham edited the test pl
shubham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14609
To: shubham, ngraham, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
shubham updated this revision to Diff 39097.
shubham added a comment.
Remove **cons**t
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14609?vs=39078=39097
REVISION DETAIL
https://phabricator.kde.org/D14609
AFFECTED FILES
src/filewidgets
shubham added a reviewer: broulik.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14609
To: shubham, ngraham, cfeck, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
shubham added a comment.
> Not if you set a maximum width.
@rkflx eeh, skipped from my mind
btw , then it is doable
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14449
To: shubham, elvisangelaccio, ngraham, #frameworks
Cc: rkflx, dhaumann, kde-frameworks-de
shubham added a comment.
using arc land --rev id, arc gives error saying Audit Failure : Non full name
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14609
To: shubham, ngraham, cfeck, broulik
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
shubham updated this revision to Diff 39112.
shubham added a comment.
Re-use Qlabel
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14610?vs=39082=39112
REVISION DETAIL
https://phabricator.kde.org/D14610
AFFECTED FILES
src/widgets/kpropertiesdialog.cpp
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:65f56f12aa7f: Do not return reference (authored by
shubham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14609?vs=39097=39099
REVISION DETAIL
https
shubham added a comment.
> Let me plug my suggestion again:
>
> Device capacity: ==- 24% used of 94.4 Gib
>22.5 GiB used, 71.9 GiB free
>
if this design is used , then the capacity bar would look elongated and
stretched, which doe
shubham updated this revision to Diff 39120.
shubham added a comment.
F6176187: 2.png <https://phabricator.kde.org/F6176187>
@rkflx is this okay now?
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14449?vs=38784=39120
REVISION DETAIL
shubham edited reviewers, added: rkflx; removed: elvisangelaccio.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14449
To: shubham, ngraham, #frameworks, rkflx, elvisangelaccio
Cc: rkflx, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
shubham added a comment.
In D14449#303710 <https://phabricator.kde.org/D14449#303710>, @rkflx wrote:
> - The vertical spacing between the first and the second line is too big, it
should be the same as for Size:.
is there any other simpler way to achieve this?
INLINE
shubham added a comment.
In D14449#300327 <https://phabricator.kde.org/D14449#300327>, @ngraham wrote:
> +1 for using the same label but putting the information on more than one
line like @rkflx suggests.
sorry for causing trouble : (
REPOSITORY
R241 KIO
REVISI
shubham added a comment.
In D14610#303706 <https://phabricator.kde.org/D14610#303706>, @rkflx wrote:
> In D14610#303537 <https://phabricator.kde.org/D14610#303537>, @rkflx wrote:
>
> > `KPropertiesDialog::setFileNameReadOnly`
> > `m_bFromTemplate`
&
shubham added a comment.
In D14360#302141 <https://phabricator.kde.org/D14360#302141>, @cfeck wrote:
> Well, I had to look up your 'previous contributions' page to find your full
name and mail address, and I would say given your rate of submits it makes
sense to apply for a
shubham added a comment.
In D14360#302306 <https://phabricator.kde.org/D14360#302306>, @cfeck wrote:
> I just noticed that this header says "const QString () const;" i.e. we
return a reference to a string. Assuming this API is really not public, it
probably needs to
shubham added a comment.
In D14360#302343 <https://phabricator.kde.org/D14360#302343>, @cfeck wrote:
> In D14360#302335 <https://phabricator.kde.org/D14360#302335>, @shubham
wrote:
>
> > can I give your name as supporter for KDE developer account application
shubham added a comment.
@anthonyfieroni righty said , strictly it should return T/F
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
To: shubham, ngraham, broulik, #dolphin, #frameworks, pino
Cc: anthonyfieroni, cfeck, pino, kde-frameworks-devel, michaelh, ngraham
shubham updated this revision to Diff 38913.
shubham added a comment.
remove @since tag,
return m_iconButton != nullptr
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14360?vs=38868=38913
REVISION DETAIL
https://phabricator.kde.org/D14360
AFFECTED FILES
shubham added a comment.
ping?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
To: shubham, ngraham, broulik, #dolphin, #frameworks, pino
Cc: cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns
shubham added a comment.
@dfaure is this patch okay
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
To: shubham, ngraham, broulik, #dolphin, #frameworks, pino
Cc: dfaure, anthonyfieroni, cfeck, pino, kde-frameworks-devel, michaelh,
ngraham, bruns
shubham updated this revision to Diff 38927.
shubham added a comment.
Fix typos
return m_iconButton
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14360?vs=38913=38927
REVISION DETAIL
https://phabricator.kde.org/D14360
AFFECTED FILES
src/filewidgets
shubham added a comment.
@dfaure I don't have commit access
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
To: shubham, ngraham, broulik, #dolphin, #frameworks, pino, dfaure
Cc: dfaure, anthonyfieroni, cfeck, pino, kde-frameworks-devel, michaelh,
ngraham, bruns
shubham updated this revision to Diff 38740.
shubham retitled this revision from "Display used space in GiB also" to "Modify
device usage information".
shubham added a comment.
F6162515: Screenshot_20180730_113005.png
<https://phabricator.kde.org/F6162515> Looks
shubham added a comment.
ping?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14360
To: shubham, ngraham, broulik, #dolphin, #frameworks, pino
Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e2c56f6ddc51: Use KLineEdit for folder name if folder has
write access, else use QLabel (authored by shubham).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14610?vs
shubham updated this revision to Diff 39163.
shubham added a comment.
Re factor
Remove unnecessary indentations
use only !itemList.supportsMoving()
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14610?vs=39112=39163
REVISION DETAIL
https
shubham updated this revision to Diff 39164.
shubham added a comment.
Add check for bFromTemplate
simplify expression (!d->m_bFromTemplate && !itemList.supportsMoving()) to
!(d->m_bFromTemplate || itemList.supportsMoving()) for better readability
REPOSITORY
R241 KIO
CHAN
shubham added a reviewer: cfeck.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14757
To: shubham, pino, dfaure, cfeck
Cc: dfaure, pino, kde-frameworks-devel, michaelh, ngraham, bruns
1 - 100 of 385 matches
Mail list logo
