D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

bruns added a comment. please remove the 2 comments. REPOSITORY R245 Solid BRANCH arcpatch-D21204 REVISION DETAIL https://phabricator.kde.org/D21204 To: meven, bruns, #frameworks, ngraham Cc: broulik, dhaumann, anthonyfieroni, ngraham, bruns, apol, kde-frameworks-devel, LeGast00n,

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

bruns accepted this revision. bruns added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > fstabhandling.cpp:246 > +if (deviceName.endsWith(QLatin1Char('/'))) { > +// remove trailing slash > +deviceName.chop(1); This comment is

D25934: [xattr] Fix passing negative size to QByteArray

bruns added a comment. Duplicate of D25414 REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25934 To: anthonyfieroni, bruns, astippich Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2,

D25414: xattr: fix crash on dangling symlinks

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH fix_symlink REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n,

D25516: Remove unrequired private declarations for taglibextractor

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH cleanupTagLib REVISION DETAIL https://phabricator.kde.org/D25516 To: astippich, #baloo, bruns, ngraham, mgallien Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n,

D25789: Correctly report if baloo_file is unavailable

bruns added inline comments. INLINE COMMENTS > monitor.cpp:67 > m_balooRunning = false; > QDBusServiceWatcher* balooWatcher = new > QDBusServiceWatcher(m_scheduler->service(), > m_bus, The watcher should be

D25622: partial solution to accept accentuated characters on windows

bruns added a reviewer: Windows. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25622 To: mgallien, bruns, #windows Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D25583: Quit baloo_file_extractor if DB transaction fails

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Please allow some time for reviewing ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven,

D25515: Only extract lyrics when the plain text flag is set

bruns added a comment. The dolphin temp extractor uses `KFileMetaData::ExtractionResult::ExtractMetaData` explicitly. Though in general I agree (and "PlainText" should be better named "FullText"). REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25515 To:

D25516: Remove unrequired private declarations for taglibextractor

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > taglibextractor.cpp:105 > > -void TagLibExtractor::readGenericProperties(const TagLib::PropertyMap > , ExtractionResult* result) > +void

D25517: Add an option to extract binary data and add front cover property

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > extractionresult.h:61 > + */ > +ExtractBinaryData = 4, > +ExtractEverythingIncludingBinary = (ExtractEverything | > ExtractBinaryData),

D25443: [chmodjob] Port away from QLinkedList

bruns added a comment. Or just change the direction? INLINE COMMENTS > chmodjob.cpp:115 > { > Q_Q(ChmodJob); > while (!m_lstItems.isEmpty()) { For efficiency, probably do a `m_infos.reserve(m_infos.capacity() + m_lstItems.size());` here. > chmodjob.cpp:155 >

D25421: [file_extractor] improve log message when the database can't be opened

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. This is obviously the wrong line of code for the referenced bug report. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25421 To: ahmadsamir, #baloo,

D25414: xattr: fix crash on dangling symlinks

bruns added inline comments. INLINE COMMENTS > usermetadatawritertest.cpp:44 > +QFile tempTarget(testFilePath("temporal_target")); > +tempTarget.link(testFilePath(TEST_SYMLINK)); > +tempTarget.remove(); You can just use the static overload and provide an invalid target name.

D25414: xattr: fix crash on dangling symlinks

bruns added a comment. Also add a testcase covering this, autotests/usermetadatawritertest.cpp REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n,

D25414: xattr: fix crash on dangling symlinks

bruns added a comment. wrap the summary at <80 characters REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D25414: xattr: fix crash on dangling symlinks

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25414 To: iasensio, astippich, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas,

D25414: xattr: fix crash on dangling symlinks

bruns added inline comments. INLINE COMMENTS > xattr_p.h:228 > > +if (size == -1 && errno == ENOENT) { > +return UserMetaData::Attribute::None; if (size < 0) { if (errno == E2BIG) { return UserMetaData::Attribute::All; } return

D21235: Add handling of fuseiso filesystem type

bruns added a comment. Moving it to a separate class will also make creating a unit test trivial. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21235 To: hallas, bruns, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fstabhandling.cpp:301 > + > +void Solid::Backends::Fstab::FstabHandling::parseMtabFile(const QString& > mtabPath, QMultiHash& activeMounts, QHash QString>&

D24959: Add new preferences search icons

bruns accepted this revision. REPOSITORY R266 Breeze Icons BRANCH newSearchIcon REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham, trickyricky26, bruns Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D23787: [baloo_file_extractor] Improve handling of large plain-text files

bruns added a comment. In D23787#541963 , @poboiko wrote: > In D23787#537891 , @bruns wrote: > > > Can you please provide an example which: > > > > - is currently indexed though it should be

D23787: [baloo_file_extractor] Improve handling of large plain-text files

bruns added a comment. In D23787#541963 , @poboiko wrote: > > and another example which: > > > > - is currently skipped though it should be indexed > > - is indexed after this change > > There shouldn't be any. I mean,

D24433: Move URL parsing methods from kioslave to query object

bruns added a subscriber: broulik. bruns added inline comments. INLINE COMMENTS > kio_search.cpp:88 > -return jsonQueryForType(QStringLiteral("Document")); > -} else if (path.endsWith(QLatin1String("/images"))) { > -return jsonQueryForType(QStringLiteral("Image")); @broulik

D24433: Move URL parsing methods from kioslave to query object

bruns added inline comments. INLINE COMMENTS > query.cpp:317 > +{ > +const QString jsonQuery(QStringLiteral("{\"dayFilter\": 0,\ > + \"monthFilter\": 0, \ dayFilter/monthFilter/yearFilter are pointless, as they just default, but have to be parsed

D21004: [UserMetaData] Shortcut attribute queries for the common case

This revision was automatically updated to reflect the committed changes. Closed by commit R824:4fdb2048f25d: [UserMetaData] Shortcut attribute queries for the common case (authored by bruns). REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE

D21004: [UserMetaData] Shortcut attribute queries for the common case

bruns updated this revision to Diff 69416. bruns edited the summary of this revision. bruns added a comment. KF5_MIN_VERSION bump to 5.60 REPOSITORY R824 Baloo Widgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21004?vs=57507=69416 BRANCH arcpatch-D21004 REVISION DETAIL

D24958: Delete nepomuk icon

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH deleteNepomuk REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24957: Add new baloo icons

bruns added a comment. LGTM REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24959: Add new preferences search icons

bruns added a comment. Thats the "top level" icon, with "Krunner" and "File Search" (aka Baloo) below, correct? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D21235: Add handling of fuseiso filesystem type

bruns added inline comments. INLINE COMMENTS > fstabhandling.cpp:301 > + > +QStringList Solid::Backends::Fstab::FstabHandling::currentMountPoints(const > QString ) > +{ Please keep these functions at their current position, just adds unnecessary noise in the diff. REPOSITORY R245 Solid

D21235: Add handling of fuseiso filesystem type

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > hallas wrote in fstabdevice.cpp:56 > This implements a crude parser of the fuseiso mtab file. I can't use the > regular getmnt suite of functions to retrieve

D19088: Use propertymap to store properties in Baloo::Result

This revision was automatically updated to reflect the committed changes. Closed by commit R293:4f131981493b: Use propertymap to store properties in Baloo::Result (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19088?vs=51887=67815#toc REPOSITORY R293 Baloo

D19087: Add standalone conversion functions for PropertyMap to Json and vice versa

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ecebbf85dc91: Add standalone conversion functions for PropertyMap to Json and vice versa (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D24502: Replace recursion in FilteredDirIterator with loop iteration

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3319b6656043: Replace recursion in FilteredDirIterator with loop iteration (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24502?vs=67506=67569

D24492: [FilteredDirIterator] Reduce stack pressure

bruns added a comment. In D24492#543641 , @hurikhan77 wrote: > Let me change that into a proper loop. See D24502 REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24492 To:

D24502: Replace recursion in FilteredDirIterator with loop iteration

bruns added reviewers: ngraham, astippich. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24502 To: bruns, #baloo, ngraham, astippich Cc: kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D24502: Replace recursion in FilteredDirIterator with loop iteration

bruns created this revision. bruns added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case many consecutive files are skipped in a directory, the recursive next()

D23411: Fix crash in writer collection and cleanup

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH fixWriterCollection REVISION DETAIL https://phabricator.kde.org/D23411 To: astippich, bruns, mgallien, ngraham Cc: apol, kde-frameworks-devel, #baloo, lots0logs, LeGast00n,

D23787: [baloo_file_extractor] Improve handling of large plain-text files

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Can you please provide an example which: - is currently indexed though it should be skipped due to size - is skipped after this change and another example which: -

D21235: Add handling of fuseiso filesystem type

bruns added a comment. In D21235#535861 , @hallas wrote: > I have been resurrecting this patch again :) and have run into an issue I need some guidance on. To be able to parse the `~/.mtab.fuseiso` file I would like to use the `KMountPoint`

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

bruns added inline comments. INLINE COMMENTS > fstabhandling.cpp:240 > +continue; > +} else { > +// deviceName will or won't end with / depending if device ended > with one No need to put this in `.. else {` after `continue` REPOSITORY R245 Solid REVISION

D21204: Ensure mounted nfs filesystems matches their fstab declared counterpart

bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fstabhandling.cpp:236 > +auto device = it.key(); > +QString deviceName = device; > +if (deviceName.endsWith(QLatin1Char('/'))) { You

D23420: Use solid to check if a KFileItem is located on a network mount

bruns added a comment. Solid should be quite fine. When queried for devices providing 'Solid::DeviceInterface::NetworkShare', it will only use the fstab backend, which does not block and only reparses fstab/mtab when these change. There are some unnecessary QString constructions in the

D23411: Fix crash in writer collection and cleanup

bruns added inline comments. INLINE COMMENTS > apol wrote in writercollection.cpp:133 > maybe it would make sense to use shared pointers there? No. `m_plugin` is either a QPluginLoader::instance(), i.e. shared, or a collection-owned ExternalWriter. REPOSITORY R286 KFileMetaData REVISION

D17737: [CopyJob] Create clones in btrf/xfs mount

bruns added inline comments. INLINE COMMENTS > file_unix.cpp:263 > +clone_created = ioctl(dest_file.handle(), FICLONE, > src_file.handle()) != -1; > +//qDebug() << "Clone created:" << clone_created;" > +#endif nitpick - wrong indentation REPOSITORY R241 KIO REVISION DETAIL

D17595: Upstream Dolphin's file rename dialog

bruns added inline comments. INLINE COMMENTS > dfaure wrote in renamefiledialog.cpp:119 > Oops yes I meant items.first().url().path(). OK for fileName(), path() is > faster but this code path isn't speed critical. anything wrong with `KFileItem::name()`? REPOSITORY R241 KIO REVISION DETAIL

D23112: Add a event Spy for GtkFileChooser recent files

bruns added inline comments. INLINE COMMENTS > ivan wrote in GtkEventSpy.cpp:126 > No need to compare chars with strings: > > if (!exec.isEmpty() && exec[0] == '\'' && exec.back() == '\'') missing `QChar('\'')`, otherwise it breaks with QT_NO_CAST_FROM_ASCII -> `if

D23200: Fixes a crash in Peruse triggered by baloo

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH fixCrashWithEmptyFolder REVISION DETAIL https://phabricator.kde.org/D23200 To: tcanabrava, #baloo, astippich, bruns, poboiko, ngraham Cc: ngraham, kde-frameworks-devel, #baloo,

D23200: Fixes a crash in Peruse triggered by baloo

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Please just return without message, and also change the one below. Searchstore is used by krunner (via baloorunner), and it searches as you type, so a term could be invalid for

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

bruns added a comment. @poboiko - is the problem you describe purely theoretical, or did you actually see it happen? Multiple triggers of `slotNewInput` are **not** a problem, the code flow reaches the `m_tr = new Transaction(...)` only iff a batch has been read. And batches are only

D23008: [baloo_file_extractor] Be more resistant to multiple QSocketNotifier events

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D23008 To: poboiko, #baloo, bruns, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, fbampaloukas, domson, ashaposhnikov, michaelh,

D22557: [IndexCleaner] ignore non-existent entries inside config

bruns added a comment. In D22557#498002 , @ngraham wrote: > Shouldn't we make sure that entries get removed from the config file properly? An entry may become valid again. REPOSITORY R293 Baloo REVISION DETAIL

D21002: Remove kde4 migration agent completely

bruns added a comment. It tried to install the no longer existing DBus service file. Fixup pushed. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham, aacid Cc: aacid, lbeltrame, kde-frameworks-devel, damjang, LeGast00n,

D21002: Remove kde4 migration agent completely

This revision was automatically updated to reflect the committed changes. Closed by commit R311:dc5c7229bc4f: Remove kde4 migration agent completely (authored by bruns). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21002?vs=57489=61943 REVISION DETAIL

D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22502 To: poboiko, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron, fbampaloukas, domson, ashaposhnikov,

D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders

bruns added a comment. The correct fix is to check the returned/calculated ID in the IndexCleaner, otherwise its racy. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D22502 To: poboiko, #baloo, bruns, ngraham Cc: kde-frameworks-devel, LeGast00n, sbergeron,

D22339: Make sure solid backends are reentrant

bruns added a comment. I would have preferred this to only land when D22333 had been addressed fully, I assumed this required no further notice. So from a pure technical view, this indeed seems to be correct, but from an architectural view this

D21672: [PowerStateMonitor] Be conservative when determining power state

bruns added a comment. In D21672#496232 , @broulik wrote: > > Why don't you notify the relevant people first > > He kinda did by writing a bug report, but let's not argue but investigate and fix why this seemingly innocent patch caused the

D21672: [PowerStateMonitor] Be conservative when determining power state

bruns added a comment. In D21672#496217 , @romangg wrote: > Reverted by d6d86cb86c on master. See https://bugs.kde.org/show_bug.cgi?id=409405 for more info. Possibly a

D22339: Make sure solid backends are reentrant

bruns added a comment. This is inacceptable! REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D22339 To: apol, #frameworks, davidedmundson, bruns Cc: bruns, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham

D22339: Make sure solid backends are reentrant

bruns added a comment. In D22339#494149 , @apol wrote: > In D22339#494142 , @bruns wrote: > > > How do you guarantee *each thread local* copy now is connected to the right signals, i.e. the socket

D21427: Always skip trailing slashes in FilderedDirIterator

bruns added a comment. In D21427#494010 , @poboiko wrote: > Ping! > > Apparently, it does fix bug 409257, which is pretty serious one (db corruption, after all). The DB corruption is already fixed in KF5.60. REPOSITORY R293 Baloo

D22339: Make sure solid backends are reentrant

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. How do you guarantee *each thread local* copy now is connected to the right signals, i.e. the socket notifier for the mtab and inotify for fstab? REPOSITORY R245 Solid REVISION

D21002: Remove kde4 migration agent completely

bruns added a comment. Can I have a "go"? REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D21002 To: bruns, #frameworks, cfeck, ngraham Cc: aacid, lbeltrame, kde-frameworks-devel, damjang, LeGast00n, michaelh, ngraham, bruns

D20526: Fix extracting of some properties to match what was written

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH arcpatch-D20526 REVISION DETAIL https://phabricator.kde.org/D20526 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson,

D22276: Add an action to insert a non-indented newline

bruns added a comment. In D22276#491055 , @mickaelbo wrote: > Another way to avoid indented empty line is to clear the trailing spaces/indentation when pressing enter while the cursor is at the end of a line containing only spaces or \t. This

D22147: Better use of Qt APIs in Plasma::Theme

bruns added inline comments. INLINE COMMENTS > tcanabrava wrote in svg.cpp:342-349 > looks a good example of code that could be written with an std::find_if You either have to sort on `bestFit.area()` first, or do the find_if in a nested loop, to find a better match (smaller one) after the

D22157: Use debugging category in taglib extractor/writer

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH taglib_logging REVISION DETAIL https://phabricator.kde.org/D22157 To: astippich, bruns Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson, ashaposhnikov,

D22157: Use debugging category in taglib extractor/writer

bruns added inline comments. INLINE COMMENTS > CMakeLists.txt:136 > kde_enable_exceptions() > -ecm_add_test(taglibextractortest.cpp > ../src/extractors/taglibextractor.cpp > +ecm_add_test(taglibextractortest.cpp > ../src/extractors/taglibextractor.cpp

D20526: Fix extracting of some properties to match what was written

bruns added inline comments. INLINE COMMENTS > taglibwritertest.cpp:556 > + > +data.add(Property::Artist, QStringLiteral("Artist1 feat Artist2")); > +data.add(Property::AlbumArtist, QStringLiteral("Artist1 feat. Artist2")); const map properties = { {Artist, "Artist", ...}; for

D22081: [Fstab] Select appropriate icon for home or root directory

This revision was automatically updated to reflect the committed changes. Closed by commit R245:541a3d3a0573: [Fstab] Select appropriate icon for home or root directory (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22081?vs=60601=60628

D22080: [Fstab] Show mounted "overlay" filesystems

This revision was automatically updated to reflect the committed changes. Closed by commit R245:54a501f00bbe: [Fstab] Show mounted overlay filesystems (authored by bruns). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22080?vs=60600=60627 REVISION DETAIL

D15739: [Places panel] Don't show Root by default

bruns added a comment. In D15739#486047 , @fvogt wrote: > If adding such a special case makes sense, yes. I'd even argue about 'mntent.mnt_dir == "/" && !isKnownFilesystem(mntent)' or something like that to ensure that an entry for `/` is

D22080: [Fstab] Show mounted "overlay" filesystems

bruns added a dependent revision: D22081: [Fstab] Select appropriate icon for home or root directory. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D22080 To: bruns, ngraham, fvogt, broulik Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22081: [Fstab] Select appropriate icon for home or root directory

bruns created this revision. bruns added reviewers: ngraham, fvogt, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Depends on D22080 REPOSITORY R245

D22080: [Fstab] Show mounted "overlay" filesystems

bruns created this revision. bruns added reviewers: ngraham, fvogt, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Overlay filesystems are not enumerated by udisks, so add support for these

D15739: [Places panel] Don't show Root by default

bruns added a comment. In D15739#486020 , @fvogt wrote: > In D15739#486009 , @bruns wrote: > > > It actually already does, via the fstab backend (currently network (SMB/NFS) and various fuse

D15739: [Places panel] Don't show Root by default

bruns added a comment. In D15739#485983 , @fvogt wrote: > Even if all (block) devices and their mountpoints were shown in the devices view, there would be no equivalent of "/". One loop device provides the read-only base for /, but that's

D21864: [QueryTest] Test if independent phrases are really independent

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ba5de13364ed: [QueryTest] Test if independent phrases are really independent (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21864?vs=59962=60477

D21863: [TermGenerator] Insert an empty position between independent terms

This revision was automatically updated to reflect the committed changes. Closed by commit R293:60e03a38ec61: [TermGenerator] Insert an empty position between independent terms (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21862: [QueryTest] Restructure tests to allow easier extension

This revision was automatically updated to reflect the committed changes. Closed by commit R293:dea183a02e2b: [QueryTest] Restructure tests to allow easier extension (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21862?vs=59960=60475

D21830: Format photo exposure bias value

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH exposure_bias REVISION DETAIL https://phabricator.kde.org/D21830 To: astippich, bruns, ngraham Cc: kde-frameworks-devel, #baloo, LeGast00n, fbampaloukas, domson,

D21866: [TermGenerator] Leave single term phrases out of the PositionDB

This revision was automatically updated to reflect the committed changes. Closed by commit R293:1a573d5fe373: [TermGenerator] Leave single term phrases out of the PositionDB (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21865: [TermGenerator] Do Term truncation prior to UTF-8 conversion

This revision was automatically updated to reflect the committed changes. Closed by commit R293:a99bb98143c6: [TermGenerator] Do Term truncation prior to UTF-8 conversion (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21865?vs=59964=59968

D21866: [TermGenerator] Leave single term phrases out of the PositionDB

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Any search phrase consisting of a single term only can be

D21855: [IdUtils] Fix aliasing warning

bruns added a comment. In D21855#480992 , @thiago wrote: > Alternative: return (quint64(devId) << 32) | inode; > > Not endian-dependent, like the memcpy solution. Make sure the other side is adapted to match. Thats the problem here -

D21855: [IdUtils] Fix aliasing warning

bruns added a comment. In D21855#480990 , @thiago wrote: > +1 Thx for the confirmation! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21855 To: bruns, #baloo, ngraham, astippich, poboiko, thiago Cc:

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

bruns added a comment. In D21839#480777 , @poboiko wrote: > > As the limit is somewhat arbitrary, maybe we can just limit the QString? I don't think this has any serious side effects. > > Yep, that's what I've suggested (if I understood you

D21865: [TermGenerator] Do Term truncation prior to UTF-8 conversion

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The (somewhat arbitrary) term truncation was applied to

D21864: [QueryTest] Test if independent phrases are really independent

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Tags (and KFileMetaData properties) call

D21863: [TermGenerator] Insert an empty position between independent terms

bruns added a dependent revision: D21864: [QueryTest] Test if independent phrases are really independent. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21863 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson,

D21862: [QueryTest] Restructure tests to allow easier extension

bruns added a dependent revision: D21864: [QueryTest] Test if independent phrases are really independent. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D21862 To: bruns, #baloo, ngraham, astippich, poboiko Cc: kde-frameworks-devel, LeGast00n, fbampaloukas, domson,

D21863: [TermGenerator] Insert an empty position between independent terms

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Terms of a phrase have adjacent positions, but independent

D21862: [QueryTest] Restructure tests to allow easier extension

bruns created this revision. bruns added reviewers: Baloo, ngraham, astippich, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The test documents are not touched by the individual

D21855: [IdUtils] Fix aliasing warning

This revision was automatically updated to reflect the committed changes. Closed by commit R293:4651988e2963: [IdUtils] Fix aliasing warning (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21855?vs=59939=59948 REVISION DETAIL

D21835: [PostingIterator] Move positions() method to VectorPositionInfoIterator

This revision was automatically updated to reflect the committed changes. Closed by commit R293:381e2cd92379: [PostingIterator] Move positions() method to VectorPositionInfoIterator (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

bruns added a comment. In D21839#480765 , @poboiko wrote: > Actually, there is an issue with that code right now, which I wanted to fix, but forgot. > The trimming part `finalArr = finalArr.mid(0, maxTermSize);` actually should be performed

D21844: [WriteTransactionTest] Clear mixup of QString and QByteArray

This revision was automatically updated to reflect the committed changes. Closed by commit R293:3e3cd7e63336: [WriteTransactionTest] Clear mixup of QString and QByteArray (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21844?vs=59913=59941

D21839: [TermGenerator] Use UTF-8 ByteArray for termList

This revision was automatically updated to reflect the committed changes. Closed by commit R293:7420bc056326: [TermGenerator] Use UTF-8 ByteArray for termList (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21839?vs=59896=59942 REVISION

<    1   2   3   4   5   6   7   8   9   10   >