D5463: Pug/Jade Syntax

2017-04-24 Thread Volker Krause
vkrause added a comment. yep, keep the mimetype field empty in that case REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D5463 To: guoyunhe, #framework_syntax_hightlighting, #ktexteditor, #kate Cc: vkrause, dhaumann, #frameworks

Re: Application usage statistics and targeted user surveys

2017-06-10 Thread Volker Krause
On Thursday, 8 June 2017 01:36:44 CEST Aleix Pol wrote: > On Thu, Jun 8, 2017 at 12:27 AM, Albert Astals Cid wrote: > > El dissabte, 3 de juny de 2017, a les 11:49:00 CEST, Volker Krause va > > > > escriure: > >> On Thursday, 25 May 2017 12:33:49 CEST Volker Kraus

D6220: CMake: Fix CMP0058 warning when using Ninja

2017-06-22 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D6220 To: kfunk, vkrause, dhaumann Cc: #frameworks

D6810: Remove "*.conf" extension rule

2017-07-21 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Seems reasonable. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6810 To: guoyunhe, #framework_syntax_hightlighting, vkrause Cc: vkrause, #framework

D6858: Fix replaceCaptures() to work with more than 9 captures

2017-07-23 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6858 To: dhaumann, vkrause Cc: #frameworks

D6867: Add PowerShell highlighting

2017-07-24 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Based on https://github.com/jgm/highlighting-kate/pull/80/ with some fixes and improvements. REPOSITORY R216 Syntax Highlighting REVISIO

D6867: Add PowerShell highlighting

2017-07-24 Thread Volker Krause
vkrause updated this revision to Diff 17103. vkrause added a comment. Right, license is due to the original file. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6867?vs=17094&id=17103 REVISION DETAIL https://phabricator.kde.org/D6867 AFFECTE

D6867: Add PowerShell highlighting

2017-07-24 Thread Volker Krause
vkrause closed this revision. vkrause added a comment. Pushed to master. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6867 To: vkrause, dhaumann, vonreth Cc: #frameworks

D6912: Theme: Derive read-only flag from file on disk

2017-07-26 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6912 To: dhaumann, vkrause Cc: #frameworks

D6913: Theme: Remove author and license fields

2017-07-26 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6913 To: dhaumann, cullmann, vkrause Cc: #frameworks

D6976: Make ECM a dependency for all frameworks

2017-07-29 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Also, add a temporary workaround for ECM requiring lrelease/lconvert host tools if the KF5 sources include translations (which they do when

D6990: Allow to build Sonnet without Qt5Widgets

2017-07-30 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This is useful for cross-compilation, where we only need the QtCore-only parsetrigrams build tool on the host and avoids having to pull in a full graphics stack for the host build in Yocto. R

D6976: Make ECM a dependency for all frameworks

2017-07-30 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R868:ee7c296202da: Make ECM a dependency for all frameworks (authored by vkrause). REPOSITORY R868 Yocto: KDE Frameworks Packaging CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6976?vs=17353&i

D6992: Fix build on Linux without X11

2017-07-30 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D6992 AFFECTED FILES src/kcrash.cpp To: vkrause, #frameworks

D6992: Fix build on Linux without X11

2017-07-30 Thread Volker Krause
vkrause updated this revision to Diff 17388. REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6992?vs=17387&id=17388 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6992 AFFECTED FILES CMakeLists.txt src/config-kcrash.h.cmake src/kcrash.cpp

D6994: Allow to build KConfig without Qt5Gui

2017-07-30 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This is particularly useful for cross-compilation, where we only need the kconfig_compiler on the host system. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.

D6992: Fix build on Linux without X11

2017-07-30 Thread Volker Krause
vkrause added a comment. I agree on this needing runtime rather than compile-time selection code. I disagree on this not happening in reality though, the KF5 Yocto recipes assume there is no X11, which is why I ran into this in the first place :) REPOSITORY R285 KCrash REVISION DETAIL h

D7008: Don't export internal helper executables

2017-07-30 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Exporting the executables will make the cmake config file check for their presence when used, which isn't really necessary, and is actually a problem for cross-compilation, where the helper ex

D6990: Allow to build Sonnet without Qt5Widgets

2017-07-31 Thread Volker Krause
vkrause added a comment. Fair point, I'll add options for this. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D6990 To: vkrause, #frameworks, cordlandwehr Cc: aacid

D6990: Allow to build Sonnet without Qt5Widgets

2017-07-31 Thread Volker Krause
vkrause added a comment. Any preferences on the naming? [KF5|]_[NO|USE]_[WIDGETS|GUI|...]? I'm leaning towards the _USE_ variant, on by default obviously, to avoid double negative conditions in the code. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D6990 To: vkraus

D6990: Allow to build Sonnet without Qt5Widgets

2017-08-01 Thread Volker Krause
vkrause updated this revision to Diff 17513. vkrause added a comment. Add explicit option to disable the widget dependency. REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6990?vs=17379&id=17513 BRANCH sonnet-no-widget REVISION DETAIL https://phabricato

D6994: Allow to build KConfig without Qt5Gui

2017-08-02 Thread Volker Krause
vkrause updated this revision to Diff 17588. vkrause added a comment. Add explicit build option to disable QtGui dependency. REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6994?vs=17392&id=17588 BRANCH master REVISION DETAIL https://phabricator.kde.or

D6990: Allow to build Sonnet without Qt5Widgets

2017-08-02 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R246:ab4e46f45e84: Allow to build Sonnet without Qt5Widgets (authored by vkrause). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6990?vs=17513&id=17595 REVISION DETAIL

D7102: Add cross-compilation support for the highlighting indexer

2017-08-03 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH hl-cross-compile REVISION DETAIL https://phabricator.kde.org/D7102 AFFECTED FILES src/indexer/CMakeLists.txt To: vkrause, #frameworks

D7103: Allow to build KSyntaxHighlighter without Qt5Gui

2017-08-03 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This actually only builds the indexer, which is useful for cross-compilation. With Yocto this avoids pulling in a full graphics stack for the host build. REPOSITORY R216 Syntax Highlighting

D7117: Fix compilation on Yocto

2017-08-03 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY By default, Qt is built without accessibility there, which is what would indirectly include the needed QColor with a "normal" Qt build here. REPOSITORY R242 Plasma Framework (Library) BRAN

D7117: Fix compilation on Yocto

2017-08-03 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R242:0a8d1f9cd474: Fix compilation on Yocto (authored by vkrause). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7117?vs=17661&id=17677 REVISION DET

D7102: Add cross-compilation support for the highlighting indexer

2017-08-04 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:e7dcacfe64bf: Add cross-compilation support for the highlighting indexer (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7102?vs=1

D7103: Allow to build KSyntaxHighlighter without Qt5Gui

2017-08-04 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:703b48665f3d: Allow to build KSyntaxHighlighter without Qt5Gui (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7103?vs=17646&id=17

D6994: Allow to build KConfig without Qt5Gui

2017-08-04 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R237:ba75a6c6a023: Allow to build KConfig without Qt5Gui (authored by vkrause). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6994?vs=17588&id=17722 REVISION DETAIL

D7118: Add KPeople recipe

2017-08-04 Thread Volker Krause
vkrause updated this revision to Diff 17727. vkrause added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. Fix homepage URL REPOSITORY R868 Yocto: KDE Frameworks Packaging CHANGES SINCE LAST UPDATE https://phabricator.k

D7136: Don't use find_file for finding files in our own source dir

2017-08-04 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY It's not necessary, and it breaks when cross-compiling, as find_file changes its behavior then. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7136

D6992: Fix build on Linux without X11

2017-08-05 Thread Volker Krause
vkrause added a comment. Ok, now I've hit the same problem in kinit, but unlike the comment in the code here suggests it's not actually identical... So, how should this work in an ideal scenario? kinit/src/wrapper.cpp would use an empty display string if neither X11 nor XCB are found at

D7154: Only require Qt5X11Extras when we actually need it

2017-08-05 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. REPOSITORY R274 KIdleTime BRANCH master REVISION DETAIL https://phabricator.kde.org/D7154 AFFECTED FILES CMakeLists.txt To: vkrause, #frameworks

D7154: Only require Qt5X11Extras when we actually need it

2017-08-05 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R274:79d45ca682b8: Only require Qt5X11Extras when we actually need it (authored by vkrause). REPOSITORY R274 KIdleTime CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7154?vs=17757&id=17760 REV

D7136: Don't use find_file for finding files in our own source dir

2017-08-07 Thread Volker Krause
vkrause updated this revision to Diff 17843. vkrause added a comment. Replace now pointless relative path REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7136?vs=17728&id=17843 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7136 AFFECTED F

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

2017-08-07 Thread Volker Krause
vkrause added a comment. Another +1, would also help the KDE Yocto recipes. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk Cc: vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system

D7136: Don't use find_file for finding files in our own source dir

2017-08-07 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R311:a14de9351608: Don't use find_file for finding files in our own source dir (authored by vkrause). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7136?vs=17843&id=178

D7187: RFC: Make ECMAddTests respect BUILD_TESTING

2017-08-07 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D7187 To: kfunk, vkrause Cc: kossebau, vkrause, elvisangelaccio, asturmlechner, apol, #frameworks, #build_system

D7008: Don't export internal helper executables

2017-08-08 Thread Volker Krause
vkrause added a comment. I assume installation is done for cross-compilation, yes. For Yocto this wouldn't even be necessary though, we manually inject the host executables into the -dev packages there, for this it only matters that they are built, not that they are installed (see https://ph

D7118: Add KPeople recipe

2017-08-08 Thread Volker Krause
vkrause closed this revision. REPOSITORY R868 Yocto: KDE Frameworks Packaging REVISION DETAIL https://phabricator.kde.org/D7118 To: vkrause, cordlandwehr Cc: #frameworks

D7274: Allow to only build the kauth-policy-gen code generator

2017-08-12 Thread Volker Krause
vkrause added a task: T6716: Fix native kauth-policy-gen build for KAuth. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D7274 To: vkrause, #frameworks, cordlandwehr

D7274: Allow to only build the kauth-policy-gen code generator

2017-08-12 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This is primarily useful for cross-compilation, where e.g. with Yocto neither Qt5Widgets nor PolicyKit are easily available for the host build. REPOSITORY R283 KAuth BRANCH pending REVISI

D7275: Fix build with QT_NO_ACCESSIBILITY

2017-08-12 Thread Volker Krause
vkrause created this revision. Restricted Application added a subscriber: kwrite-devel. Restricted Application added a project: Frameworks. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D7275 AFFECTED FILES src/view/kateviewinternal.cpp To: vkraus

D7275: Fix build with QT_NO_ACCESSIBILITY

2017-08-13 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R39:9ef966973313: Fix build with QT_NO_ACCESSIBILITY (authored by vkrause). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7275?vs=18056&id=18074 REVISION DETAIL h

D7289: Rewrite the email syntax definition

2017-08-13 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - no more hardcoded colors, which makes the source view in KMail a lot more pleasant to look at - reduced the regexp usage in favor of key

D7289: Rewrite the email syntax definition

2017-08-13 Thread Volker Krause
vkrause marked an inline comment as done. vkrause added inline comments. INLINE COMMENTS > dhaumann wrote in email.xml:51 > Not sure, but is underscore '_' also allowed? Not here, but below indeed. > dhaumann wrote in email.xml:52 > Search for lineEmptyContext here: > https://docs.kde.org/trun

D7289: Rewrite the email syntax definition

2017-08-13 Thread Volker Krause
vkrause updated this revision to Diff 18105. vkrause added a comment. Add body context, fix some allowed characters for content boundaries and email addresses. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7289?vs=18088&id=18105 BRANCH mast

D7289: Rewrite the email syntax definition

2017-08-13 Thread Volker Krause
vkrause updated this revision to Diff 18106. vkrause added a comment. - improve content boundary regexp - don't attempt to highlight unknown header content, those can contain arbitrarily bizarrely encoded stuff (see e.g. X-Face) REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDA

D7289: Rewrite the email syntax definition

2017-08-14 Thread Volker Krause
vkrause added a comment. Correct, any highlighting of the body content is gone, intentionally. The original highlighting was from a time when emails had 4-5 human readable headers and ASCII bodys. At that time body highlighting made sense, and even reading emails in kate was feasible. Nowada

D7289: Rewrite the email syntax definition

2017-08-14 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:b54210c3e238: Rewrite the email syntax definition (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7289?vs=18106&id=18150#toc REPOSITORY R216 Syntax Highlighting CHANGE

D7439: Don't clear Qt's SSL CA certificate store

2017-08-20 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This breaks all subsequent SSL connections using QSslSocket or QNAM. Thiago said about this on #kde-devel: "in the old days, it used to be because Qt shipped with a very old database, we ha

D7439: Don't clear Qt's SSL CA certificate store

2017-08-21 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:5947eeb5f5aa: Don't clear Qt's SSL CA certificate store (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7439?vs=18456&id=18497 REVISION DETAIL

D7478: Escape hyphen in rest.xml regular expressions

2017-08-23 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7478 To: heikobecker, #framework_syntax_hightlighting, kfunk, vkrause Cc: alexeymin, #frameworks

D7478: Escape hyphen in rest.xml regular expressions

2017-08-23 Thread Volker Krause
vkrause added a comment. Ah, right, I forget to check for the version number every time :) Thanks Dominik! REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7478 To: heikobecker, #framework_syntax_hightlighting, kfunk, vkrause Cc: dhaumann

D7645: Add highlighting for QDoc configuration files

2017-09-01 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D7645 AFFECTED FILES autotests/folding/test.qdocconf.fo

D7645: Add highlighting for QDoc configuration files

2017-09-01 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > dhaumann wrote in qdocconf.xml:14 > Is the capital c intentional? yep, both according to the qdoc docs and real files > dhaumann wrote in qdocconf.xml:94 > Given lineEndContext is pop, do we need the lineEmptyContext? Yes, due to the LineContinu

D7645: Add highlighting for QDoc configuration files

2017-09-02 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:251e5e1a9392: Add highlighting for QDoc configuration files (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7645?vs=19070&id=19084

D7656: Rewrite the Sieve syntax definition

2017-09-02 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This brings the highlighting up-to-date with RFC 5228 as well as all currently published extensions, and adds a few features found in the

D7661: Add syntax definition for Adblock Plus filter lists

2017-09-02 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This will allow us to replace the handwritten highlighter in the KDE PIM adblocker plugin. REPOSITORY R216 Syntax Highlighting BRANCH

D7656: Rewrite the Sieve syntax definition

2017-09-02 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:abd5c3017df2: Rewrite the Sieve syntax definition (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7656?vs=19090&id=19100#toc REPOSITORY R216 Syntax Highlighting CHANGE

D7661: Add syntax definition for Adblock Plus filter lists

2017-09-02 Thread Volker Krause
vkrause added a comment. The .syntax files are read by the tests, for files that cannot be auto-detected. Hm, and I thought I had used #pop!option-context for switching from exception to option context, but it indeed doesn't seem to make any difference. REPOSITORY R216 Syntax Highligh

D7661: Add syntax definition for Adblock Plus filter lists

2017-09-02 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:3dcbba642b74: Add syntax definition for Adblock Plus filter lists (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7661?vs=19098&id=19106#toc REPOSITORY R216 Syntax High

D7678: Fix compilation on Linux without X11

2017-09-03 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D7678 AFFECTED FILES src/wrapper.cpp To: vkrause, #frameworks

D6992: Fix build on Linux without X11

2017-09-03 Thread Volker Krause
vkrause added a task: T6924: Fix KF5 compilation without X11. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause, #frameworks, bshah, graesslin Cc: dfaure, graesslin, bshah

D7678: Fix compilation on Linux without X11

2017-09-03 Thread Volker Krause
vkrause added a task: T6924: Fix KF5 compilation without X11. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D7678 To: vkrause, #frameworks

D7680: Fix build without KDocTools

2017-09-03 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D7680 AFFECTED FILES CMakeLists.txt To: vkrause, #frameworks

D7680: Fix build without KDocTools

2017-09-03 Thread Volker Krause
vkrause added a task: T6711: Support translations. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7680 To: vkrause, #frameworks

D7699: Add support for custom search paths for application-specific syntax and theme definitions

2017-09-06 Thread Volker Krause
vkrause added a comment. I was actually thinking about adding this for the recent KMail template highlighting patch, but decided to install the custom XML file into the default path but mark it as hidden, as that was the immediately available solution. A custom search path would be the clean

D7699: Add support for custom search paths for application-specific syntax and theme definitions

2017-09-07 Thread Volker Krause
vkrause added a comment. QRC support is definitely preferred, but that should work with the original proposal indeed. Having just one fixed QRC extension path baked in would be problematic for PIM with its hundreds of libs/components for example, AFAIK QRCs don't overlay on the same path, do

D7699: Add support for custom search paths for application-specific syntax and theme definitions

2017-09-08 Thread Volker Krause
vkrause added a comment. Ah, learned something new then :) So we can have an additional hard-coded QRC search path, that would only prevent us from having indexed content in there. Probably fine, as we are looking at a handful of custom syntax definitions at most, right? Installing the in

D7872: Let qmake highlighting win over Prolog for .pro files

2017-09-18 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7872 To: dhaumann, vkrause Cc: #frameworks

D7915: Highlighting indexer: check existence of referenced context names

2017-09-21 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. good idea :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7915 To: dhaumann, #framework_syntax_highlighting, cullmann, vkrause Cc: vkrause, #frame

D7699: Add support for custom search paths for application-specific syntax and theme definitions

2017-09-24 Thread Volker Krause
vkrause accepted this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7699 To: zrax, #kate, #framework_syntax_highlighting, dhaumann, vkrause Cc: dhaumann, vkrause, cullmann, #framework_syntax_highlighting, #frameworks

D7951: ContextChecker: support '!' context switchting and fallthroughContext

2017-09-24 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH contextchecker (branched from master) REVISION DETAIL https://phabricator.kde.org/D7951 To: dhaumann, cullmann, vkrause Cc: #frameworks

D7678: Fix compilation on Linux without X11

2017-09-24 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R303:9a3ec9f1e546: Fix compilation on Linux without X11 (authored by vkrause). REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7678?vs=19141&id=19853 REVISION DETAIL htt

D7680: Fix build without KDocTools

2017-09-24 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R242:18d04e9b4142: Fix build without KDocTools (authored by vkrause). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7680?vs=19144&id=19854 REVISION

D7976: Highlighting indexer: factor out checks for smaller while loop

2017-09-25 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH refactorindexer REVISION DETAIL https://phabricator.kde.org/D7976 To: dhaumann, vkrause Cc: #frameworks

D7699: Add support for custom search paths for application-specific syntax and theme definitions

2017-09-29 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:b8d4bb51c5db: Add support for custom search paths for application-specific syntax and themeā€¦ (authored by zrax, committed by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D8042: Fix invalid itemData references of 57 highlighting files

2017-09-29 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-attributes REVISION DETAIL https://phabricator.kde.org/D8042 To: dhaumann, vkrause, cullmann Cc: #frameworks

D8092: Fix non-existing itemDatas

2017-10-01 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-more-attributes REVISION DETAIL https://phabricator.kde.org/D8092 To: dhaumann, vkrause Cc: #frameworks

Re: qqc2-desktop-style as framework

2017-10-14 Thread Volker Krause
On Thursday, 31 August 2017 17:06:46 CEST Marco Martin wrote: > Hi all, > we have a qtquickcontrols style that is right now in workspace (unrelased, > to be released with Plasma 5.11) > it makes controls paint with qstyle to give it a reasonable desktop > appearance, plus some fixes/workarounds to

D8451: JavaScript: include standard mime types

2017-10-26 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. please also bump the version number REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D8451 To: ChALkeR, #framework_syntax_highlighting, vkrause Cc: vkr

D8546: Add Aztec code generator

2017-10-29 Thread Volker Krause
vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Needed e.g. for boarding pass rendering in https://phabricator.kde.org/D8395. REPOSITORY R280 Prison BRANCH master REVISION DETAIL h

D8427: Allow cross compiling resource file

2017-10-29 Thread Volker Krause
vkrause added a task: T6715: Add cross compilation support for breeze-icons QRC generator. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8427 To: vpinon, apol, kfunk Cc: #frameworks, bartoloni, benjaminnelan, afarid, fernandoteles, mardelle

D8546: Add Aztec code generator

2017-11-10 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > svuorela wrote in aztec-compact-data-0011.png:1 > For all these images, are this the only valid encoding for the relevant data, > or are there enough extra data in aztec codes that a valid set of data can be > encoded in multiple ways ? There ar

D8662: Validate that for all attributes an itemData exists

2017-11-10 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D8662 To: dhaumann, vkrause, cullmann Cc: #frameworks

D7274: Allow to only build the kauth-policy-gen code generator

2017-11-11 Thread Volker Krause
vkrause added a comment. ping? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D7274 To: vkrause, #frameworks, cordlandwehr

D8546: Add Aztec code generator

2017-11-11 Thread Volker Krause
vkrause updated this revision to Diff 22188. vkrause added a comment. Adapt to review comments. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8546?vs=21526&id=22188 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8546 AFFECTED FILES CMak

D8546: Add Aztec code generator

2017-11-11 Thread Volker Krause
vkrause updated this revision to Diff 22205. vkrause added a comment. Fix off-by-one inconsistency in layerCount It now always means the amount of layers and not the index of the last layer. Fixes rendering of the unusually short Air Baltic boarding pass data. REPOSITORY R2

D7274: Allow to only build the kauth-policy-gen code generator

2017-11-12 Thread Volker Krause
vkrause updated this revision to Diff 5. vkrause added a comment. Integrate review feedback. REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7274?vs=18053&id=5 BRANCH pending REVISION DETAIL https://phabricator.kde.org/D7274 AFFECTED FILES CMa

D8782: add *.email to the extensions

2017-11-13 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Not an extension I have ever encountered, but it's conflict-free with everything else we have, so that should be fine. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://ph

D7274: Allow to only build the kauth-policy-gen code generator

2017-11-13 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R283:af4f0052f1ef: Allow to only build the kauth-policy-gen code generator (authored by vkrause). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7274?vs=5&id=22275 RE

D8790: Add FindSasl2.cmake to ECM

2017-11-13 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D8790 To: cgiboudeaux, #kde_pim, vkrause Cc: #frameworks, #build_system, dvasin, winterz, vkrause, mlaurent, knaus

D8546: Add Aztec code generator

2017-11-18 Thread Volker Krause
vkrause updated this revision to Diff 22559. vkrause added a comment. Separate test images into those containing only rendering/layouting data and those with full data encoding. REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8546?vs=22205&id=22559 BRANCH

D9002: add PKGUILD to bash syntax

2017-11-26 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D9002 To: jvanderwaa, #framework_syntax_highlighting, vkrause Cc: #frameworks, genethomas, cullmann, vkrause, dhaumann

D8546: Add Aztec code generator

2017-11-26 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:2e2664b0ab0a: Add Aztec code generator (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8546?vs=22559&id=22969 REVISION DETAIL https://phabri

Re: KDE Frameworks on Android

2017-12-02 Thread Volker Krause
On Thursday, 30 November 2017 21:21:18 CET Aleix Pol wrote: > Hi, > Recently I put together some CI for Android, where some frameworks are > being checked to _build_ for Android + ARM. > > Now there's many frameworks that can't be built at the moment, you can > see them listed here: > https://phab

D9125: Validate that for all attributes an itemData exists

2017-12-03 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH AttributeChecker REVISION DETAIL https://phabricator.kde.org/D9125 To: dhaumann, vkrause Cc: #frameworks

D9127: Highlighting indexer: Check DetectChar and Detect2Chars

2017-12-03 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH DetectCharChecker (branched from master) REVISION DETAIL https://phabricator.kde.org/D9127 To: dhaumann, vkrause Cc: #frameworks

<    1   2   3   4   5   6   7   8   9   10   >