D17817: Build without D-Bus on Android

vkrause added a comment. D17868 adds kwindowsystem to the Android CI, which is (still) a dependency for knotifications, I'll add knotifications itself too once the necessary patches have landed. REPOSITORY R289 KNotifications REVISION DETAIL https://

D17851: Add Android notification backend

vkrause added a comment. In D17851#383718 , @nicolasfella wrote: > By using AndroidX (formerly known as the support library) we could enable it for Android version older than 23 (which is about 29% of all active devices). That would require add

D17817: Build without D-Bus on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R289:8c3fa065fb1e: Build without D-Bus on Android (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17817?vs=48282&id=48469 REVISION DETAIL

D17851: Add Android notification backend

This revision was automatically updated to reflect the committed changes. Closed by commit R289:a54c7b17045a: Add Android notification backend (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17851?vs=48339&id=48609 REVISION DETAIL

D17851: Add Android notification backend

vkrause added a comment. In D17851#386243 , @nicolasfella wrote: > Please note that all apps uploaded to the Play Store need to have a target API level >= 26 (Oreo). This means (among other things) that notifications need to have a channel (see

D17973: [Android] Fail more gracefully when building with API < 23

vkrause accepted this revision. REPOSITORY R289 KNotifications BRANCH grace REVISION DETAIL https://phabricator.kde.org/D17973 To: nicolasfella, vkrause, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17986: Build the Java side with Gradle, as AAR instead of JAR

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Most importantly this allows us to use the AndroidX support library, to properly support a wide range of different And

D17854: Search for notfication event configuration in qrc resources

vkrause added a comment. ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D17854 To: vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17854: Search for notfication event configuration in qrc resources

vkrause added a comment. In D17854#387474 , @cullmann wrote: > Would it make sense to put the files in some :/org.kde.knotifications/config folder to avoid clashs with other resources, like we do for syntax-highlighting? > > Otherwise I thin

D17854: Search for notfication event configuration in qrc resources

This revision was automatically updated to reflect the committed changes. Closed by commit R289:aec9d7a29c80: Search for notfication event configuration in qrc resources (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17854?vs=4835

D17855: Don't rely on the Plasma workspace integration on Android

This revision was automatically updated to reflect the committed changes. Closed by commit R289:7e5cf84798cd: Don't rely on the Plasma workspace integration on Android (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17855?vs=48355&id=48877#toc REPOSITORY R289 KNot

D17986: Build the Java side with Gradle, as AAR instead of JAR

vkrause updated this revision to Diff 48881. vkrause added a comment. Move Android specifc stuff into a subdir. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17986?vs=48727&id=48881 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17

D17986: Build the Java side with Gradle, as AAR instead of JAR

vkrause added inline comments. INLINE COMMENTS > apol wrote in FindGradle.cmake:5 > Sounds like it should be in ECM, no? Right, that's the obvious final location for this, once it has proven itself as the right approach here. REPOSITORY R289 KNotifications REVISION DETAIL https://phabrica

D17986: Build the Java side with Gradle, as AAR instead of JAR

This revision was automatically updated to reflect the committed changes. Closed by commit R289:054b4548ce1e: Build the Java side with Gradle, as AAR instead of JAR (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17986?vs=48881&id=49026#toc REPOSITORY R289 KNotifi

D10446: Add KLanguageName

vkrause added a comment. In D10446#390025 , @aacid wrote: > In D10446#389972 , @dhaumann wrote: > > > Btw, wouldn't this be a good candidate to upstream to Qt itself? > > > You'd have to import

D18134: KEncodingProber: Delete copy constructor and assignment operator

vkrause added a comment. As discussed on IRC, I think this is "only" SIC, not BIC. I'd therefore agree with Albert's reasoning for this change (and same for D18135 ). REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D18134 To: aaci

D18135: KEmailSettings: Delete copy constructor and assignment operator

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D18135 To: aacid, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18134: KEncodingProber: Delete copy constructor and assignment operator

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R270 KCodecs BRANCH master REVISION DETAIL https://phabricator.kde.org/D18134 To: aacid, vkrause Cc: apol, vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D18136: kconfig_compiler: delete the assignment operator and copy constructor

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D18136 To: aacid, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18167: Move -Wsuggest-override -Wlogical-op to regular compiler settings

vkrause added a comment. IMHO a good idea, +1. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18167 To: aacid Cc: vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D18191: Rebuild AAR when Java sources change

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is a fairly aggressive heuristic, but that's fine as Gradle wont do much if nothing relevant changed, so it's mor

D18192: Remove unused forward declaration

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Technically SIC, but this is "leaking" D-Bus related classes into user code which doesn't exist on Android. REPOSITOR

D17851: Add Android notification backend

vkrause added inline comments. INLINE COMMENTS > broulik wrote in notifybyandroid.cpp:79 > Can there be multiple instances of this `NotifyByAndroid`? KNotificationManager prevents that IIUC. > broulik wrote in notifybyandroid.cpp:125 > Does this need a `FreeLocalRef` call? Possible, I'll inves

D18243: Fix qmake module generation for Qt 5.12.1

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Patch by Eike Ziller from https://github.com/KDAB/GammaRay/pull/526 in response to Qt cha

D18243: Fix qmake module generation for Qt 5.12.1

This revision was automatically updated to reflect the committed changes. Closed by commit R240:79bf23008f66: Fix qmake module generation for Qt 5.12.1 (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18243?vs=49447&id=49449 R

D18192: Remove unused forward declaration

This revision was automatically updated to reflect the committed changes. Closed by commit R289:b2c0b2748447: Remove unused forward declaration (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18192?vs=49266&id=49471 REVISION DETAI

D18191: Rebuild AAR when Java sources change

This revision was automatically updated to reflect the committed changes. Closed by commit R289:400ce7bc5f93: Rebuild AAR when Java sources change (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18191?vs=49265&id=49470 REVISION DE

D18253: Move the Android API level checks to runtime

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This doesn't make notifications on API level < 23 work yet, but it allows us to build against lower API levels and hav

D18253: Move the Android API level checks to runtime

vkrause added a comment. In D18253#393283 , @apol wrote: > Maybe we could print something for adb logcat that says that notifications won't be working? Android itself is already doing that. And support for older API levels is hopefully n

D18253: Move the Android API level checks to runtime

This revision was automatically updated to reflect the committed changes. Closed by commit R289:e9a35ccb2a60: Move the Android API level checks to runtime (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18253?vs=49486&id=49550 REV

D18274: Make notifications work on Android with API level < 23

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY At API level < 23 we cannot set a custom icon but have to use a static one from the Android resource system, so let's

D18274: Make notifications work on Android with API level < 23

This revision was automatically updated to reflect the committed changes. Closed by commit R289:60dc31f81b4f: Make notifications work on Android with API level < 23 (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18274?vs=49551&id=

D18302: Add Android notification channel support

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is required for API level 28 or higher. This actually matches the notfication events KNotification defines quite

D18329: Remove the AndroidX support library dependency

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Turns out we don't actually need that, the version checks in the Java code accomplish the same. More importantly, it d

D18369: Create tel: links for phone numbers

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY KDE Connect can handle tel: URLs and trigger a call, so this enables to directly call phone numbers found e.g. in emai

D18369: Create tel: links for phone numbers

vkrause updated this revision to Diff 49836. vkrause added a comment. Handle empty tel: URLs, as found in the review email. REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18369?vs=49834&id=49836 BRANCH master REVISION DETAIL https://phabricator.kd

D18302: Add Android notification channel support

This revision was automatically updated to reflect the committed changes. Closed by commit R289:1c3c1dd70980: Add Android notification channel support (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18302?vs=49661&id=49865 REVISIO

D18329: Remove the AndroidX support library dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R289:8536ef7e67a5: Remove the AndroidX support library dependency (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18329?vs=49737&id=49887 R

D18385: Build without KAuth and D-Bus on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY D-Bus isn't available on Android, and KAuth makes no sense either as the concept of executing things with elevated acc

D18386: Build without D-Bus on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY There is no D-Bus on Android. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.or

D18387: Build without D-Bus on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY There is no D-Bus on Android. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde

D18388: Build without D-Bus on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D18388 AFFECTED FILES CMakeLists.txt KF5XmlG

D18389: Build without D-Bus on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R245 Solid BRANCH master REVISION DETAIL https://phabricator.kde.org/D18389 AFFECTED FILES CMakeLists.txt src/solid

D18390: Build without D-Bus on Android

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R294 KBookmarks BRANCH master REVISION DETAIL https://phabricator.kde.org/D18390 AFFECTED FILES CMakeLists.txt src/

D18390: Build without D-Bus on Android

vkrause added a comment. In D18390#396771 , @dhaumann wrote: > You likely get a warning about an unused variable now in KBookmarkManager::init(const QString &dbusPath), since the function is empty. Yep (and same for the other frameworks).

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

vkrause added a comment. ping? REPOSITORY R300 KDEWebKit REVISION DETAIL https://phabricator.kde.org/D21400 To: vkrause Cc: apol, asturmlechner, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21313: Create specific directory for Qt logging categories file

vkrause added a comment. In D21313#480401 , @kossebau wrote: > @apol @vkrause Perhaps something to check wit the CI or in general with the ECM Android toolchain to make sure the ECM of the host and the target are not accidentally mixed or both

Re: KInit - Current state and benchmarks

Thanks for the very interesting and useful research! On Monday, 17 June 2019 11:56:15 CEST David Edmundson wrote: > From API.kde.org: > >Using kdeinit to launch KDE applications makes starting a typical KDE > >applications 2.5 times faster (100ms instead of 250ms on a P-III 500) > Certainly sounds

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

vkrause added a comment. In D19996#480571 , @kossebau wrote: > Any chance this could not be done by abusing KDECMakeSettings.cmake as injection vector? I completely agree that this is a rather hacky approach. IMHO the challenge here is f

Re: KInit - Current state and benchmarks

On Monday, 17 June 2019 21:34:38 CEST David Edmundson wrote: > > Which libraries are covered by this mechanism nowadays? The impact is of > > course bigger the more of the dependencies of the applications are already > > loaded. When this was developed this was a small amount of relatively > > larg

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

This revision was automatically updated to reflect the committed changes. Closed by commit R300:0ae8718ff331: Downgrade KDEWebKit from Tier 3 to Porting Aids (authored by vkrause). REPOSITORY R300 KDEWebKit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21400?vs=58645&id=60303 REVIS

D22018: Install KFileCustomDialog

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY API docs advertise this as public API, and it seems to be intended as such. REPOSITORY R241 KIO BRANCH master REV

D22018: Install KFileCustomDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:ae84a6709389: Install KFileCustomDialog (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22018?vs=60422&id=60615 REVISION DETAIL https://phabric

D22317: Fix type names casing

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D22317 To: apol, #frameworks, #android, vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, m

Re: New framework: KCalCore

proceed? Thanks, Volker On Sunday, 7 April 2019 14:45:09 CEST Volker Krause wrote: > Hi, > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > KCalCore is an implementation of the iCalendar standard based on libical, > covering the data model

Re: New framework: KCalCore

On Monday, 15 July 2019 18:43:42 CEST Aleix Pol wrote: > On Fri, Jul 12, 2019 at 9:03 PM Allen Winter wrote: > > On Friday, July 12, 2019 12:23:58 PM EDT Volker Krause wrote: > > > With the 19.08 release approaching (and thus the deadline for > > > incompatible > &

Re: New framework: KContacts

On Saturday, 6 April 2019 18:01:09 CEST Volker Krause wrote: > Hi, > > I'd like to propose KContacts for review to move from KDE PIM to KF5. > > KContacts is essentially an implementation of the vCard standard, covering > the data model as well as parsing and creating

D22515: Add support for additional QML keywords not part of JavaScript

vkrause created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vkrause requested review of this revision. REVISION SUMMARY Also, add the QtObject type while we are at it. REPOSITORY R216 Syntax Highlighting BRANCH maste

D22515: Add support for additional QML keywords not part of JavaScript

vkrause updated this revision to Diff 61927. vkrause added a comment. I am blind, the QtObject type is already there (no idea why it wasn't highlighting correctly...). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22515?vs=61926&id=61927 BRAN

D22515: Add support for additional QML keywords not part of JavaScript

vkrause edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D22515 To: vkrause Cc: broulik, kwrite-devel, kde-frameworks-devel, LeGast00n, sbergeron, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

Re: New framework: KCalCore

On Wednesday, 17 July 2019 01:51:42 CEST Aleix Pol wrote: > On Tue, Jul 16, 2019 at 6:10 PM Volker Krause wrote: > > On Monday, 15 July 2019 18:43:42 CEST Aleix Pol wrote: > > > On Fri, Jul 12, 2019 at 9:03 PM Allen Winter wrote: > > > > On Friday, July 12, 2019

D22515: Add support for additional QML keywords not part of JavaScript

This revision was automatically updated to reflect the committed changes. Closed by commit R216:7b06481d5506: Add support for additional QML keywords not part of JavaScript (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22515

Re: kdewebkit tarball gone missing?!

On Thursday, 18 July 2019 00:15:16 CEST René J. V. Bertin wrote: > Albert Astals Cid wrote: > > https://download.kde.org/stable/frameworks/5.60/portingAids/ > > Ah, thanks, I must have missed the announcement of its promotion. > > So what kind of tier is kdesigner-plugin now - I still have it cat

Re: kdewebkit tarball gone missing?!

On Friday, 19 July 2019 16:03:34 CEST Friedrich W. H. Kossebau wrote: > Am Freitag, 19. Juli 2019, 09:05:39 CEST schrieb Volker Krause: > > On Thursday, 18 July 2019 00:15:16 CEST René J. V. Bertin wrote: > > > Albert Astals Cid wrote: > > > > https://download.

Re: Qt dependency policy

On Sunday, 21 July 2019 12:55:21 CEST David Faure wrote: > Taking into account the feedback from the SUSE packagers > (about how dropping support for Qt 5.9 LTS the very month Qt 5.12 LTS comes > out is a problem since not everyone can upgrade to Qt 5.12 LTS right away) > I have modified the policy

D22805: set autorcc by default

vkrause added a comment. +1, same for AUTOUIC probably? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: vkrause, kossebau, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, sbergeron, bencreasy, michaelh, ngraham, bruns

D22800: Fix KService build on Android

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Change looks fine to me, no opinion on the platform define style. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D22800 To: apol, #frameworks,

D23062: Disable KCONFIG_USE_DBUS on Android

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH nodbus REVISION DETAIL https://phabricator.kde.org/D23062 To: nicolasfella, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23092: KRun: remove KProcessRunner dependency on QtWidgets

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH kprocessrunner REVISION DETAIL https://phabricator.kde.org/D23092 To: dfaure, nicolasfella, vkrause Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

vkrause added a comment. It looks like this made D-Bus and Phonon hard required dependencies on Android again!? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: vkrause, nicolasfella, pino, kde-fra

Re: KCalendarCore plugins/datasources?

On Sunday, 11 August 2019 12:12:10 CEST Bhushan Shah wrote: > [I am not subscribed to kde-pim list, please keep me or k-f-d in CC] > > Hello, > > So yesterday I was discussing this with the Volker in #kde-devel, that > currently kcalcore doesn't provide a "plugin interface" to create a > various

D21661: add snoretoast backend for KNotifications on Windows

vkrause added a comment. In D21661#511172 , @brute4s99 wrote: > In D21661#510813 , @vkrause wrote: > > > It looks like this made D-Bus and Phonon hard required dependencies on Android again!? >

D23131: Define install location for JAR/AAR files for Android

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This follows where Qt installs those, and thus androiddeployqt looks for them. Currently

D23131: Define install location for JAR/AAR files for Android

vkrause added reviewers: Build System, Android. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23131 To: vkrause, #build_system, #android Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, michaelh, ngraham, bruns

D23124: Remove unused DBus XML file

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Not only unused, but also seems to contain an interface that doesn't exist (anymore). REPOSITORY R289 KNotifications BRANCH noknotixml REVISION DETAIL https://phabricator.kde.org/

D23147: KRun: fix runtime warning when widget is null

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23147 To: dfaure, nicolasfella, vkrause Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23149: Only build tests when DBus is available

vkrause added inline comments. INLINE COMMENTS > CMakeLists.txt:127 > add_subdirectory(src) > -if (BUILD_TESTING) > +if (TARGET QT5::DBus AND BUILD_TESTING) > add_subdirectory(autotests) Qt5::DBus, not sure if this is case-sensitive, if it is this would disable the tests for everyone I th

D22805: set autorcc and autouic by default

vkrause added a comment. I'm happy with this, +2 from my side. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter Cc: cgiboudeaux, vkrause, kossebau, apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, bencreasy, michaelh, ngraham, brun

D23131: Define install location for JAR/AAR files for Android

This revision was automatically updated to reflect the committed changes. Closed by commit R240:6faff48245c2: Define install location for JAR/AAR files for Android (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23131?vs=63672

D23188: Fix supported OS attributes for api.kde.org

vkrause added a reviewer: Frameworks. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23188 To: vkrause, #frameworks Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, mart, hein

D23215: Port to non-deprecated KWindowSystem::setMainWindow overload

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D23215 To: dfaure, zzag, vkrause Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23217: KIO: port to non-deprecated KWindowSystem::setMainWindow

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23217 To: dfaure, vkrause, zzag Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23188: Fix supported OS attributes for api.kde.org

vkrause added inline comments. INLINE COMMENTS > apol wrote in metainfo.yaml:12 > Isn't it called macOS nowadays? Or is it a keyword we have that we'd need to > change elsewhere? See commit message, yes. We'd need to change it everywhere in order to show up as a single "macOS" entry on api.kde

D23269: Fix creating archives on Android content: URLs

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Needs https://codereview.qt-project.org/c/qt/qtbase/+/270849 to work. REPOSITORY R243 KArchive BRANCH master REVI

D23269: Fix creating archives on Android content: URLs

vkrause added reviewers: Frameworks, Android. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D23269 To: vkrause, #frameworks, #android Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23188: Fix supported OS attributes for api.kde.org

This revision was automatically updated to reflect the committed changes. Closed by commit R169:c67827d4274f: Fix supported OS attributes for api.kde.org (authored by vkrause). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23188?vs=63822&id=64058 REVISION D

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23323 AFFECTED FILES src/core/ktcpsocket.cpp sr

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

vkrause edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23323 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

vkrause added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23323 To: vkrause, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23269: Fix creating archives on Android content: URLs

This revision was automatically updated to reflect the committed changes. Closed by commit R243:9cdcc8afdcc8: Fix creating archives on Android content: URLs (authored by vkrause). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23269?vs=64055&id=64544 REVISIO

D21897: Address some issues reported by Krazy analysis

vkrause added inline comments. INLINE COMMENTS > elvisangelaccio wrote in krichtextwidget.cpp:638 > This should be `linkDialog && linkDialog->exec()` This is unusual, but it's the right way around. The point of this is to check if the dialog has been deleted during the sub-eventloop behind exec

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

vkrause added a comment. In D23323#519093 , @dhaumann wrote: > In D23323#516317 , @apol wrote: > > > Makes sense, but I feel some explanation is missing ^^' > > > > Put it in the commit message?

D23468: Resolve whether there's dbus before processing src/

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D23468 To: apol, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

vkrause added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23323 To: vkrause, #frameworks, dfaure Cc: dhaumann, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b97ce61950c9: Add support for handling QNAM SSL errors to KSslErrorUiData (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23323?vs=64233&id=65061#toc REPOSITORY R241 KI

D23739: Fix uninitialized memory read

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats BRANCH master REVISION DETAIL https://phabricator.kde.org/D23739 To: aacid, dfaure, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23809: Remove the man KPart, and thus the last KHtml user in kio-extras

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The man KPart was originally added to open troff files directly from

D23809: Remove the man KPart, and thus the last KHtml user in kio-extras

This revision was automatically updated to reflect the committed changes. Closed by commit R320:f9f2ef104fa7: Remove the man KPart, and thus the last KHtml user in kio-extras (authored by vkrause). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23809?vs=657

T11542: Remove KHTML

vkrause triaged this task as "Normal" priority. TASK DETAIL https://phabricator.kde.org/T11542 To: vkrause Cc: ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, GB_2, niccolove, kpiwowarski, vkrause, cordlandwehr, dfaure

D23825: Split KSslErrorUiData from KTcpSocket

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY The former we want to keep, the latter we want to deprecate, so this is a necessary

<    4   5   6   7   8   9   10   11   12   >