D23014: Lua: fix color of end with several levels of condition and function nesting

2019-08-08 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:2b06bf42be04: Lua: fix color of end with several levels of condition and function nesting (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23014?vs=63376&id=63377#toc REPO

D23013: Latex: several fixes (math mode, nested verbatim, ...)

2019-08-08 Thread jonathan poelen
jpoelen updated this revision to Diff 63378. jpoelen added a comment. At first, I didn't have much change. But as I broke my teeth on one of the bugs and there were some problems here and there, I armed myself with a bulldozer :D REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDA

D23013: Latex: several fixes (math mode, nested verbatim, ...)

2019-08-08 Thread jonathan poelen
jpoelen added a comment. The 410477 did not exist when I started my modifications, I add it in the list. REPOSITORY R216 Syntax Highlighting BRANCH tex (branched from master) REVISION DETAIL https://phabricator.kde.org/D23013 To: jpoelen, #framework_syntax_highlighting, dhaumann, cul

D23013: Latex: several fixes (math mode, nested verbatim, ...)

2019-08-08 Thread jonathan poelen
jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting BRANCH tex (branched from master) REVISION DETAIL https://phabricator.kde.org/D23013 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, kde-frameworks-devel, kwrite-devel, univerz, Le

D23013: Latex: several fixes (math mode, nested verbatim, ...)

2019-08-08 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:75e233dc5792: Latex: several fixes (math mode, nested verbatim, ...) (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23013?vs=63378&id=63379#toc REPOSITORY R216 Syntax

D23034: implicit fallthough if there is fallthoughContext

2019-08-08 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY fallthrough="true" is redundant with fallthroughContext="xxx" and there is no reason

D23034: implicit fallthough if there is fallthoughContext

2019-08-09 Thread jonathan poelen
jpoelen added a comment. I will hand over the original xml files, that seems preferable to me too. I did not see `fallthrough="false"` nor `fallthrough="0"`. But after checking, `brightscript.xml` uses` fallthroughContext` twice without `fallthrough`. in my opinion, it's an oblivion with

D23034: implicit fallthough if there is fallthoughContext

2019-08-09 Thread jonathan poelen
jpoelen updated this revision to Diff 63455. jpoelen added a comment. - don't modify the *.xml files to maintain the compatibility in older versions of KF5 - langauge.xsd: accept only 1 or true for fallthrough attribute REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE http

D23134: fix additionalDeliminator attribute

2019-08-13 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY The initialization of the `Rule::m_wordDelimiter` cache was done before the delimiter

D23134: fix additionalDeliminator attribute

2019-08-13 Thread jonathan poelen
jpoelen added a comment. I don't understand why there's so much difference in what's displayed :/ REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23134 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel,

D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

2019-08-13 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - fix #| (previous untranslated string) - fix hexadecimal entity - fix html tag in

D23136: Jam: Fix local with variable without initilisation and highlight SubRule

2019-08-13 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL https:/

D23137: C++: contracts are not in C++20

2019-08-13 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY For C ++ 23 or C ++ 26 with perhaps a syntax change REPOSITORY R216 Syntax Highligh

D23137: C++: contracts are not in C++20

2019-08-13 Thread jonathan poelen
jpoelen updated this revision to Diff 63689. jpoelen added a comment. - increase version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23137?vs=63686&id=63689 BRANCH cpp_no_contract (branched from master) REVISION DETAIL https://phabricat

D23134: fix additionalDeliminator attribute

2019-08-14 Thread jonathan poelen
jpoelen updated this revision to Diff 63771. jpoelen added a comment. - add unit test REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23134?vs=63683&id=63771 BRANCH fix_wordDelimiters (branched from master) REVISION DETAIL https://phabricat

D14632: keyword rule: Spport for keywords inclusion from another language/file

2019-08-15 Thread jonathan poelen
jpoelen added a comment. I don't think using the original word delimiters is a good thing. Let's imagine that c.xml lists the functions of the libc and a language that allows them to be used as `ffi.C.printf` (luajit for the curious). The separators of the 2 languages are not the same and `p

D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

2019-08-15 Thread jonathan poelen
jpoelen added a comment. If it is better not to have a hard-coded color, wouldn't it be better to remove them once and for all? Without necessarily incrementing the version. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23135 To: jpoelen, #framework_sy

D23195: SCSS: fix interpolation (#{...}) and add the Interpolation color

2019-08-15 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Only interpolation with variable (`#{$...}`) and beginning of the string (`"${...}...

D23245: New syntax: SASS. Some fixes for CSS and SCSS

2019-08-18 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY CSS, SCSS (CSS4): - number in scientific notation: `12.3e3` - hexadecimal rgba:

D23245: New syntax: SASS. Some fixes for CSS and SCSS

2019-08-19 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:0edc0cb01ab7: New syntax: SASS. Some fixes for CSS and SCSS (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23245?vs=63987&id=64075#toc REPOSITORY R216 Syntax Highlight

D23278: LESS: import CSS keywords, new highlighting and some improvements

2019-08-19 Thread jonathan poelen
jpoelen created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REVISION SUMMARY New highlighting (same as CSS): - Value Keyword - Color - Number - Unit Improvements a

D23278: LESS: import CSS keywords, new highlighting and some improvements

2019-08-19 Thread jonathan poelen
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23278 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, micha

D23278: LESS: import CSS keywords, new highlighting and some improvements

2019-08-20 Thread jonathan poelen
jpoelen added a comment. The other files that use the include statement are also in version 5.53. If highlightingindexer adds a version check, it is also necessary to check that the included files are of the same or lower version. Ideally, this should also be done for IncludeRules.

D23278: LESS: import CSS keywords, new highlighting and some improvements

2019-08-20 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:63719f49867b: LESS: import CSS keywords, new highlighting and some improvements (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23278?vs=64078&id=64182#toc REPOSITORY R

D23312: JSP: support of

2019-08-20 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY BUG: 345003 REPOSITORY R216 Syntax Highlighting BRANCH jsp (branched from master

D23312: JSP: support of

2019-08-21 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:433e5d85979c: JSP: support of