D27263: RFC: Accent colour for KColorScheme

cblack abandoned this revision. cblack added a comment. https://invent.kde.org/frameworks/kconfigwidgets/-/merge_requests/24 REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27263 To: cblack, #plasma Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis,

D7563: Add privilegeExecution field to file protocol description

cblack abandoned this revision. cblack added a comment. Moving this to GitLab: https://invent.kde.org/frameworks/kio/-/merge_requests/143 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham Cc: cblack, sitter,

D7563: Add privilegeExecution field to file protocol description

cblack updated this revision to Diff 83347. cblack marked an inline comment as done. cblack added a comment. i18n the strings REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=83344=83347 BRANCH arcpatch-D7563 REVISION DETAIL

D7563: Add privilegeExecution field to file protocol description

cblack marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n,

D7563: Add privilegeExecution field to file protocol description

cblack updated this revision to Diff 83344. cblack added a comment. Redo that switchcase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=83343=83344 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.kde.org/D7563 AFFECTED FILES

D7563: Add privilegeExecution field to file protocol description

cblack updated this revision to Diff 83343. cblack added a comment. Break those cases; this lang ain't got sane case behaviour REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=83342=83343 BRANCH arcpatch-D7563 REVISION DETAIL

D7563: Add privilegeExecution field to file protocol description

cblack updated this revision to Diff 83342. cblack marked an inline comment as done. cblack added a comment. Add more descriptive authentication details REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80668=83342 BRANCH arcpatch-D7563 REVISION

D7563: Add privilegeExecution field to file protocol description

cblack commandeered this revision. cblack added a reviewer: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7563 To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, ngraham,

D7563: Add privilegeExecution field to file protocol description

cblack added a comment. In D7563#674682 , @sitter wrote: > This really cannot land right now IMHO. Dolphin can actually deadlock itself because it uses way too much nested event looping and will be entirely unresponsive to mouse inputs when

D29436: Use font: instead of font.pointSize: where possible

cblack accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH use-whole-font (branched from master) REVISION DETAIL https://phabricator.kde.org/D29436 To: ngraham, #plasma, cblack Cc: kde-frameworks-devel, LeGast00n,

D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

cblack accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH show-warnings-for-leading-and-trailing-spaces-when-creating-files-or-folders-and-wow-this-is-a-long-branch-name-at-this-point (branched from master) REVISION DETAIL

D29802: Require out-of-source builds

cblack accepted this revision. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella, ndavis, tfella, filipf, cblack Cc: ltoscano, davidre,

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

cblack added a comment. In D29797#672263 , @kossebau wrote: > Thanks for the (first) review :) > > Open questions I have are these: > a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

cblack accepted this revision. REPOSITORY R264 KApiDox BRANCH makedepworkwithpython3 REVISION DETAIL https://phabricator.kde.org/D29797 To: kossebau, #frameworks, ochurlaud, ognarb, cblack Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, michaelh,

D29667: Export metalist to json file

This revision was automatically updated to reflect the committed changes. Closed by commit R264:c8e125d0860e: Export metalist to json file (authored by cblack). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29667?vs=82608=82692 REVISION DETAIL

D29667: Export metalist to json file

cblack added a comment. In D29667#669622 , @ochurlaud wrote: > Don't use file as a variable name as it's a python keyword. >>> import keyword >>> keyword.iskeyword("file") False It's not. > Do you really want to

D29667: Export metalist to json file

cblack updated this revision to Diff 82608. cblack added a comment. Dump output information as well REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29667?vs=82603=82608 BRANCH cblack/metadata (branched from master) REVISION DETAIL

D29667: Export metalist to json file

cblack created this revision. cblack added a reviewer: ochurlaud. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY This will allow tooling to better introspect the

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

cblack added inline comments. INLINE COMMENTS > kcolorcombo.h:52 > Q_PROPERTY(QList colors READ colors WRITE setColors) > +Q_PROPERTY(QList> namedColors READ namedColors > WRITE setNamedColors) > Is a simple tuple list really the best way to represent colours? Knowing what most

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

cblack added inline comments. INLINE COMMENTS > kcolorcombo.cpp:90 > +innerColor.getHsv(, , ); > +textColor = v > 128 ? Qt::black : Qt::white; > +} I would probably do what Kirigami does for `ColorUtils::brightnessForColor` here: `((0.299 * color.red() + 0.587 *

D29534: Implement wheel/touchpad scrolling for SpinBox control

cblack added inline comments. INLINE COMMENTS > SpinBox.qml:49 > +if (wheel.angleDelta.y > 0 && control.value <= control.to) { > +control.value = parseInt(control.value, 10) + > control.stepSize > +valueModified() `control.value` is

D29511: Label: Add ping-pong logic

cblack added a comment. You should include a video in the test plan since you're creating visual changes with motion. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29511 To: patrickelectric, #plasma, #vdg Cc: cblack, kde-frameworks-devel,

D29511: Label: Add ping-pong logic

cblack added reviewers: Plasma, VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29511 To: patrickelectric, #plasma, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29434: Use small font for ExpandableListItem subtitle

cblack added inline comments. INLINE COMMENTS > ExpandableListItem.qml:434 > visible: text.length > 0 > +font.pointSize: theme.smallestFont.pointSize > `font: theme.smallestFont` REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D29412: Add smallFont to Kirigami plasma style

This revision was automatically updated to reflect the committed changes. Closed by commit R242:68d5995c6352: Add smallFont to Kirigami plasma style (authored by cblack). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29412?vs=81897=81898

D29412: Add smallFont to Kirigami plasma style

cblack created this revision. cblack added a reviewer: Kirigami. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. TEST PLAN F8283833: ksnip_20200504-102619.png REPOSITORY R242

D29409: Add documentation line on KCM translations

cblack added inline comments. INLINE COMMENTS > configmodule.h:98 > + * > + * Translation domain will be set to "kcm_componentName" from the KAboutData > as described above. > + * You probably want to use backticks instead of quotes as this is referring to something codewise. REPOSITORY

D29292: Port KKeySequenceItem to QQC2

cblack added inline comments. INLINE COMMENTS > KeySequenceItem.qml:57 > +ToolTip.visible: hovered > +ToolTip.delay: 1000 > +ToolTip.text: _tr.i18n("Click on the button, then enter the > shortcut like you would in the program.\nExample for Ctrl+A: hold the Ctrl > key

D29232: [WIP][RFC]Introduce the Header color set

cblack added inline comments. INLINE COMMENTS > ndavis wrote in kcolorscheme.h:133 > I think it would be good to explain the issue about enums being converted > into plain integers here so that people know why they shouldn't depend on it. > Also, is there a way to hide this from the

D29232: [WIP][RFC]Introduce the Tools color set

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. +1 to the approach here. I assume this would probably replace the `WM` set in kdeglobals for all practical usage? REPOSITORY R265 KConfigWidgets BRANCH phab/toolsSet REVISION DETAIL

D26918: Improve KNotification API docs

cblack requested changes to this revision. cblack added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Mainpage.dox:13 > +In order to perform a notification, you need to create a description file, > which contains > +default parameters of the notification. It

D28766: Add auth-sim-locked and auth-sim-missing

cblack accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH sim-card (branched from master) REVISION DETAIL https://phabricator.kde.org/D28766 To: ndavis, #vdg, cblack Cc: kde-frameworks-devel, salvahg, Orage, LeGast00n, cblack,

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

cblack added inline comments. INLINE COMMENTS > kcmoduleinfo.h:130 > * @return a QExplicitlySharedDataPointer to KService created from the > modules .desktop file > + * WARNING: this will be null if this KCModuleInfo was created from a > KPluginInfo coming from KPluginMetaData > +

D28734: Port to Aether Bootstrap 4

cblack closed this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28734 To: cblack, #vdg, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna

D28737: Add sim card device icons

cblack accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH sim-card (branched from master) REVISION DETAIL https://phabricator.kde.org/D28737 To: ndavis, #vdg, cblack Cc: kde-frameworks-devel, Orage, LeGast00n, cblack, hannahk,

D28734: Port to Aether Bootstrap 4

cblack updated this revision to Diff 79798. cblack added a comment. Remove unused Bootstrap 3 assets REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28734?vs=79796=79798 BRANCH cblack+ognarb/bootstrap-4 (branched from master) REVISION DETAIL

D28734: Port to Aether Bootstrap 4

cblack updated this revision to Diff 79796. cblack added a comment. Fix footer text REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28734?vs=79794=79796 BRANCH cblack+ognarb/bootstrap-4 (branched from master) REVISION DETAIL

D28734: Port to Aether Bootstrap 4

cblack edited the summary of this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28734 To: cblack, #vdg, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28734: Port to Aether Bootstrap 4

cblack edited the summary of this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D28734 To: cblack, #vdg, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28734: Port to Aether Bootstrap 4

cblack created this revision. cblack added reviewers: VDG, ochurlaud. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY Output generated by kapidox now uses Aether

D28712: Redo api.kde.org to look more like Aether

This revision was automatically updated to reflect the committed changes. Closed by commit R264:a6c47b24d1df: Redo api.kde.org to look more like Aether (authored by cblack). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28712?vs=79738=79769 REVISION DETAIL

D28712: Redo api.kde.org to look more like Aether

cblack created this revision. cblack added reviewers: VDG, ognarb. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. cblack requested review of this revision. TEST PLAN F8227629: image.png

D28444: Add ECMCargo module

cblack updated this revision to Diff 79521. cblack added a comment. Add STATIC_LIBNAME and DYNAMIC_LIBNAME options REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28444?vs=79430=79521 BRANCH cblack/cargo-integration REVISION DETAIL

D27263: RFC: Accent colour for KColorScheme

cblack updated this revision to Diff 79517. cblack added a comment. Fix typo REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27263?vs=75311=79517 BRANCH kcolorscheme-accent (branched from master) REVISION DETAIL

D28444: WIP/RFC: Add ECMCargo module

cblack updated this revision to Diff 79430. cblack added a comment. Address feedback REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28444?vs=78925=79430 BRANCH cblack/cargo-integration REVISION DETAIL https://phabricator.kde.org/D28444

D28444: Add ECMCargo module

cblack retitled this revision from "WIP/RFC: Add ECMCargo module" to "Add ECMCargo module". cblack edited the summary of this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28444 To: cblack, #frameworks, #build_system Cc: apol, IlyaBizyaev,

D28579: Improve the look of kcachegrind

cblack accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH kcachegrind (branched from master) REVISION DETAIL https://phabricator.kde.org/D28579 To: ndavis, #vdg, cblack Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28470: WIP: IconItem: Refactor source handling for different types

cblack added a comment. Splitting into multiple classes seems like a good idea, but "strategy"? Seems like an odd choice of name to me. INLINE COMMENTS > iconitem.cpp:58 > + > +class NullStategy : public IconItemStrategy > +{ Is this class necessary? I feel like this class's behaviour

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638988 , @IlyaBizyaev wrote: > In D28444#638877 , @cblack wrote: > > > CMake needs to know when the Rust source has changed so it can rebuild it > > > Changes

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638540 , @IlyaBizyaev wrote: > In D28444#638430 , @cblack wrote: > > > more than half of Ikona's CMakeLists.txt is boilerplate dedicated to integrating Rust with

D28452: Fix baloo compile

cblack accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28452 To: usta, #baloo, ngraham, cblack Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson,

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638435 , @apol wrote: > Will this make all the boilerplate in ikona disappear? It'll bring it down to the same level as everything else. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D28444: WIP/RFC: Add ECMCargo module

cblack added a comment. In D28444#638428 , @apol wrote: > I wonder if this is covering a very widespread use-case. If there's just one application that needs it, it could make sense to keep it there and once it's polished, we put it in ECM to

D28444: WIP/RFC: Add ECMCargo module

cblack created this revision. cblack added reviewers: Frameworks, Build System. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY The ECMCargo module allows for easy usage

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack requested changes to this revision. cblack added a comment. I've changed my mind to agree with @ngraham here—this is too transparent. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack, ngraham Cc:

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack added a comment. In D28353#636183 , @niccolove wrote: > In D28353#636164 , @cblack wrote: > > > Looks visually appealing to me, with one question: How does this look on low-end hardware

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack accepted this revision as: VDG, cblack. cblack added a comment. This revision is now accepted and ready to land. Looks visually appealing to me, with one question: How does this look on low-end hardware where there's compositing but no blur? REPOSITORY R242 Plasma Framework

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

cblack added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

cblack accepted this revision as: VDG, cblack. cblack added a comment. This revision is now accepted and ready to land. Pin icon looks good, but I fail to see how removing edit-delete is a related change in this patch. REPOSITORY R242 Plasma Framework (Library) BRANCH pin-icon (branched

D28168: Broadcast application menu to resources when registering them

This revision was automatically updated to reflect the committed changes. Closed by commit R127:8032cb0f0e9a: Broadcast application menu to resources when registering them (authored by cblack). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D28168: Broadcast application menu to resources when registering them

cblack created this revision. cblack added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY Previously, KWayland wasn't hanging onto the application menu to broadcast it when

D28164: Add test for application menu in PWM interface

This revision was automatically updated to reflect the committed changes. Closed by commit R127:4f4142d3d3a8: Add test for application menu in PWM interface (authored by cblack). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28164?vs=78109=78111 REVISION

D28164: Add test for application menu in PWM interface

cblack created this revision. cblack added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. TEST PLAN See that the test works as expected. REPOSITORY R127 KWayland BRANCH cblack/appmenu-tests

D28112: Expose application menu via KWindowInfo

This revision was automatically updated to reflect the committed changes. Closed by commit R278:93814b513d45: Expose application menu via KWindowInfo (authored by cblack). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28112?vs=77921=77922 REVISION

D28112: Expose application menu via KWindowInfo

cblack edited the summary of this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28112 To: cblack, #plasma, broulik, zzag, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28112: [WIP] Expose application menu via KWindowInfo

cblack updated this revision to Diff 77921. cblack added a comment. Plonk a space REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28112?vs=77915=77921 BRANCH appmenu-x11 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28112

D28112: Expose application menu via KWindowInfo

cblack retitled this revision from "[WIP] Expose application menu via KWindowInfo" to "Expose application menu via KWindowInfo". REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28112 To: cblack, #plasma, broulik, zzag, #kwin Cc: zzag, kde-frameworks-devel,

D28112: Expose application menu via KWindowInfo

cblack marked 2 inline comments as done. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28112 To: cblack, #plasma, broulik, zzag, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28112: [WIP] Expose application menu via KWindowInfo

cblack updated this revision to Diff 77915. cblack marked 8 inline comments as done. cblack added a comment. Address feedback REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28112?vs=77875=77915 BRANCH appmenu-x11 (branched from master) REVISION

D28114: Add call-incoming/missed/outgoing

cblack requested changes to this revision. cblack added a comment. This revision now requires changes to proceed. The 16px icons should probably drop the phone, as the distinguishing elements between them are so small as to impair the ease of telling the icons apart. Legibility should be

D28112: [WIP] Expose application menu via KWindowInfo

cblack created this revision. cblack added reviewers: Plasma, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY Application menu information is now available via KWindowInfo's APIs on X11.

D28111: Add transmission-tray-icon

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. LGTM. REPOSITORY R266 Breeze Icons BRANCH transmission (branched from master) REVISION DETAIL https://phabricator.kde.org/D28111 To: ndavis, #vdg, cblack Cc: cblack,

D27416: Add small icons for KeePassXC

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. LGTM now. Good icon  REPOSITORY R266 Breeze Icons BRANCH keepassxc-small REVISION DETAIL https://phabricator.kde.org/D27416 To: wsdfhjxc, #vdg, cblack, ndavis Cc: ndavis, cblack,

D27416: Add small icons for KeePassXC

cblack requested changes to this revision. cblack added a comment. This revision now requires changes to proceed. The key in both icons should be pixel aligned to prevent blurry edges at the size it's going to be rendered at. F8180107: image.png

D28033: Create ExpandableListItem

cblack added a comment. In D28033#627180 , @davidre wrote: > I would love if we could find a way to show that the item is expandable I would probably use a pointing down arrow without a stem when collapsed, and pointing up when open.

D27464: Add application menu dbus paths to org_kde_plasma_window interface

This revision was automatically updated to reflect the committed changes. Closed by commit R127:dddf9d1ac3f2: Add application menu dbus paths to org_kde_plasma_window interface (authored by cblack). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D27851: Add rss icons in action

cblack added a comment. SVG-wise, optimization here seems suboptimal. There's excess elements that could be removed. Visually, the icon looks like the RSS icon, which is about all you need out of an RSS icon. I do believe we need at least 16px and 22px for monochromatic actions,

D27851: Add rss icons in action

cblack edited reviewers, added: VDG, Breeze; removed: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27851 To: ognarb, #vdg, #breeze, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, trickyricky26, michaelh, ngraham, bruns

D27848: Remove the tooltip icon

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. Visually, LGTM. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27848 To: ngraham, #vdg,

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack added a dependent revision: D27818: [wayland/AbstractClient] Broadcast application menu events. REPOSITORY R127 KWayland BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag, davidedmundson Cc: davidedmundson,

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76886. cblack added a comment. Add missing documentation REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76885=76886 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76885. cblack added a comment. Address feedback REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76811=76885 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 AFFECTED

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack added a comment. @zzag does anything else look off to you? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag, davidedmundson Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76811. cblack added a comment. Coding style REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76805=76811 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 AFFECTED FILES

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack marked 3 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76805. cblack added a comment. Tick up PWM version REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76804=76805 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 AFFECTED

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack marked 6 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76804. cblack added a comment. Address feedback REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76035=76804 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 AFFECTED

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack added a comment. Would the version number already being 9 in old versions of KWayland cause any issues? I have a feeling old KWayland versions may not like it when they're sent events they don't recognize, unless libwayland/KWayland handle that usecase. REPOSITORY R127 KWayland

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack added inline comments. INLINE COMMENTS > davidedmundson wrote in plasmawindowmanagement_interface.cpp:129 > how is this 9 already? Git blame shows that it's been 9 since 2018. Looks like someone made a mistake a while back? REPOSITORY R127 KWayland REVISION DETAIL

D27589: Try to apply the colorscheme of the current theme to QIcons

cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. Patch works as advertised and the code LGTM. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack added a comment. In D27464#614479 , @davidedmundson wrote: > Good start. The direction makes sense. > > display.cpp and registry.cpp need updating to the new version number. Otherwise we won't be able to use this new method. > >

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76035. cblack added a comment. Use utf8 encoding on client side REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=75855=76035 BRANCH cblack/appmenu-listener REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 75855. cblack added a comment. Figure out how to use arc correctly REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=75854=75855 BRANCH cblack/appmenu-listener REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack planned changes to this revision. cblack added a comment. whoops, I seem to have forgotten how to use arc REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack created this revision. cblack added reviewers: KWin, zzag. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY This patch adds an interface allowing a compositor to send the service name and

D27246: add buho icon

cblack added a comment. In D27246#610777 , @ndavis wrote: > What is buho? Maui's note taking app REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27246 To: mbruchert, camiloh, #vdg, ndavis Cc: cblack,

D27218: Add icon for org.kde.Ikona

This revision was automatically updated to reflect the committed changes. Closed by commit R266:96cf15e1905d: Add icon for org.kde.Ikona (authored by cblack). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27218?vs=75577=75578 REVISION DETAIL

  1   2   >