D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Dominik Haumann
dhaumann added a comment. Looks good to me. Btw, you posted several patches over the last two years. You could also apply for a KDE contributor account and push yourself, if you want. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25054 To: zrax,

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Please commit. REPOSITORY R216 Syntax Highlighting BRANCH ps-escape (branched from master) REVISION DETAIL https://phabricator.kde.org/D25054 To: zrax, dhaumann Cc: dhaumann,

D24982: Small improvements in some XML files

2019-10-28 Thread Dominik Haumann
dhaumann added a comment. Hm right... too bad. I was hoping to find an automated way to detect this. Since relying on the user to optimize the RegExps will always be suboptimal. @cullmann Do you have any ideas? REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D24983: KateModeMenuList: improve word wrap

2019-10-28 Thread Dominik Haumann
dhaumann added a comment. Good, fine with me. Related: Maybe the translation should also be shorter, but the general possible problem persists. Please go ahead. REPOSITORY R39 KTextEditor BRANCH improve-word-wrap REVISION DETAIL https://phabricator.kde.org/D24983 To: nibags,

D24982: Small improvements in some XML files

2019-10-28 Thread Dominik Haumann
dhaumann added a comment. > [...] > One option would be to add a **capture** or **dontCapture** attribute to enable or disable captures for RegExpr rules. Also, captures could be enabled or disabled in all RegExpr rules using the group, adding an element for that. But don't we

Re: KSyntaxHighlighting: My changes to data files don’t seem to affect test outputs

2019-10-27 Thread Dominik Haumann
What does `ldd build/bin/syntax/testhighlighter_test` tell you? What, if you first source build/prefix.sh? Likely the wrong lib is used. Greetings Dominik Adrian Chaves schrieb am So., 27. Okt. 2019, 17:49: > I emptied data/syntax/rest.xml (made it a valid syntax file that would > mark all

D24983: KateModeMenuList: improve word wrap

2019-10-27 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. It's hard to review all the pixel changes with no screenshots. It's even unclear to me what problem exactly is fixed at hand. Given it's all your code, I trust you know what you are

D24982: Small improvements in some XML files

2019-10-27 Thread Dominik Haumann
dhaumann added a comment. I wonder if the `?:` optimizations make sense. QRegularExpression has the option `QRegularExpression::DontCaptureOption` to not capture anything. Looking into our code we have: 561 bool RegExpr::doLoad(QXmlStreamReader& reader) 562 { 563

D24981: Modelines: fix end of comment

2019-10-27 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-end-modelines REVISION DETAIL https://phabricator.kde.org/D24981 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D24939: Meson: more built-in functions and add built-in member functions

2019-10-24 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me, thanks! REPOSITORY R216 Syntax Highlighting BRANCH meson (branched from master) REVISION DETAIL https://phabricator.kde.org/D24939 To: jpoelen,

D24620: Windows MSVC compile fix

2019-10-20 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Imo we should simply try: We have another two weeks for testing. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D24620 To: cullmann,

D24568: Provide clang-format target with a common KDE style file

2019-10-12 Thread Dominik Haumann
dhaumann added a comment. I'm all for it. This would unify how we can reformat any KDE module, which is very much desirable. Being able to just reformat a patch sounds interesting, too, but can be added later still. Don't let the perfect be the enemy of the good... The example

D24578: Meson: Add a comment section for comment/uncomment with Kate

2019-10-12 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Please increase the version number and commit. REPOSITORY R216 Syntax Highlighting BRANCH meson (branched from master) REVISION DETAIL https://phabricator.kde.org/D24578 To:

D24443: Add a plugin system

2019-10-07 Thread Dominik Haumann
dhaumann added a comment. I'd go for a QVector for now. Arguing with Qt6 doesn't sound convincing to me, since Qt6 will take another>=1 year(s). So why try this experiment in public API now? :) REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma Cc:

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-04 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > kstyle.cpp:422 > } > +#if QT_VERSION >= 0x050E00 // Check if Qt version >= 5.14 > +case QStyle::SP_DialogYesToAllButton: Instead of 0x050E00 you could use the macro QT_VERSION_CHECK(5, 14, 0). This would be a bit more self explanatory.

D24403: Small performance improvements suggested by clang-tidy

2019-10-04 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. I also think it's fine. A next patch could convert the QRegExp to a QRegularExpression. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D24403 To: aacid, cullmann, dhaumann Cc: dhaumann, cullmann,

D24404: Small performance improvements suggested by clang-tidy

2019-10-04 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D24404 To: aacid, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham,

D24354: Mustache/Handlebars: minor fixes

2019-10-04 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-delimiters-mustache REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D24399: Pass QDir by const & instead of copy

2019-10-03 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24399 To: aacid, dhaumann Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

2019-10-03 Thread Dominik Haumann
dhaumann added a comment. @graesslin pong? One year passed. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann, apol, broulik Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24378: WordDetect rule: detect delimiters at the inner edge of the string

2019-10-03 Thread Dominik Haumann
dhaumann added a comment. I think it's fine as is. The docbook says: Detect an exact string but additionally require word boundaries such as a dot '.' or a whitespace on the beginning and the end of the word. Think of \bstring\b in terms of a regular expression, but it is

D24378: WordDetect rule: detect delimiters at the inner edge of the string

2019-10-03 Thread Dominik Haumann
dhaumann added a comment. This looks good to me and as mentioned in D24354 WordDetect is better than RegExpr. +1, but I'd like another review by @cullmann or @vkrause. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D24326: Add syntax highlighting for RenPy (.rpy)

2019-10-03 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH renpy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24326 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-03 Thread Dominik Haumann
dhaumann added a comment. Thanks a lot! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-02 Thread Dominik Haumann
dhaumann added a comment. Hm, would it make sense to change this? I.e. if the word itself has a word boundary, also use this? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc:

D24354: Mustache/Handlebars: fix delimiters in HTML tags

2019-10-02 Thread Dominik Haumann
dhaumann added a comment. Would it also be an option to fix WordDetect? I always thought WordDetect ignores the string contents, it should only check on the boundaries left and right REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24354 To: nibags,

D24262: Modernize code: use range-based loops & algorithms in more places

2019-09-28 Thread Dominik Haumann
dhaumann added a comment. In D24262#539317 , @dfaure wrote: > It's actually quite clear in my head, because I imagine the generated class. A captured variable in a lambda becomes a member variable. If it's a capture by value (which is what

D24262: Modernize code: use range-based loops & algorithms in more places

2019-09-28 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > kossebau wrote in plugin.cpp:196 > Confirmed by experiments. Still not yet found a document where explicitly it > is mentioned that the copy constructor will be invoked to generate a copy of > the object for any captured variables only being of

D24262: Modernize code: use range-based loops & algorithms in more places

2019-09-28 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > plugin.cpp:196 > > -QObjectList::ConstIterator it = plugins.begin(); > -for (; it != plugins.end(); ++it) { > -Plugin *plugin = qobject_cast(*it); > -if (plugin && plugin->d->m_library == library) { > -return

D24261: Modernize code: use range-based for loop in more places

2019-09-28 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > kedittoolbar.cpp:1566 > { > -XmlDataList::Iterator xit = m_xmlFiles.begin(); > -for (; xit != m_xmlFiles.end(); ++xit) { > -if ((*xit).type() == XmlData::Merged) { > +for (auto& xmlFile : m_xmlFiles) { > +if

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

2019-09-25 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R216 Syntax Highlighting BRANCH add-syntax-srt REVISION DETAIL https://phabricator.kde.org/D24211 To: nibags, #framework_syntax_highlighting, dhaumann,

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

2019-09-25 Thread Dominik Haumann
dhaumann added a comment. I'd indeed prefer another/separate diff. :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24211 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson,

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

2019-09-25 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > subrip-subtitles.xml:22 > + version="1" > + kateversion="5.53" > + section="Other" What feature do you use to require 5.53 instead of 5.0? REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

2019-09-25 Thread Dominik Haumann
dhaumann added a comment. There are also changes in other xml files. Are these intentional? E.g. the changes from WordDetect to RegExpr seem suspicious. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24211 To: nibags, #framework_syntax_highlighting,

D24166: Status bar mode menu: Reuse empty QIcon that is implicitly shared

2019-09-23 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:8cb82970b347: Status bar mode menu: Reuse empty QIcon that is implicitly shared (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D24166: Status bar mode menu: Reuse empty QIcon that is implicitly shared

2019-09-23 Thread Dominik Haumann
dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Instead of creating N empty QIcons, use just one QIcon that

D24164: Expose KTextEditor::MainWindow::showPluginConfigPage()

2019-09-23 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:f1ed78f55d64: Expose KTextEditor::MainWindow::showPluginConfigPage() (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24164?vs=66683=66686

D24164: Expose KTextEditor::MainWindow::showPluginConfigPage()

2019-09-23 Thread Dominik Haumann
dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY The application already has a counterpart that takes a

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-15 Thread Dominik Haumann
dhaumann added a comment. @dfaure: D21197 can be closed / abandoned? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23875 To: dfaure, #frameworks, ahmadsamir Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23935: KateModeMenuList: add "Best Search Matches" section and fixes for Windows

2019-09-14 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > katemodemenulist.cpp:175 > +// which will remain hidden and will only be shown when necessary. > +createSectionList(QStringLiteral(""), false); > +m_list->setRowHidden(0, true); QStringLiteral("") us discouraged and should simply be

D23927: Improve naming of KTitleWidget icon methods

2019-09-13 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > ktitlewidget.h:45 > titleWidget->setText(i18n("Title")); > titleWidget->setPixmap(QIcon::fromTheme("screen").pixmap(22, 22)); > * @endcode Could you also fix the documentation here? This is typically copy & pasted later ;) REPOSITORY

D23884: Fix KListOpenFilesJob unit test on Unix if lsof is not installed

2019-09-11 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > klistopenfilesjobtest_unix.cpp:34 > + > +bool HasLsofInstalled() > +{ Can't you simply use QStandardPaths::findExecutable()? https://doc.qt.io/qt-5/qstandardpaths.html#findExecutable REPOSITORY R244 KCoreAddons REVISION DETAIL

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-11 Thread Dominik Haumann
dhaumann added a reviewer: chinmoyr. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23875 To: ahmadsamir, #frameworks, dfaure, chinmoyr Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-11 Thread Dominik Haumann
dhaumann added a comment. A different patch was proposed with D21197 in May 2019. By the way, this will likely also fix: - https://bugs.kde.org/show_bug.cgi?id=411353: Gwenview crashed during file copy -

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-11 Thread Dominik Haumann
dhaumann edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23875 To: ahmadsamir, #frameworks, dfaure Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-11 Thread Dominik Haumann
dhaumann added a comment. Since this crash is in KCoreDirLister, I wonder whether we can find a unit test that reproduces this without the KFileWidget. But in any case - thanks for having a look into this, since it will fixes a crash in many applications. Bug

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

2019-09-11 Thread Dominik Haumann
dhaumann edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23875 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23832: Backup on save: Support time and date string replacements

2019-09-11 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. dhaumann marked 3 inline comments as done. Closed by commit R39:a32b79d9394a: Backup on save: Support time and date string replacements (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D23832: Backup on save: Support time and date string replacements

2019-09-11 Thread Dominik Haumann
dhaumann updated this revision to Diff 65843. dhaumann added a comment. - Avoid running the backup when no backup prefix/suffix was provided REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23832?vs=65754=65843 BRANCH bug REVISION DETAIL

D23832: Backup on save: Support time and date string replacements

2019-09-11 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > cullmann wrote in katedocument.cpp:2594 > Why not, saves useless evals. No: that's exactly the point: I currently don't think it's possible, but both evals could result in empty strings. Can you do the integration? Author does not matter.

D23832: Backup on save: Support time and date string replacements

2019-09-11 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > katedocument.cpp:2594 > +const auto backupSuffix = > KTextEditor::EditorPrivate::self()->variableExpansionManager()->expandText(config()->backupSuffix(), > nullptr); > +if (backupPrefix.contains(QDir::separator())) { > /**

D23832: Backup on save: Support time and date string replacements

2019-09-10 Thread Dominik Haumann
dhaumann retitled this revision from "Variable expansion: Prefer return value over return argument" to "Backup on save: Support time and date string replacements". dhaumann edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23832

D23832: Variable expansion: Prefer return value over return argument

2019-09-10 Thread Dominik Haumann
dhaumann added a subscriber: ngraham. dhaumann added a comment. @ngraham: This may be interesting to you as well (and a prereq for the External Tools plugin) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23832 To: dhaumann, cullmann Cc: ngraham, kwrite-devel,

D23832: Variable expansion: Prefer return value over return argument

2019-09-10 Thread Dominik Haumann
dhaumann edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23832 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23832: Variable expansion: Prefer return value over return argument

2019-09-10 Thread Dominik Haumann
dhaumann added a reviewer: cullmann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23832 To: dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D23832: Variable expansion: Prefer return value over return argument

2019-09-10 Thread Dominik Haumann
dhaumann updated this revision to Diff 65754. dhaumann added a comment. - rebase to master REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23832?vs=65750=65754 BRANCH bug REVISION DETAIL https://phabricator.kde.org/D23832 AFFECTED FILES

D23832: Variable expansion: Prefer return value over return argument

2019-09-10 Thread Dominik Haumann
dhaumann reopened this revision. dhaumann added a comment. arc bug: it's not yet committed. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23832 To: dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking,

D23832: Variable expansion: Prefer return value over return argument

2019-09-10 Thread Dominik Haumann
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:5ed71b5b75ec: Variable expansion: Prefer return value over return argument (authored by dhaumann). CHANGED PRIOR TO

D23832: Variable expansion: Prefer return value over return argument

2019-09-10 Thread Dominik Haumann
dhaumann added a comment. KateDialogs contains the following: if (uiadv->edtBackupSuffix->text().isEmpty() && uiadv->edtBackupPrefix->text().isEmpty()) { KMessageBox::information( this, i18n("You did not provide a backup suffix or prefix. Using default

D23832: Variable expansion: Prefer return value over return argument

2019-09-10 Thread Dominik Haumann
dhaumann created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Backup on save: Support time and date string replacements Supported variables are: -

D23824: Initial start of variables dialog

2019-09-10 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:6b8b652979a2: Initial start of variables dialog (authored by dhaumann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23824?vs=65730=65732 REVISION DETAIL

D23824: Initial start of variables dialog

2019-09-10 Thread Dominik Haumann
dhaumann created this revision. dhaumann added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY This patch adds one public function to KTextEditor::Editor:

D23797: [KWidgetAddons] port to non-deprecated Qt API

2019-09-09 Thread Dominik Haumann
dhaumann added a comment. Lgtm. INLINE COMMENTS > dhaumann wrote in ktitlewidget.cpp:137 > Is that not needed anymore? Sorry, the next line gives the answer ;) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23797 To: dfaure, cfeck Cc: dhaumann, aacid,

D23797: [KWidgetAddons] port to non-deprecated Qt API

2019-09-09 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > ktitlewidget.cpp:137 > d->headerLayout->setColumnStretch(0, 1); > -d->headerLayout->setMargin(6); > d->headerLayout->setContentsMargins(0, 0, 0, 0); Is that not needed anymore? REPOSITORY R236 KWidgetsAddons REVISION DETAIL

Re: Proposing Quick Charts as a new framework

2019-09-09 Thread Dominik Haumann
Hi, On Sat, Sep 7, 2019 at 3:59 PM Arjen Hiemstra wrote: > On 06-09-2019 02:49, Aleix Pol wrote: > > On Thu, Sep 5, 2019 at 10:53 PM Arjen Hiemstra > > wrote: > >> > >> On 02-09-2019 19:26, Luigi Toscano wrote: > >> > Arjen Hiemstra ha scritto: > [...] > >> That's actually a good point,

D23771: Improve API documentation for Definition::setKeywordList()

2019-09-07 Thread Dominik Haumann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:5db5ac6dad3d: Improve API documentation for Definition::setKeywordList() (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D23771: Improve API documentation for Definition::setKeywordList()

2019-09-07 Thread Dominik Haumann
dhaumann added a comment. Thanks for the quick review! REPOSITORY R216 Syntax Highlighting BRANCH improve-docs REVISION DETAIL https://phabricator.kde.org/D23771 To: dhaumann, sirgienko Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,

D23771: Improve API documentation for Definition::setKeywordList()

2019-09-07 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > sirgienko wrote in definition.h:344 > > In general, ... in general > > Is it correct? Or just accidental typo? Of course not! Thanks! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23771 To: dhaumann,

D23771: Improve API documentation for Definition::setKeywordList()

2019-09-07 Thread Dominik Haumann
dhaumann updated this revision to Diff 65571. dhaumann added a comment. - Fix duplication of "in general" REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23771?vs=65570=65571 BRANCH improve-docs REVISION DETAIL

D23771: Improve API documentation for Definition::setKeywordList()

2019-09-07 Thread Dominik Haumann
dhaumann created this revision. dhaumann added a reviewer: sirgienko. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dhaumann requested review of this revision. REVISION SUMMARY Followup to D23061 .

D23721: Fix race condition in TextBuffer

2019-09-04 Thread Dominik Haumann
dhaumann added a comment. KTextEditor is nowhere designed to be thread-safe. Even if this patch solves a particular issue you have in multithreaded access, we can be sure there will be other (corner?) cases where it won't work: Think only of modifying the text at some other place at the

D23700: view: Port away from foreach loops over members without calls to owner

2019-09-03 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_view REVISION DETAIL https://phabricator.kde.org/D23700 To: kossebau, #kate, dhaumann Cc: kwrite-devel,

D23701: undo: Port away from foreach loops over members without calls to owner

2019-09-03 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_undo REVISION DETAIL https://phabricator.kde.org/D23701 To: kossebau, #kate, dhaumann

D23702: utils: Port away from foreach loops over members without calls to owner

2019-09-03 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm, please commit. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_utils REVISION DETAIL https://phabricator.kde.org/D23702 To: kossebau,

D23703: (others): Port away from foreach loops over members without calls to owner

2019-09-03 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Please commit, thanks. REPOSITORY R39 KTextEditor BRANCH portawayfromforeachforitemconstructionestimation_others REVISION DETAIL https://phabricator.kde.org/D23703 To:

D23689: Port away from Qt's foreach all loops over rvalue container objects

2019-09-03 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm REPOSITORY R39 KTextEditor BRANCH moreplainforeachport REVISION DETAIL https://phabricator.kde.org/D23689 To: kossebau, #kate, dhaumann Cc: dhaumann, kwrite-devel,

D23661: Port away from Qt's foreach all loops over method-local containers

2019-09-02 Thread Dominik Haumann
dhaumann added a comment. Also did a review and it looks good to me, thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23661 To: kossebau, #kate, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh,

D23657: Markdown, TypeScript & Logcat: some fixes

2019-09-01 Thread Dominik Haumann
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH update-syntax REVISION DETAIL https://phabricator.kde.org/D23657 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D23645: Do not generate string list at runtime

2019-09-01 Thread Dominik Haumann
dhaumann added a subscriber: mwolff. dhaumann added inline comments. INLINE COMMENTS > kossebau wrote in katemodemanager.cpp:214 > I saw you mentioned this elsewhere, but thought it was a typo. Never seen > this before, so curious to leatn what advantage using an initializer list > brings

D23645: Do not generate string list at runtime

2019-09-01 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > katemodemanager.cpp:214 > if (! fileName.isEmpty()) { > -static const QStringList commonSuffixes = > QStringLiteral(".orig;.new;~;.bak;.BAK").split(QLatin1Char(';')); > +static const QLatin1String commonSuffixes[] = { > +

D23626: Use QChar overload for single char strings where possible

2019-09-01 Thread Dominik Haumann
dhaumann added a comment. Do you have a clang-tidy plugin for such changes, or do you use a manual regexp for detection? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23626 To: kossebau, #kate, cullmann Cc: dhaumann, cullmann, kwrite-devel,

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

2019-09-01 Thread Dominik Haumann
dhaumann accepted this revision. REPOSITORY R39 KTextEditor BRANCH turnoff-attr REVISION DETAIL https://phabricator.kde.org/D23516 To: nibags, #ktexteditor, cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking,

D23515: Format class: add functions to know if XML files set style attributes

2019-09-01 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Thanks!! REPOSITORY R216 Syntax Highlighting BRANCH format-new-functions REVISION DETAIL https://phabricator.kde.org/D23515 To: nibags, #framework_syntax_highlighting,

D23597: Bulk port away from foreach

2019-09-01 Thread Dominik Haumann
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. I think this patch is good to go in. REPOSITORY R236 KWidgetsAddons BRANCH portmostfporeach REVISION DETAIL https://phabricator.kde.org/D23597 To: kossebau, #frameworks, cfeck,

D23597: Bulk port away from foreach

2019-08-31 Thread Dominik Haumann
dhaumann added a comment. PS: could you do the same for kate.git ? :-D REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D23597 To: kossebau, #frameworks, cfeck Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23597: Bulk port away from foreach

2019-08-31 Thread Dominik Haumann
dhaumann added a comment. I think the patch is fine: +1 Please address/comment on `fir` :) besides that, another review won't hurt, since you simplify the code in 1-2 places, i.e. the changes are slightly more than just the transition to `for`. INLINE COMMENTS > fonthelpers.cpp:97 >

D23515: Format class: add functions to know if XML files set style attributes

2019-08-30 Thread Dominik Haumann
dhaumann added a comment. I believe you still need the hasTextColorOverride etc. hasTextColor is different and matches from the meaning isBold etc. Background: The styleOverrides are yet another concept: if the user changes a color of a highlighting in the Highlighting Text Styles tab,

D23515: Format class: add functions to know if XML files set style attributes

2019-08-30 Thread Dominik Haumann
dhaumann added a comment. Yes, that is also fine with me, please do the changes and proceed. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23515 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause Cc: kwrite-devel,

D23515: Format class: add functions to know if XML files set style attributes

2019-08-29 Thread Dominik Haumann
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. What I currently dislike is that `definitionHasXyz` implies the Definition class has something, which is not correct, since it's about whether the Format has an override. I

D23500: Support for native Matlab strings

2019-08-28 Thread Dominik Haumann
dhaumann added a comment. You can also add the changes from your other review request if you want, since the changes are rather small. But on general it's a good idea to have many small manageable review request instead of one big one. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D23385: More porting from QRegExp to QRegularExpression

2019-08-28 Thread Dominik Haumann
dhaumann added a comment. Oh, in that case can you or @cullmann simply revert this part or #ifdef it? I currently cannot at least until the weekend (sorry!). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23385 To: dhaumann, cullmann Cc: dvratil, kwrite-devel,

D23513: Gettext: Add "Translated String" style and spellChecking attribute

2019-08-28 Thread Dominik Haumann
dhaumann closed this revision. dhaumann added a comment. Sorry accidentally reopened. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23513 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n,

D23513: Gettext: Add "Translated String" style and spellChecking attribute

2019-08-28 Thread Dominik Haumann
dhaumann reopened this revision. dhaumann added a comment. This revision is now accepted and ready to land. Lgtm. There are many dsStrings now, which could be distinguished by the default styles for strings in a later patch (dsVerbatim, ...):

D23516: Fix for all themes: allow turn off attributes in XML highlighting files

2019-08-28 Thread Dominik Haumann
dhaumann added a comment. I like it, although this all will not be needed anymore oncee KTextEditor is fully ported to KSyntaxHighlighting::Theme. Still a long way to go. +1 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23516 To: nibags, #ktexteditor,

D23515: Format class: add functions to know if XML files set style attributes

2019-08-28 Thread Dominik Haumann
dhaumann added a comment. I am thinking about whether ` overwritesBold()` , ... is better than `definitionHasBold()`. Because the `Format` matches an `itemData` in xml. Or even `boldHardcoded()`. Any thoughts? PS: Another solution is to port all xml files to not use hard coded

D23500: Support for native Matlab strings

2019-08-27 Thread Dominik Haumann
dhaumann added a comment. If you use kateversion="5.0" then you can use the new text styles we introduced with KDE 5: https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/ This allows to remove many of the hardcoded colors so that the

D23472: Mimic QInputControl::isAcceptableInput() when filtering typed characters

2019-08-26 Thread Dominik Haumann
dhaumann added a comment. In D23472#519774 , @ahmadsamir wrote: > Digging around in git log I found: https://git.reviewboard.kde.org/r/127026/ > > But I think that's covered by the method in QInputControl, and ktexteditor has a unit test

D22477: With auto completion don't show completions that don't match from beginning of typed word

2019-08-26 Thread Dominik Haumann
dhaumann added a comment. Unconditionally removing this is not a good idea, since the feature significantly helps to discover API via code completion. In any case, feedback from @kfunk, @molff is needed here imho REPOSITORY R39 KTextEditor REVISION DETAIL

D23061: Possiblity to change Definition data after loading

2019-08-26 Thread Dominik Haumann
dhaumann added inline comments. INLINE COMMENTS > sirgienko wrote in definition.h:339 > Is it enough? I mean, I can add explanation, that rehiglighting whole > document (after keyword list modification) works via > `QSyntaxHighlighter::rehighlight()`, but i think, it is pretty obivously for >

D23323: Add support for handling QNAM SSL errors to KSslErrorUiData

2019-08-25 Thread Dominik Haumann
dhaumann added a comment. In D23323#516317 , @apol wrote: > Makes sense, but I feel some explanation is missing ^^' > > Put it in the commit message? Better: put it into the API documentation? REPOSITORY R241 KIO REVISION DETAIL

  1   2   3   4   5   6   7   8   9   10   >