Re: QString -> QStringLiteral conversions might make applications crash on exit

Hi, 2016-02-29 19:04 GMT+01:00 Milian Wolff: > On Friday, February 26, 2016 1:37:57 AM CET Frank Reininghaus wrote: >> Hi everyone, >> >> sorry if most of you know about this already, but since it seems that >> QStringLiterals are being introduced ev

Re: QString -> QStringLiteral conversions might make applications crash on exit

Hi Albert, 2016-02-28 11:54 GMT+01:00 Albert Astals Cid: > El Friday 26 February 2016, a les 01:37:57, Frank Reininghaus va escriure: >> Hi everyone, >> >> sorry if most of you know about this already, but since it seems that >> QStringLiterals are being introduced ev

Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl

l. To reply, visit: > https://git.reviewboard.kde.org/r/127111/ > --- > > (Updated Feb. 18, 2016, 9:53 p.m.) > > > Review request for Dolphin, KDE Frameworks, Emmanuel Pescosta, and Frank > Reininghaus. > > > Bug

Re: Review Request 126894: Refactor the listjobtest to allow listing of multile paths.

overhead is added to each allocation. Each allocation takes at least 32 bytes of memory when using GCC+glibc on a 64-bit system. But I guess that there must be a better way than the `cin.ignore()` hack to easily get the real memory usage. - Frank Reininghaus On Jan. 26, 2016, 3:34 nachm

Re: Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

currently do not > have a full self-built Plasma session running. It could probably be checked > by opening the "Properties..." of a file in FolderView, clicking the icon, > and then opening the "Browse..." sub dialog of the KIconDialog. This should > hopefully not lock the

Review Request 126750: Make KIconDialog and its sub-dialog Qt::WindowModal, rather than Qt::NonModal

then opening the "Browse..." sub dialog of the KIconDialog. This should hopefully not lock the entire Plasma session (because the dialogs are window modal, and not application modal). If anyone finds problems with that or has ideas for improvement, please let me know! Thanks,

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

find a fail-safe solution with a dynamically increasing buffer prettier, but it's so extremely unlikely that this will ever cause problems that it's not worth arguing about it :-) - Frank Reininghaus On Okt. 10, 2015, 3:29 nachm., David Faure wrote

Re: Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 119 - Still Unstable!

Am 07.10.2015 22:25 schrieb "Albert Astals Cid" <aa...@kde.org>: > > El Tuesday 06 October 2015, a les 19:20:00, Frank Reininghaus va escriure: > > Hi, > > > > 2015-10-06 15:04 GMT+02:00 <no-re...@kde.org>: > > > GENERAL INFO > > > &

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 4b24b70c93523c5bc56c90c04a5a666331e96a1b by Frank Reininghaus to branch master. Bugs: 350769 https://bugs.kde.org/show_bug.cgi?id=350769 Repository: kio Description

Re: Review Request 124983: Move the desktop files and file templates for the "Create New..." menu from kde-baseapps to kio

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 1b98a313983b75f3340639e5cd9519c56fca7113 by Frank Reininghaus to branch master. Bugs: 349654 https://bugs.kde.org/show_bug.cgi?id=349654 Repository: kio Description

Re: Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 119 - Still Unstable!

Hi, 2015-10-06 15:04 GMT+02:00 : > > GENERAL INFO > > BUILD UNSTABLE > Build URL: > https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/119/ > Project: PLATFORM=Linux,compiler=gcc > Date of build: Tue, 06 Oct 2015 12:34:13 + > Build duration: 14

Re: Review Request 125515: Preserve relative link targets when copying symlinks.

1000 bytes are guaranteed to be enough. Some quick Googling tells me that path lengths of 4096 are possible. Maybe we could allocate a temporary large array on the heap if the readlink call fails with the 1000 byte buffer on the stack? - Frank Reininghaus On Okt. 4, 2015, 9:24 vorm., David

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86276 --- On Okt. 3, 2015, 7:50 vorm., Frank Reining

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

oth, > > querying for both and skipping the installation of > > konqpopupmenuplugin.desktop if the KIO version is > 5.15? > > Frank Reininghaus wrote: > If we change the ServiceType entry in the file, then every service menu > will have to be changed, right

Re: Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

ServiceType/file name mismatch. - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125425/#review86028 --- On Sept. 27,

Review Request 125425: Add the desktop file that is required for adding services to the context menu for files and directories

/widgets/CMakeLists.txt 820cd34 src/widgets/kioservicemenuplugin.desktop PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125425/diff/ Testing --- Konsole service actions are shown in the context menu again. Thanks, Frank Reininghaus

Re: Review Request 124983: Move the desktop files and file templates for the "Create New..." menu from kde-baseapps to kio

te New..." menu was empty then, but it is populated again with this patch. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

: it is possible to create hidden directories, and it is also possible to choose a new name. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 689fd43ae226ad026dd2fb6e198a5fef40c24b13 by Frank Reininghaus to branch master. Bugs: 352770 https://bugs.kde.org/show_bug.cgi?id=352770 Repository: kio Description

Re: Review Request 125158: add logic to use icons for default xdg user dirs

add a .directory file with the desired icon name. Is there a reason why the problem can't be solved this way? - Frank Reininghaus On Sept. 11, 2015, 10:50 vorm., Harald Sitter wrote: > > --- > This is an automatically generat

Review Request 124983: Move the desktop files and file templates for the Create New... menu from kde-baseapps to kio

, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

On Mai 12, 2015, 3:49 nachm., Jan Kundrát wrote: Was the old code a part of some release? If yes, this should get a CVE security announcement because it allows a local attacker to e.g. force you to overwirte some of your user's files. Michael Palimaka wrote: It looks like it was

Re: OSX/CI: kio placed files erroneously due to missing required backslash in path

Hi, 2014-12-23 9:44 GMT+01:00 David Faure: On Tuesday 23 December 2014 00:59:56 Marko Käning wrote: Fixed in http://commits.kde.org/kio/c5522b6931908d3fd8ad97555a3edf2a3e859b50 Ooops, should I have pushed this through Gerrit before committing? Nope, that's fine, trivial fix. Thanks!

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

. - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452/#review72334 --- On Dez. 11, 2014, 10:08 nachm., Frank Reininghaus

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

/2014/12/09/038e443c-78eb-443b-b33a-b451b28d10ea__UDSEntry-benchmarks.png Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/038e443c-78eb-443b-b33a-b451b28d10ea__UDSEntry-benchmarks.png Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Change in kio[master]: Apply the edited URL to the navigator when clicking the Che...

Frank Reininghaus has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/233 Change subject: Apply the edited URL to the navigator when clicking the Check button .. Apply the edited URL to the navigator

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

--- On Dez. 9, 2014, 10:44 nachm., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

). - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118452/#review71763 --- On Dez. 9, 2014, 10:44 nachm., Frank Reininghaus wrote

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

://git.reviewboard.kde.org/media/uploaded/files/2014/12/09/038e443c-78eb-443b-b33a-b451b28d10ea__UDSEntry-benchmarks.png Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119607: Support for .hidden files

On Sept. 14, 2014, 3:27 nachm., Frank Reininghaus wrote: src/core/kfileitem.h, line 262 https://git.reviewboard.kde.org/r/119607/diff/2/?file=301216#file301216line262 Since we probably do not want to make it possible that all users of this class can make items hidden, I'm

Re: How to port KTabBar::mouseMiddleClick?

Hi, 2014-11-06 2:59 GMT+01:00 Milian Wolff: Hey all, what do I do to get middle-click-closes-tab in Qt 5 without KTabBar? Previously, we used KTabBar and its mouseMiddleClick signal. AFAIK, currently the only solution is to subclass QTabBar, override the mousePressEvent method and emit a

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

On Okt. 23, 2014, 11:14 vorm., Emmanuel Pescosta wrote: src/widgets/krun.cpp, line 1013 https://git.reviewboard.kde.org/r/120666/diff/2/?file=321616#file321616line1013 Any reason why using show instead of exec? Exec would avoid the rather complex and error-prone code path.

Re: KConfig build fails

Hi, 2014-07-14 23:21 GMT+02:00 David Gil Oliva: Hi! KConfig build fails with this messages, all of them related to QBasicAtomicInt. Are they KF5 bugs? probably this is the same issue that has been discussed in https://git.reviewboard.kde.org/r/119257/ ? According to David F., this might

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

/ Testing --- Unit tests still pass. I verified that the memory usage of a KFileItemList with many items decreases as expected. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

Diff: https://git.reviewboard.kde.org/r/118775/diff/ Testing --- Unit tests still pass. I verified that the memory usage of a KFileItemList with many items decreases as expected. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing

KCoreAddons does not install most of its headers on my system

Hello everyone, I tried to set up a separate Qt5+KF5 build in release mode. Unfortunately, I did not succeed :-( The first package that fails to build (even if I repeat the kdesrc-build process many times) is kservice. The comiler reports [ 30%] Building CXX object

Review Request 118775: Make KFileItem a Q_MOVABLE type

with many items decreases as expected. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

. - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/#review60179 --- On June 16, 2014, 7:58 a.m., Frank Reininghaus wrote

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

://git.reviewboard.kde.org/r/118452/#review59479 --- On June 1, 2014, 1:50 p.m., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations

://git.reviewboard.kde.org/r/118269/diff/ Testing --- Fixes the crash for me, and the confirmation dialog works as expected (i.e., the user can choose if the file should really be deleted/trashed or not). Thanks, Frank Reininghaus ___ Kde-frameworks

Re: Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations

! - Frank --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118269/#review58902 --- On May 22, 2014, 9:39 p.m., Frank Reininghaus wrote

Re: KIO directory listing - CPU slows down SSD

Hi, 2014-06-02 18:42 GMT+02:00 Aaron J. Seigo: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: dolphin on a massive folder. In fact, those that use kio::listdir for listing folders only have interfaces that become usable when all entries are fetched. assuming these UIs receive

Re: KIO directory listing - CPU slows down SSD

Hi, 2014-06-02 20:54 GMT+02:00 Mark Gaiser: On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: dolphin on a massive folder. In fact, those that use kio::listdir for listing folders only have interfaces that become usable when all

Re: KIO directory listing - CPU slows down SSD

Hi, 2014-06-02 23:39 GMT+02:00 Frank Reininghaus: Hi, 2014-06-02 20:54 GMT+02:00 Mark Gaiser: On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: dolphin on a massive folder. In fact, those that use kio::listdir for listing folders

Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118269: Fix crash when showing the confirmation dialog for trash/delete operations

, and the confirmation dialog works as expected (i.e., the user can choose if the file should really be deleted/trashed or not). Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

really want that the detailed listview in dolphin? I can more easily recognize the biggest number by being the one with most digits, than having to go through a list of kB, MB, and GB values. It might even break the sorting by size. Let's ask Frank Reininghaus, but I'm not sure

Re: KIO directory listing - CPU slows down SSD

Hi Mark, 2014-05-11 21:57 GMT+02:00 Mark Gaiser: Hi, I've been playing with KIO speed improvements for quite a while now and found some very interesting issues with KIO in combination with my SSD drive: Samsung SSD 840 PRO Series. My testcase is one directory filled with 500.000 files to

Re: Review Request 117799: Clean up private slots in KCompletion

straightforward transformation, and I haven't spotted anything that looks like it could break things. Considering that the tests still work for you, I think that there is no reason not to push it. - Frank Reininghaus On April 26, 2014, 11:23 p.m., David Gil Oliva wrote

Re: Review Request 116886: Refactor private variables of KCompletion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116886/#review53705 --- Ship it! Looks reasonable to me, thanks! - Frank

Re: Review Request 116886: Refactor private variables of KCompletion

, one could make 'order' a bitfield and move it next to the bools. - Frank Reininghaus On March 18, 2014, 11:01 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 116542: Fix compilation with clang 3.4.

and thanks for taking care of it. I wasn't aware at all that there might be a problem if the operator== is declared outside the namespace, but if I had been, then I would have put it inside he namespace, of course. So Ship it! from me too. - Frank Reininghaus On March 2, 2014, 8:20 p.m., Milian Wolff

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

results when I work on further improvements in the future. Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

On Feb. 15, 2014, 7:38 p.m., David Faure wrote: src/khistorycombobox.cpp, line 508 https://git.reviewboard.kde.org/r/115710/diff/1/?file=243810#file243810line508 infinite recursion! Sounds like a unittest for reset() should be added. David Gil Oliva wrote: There

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

://git.reviewboard.kde.org/r/115739/#review49873 --- On Feb. 13, 2014, 8:23 p.m., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

depends on qtbase, I might be able to just do a release build of qtbase and build a stand-alone version of UDSEntry+benchmarks on top of that. I'll look into this option for getting reliable benchmark results when I work on further improvements in the future. Thanks, Frank Reininghaus

Re: Review Request 115739: Make UDSEntry a Q_MOVABLE type, and add some benchmarks and tests

., Frank Reininghaus wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115739/ --- (Updated Feb. 13, 2014, 8:23 p.m

Review Request 114921: Make KFileItemActions the parent of the actions it creates

. Existing kio unit tests pass on my system (except for kiocore-kacltest, but I believe that the failure is unrelated to this patch). Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

://git.reviewboard.kde.org/r/114921/diff/ Testing --- New unit test crashes with master, and passes if the patch is applied. Existing kio unit tests pass on my system (except for kiocore-kacltest, but I believe that the failure is unrelated to this patch). Thanks, Frank Reininghaus

Re: Review Request 114921: Make KFileItemActions the parent of the actions it creates

/diff/ Testing --- New unit test crashes with master, and passes if the patch is applied. Existing kio unit tests pass on my system (except for kiocore-kacltest, but I believe that the failure is unrelated to this patch). Thanks, Frank Reininghaus

Re: Tracking bugs in Frameworks

Hi, 2013/12/14 David Edmundson: As we gear Frameworks up for release we need a way to track bugs that exist in the new Frameworks. We have two options; either we copy all the bugs in kdelibs, triaging, testing and moving to the right new component or we start fresh. There are approximate

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

On Nov. 25, 2013, 1:48 p.m., Kevin Ottens wrote: Any chance for a review? We really need to tie up loose ends now. I think that this is a very nice piece of work, and the new data-driven test also looks good to me. The only thing I'm concerned about is the run time of the test - I like

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

to, and having it point to the next item (or end()) afterwards. - Frank Reininghaus On Nov. 15, 2013, 9:48 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request 113877: Use QMutableMapIterator for removing KStartupInfoIds

with a less time-consuming solution. If there was a signal that was emitted if everything went OK, one could simply wait for it. - Frank Reininghaus On Nov. 15, 2013, 10:42 a.m., Martin Gräßlin wrote: --- This is an automatically

Re: Review Request 112717: Start adopting QCollator

On Sept. 15, 2013, 10:29 a.m., Frank Reininghaus wrote: Thanks for your cool work on QCollator! It will be interesting to see how much we can gain by using QCollatorSortKey for sorting large sets of QStrings :-) I'm not really familiar with most of the affected code, and I couldn't

Re: Review Request 112717: Start adopting QCollator

On Sept. 15, 2013, 10:29 a.m., Frank Reininghaus wrote: Thanks for your cool work on QCollator! It will be interesting to see how much we can gain by using QCollatorSortKey for sorting large sets of QStrings :-) I'm not really familiar with most of the affected code, and I couldn't

Re: Review Request 112717: Start adopting QCollator

. Probably the best solution would be to try to get something like our KStringHandler::naturalCompare() function into qcollator_posix.cpp, to make sure that the fallback that is used if ICU isn't available actually uses numeric mode if it's told to? - Frank Reininghaus On Sept. 13, 2013, 5:55

Re: KFileItem (Re: Jenkins build became unstable: kdelibs_frameworks_qt5 #982)

Hi, 2013/8/22 David Faure: On Thursday 08 August 2013 13:17:18 Frank Reininghaus wrote: Hi David, 2013/8/7 David Faure: On Tuesday 06 August 2013 20:53:05 Frank Reininghaus wrote: OK, I see now that it uses pointers to be able to modify the actual KFileItems in KDirListerCache

Re: Review Request 111897: Move KFileMetaData (and friends) to kde4support

On Aug. 6, 2013, 9 a.m., Vishesh Handa wrote: I was just working on the same thing. I'm not sure if we want to move this to kde4support. Can we just throw it away? Or would that be terribly wrong? We have a replacement in nepomuk-widgets. Strigi doesn't need to be ported to

Re: Revising changing configurations with KConfig

Hi, 2013/8/1 Kevin Ottens: On Thursday 01 August 2013 00:57:05 Aleix Pol wrote: Well, that setting is used in KDirSortFilterProxyModel as well... Should we just always sort naturally by default there then? Would make sense to add an accessor pair to KDirSortFilterProxyModel, and have the

Review Request 111789: Improve KFileItemList memory usage and performance

/2013/07/29/before.png Memory usage WITH patch http://git.reviewboard.kde.org/media/uploaded/files/2013/07/29/after.png Thanks, Frank Reininghaus ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: naturalCompare Qt5 task

Hi, 2013/7/19 Aleix Pol: Hi, I was looking at that task in the Qt5 epics list and I didn't understand it fully. contribute natural-comparison to Qt5 (see KStringHandler). In Qt there is naturalCompare function but private and not as good as from KStringHandler. Thiago says: add the feature

Re: KF5 Update Meeting Minutes 2013-w24

Hi, thanks for the explanation! 2013/6/12 Kevin Ottens: Hello, On Tuesday 11 June 2013 21:08:45 Frank Reininghaus wrote: 2013/6/11 Kevin Ottens: [...] * ItemViews will be tier 2 until we contribute the natural compare to Qt; I thought that Qt 5.1 will have the QCollator class, which

Re: KF5 Update Meeting Minutes 2013-w24

Hi, 2013/6/11 Kevin Ottens: [...] * ItemViews will be tier 2 until we contribute the natural compare to Qt; I thought that Qt 5.1 will have the QCollator class, which can perform natural comparison of strings if you use numeric mode? Cheers, Frank

Re: please make it easier to hack on frameworks

Hi, 2013/4/30 Aaron J. Seigo: On Tuesday, April 30, 2013 11:20:47 Stephen Kelly wrote: I am clueless to understand why building cmake from git and installing it into your kf5 prefix is a showstopper. Can you tell me? Time is limited. Every repository that I have to build (e.g. cmake)

Re: Review Request 109538: port KFileMetaDataReader to QProcess

On March 17, 2013, 2:05 p.m., Vishesh Handa wrote: But why? KFileMetadataReader and the other KFileMetadataStuff should just be marked as deprecated. Why are we porting them? We already have better alternatives in the nepomuk-widgets repository. Martin Tobias Holmedahl Sandsmark

Re: Separating everything ?

Hi, 2013/2/7 Kevin Ottens: On Thursday 7 February 2013 16:09:51 Frank Reininghaus wrote: Is there anything obvious that I'm overlooking? One could argue that separate repositories make it easier for non-KDE people to contribute to one particular framework. It's not only contributing

Re: Separating everything ?

Hi Patrick, 2013/2/8 Patrick Spendrin: Am 07.02.2013 23:32, schrieb Frank Reininghaus: ... Since I am reading this thread by chance, I might as well reply. One of the reasons of splitting kdelibs into separate repositories is to simplify the usage of single modules. From the perspective

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

Hi Mark, 2013/2/4 Mark: I really really really dislike KDirModel and friends (KDirLister, KFileItem). before you get even more emotional in your next reply to this thread, please consider reading http://www.kde.org/code-of-conduct/ I sort of got used to reading disrespectful messages with

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

Hi, 2013/1/21 Aaron J. Seigo: On Tuesday, January 15, 2013 10:40:58 Frank Reininghaus wrote: Right, but considering that Dolphin doesn't even use KDirModel any more, going the QAbstractItemView way would feel like throwing away most of what happened in Dolphin in the last 2 years. dolphin

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

Hi, 2013/1/21 Aaron J. Seigo ase...@kde.org: On Monday, January 21, 2013 17:53:48 Frank Reininghaus wrote: http://ppenz.blogspot.de/2011/08/introducing-dolphin-20.html Ah, that's right .. it uses ItemViewsNG. of which the last commits seem to be in 2010, and QGraphicsView is not receiving

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

Hi, 2013/1/9 Mark: On Wed, Jan 9, 2013 at 2:51 PM, David Faure wrote: On Wednesday 09 January 2013 11:15:20 Mark wrote: A little more in depth questions for KDirLister and KFileItem. In my profiling KFileItem ends up high due to various reasons, but KDirLister is also a bit of a heavy

Re: KDirModelV2, KDirListerV2 and UDSEntryV2 suggestions

Hi, 2013/1/10 Aaron J. Seigo: in the case of dolphin, i can imagine a goal that could lead to over- calculating: wanting even spacing between all icons, which in turn means knowing how much space each and every icon will require (thumbnail? how much text? etc.) The number of text lines

Re: Introduction and PhononQt5 porting

Hi Jon, 2012/10/7 Jon Severinsson: Hi again With the previosly mentioned updated phonon [1], and these three fixes to kdelibs [2], it all compiles for me. The unit test does however show several failure, but I'll have to investigate that another day, as it is past midnight here... Best

Re: Porting KWidgets to Qt5

Hi, 2012/7/9 Иван Комиссаров: I answered to them. They disagree with them in that case. For me is biggest priority is to port as much kde as code as possible. getting code upstream into Qt is good, of course, but you can't expect that the Qt people will accept KDE code without modifications.

Re: Porting KWidgets to Qt5

Hi, 2012/7/9 Иван Комиссаров: Hm, it seems that Qt guys are not very happy seeing KDE features in qt. I would like someone from KDE to participate in discussions about changes. For example, they insist that KTabBar functionality is not needed as it can be easily implemented in subclass:)

Re: Monitoring autotest coverage in frameworks

Hi, Am 1. März 2012 00:44 schrieb Dario Freddi: I was wondering if we already had a way to generate reports on autotests coverage using lcov/gcov in frameworks. Looking at our cmake infrastructure, I spotted a build mode Profile which should apparently set the correct compiler flags (but