Re: Major CI changes - FreeBSD and Linux

On Mon, Jan 22, 2024 at 12:09 PM Ben Cooksley wrote: > > Hi all, > > Over the past few weeks significant work has been undertaken to develop the > ability to make use of containerised builds for FreeBSD. This is great news! Thank you for all the work done on that front.

Re: Gitlab CI Dashboards and retirement of build.kde.org

On Sat, Sep 3, 2022 at 7:46 AM Ben Cooksley wrote: > > As previously indicated, I have now shutdown build.kde.org along with the > domain that supported it's version of the CI tooling. > The repository containing that tooling has now also been archived, and the > former build.kde.org domain has

Re: Rollout of Gitlab CI

On Sun, Oct 3, 2021 at 10:40 AM Ben Cooksley wrote: > As an update to this, work on FreeBSD and Android support is progressing > well and should be made available within the next week all going well. > As a FreeBSD user I'm extremely excited about this. Thanks for all your hard work! Cheers, >

D17816: Support for xattrs on kio copy/move

arrowd abandoned this revision. arrowd added a comment. Mark the revision as closed to reflect reality. REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: kdudka, usta, scheirle, tmarshall, arrowd, cfeck, bruns,

D17816: Support for xattrs on kio copy/move

arrowd added a comment. In D17816#677446 , @kdudka wrote: > I was wondering why copying files in Krusader or Dolphin from a vfat-formatted memory card stopped working for me after update. After copying the first file, the transfer stopped progr

KACL from KIO isn't really POSIX-compliant

Hello everyone. I tried compiling kio/src/core/kacl.cpp on FreeBSD, which does support POSIX ACLs, and failed. This is because KACL's code uses non-standard Linux-specific acl_* functions. I tried implementing them using standard ones and it turned out to be impossible, mainly because types like a

D17816: Support for xattrs on kio copy/move

arrowd added inline comments. INLINE COMMENTS > dfaure wrote in ConfigureChecks.cmake:12 > I'm talking about the implementation of fileSystemSupportsACL in > kpropertiesdialog.cpp, which uses getxattr. > But now that I take another look at it, I see that it's already implemented > on FreeBSD, w

D17816: Support for xattrs on kio copy/move

arrowd added inline comments. INLINE COMMENTS > dfaure wrote in ConfigureChecks.cmake:12 > Ah, I see, OK. No extra lib needed makes it simple. > > The FindACL.cmake stuff is a bit of a mess now, with the need for extended > attributes outside the ACL related code. > Maybe this could be split up

D17816: Support for xattrs on kio copy/move

arrowd added inline comments. INLINE COMMENTS > dfaure wrote in ConfigureChecks.cmake:12 > This is already done by `cmake/FindACL.cmake`, why not add the other one > (extattr.h) to that file as well? > > The CMakeLists.txt in this directory calls `find_package(ACL)` so it'll be > used. > > Ev

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83375. arrowd marked an inline comment as done. arrowd added a comment. - Put FileProtocol::copyXattrs inside a #if CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83366&id=83375 BRANCH arcpatch-D17816 REVISION DETAIL https://phabric

D17816: Support for xattrs on kio copy/move

arrowd added a comment. Another bump. REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, ath

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83366. arrowd marked 5 inline comments as done. arrowd added a comment. - Address comments. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83365&id=83366 BRANCH arcpatch-D17816 REVISION DETAIL https://phabricator.kde.org/D17816 AFF

D17816: Support for xattrs on kio copy/move

arrowd added inline comments. INLINE COMMENTS > usta wrote in file_unix.cpp:1517 > isnt this ignoring acl_from_mode part ? I mean not sure but i think we need > to check if it is nullptr or not before assigning it otherwise we will ignore > the acl_from_mode part. You seem to be right. I blame

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83365. arrowd marked an inline comment as done. arrowd added a comment. - More const QString. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83364&id=83365 BRANCH arcpatch-D17816 REVISION DETAIL https://phabricator.kde.org/D17816 A

D17816: Support for xattrs on kio copy/move

arrowd added inline comments. INLINE COMMENTS > bruns wrote in jobtest.cpp:780 > And now you **only** check the source FS, but no longer the destination FS. To be honest, I was confused by your first comment. What was wrong with the first version of this code? My understanding was that we want

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83364. arrowd marked 2 inline comments as done. arrowd added a comment. - Make checkXattrFsSupport accept directory as a parameter. - Consitify QStrings. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83361&id=83364 BRANCH arcpatch-D

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83361. arrowd marked an inline comment as done. arrowd added a comment. - Return "true" if the file doesn't have any xattrs. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83334&id=83361 BRANCH arcpatch-D17816 REVISION DETAIL https:

D17816: Support for xattrs on kio copy/move

arrowd added a comment. Bump. REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane,

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83334. arrowd added a comment. Rebase on master. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83319&id=83334 BRANCH arcpatch-D17816 REVISION DETAIL https://phabricator.kde.org/D17816 AFFECTED FILES autotests/jobtest.cpp autot

D17816: Support for xattrs on kio copy/move

arrowd added inline comments. INLINE COMMENTS > bruns wrote in jobtest.cpp:487 > not done ... There are no arrays of `512` size anymore. Or am I missing something? REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83319. arrowd marked an inline comment as done. arrowd added a comment. - Remove extraneous debugging output. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83318&id=83319 BRANCH arcpatch-D17816 REVISION DETAIL https://phabricator.k

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83318. arrowd marked 3 inline comments as done. arrowd added a comment. - Handle attrs with empty values. - Add test for it. - Fix syscalls for FreeBSD case. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83309&id=83318 BRANCH arcp

D17816: Support for xattrs on kio copy/move

arrowd added inline comments. INLINE COMMENTS > bruns wrote in file_unix.cpp:625 > Infinite loop on valuelen == 0 Why? `ERANGE` means we need to come up with new value for `valuelen`, so we set it to zero and start over. On the new iteration it gets passed into `fgetxattr`/`extattr_get_fd` to

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83309. arrowd marked an inline comment as done. arrowd added a comment. - Improve comment. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83302&id=83309 BRANCH arcpatch-D17816 REVISION DETAIL https://phabricator.kde.org/D17816 AFFE

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83302. arrowd added a comment. - Rebase on master. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83207&id=83302 BRANCH arcpatch-D17816 REVISION DETAIL https://phabricator.kde.org/D17816 AFFECTED FILES autotests/jobtest.cpp aut

D17816: Support for xattrs on kio copy/move

arrowd added a comment. I'd appreciate if someone test this on Linux and MacOS. I got FreeBSD covered. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd,

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83207. arrowd marked 8 inline comments as done. arrowd added a comment. - Address comments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83203&id=83207 BRANCH arcpatch-D17816 REVISION DETAIL https://phabrica

D17816: Support for xattrs on kio copy/move

arrowd added a comment. Almost every comment have been addressed. Please, give this another look. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83203. arrowd marked 17 inline comments as done. arrowd added a comment. - Address comments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83192&id=83203 BRANCH arcpatch-D17816 REVISION DETAIL https://phabric

D17816: Support for xattrs on kio copy/move

arrowd marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davide

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83192. arrowd marked 2 inline comments as done. arrowd added a comment. - Change the algorithm in FileProtocol::copyXattrs() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83166&id=83192 BRANCH arcpatch-D17816 R

D17816: Support for xattrs on kio copy/move

arrowd marked an inline comment as done. arrowd added a comment. Mark stale command as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bru

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83166. arrowd marked an inline comment as done. arrowd added a comment. - Use std::function to store a generator function for m_setXattrCmd's arguments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83143&id=83166

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83143. arrowd marked 5 inline comments as done. arrowd added a comment. - Refactor common code from compareXattr() into readXattr() as requested in comments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83068&id=

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83068. arrowd marked 18 inline comments as done. arrowd added a comment. - Use full paths to command line utilities and pass xattr args correctly. - Mark some stale comments as done. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.k

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 83016. arrowd added a comment. - Fix tests on FreeBSD. - Fix bug: Move `keylist.squeeze()` call before acquiring an interator. At this stage, all tests in `jobtest` pass on FreeBSD. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricat

D17816: Support for xattrs on kio copy/move

arrowd updated this revision to Diff 82960. arrowd added a comment. I decided to help with this a bit. - Fix detection of header. It requires to be included too. - Implement test helpers for BSD (extattr). At the moment, some tests fail for me, because xattrs don't seem to be co

D17816: Support for xattrs on kio copy/move

arrowd commandeered this revision. arrowd added a reviewer: cochise. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho,

Re: Does FreeBSD have HAL?

On Sun, Jan 5, 2020 at 3:37 PM Tijl Coosemans wrote: > On Sun, 5 Jan 2020 10:06:08 +0100 "Tobias C. Berner" > wrote: > > Moin moin > > > > We will replace (ancient) hal with Gleb's implementation of usdisks2 > > "bsdisks2" in the near future by default. > > > > Hald is likely not enabled on the C

Re: Does FreeBSD have HAL?

On Sun, Jan 5, 2020 at 1:06 PM Tobias C. Berner wrote: > Moin moin > > We will replace (ancient) hal with Gleb's implementation of usdisks2 > "bsdisks2" in the near future by default. > > Hald is likely not enabled on the CI hosts -- I could enable it :) -- > or we could push the switch and make

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd added a comment. I'm not familiar with KDE release engineering, so I'm asking to do merging someone else. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel, #f

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

This revision was automatically updated to reflect the committed changes. Closed by commit R126:6d86fd453417: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with… (authored by arrowd). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kd

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd added a comment. In D22525#498393 , @dfaure wrote: > I suppose the kate developers like the fact that this currently works over FTP, SFTP, FISH, SMB, etc. > So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries have

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd added a reviewer: Frameworks. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensre

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd added a comment. In D22525#497556 , @cfeck wrote: > Oh, if the latter syntax also works, then you are right. Not sure what you mean by "also works". Current code checks if the URL ends with `:x:y` and turns it into `?line=x&column=

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd added a comment. In D22525#497332 , @cfeck wrote: > Could we only apply the `:xx` check on the filename part, not on the server part? Someone might expect that `http://path.to/file.txt:99` also works for remote files. I don't thin

D22525: kioclient: Don't convert `:x:y` to `?line=x&column=y` for URLs starting with remote schemes.

arrowd created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arrowd requested review of this revision. REVISION SUMMARY BUG: 408632 TEST PLAN `kioclient5 exec http://localhost:9000` now works correctly. REPOSITORY R126 KDE CLI Utilities BRANCH m

D20967: [UserMetaData] Add method to query which attributes are set

arrowd added a comment. Now the test passes! INLINE COMMENTS > xattr_p.h:194 > +{ > +int pos; > +QList entries; variable 'pos' is uninitialized REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham C

D21720: Enable usermetadatawritertest for all UNIXes, not only Linux.

This revision was automatically updated to reflect the committed changes. Closed by commit R286:346918916474: Enable usermetadatawritertest for all UNIXes, not only Linux. (authored by arrowd). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21720?vs=5950

D21720: Enable usermetadatawritertest for all UNIXes, not only Linux.

arrowd created this revision. arrowd added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. arrowd requested review of this revision. TEST PLAN The test passes on FreeBSD. REPOSITORY R286 KFileMetaData BRANCH mas

D20967: [UserMetaData] Add method to query which attributes are set

arrowd added a comment. In D20967#477314 , @bruns wrote: > Apparently, the usermetadatawritertest was not executed on *BSD before, can you check if the test succeeds on the old code? Yep, it works on master. The output with `qDebug()

D20967: [UserMetaData] Add method to query which attributes are set

arrowd added a comment. It compiles now, but the test fails: * Start testing of UserMetaDataWriterTest * Config: Using QtTest library 5.12.2, Qt 5.12.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 8.0.0 (tags/RELEASE_800/final 356365)) PASS

D20967: [UserMetaData] Add method to query which attributes are set

arrowd added inline comments. INLINE COMMENTS > xattr_p.h:204 > +#elif defined(Q_OS_FREEBSD) || defined(Q_OS_NETBSD) > +const ssize_t size = extattr_list_file(encodedPath, > EXTATTR_NAMESPACE_USER, attributeName, nullptr, 0); > +#endif error: use of undeclared identifier 'attributeN

D21380: show static word wrap marker always if requested

arrowd accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D21380 To: cullmann, #ktexteditor, #frameworks, arrowd Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, br

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd marked an inline comment as done. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, elvisangelaccio Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenB

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

This revision was automatically updated to reflect the committed changes. Closed by commit R126:8072a6acf221: Add support for passing cursor information via URL parameters when running… (authored by arrowd). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18296?vs=55879&id=55973#toc REPOS

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added inline comments. INLINE COMMENTS > dfaure wrote in urlinfo.h:77 > But then you can't do `kde-open5 www.google.fr` anymore, right? > > I see what you mean with typo handling, but there is no perfect solution. > Either we treat typos as URLs (but it means we also treat actual URLs as

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd updated this revision to Diff 55879. arrowd marked 5 inline comments as done. arrowd added a comment. Address comments. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18296?vs=54774&id=55879 BRANCH cursor REVISION DETAIL https://phabr

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. In D18296#445829 , @dfaure wrote: > Is the makeURL function still used, or should it be removed now? Yep, it is still used in a bunch of other places. INLINE COMMENTS > dfaure wrote in urlinfo.h:39 > const QString

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added inline comments. INLINE COMMENTS > elvisangelaccio wrote in urlinfo.h:45-52 > Why doesn't it parse the URL if the file already exists? If the file is named `foo:123`, it refuses to search for cursor infomation and just open it. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

arrowd added a comment. In D18296#444642 , @elvisangelaccio wrote: > Is it really necessary to copy `urlinfo.h` here? Wouldn't be enough to just create a static function and put the URL parsing logic there? I just copied this from Kate p

D17938: Add support for passing cursor information to KRun.

arrowd abandoned this revision. arrowd added a comment. Right. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17938 To: arrowd, #frameworks Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17938: Add support for passing cursor information to KRun.

arrowd added a comment. In D17938#386985 , @elvisangelaccio wrote: > I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. I'm not sure they make sense in the KRun API. I'd say they are both filetype-specific and servi

D17938: Add support for passing cursor information to KRun.

arrowd created this revision. arrowd added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arrowd requested review of this revision. REVISION SUMMARY This is the KIO part of https://bugs.kde.org/show_bug.cgi?id=398998 TEST PLAN With

D6430: Add syntax definition for julius language.

arrowdodger abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6430 To: arrowdodger Cc: #frameworks

D6430: Add syntax definition for julius language.

arrowdodger created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D6430 AFFECTED FILES data/syntax/julius.xml To: ar

D6087: Haskell: Add all language pragmas as keywords.

This revision was automatically updated to reflect the committed changes. Closed by commit R216:d2a38d790914: Haskell: Add all language pragmas as keywords. (authored by arrowdodger). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6087?vs=15982&id=

D6087: Haskell: Add all language pragmas as keywords.

arrowdodger updated this revision to Diff 15982. arrowdodger added a comment. Updated reference file for autotest as well. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6087?vs=15981&id=15982 BRANCH master REVISION DETAIL https://phabrica

D6087: Haskell: Add all language pragmas as keywords.

arrowdodger updated this revision to Diff 15981. arrowdodger added a comment. Added autotests. Not sure if .ref file should be updated, as the tests pass as they are now. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6087?vs=15772&id=15981 BR

D6087: Haskell: Add all language pragmas as keywords.

arrowdodger added a comment. So, can I push this? REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D6087 To: arrowdodger, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, #frameworks

D6087: Haskell: Add all language pragmas as keywords.

arrowdodger added a comment. In https://phabricator.kde.org/D6087#118963, @dhaumann wrote: > Demo for the highlighting rule - I don't think I can say anything to the auto completion issue. I am pretty sure it is unrelated to your xml file. Sure. Pragmas have following form:

D6087: Haskell: Add all language pragmas as keywords.

arrowdodger added a comment. In https://phabricator.kde.org/D6087#117019, @dhaumann wrote: > Also: could you provide us with a small demo code so that we can extend our unit test? The demo for added highlighting rule, or the problem with autocompletion? REPOSITORY R216 Syntax H

D6087: Haskell: Add all language pragmas as keywords.

arrowdodger updated this revision to Diff 15772. arrowdodger added a comment. - Use WordDetect instead of StringDetect for `omport` keyword. - Pop `Pragma` context on `#-}` string, not newline. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D60

D6102: KUrlRequester: Set NOTIFY signal to textChanged() for text property.

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f7dfb713a852: KUrlRequester: Set NOTIFY signal to textChanged() for text property. (authored by arrowdodger). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6102?vs=151

D6087: Haskell: Add all language pragmas as keywords.

arrowdodger added a comment. I just found that the same problem exists for `import_keywords` too - when I type `import qual`, the completion doesn't show up, and deleteting `qual` and typing it again causes it to show. So, it seems to be a coding bug. REPOSITORY R216 Syntax Highlighti

D6101: Work-around MSVC2017 compiler bug

arrowdodger accepted this revision. This revision is now accepted and ready to land. REPOSITORY R279 ThreadWeaver BRANCH master REVISION DETAIL https://phabricator.kde.org/D6101 To: kfunk, arrowdodger, bcooksley Cc: #frameworks

D6102: KUrlRequester: Set NOTIFY signal to textChanged() for text property.

arrowdodger created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Having `NOTIFY textChanged` on `text` property may come useful when using KUrlRequester with KConfig. KUrlRequester field may hold paths for executables and sometimes it is more convenient t

D6087: Haskell: Add all language pragmas as keywords.

arrowdodger edited the summary of this revision. arrowdodger edited the test plan for this revision. arrowdodger added a reviewer: Framework: Syntax Hightlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6087 To: arrowdodger, #framework_syntax_hightli

D6087: Haskell: Add all language pragmas as keywords.

arrowdodger created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D6087 AFFECTED FILES data/syntax/haskell.xml To: a

D5890: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this symbol seems to have a special meaning.

This revision was automatically updated to reflect the committed changes. Closed by commit R313:07a8a4e6985c: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this… (authored by arrowdodger). REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5

D5890: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this symbol seems to have a special meaning.

arrowdodger added a comment. In https://phabricator.kde.org/D5890#110586, @bcooksley wrote: > This looks good to me. Would this also resolve https://build-sandbox.kde.org/view/Frameworks/job/Frameworks%20kcodecs%20kf5-qt5%20WindowsQt5.7/6/console ? > Invalid position value

D5890: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this symbol seems to have a special meaning.

arrowdodger created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this symbol seems to have a special meaning. TEST PLAN Successfully compiled with MSVC. REPOSITORY R313 KHtml BRA

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

arrowdodger accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger, rakuco, dfaure Cc: #frameworks

Re: breeze-icons and the symlink business

On Thu, Feb 2, 2017 at 2:49 AM, Harald Sitter wrote: > hola > > breeze-icons uses lots of symlinks. Unfortunately, ever so often our > icon designers make a mistake and create a bad symlink. To mitigate > this I added a bunch of tests making sure everything is nice and > dandy. > > In the mean pa

Review Request 129590: KAuth: Make D-Bus dependency optional.

autotests/CMakeLists.txt b53d760 src/CMakeLists.txt 1b6930d Diff: https://git.reviewboard.kde.org/r/129590/diff/ Testing --- Thanks, Gleb Popov

Re: Review Request 128112: New module: ecm_win_resolve_symlinks

marked as submitted. Review request for Extra Cmake Modules and KDE Frameworks. Changes --- Submitted with commit 632b8868de38e2f85fb4969bcae3dd89a2a0695c by Gleb Popov to branch master. Repository: extra-cmake-modules Description --- When git is checking out repositories with UNIX

Re: Review Request 129244: Make UDisks2 backend compile on FreeBSD (and, possibly, other UNIXes).

marked as submitted. Review request for KDE Frameworks and Solid. Changes --- Submitted with commit 9bca1fd1993665a2233e0155a1baf9973c7a4b6f by Gleb Popov to branch master. Repository: solid Description --- This patch makes Solid UDisks2 backend compile on FreeBSD. Diffs

Re: Review Request 129197: Fix tests on FreeBSD

> On Oct. 16, 2016, 4:12 p.m., Tobias Berner wrote: > > I'm kind of unsure if this is right. Yes, the tests run now, but isn't the > > issue rather in the way kpty works (or fails to work on FreeBSD)? > > Gleb Popov wrote: > From what i

Re: Review Request 129244: Make UDisks2 backend compile on FreeBSD (and, possibly, other UNIXes).

://git.reviewboard.kde.org/r/129244/diff/ Testing --- Thanks, Gleb Popov

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129122/ > --- > > (Updated Oct. 19, 2016, 10:51 p.m.) > > > Review request for KDE Frameworks, Adriaan de G

Re: Review Request 129197: Fix tests on FreeBSD

it, i'm also unsure if this `ioctl` behaves different on Linux. - Gleb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129197/#review100039 -----

Review Request 129197: Fix tests on FreeBSD

tests/kptyprocesstest.cpp 8b0b5b0 Diff: https://git.reviewboard.kde.org/r/129197/diff/ Testing --- make test on FreeBSD Thanks, Gleb Popov

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

tps://git.reviewboard.kde.org/r/129122/#comment67101> Why search in `KDE_INSTALL` folders? `ulog-helper` comes with base and should always be in `/usr/libexec`, no? - Gleb Popov On Oct. 8, 2016, 9:37 p.m., Tobias Berner wrote: > > ---

Re: Review Request 129020: Fix find invocation in validate_svg.sh on FreeBSD.

marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 9e0466a1996717e44ca8c3842abd304d69af7ea7 by Gleb Popov to branch master. Repository: breeze-icons Description --- Without this patch the build was failing with ``` find: illegal option -- n

Review Request 129020: Fix find invocation in validate_svg.sh on FreeBSD.

://git.reviewboard.kde.org/r/129020/diff/ Testing --- Thanks, Gleb Popov

Re: Review Request 128112: New module: ecm_win_resolve_symlinks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128112/#review99356 --- Bump. - Gleb Popov On June 17, 2016, 11:32 a.m., Gleb

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

ly, visit: > https://git.reviewboard.kde.org/r/128916/ > --- > > (Updated Sept. 16, 2016, 10:17 a.m.) > > > Review request for KDE Frameworks and Gleb Popov. > > > Repository: kconfig > > > Description >

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

board.kde.org/r/128916/ > --- > > (Updated Sept. 16, 2016, 10:17 a.m.) > > > Review request for KDE Frameworks and Gleb Popov. > > > Repository: kconfig > > > Description > --- > > The test checks that saving a read-only config file fails. But because root

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

> On Sept. 15, 2016, 3:01 p.m., Gleb Popov wrote: > > autotests/kconfigtest.cpp, line 1378 > > <https://git.reviewboard.kde.org/r/128916/diff/1/?file=476914#file476914line1378> > > > > I'd put both `cgLocal.writeEntry("someLocalString"

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

tps://git.reviewboard.kde.org/r/128916/#comment66803> getuid() isn't present on Windows. Guard this check with `#ifndef Q_OS_WIN`. - Gleb Popov On Sept. 15, 2016, 4:20 p.m., Evgeniy Sadovnik wrote: > > --- > This is an automatica

  1   2   >