Re: plasma-framework, kactivities and kactivities-stats: please consider proper de-KF-ication now

k without Baloo? It even seems to do the right thing if I trust its CMakeLists.txt. It has Baloo as a recommended but optional dependency, and disable it altogether for Win32 builds. Regards. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute Couture - proud supporting member of KDE https://hc.enio

Re: Splitting KGlobalAccel interface and runtime

parts > will have different release schedules, we will have to be careful about > protocol changes. Perhaps we could borrow a thing or two from activities? Or... move both runtime and API on the Plasma side? This way no problem of different release schedules and it makes it clear that using

Re: KF6 meeting notes 2021-06-12

Hello, On Friday, 18 June 2021 22:36:34 CEST Volker Krause wrote: > On Freitag, 18. Juni 2021 22:27:40 CEST Kevin Ottens wrote: > > On Friday, 18 June 2021 15:21:07 CEST Volker Krause wrote: > > > Added now, Monday 09:00 UTC. > > > > OK, I will show up only at 10

Re: KF6 meeting notes 2021-06-12

On Friday, 18 June 2021 15:21:07 CEST Volker Krause wrote: > Added now, Monday 09:00 UTC. OK, I will show up only at 10 though. I can't do 9. Cheers. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute Couture - proud patron of KDE, https://hc.enioka.com/en signature.asc Descript

Re: KF6 meeting notes 2021-06-12

; > https://community.kde.org/Akademy/2021/Monday > > > > What do you (plural you) think? > > I'd vote for the Monday morning slots as well, we can then still schedule > subsequent session later that week if needed, QtCS and Akadmey BoF slots are > not overlapping all day AF

Re: KF6 meeting notes 2021-06-12

e with overlapping with the "KDE goal" > slots at 17:00 UTC and 18:00 UTC (there is Kirigami at 16:00 UTC, so maybe > not that one): > > https://community.kde.org/Akademy/2021/Monday > > What do you (plural you) think? FWIW, best for me would be Monday at 10:00 UTC

Re: Re KIO workers

Hello, On Saturday, 5 June 2021 22:01:54 CEST David Faure wrote: > On samedi 5 juin 2021 21:07:39 CEST Kevin Ottens wrote: > > On Saturday, 5 June 2021 17:51:18 CEST David Faure wrote: > > > On samedi 5 juin 2021 16:29:10 CEST Volker Krause wrote: > > > > Do KIO s

Re: Re KIO workers

that apps fork kio worker processes directly, without > going via klauncher/kinit. BTW it seems to work fine. I wonder if we should > toggle that in 5.84, as part of the incremental move to the KF6 world. Actually it works so well that I almost forgot I turned KIO_FORK_SLAVES on... Regards

Re: KF6 online sprint: March 27-28

illing the other slots. ;-) Regards. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute Couture - proud patron of KDE, https://hc.enioka.com/en signature.asc Description: This is a digitally signed message part.

Re: KCGroups in KDEreview

ser > user.slice/user-1000.slice/user@1000.service/app.slice -> UserApps > user.slice/user-1000.slice/user@1000.service/session.slice -> UserSession > user.slice/user-1000.slice/user@1000.service/background.slice -> > UserBackground Sounds good to me. Let's go for this. Re

Re: KDE Frameworks 6 - Virtual Sprint setup

Hello, On Saturday, 30 January 2021 12:14:27 CET Volker Krause wrote: > Thanks for driving this, I'm in! European hours preferred, any weekend > starting from w6 should be possible. Same here, not before week 10 or even better not before week 13. Cheers. -- Kevin Ottens

Re: KCGroups in KDEreview

On Sunday, 13 December 2020 22:41:24 CET David Edmundson wrote: > On Thu, Dec 3, 2020 at 11:48 AM Kevin Ottens wrote: > > Hello, > > > > On Thursday, 3 December 2020 12:15:52 CET David Edmundson wrote: > > > Ultimately this isn't really dealing with cgroups direc

Re: KCGroups in KDEreview

nt. Got a similar question though, which other unit types would be useful to control? Reason being that API wise I'd smell an enum for something like this. Regards. -- Kevin Ottens, http://ervin.ipsquad.net signature.asc Description: This is a digitally signed message part.

Re: KCGroups in KDEreview

ts IMHO, often those manual tests end up used as examples by people and having better readability helps (also avoids having people copying and pasting shameful things). ;-) That's not much but I'm obviously biased by the fact that we discussed this API together already. :-) Regards. -- Kevin Ot

Re: Add loop device interface to Solid framework

t it's more something you'd want in the file manager and solid reacting to it) then maybe just this time we could have a static method in the future "LoopDevice" (or whatever name ends up picked) interface for creating those. Just my 0.02€. Regards. -- Kevin Ottens, http://ervin.ip

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

ervin added inline comments. INLINE COMMENTS > meven wrote in device.h:99 > Well I have to make this virtual it seems so this call is dynamically > dispatched by `return_SOLID_CALL(Ifaces::Device *, d->backendObject(), > QString(), displayName());` > I assumed this would work based on my

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

ervin added a comment. LGTM now, I'll let the other reviewers weight in though. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28590 To: meven, #frameworks, bruns, sitter, dfaure Cc: dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

ervin added inline comments. INLINE COMMENTS > device.h:99 > + */ > +virtual QString displayName() const = 0; > + Why not have a default implementation which returns descriptions()? This would make for a less intrusive patch (I think it's in part what @bruns suggested earlier).

D28460: Add KCModuleDada as base class for plugin

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. Please fix the typo in the commit title before pushing, otherwise looks fine to me. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma,

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a comment. You know it started as a proper painted indicator within the widget area, right? As such it couldn't have any of the issues you're pointing out now... Who pushed me to have them at distance I wonder? Right, was people from the VDG. So I find grand that then it goes

D29014: Fix the exclusive group box case for default indicators

This revision was automatically updated to reflect the committed changes. Closed by commit R265:14ecec53296a: Fix the exclusive group box case for default indicators (authored by ervin). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D29014: Fix the exclusive group box case for default indicators

ervin updated this revision to Diff 80664. ervin added a comment. Fix misplaced * REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29014?vs=80661=80664 REVISION DETAIL https://phabricator.kde.org/D29014 AFFECTED FILES

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a comment. In D27540#652669 , @ngraham wrote: > Finally clicking on the revert button in Spectacle's settings page causes a segfault for me: P590 Spectacle crash backtrace Couldn't quite

D29014: Fix the exclusive group box case for default indicators

ervin created this revision. ervin added reviewers: ngraham, davidedmundson, bport, crossi. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY Turns out there was an oversight here, in case of an

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a comment. In D27540#652664 , @ngraham wrote: > David asked for VDG to approve before this landed, which wasn't done. Dude, I jumped through all the hoops for the past weeks. Also it got no further reply after I updated the

D27840: Introduce SettingState* elements to ease KCM writing

This revision was automatically updated to reflect the committed changes. Closed by commit R296:24211925f835: Introduce SettingState* elements to ease KCM writing (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=80305=80654

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

This revision was automatically updated to reflect the committed changes. Closed by commit R119:dfc144bf3f45: Port desktoptheme, icons and workspace KCMs to SettingStateBinding (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D27839: Properly name the content of the kcmcontrols project

This revision was automatically updated to reflect the committed changes. Closed by commit R296:3501bcbe8da6: Properly name the content of the kcmcontrols project (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27839?vs=76951=80653

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

This revision was automatically updated to reflect the committed changes. Closed by commit R265:11186c056198: KCModule: Indicate when a setting has been changed from the default or previous… (authored by ervin). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

Re: Problems in KWayland causes by API and ABI compatibility promises

Hello, On Thursday, 16 April 2020 23:38:23 CEST David Edmundson wrote: > On Wed, Apr 8, 2020 at 5:10 PM Kevin Ottens wrote: > > On Wednesday, 1 April 2020 14:04:10 CEST David Edmundson wrote: > > > Here is a list of active uses of the KWayland::Client API. >

D27840: Introduce SettingState* elements to ease KCM writing

ervin updated this revision to Diff 80305. ervin added a comment. Fix issues found with Cyril's patches on various KCMs. REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=78698=80305 REVISION DETAIL https://phabricator.kde.org/D27840

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin added a comment. Agreed, nullptr is going to be the boolean flag of our time, before it was 0 though, so still an improvement. ;-) More seriously, here I'm not sure how to avoid it, at least it's a case of "if you feel like passing nullptr here you might be doing something wrong".

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin added a comment. In D28742#646050 , @dfaure wrote: > In D28742#646009 , @kossebau wrote: > > > And perhaps could be defaulted to nullptr, for use-cases which do not have a window at hand and

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. ervin added a comment. Indeed, good point. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28753: Add KNotificationJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D28753 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28743: Port kruntest to ApplicationLauncherJob

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28743 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28742: Add KDialogJobUiDelegate(KJobUiDelegate::Flags) constructor

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R288 KJobWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D28742 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28741: [KJobUiDelegate] Add AutoHandlingEnabled flag

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28741 To: dfaure, broulik, davidedmundson, ervin Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin updated this revision to Diff 79656. ervin marked 6 inline comments as done. ervin added a comment. Addresses David's comments REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27540?vs=78703=79656 REVISION DETAIL

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin marked 6 inline comments as done. ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in kconfigdialogmanager.cpp:609 > Why not item->readDefault()? Wouldn't do the same thing at all. readDefault() takes a KConfig object and updates the default value stored in the item

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a comment. In D27540#638985 , @ndavis wrote: > Somehow I missed the notification that this was updated. > > Thanks for the horizontal alignment. Could you also add a left margin to the column of reset buttons? It should be the

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack,

Re: Problems in KWayland causes by API and ABI compatibility promises

no > kscreenlocker > powerdevil > kwayland-integration (the backend for kwindowsystem) > plasma-phone-components > plasma-integration I think the above is less of an issue, right? Because workspace would have a copy of KWayland which could be shared with whateve

D28460: Add KCModuleStateProbe as base class for plugin

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcmoduleloader.cpp:161 > +if (!mod.service() || mod.service()->noDisplay() || > mod.library().isEmpty()) > +{ > +return true; Curly brace

D28221: Don't write default value to configuration file when default value came from /etc/* file

ervin added a comment. LGTM but @dfaure concerns need to be addressed. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28221 To: bport, ervin, dfaure, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28128: Add force save behavior to KEntryMap

ervin accepted this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28128 To: bport, ervin, dfaure, meven, crossi, hchain Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: New Framework Review: KDAV

e me as an odd choice. Overall apidox would likely need a big pass of cleanups as well. I think that's it from me. Regards. -- Kevin Ottens, http://ervin.ipsquad.net enioka Haute Couture - proud patron of KDE, https://hc.enioka.com/en signature.asc Description: This is a digitally signed message part.

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin updated this revision to Diff 78703. ervin added a comment. As advised by Kai and David on D27840 , switch to using tool buttons and fix RTL handling. REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a reviewer: broulik. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27840: Introduce SettingState* elements to ease KCM writing

ervin updated this revision to Diff 78698. ervin marked 10 inline comments as done. ervin added a comment. Addresses Kai and David comments. REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=78469=78698 REVISION DETAIL

D27840: Introduce SettingState* elements to ease KCM writing

ervin marked 15 inline comments as done. ervin added inline comments. INLINE COMMENTS > broulik wrote in SettingStateBinding.qml:58 > This description didn't really help me in understanding what it does until I > read the code further down. Went for something much more verbose, but at least it

D28221: Don't write default value to configuration file when default value came from /etc/* file

ervin requested changes to this revision. ervin added inline comments. INLINE COMMENTS > kconfigskeletontest.cpp:25 > > +static inline QString kdeGlobalsPath() { > +return > QStandardPaths::writableLocation(QStandardPaths::GenericConfigLocation) + > "/kdeglobals"; { should be on its own

D28128: Add force save behavior to KEntryMap

ervin added inline comments. INLINE COMMENTS > kconfigtest.cpp:1953 > + > +void KConfigTest::testKdeglobalsVSDefault() > +{ Seeing how this test confuses everyone (including me and I knew the problem before hand...), I think it'd benefit greatly from getting comments at the most important

Re: Problems in KWayland causes by API and ABI compatibility promises

API deprecated and freeze it; 7) when KF6 gets branched drop all the deprecated APIs. Again, I'm no Wayland expert so I might be missing some things. In any case: yes, this is quite some work and might incur some pain and trade-offs... it's unfortunately a price to pay to get out of what seems

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a comment. In D27540#629380 , @ervin wrote: > In D27540#629362 , @ndavis wrote: > > > Is it possible to align all of the reset buttons like a column? > > > Why I'm not surprised.

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27840: Introduce SettingState* elements to ease KCM writing

ervin updated this revision to Diff 78469. ervin added a comment. Have the indicators line up vertically automatically when applicable REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=77848=78469 REVISION DETAIL

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin updated this revision to Diff 78468. ervin added a comment. Have the indicators vertically line up automatically REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27540?vs=77847=78468 REVISION DETAIL https://phabricator.kde.org/D27540

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a comment. In D27540#629362 , @ndavis wrote: > Is it possible to align all of the reset buttons like a column? Why I'm not surprised. ;-) Honestly with enough code it might be possible, but that'd be expensive in term of

D27840: Introduce SettingState* elements to ease KCM writing

ervin updated this revision to Diff 77848. ervin added a comment. Take feedback about the GUI into account REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=76952=77848 REVISION DETAIL https://phabricator.kde.org/D27840 AFFECTED FILES

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin edited the summary of this revision. ervin edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis Cc: alexde, ndavis, iasensio, davidre,

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin updated this revision to Diff 77847. ervin added a comment. Take feedback about the GUI into account REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27540?vs=76362=77847 REVISION DETAIL https://phabricator.kde.org/D27540 AFFECTED FILES

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a comment. In D27540#627618 , @ndavis wrote: > Some extra rules I thought of: > > - With the checkable label example in the mockup above, it should reset both the label and the checkbox. Just for the record, this will

D27133: kconfig_compiler : generate kconfig settings with subgroup

ervin accepted this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27133 To: crossi, ervin, dfaure, #frameworks Cc: apol, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. What @meven said about the typo, otherwise LGTM indeed. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D27724 To: davidedmundson, ervin Cc: ervin, meven,

D27502: Create ConfigView an unmanaged ConfigWidget

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D27502 To: bport, #plasma, ervin, crossi, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a comment. In D27540#617485 , @ervin wrote: > And now you got a screenshot as well. Waiting for further feedback now. Ping? This patch was first created three weeks ago now. Note that look in D27840

D27463: KconfigXT: Add a value attribute to Enum field choices

ervin accepted this revision. REPOSITORY R237 KConfig BRANCH arcpatch-D27463_2 REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

ervin accepted this revision. ervin added a comment. This revision is now accepted and ready to land. LGTM, please fix the typo in the docs before pushing though INLINE COMMENTS > README.dox:372 > > +Since 5.68, if present the value attribute will be used used as the > choice value

D27133: kconfig_compiler : generate kconfig settings with subgroup

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27133 To: crossi, ervin, dfaure, #frameworks Cc: meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27840: Introduce SettingState* elements to ease KCM writing

ervin added a comment. In D27840#622937 , @ngraham wrote: > This patch doesn't apply on top of KDeclarative for me: > > This diff is against commit 3d8757d5dfea2360304e2c8e7d0d575d04b00735, but > the commit is nowhere in the

D27811: [KConfigGui] Check font weight when clearing styleName property

ervin added a comment. In D27811#622916 , @ahmadsamir wrote: > In D27811#622885 , @ervin wrote: > > > This styleName thing is an endless amount of fun... The patch LGTM, I'll let others weight in

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. In D27833#622353 , @apol wrote: > What's the use-case? Having an idea of the patch you want to build on top of this would

D27811: [KConfigGui] Check font weight when clearing styleName property

ervin added a comment. This styleName thing is an endless amount of fun... The patch LGTM, I'll let others weight in though since it can have ramifications I might miss. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27811 To: ahmadsamir, #frameworks, dfaure,

D27463: KconfigXT: Add a value attribute to Enum field choices

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcoreconfigskeleton.cpp:581 > +// HACK for BC concerns > +// TODO KF6: remove KCoreConfigSkeletonPrivate::mValues and add a value > field to

D27811: [KConfigGui] Check font weight when clearing styleName property

ervin added a reviewer: bport. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27811 To: ahmadsamir, #frameworks, dfaure, davidedmundson, cfeck, ervin, meven, bport Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27133: kconfig_compiler : generate kconfig settings with subgroup

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kconfigcompiler_test.cpp:80 > "test_signal", > +"test_notifiers", > "test_translation_kde", This seems unrelated... So we had this test case

D27463: KconfigXT: Add a value attribute to Enum field choices

ervin added inline comments. INLINE COMMENTS > meven wrote in kcoreconfigskeleton.cpp:580 > You mean I should prepare this and put it in KF6 waiting for merge queue ? No I meant the comment needs to be adjusted due to the changes (fields changing place and such) sorry if I was unclear. >

D27463: KconfigXT: Add a value attribute to Enum field choices

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcoreconfigskeleton.cpp:580 > +{ > +// TODO KF6 move value to ItemEnum::Choice and remove > KCoreConfigSkeleton::ItemEnum::mValues > +const auto inHash

D27840: Introduce SettingState* elements to ease KCM writing

ervin added a dependent revision: D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc:

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

ervin edited the summary of this revision. ervin added reviewers: Frameworks, Plasma, VDG. ervin added a dependency: D27840: Introduce SettingState* elements to ease KCM writing. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27841 To: ervin, crossi, hchain,

D27840: Introduce SettingState* elements to ease KCM writing

ervin edited the summary of this revision. ervin added reviewers: Frameworks, Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: kde-frameworks-devel,

D27839: Properly name the content of the kcmcontrols project

ervin added reviewers: Frameworks, Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27839 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27840: Introduce SettingState* elements to ease KCM writing

ervin created this revision. ervin added reviewers: crossi, hchain, meven, bport, davidedmundson, mart, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This is the QML based counterpart of

D27839: Properly name the content of the kcmcontrols project

ervin created this revision. ervin added reviewers: crossi, hchain, meven, bport, davidedmundson, mart, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY Looks like it was copied from

D27717: fix min/max entries with dpointer

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27717 To: hchain, meven, ervin Cc: kde-frameworks-devel, aacid, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27502: Create ConfigView an unmanaged ConfigWidget

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > settings.cpp:62 > > -bool Settings::setCheckUppercase(bool check) > +void Settings::setSkipUppercase(bool check) > { Rename the parameter to skip as well

D27463: KconfigXT: Add a value attribute to Enum field choices

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ervin wrote in kcoreconfigskeleton.h:764 > Oh right, stupid me, this obviously breaks binary compatibility, we need to > find another way to store this. Most

D27463: KconfigXT: Add a value attribute to Enum field choices

ervin added inline comments. INLINE COMMENTS > meven wrote in kcoreconfigskeleton.h:764 > Something I have noticed while testing this. > Since it changes the memory of a very common data struct in a very common > lib, it creates a lot of crashes if apps are not compiled with the installed >

D27502: Create ConfigView an unmanaged ConfigWidget

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > settings.cpp:62 > > -bool Settings::setCheckUppercase(bool check) > +void Settings::setCheckUppercase(bool check) > { Please rename it to "skip

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a comment. In D27540#617589 , @alexde wrote: > Does this patch also fix indirectly #274629? I doubt it, this bug report seems confused BTW... it was never broken on the kdelibs side but *some* dialogs have bugs which break

D27133: kconfig_compiler : generate kconfig settings with subgroup

ervin added a comment. In D27133#617577 , @dfaure wrote: > I really have zero experience with this stuff, but you're asking for my opinion nonetheless, so you'll get it, as crappy as it might be :-) > > Your comment refers to "group

D27497: Fix code generation for entries with min/max

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27497 To: hchain, meven, crossi, ervin, bport, tcanabrava Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27497: Fix code generation for entries with min/max

ervin edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27497 To: hchain, meven, crossi, ervin, bport, tcanabrava Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

ervin added a comment. In D27540#615160 , @ervin wrote: > In D27540#615156 , @ngraham wrote: > > > Please add screenshots to the Test Plan section for patches that change the UI. :) Also it would

D27540: Status indicator for individual widgets in KCModule

ervin edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg Cc: iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

ervin updated this revision to Diff 76362. ervin added a comment. Handle visibility of the tracked widget, setters become slots, and add plural to "indicatorWidgets". REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27540?vs=76089=76362 REVISION

  1   2   3   4   5   6   7   8   9   10   >