D6366: Fix configure with Qt5Multimedia disabled.

2017-06-24 Thread Michael Palimaka
This revision was automatically updated to reflect the committed changes. Closed by commit R286:f30fede21bf0: Fix configure with Qt5Multimedia disabled. (authored by palimaka). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6366?vs=15810=15821 REVISION

D6366: Fix configure with Qt5Multimedia disabled.

2017-06-23 Thread Michael Palimaka
palimaka created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY When passed -DBUILD_TESTING=OFF -DCMAKE_DISABLE_FIND_PACKAGE_Qt5Multimedia=ON, CMake failed because find_package(Qt5 COMPONENTS MULTIMEDIA) was treated as required due to the previous

D6249: FindQHelpGenerator: avoid picking up Qt4 version

2017-06-23 Thread Michael Palimaka
palimaka added a comment. Sorry for the delay, I was away. Thanks for pushing! REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6249 To: palimaka, #frameworks, kossebau, kfunk Cc: alexeymin, asturmlechner, #build_system

D6249: FindQHelpGenerator: avoid picking up Qt4 version

2017-06-17 Thread Michael Palimaka
palimaka updated this revision to Diff 15514. palimaka added a comment. Fix indentation. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6249?vs=15512=15514 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6249 AFFECTED FILES

D6249: FindQHelpGenerator: avoid picking up Qt4 version

2017-06-17 Thread Michael Palimaka
palimaka added a reviewer: kossebau. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6249 To: palimaka, #frameworks, kossebau Cc: asturmlechner, #build_system

D6249: FindQHelpGenerator: avoid picking up Qt4 version

2017-06-17 Thread Michael Palimaka
palimaka created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added a subscriber: Build System. REVISION SUMMARY Passing NO_DEFAULT_PATH ignores $PATH and ensures that we use the previously-detected Qt5 binary path. TEST PLAN

Re: Review Request 128922: Remove invalid directory from index.theme

2016-09-29 Thread Michael Palimaka
marked as submitted. Review request for KDE Frameworks and Andreas Kainz. Changes --- Submitted with commit 7648c0005fafd5a6834d2479796c3717b77e5549 by Michael Palimaka to branch master. Repository: oxygen-icons5 Description --- This removes the directory "base/" from i

Review Request 128922: Remove invalid directory from index.theme

2016-09-15 Thread Michael Palimaka
index.theme 2fc77f7 Diff: https://git.reviewboard.kde.org/r/128922/diff/ Testing --- Warning disappears, oxygen icons still appear in a GTK application. Thanks, Michael Palimaka

Re: Review Request/New Framework: KF5::SyntaxHighlighting

2016-09-10 Thread Michael Palimaka
Hi, On 11/09/16 01:47, Volker Krause wrote: > Hi, > > please review KF5::SyntaxHighlighting (syntax-highlighting in Git) for > becoming a framework :) Thanks a lot for working on this. I noticed that KF5SyntaxHighlightingConfig.cmake.in searches for Qt5Widgets, but that doesn't seem to used

Re: Review Request 128814: Add Qt5Network as a public dependency.

2016-09-02 Thread Michael Palimaka
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 99f220a81e82b2114f408823cdaa13a002e4fae5 by Michael Palimaka to branch master. Repository: attica Description --- Attica uses Qt5Network in its public API, so it must declare it as a public

Review Request 128814: Add Qt5Network as a public dependency.

2016-09-01 Thread Michael Palimaka
the change it fails to build with ``ld: cannot find -lQt5::Network``, after the change it passes. Thanks, Michael Palimaka

Re: Review Request 128192: Remove man pages for scripts that no longer exist

2016-06-16 Thread Michael Palimaka
marked as submitted. Review request for KDE Frameworks, Alex Merry and Olivier Churlaud. Changes --- Submitted with commit e34c35ec98c260c87171e81b134e771f689e0180 by Michael Palimaka to branch master. Repository: kapidox Description --- kgenapidox and kgenframeworksapidox were

Review Request 128192: Remove man pages for scripts that no longer exist

2016-06-15 Thread Michael Palimaka
607388bb6339a7c1ea81b1ec58690df3fed12252 Diff: https://git.reviewboard.kde.org/r/128192/diff/ Testing --- Builds and installs correctly to temporary directory. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 127895: Remove unused dependencies and translation handling.

2016-05-11 Thread Michael Palimaka
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b50958516e6cf05f04ff92437e04228950a0ddec by Michael Palimaka to branch master. Repository: frameworkintegration Description --- These are no longer used since

Re: Qt 5.6/QtWebkit

2016-03-20 Thread Michael Palimaka
On 17/03/16 03:59, René J. V. Bertin wrote: > Aleix Pol wrote: > > >> >> https://code.qt.io/cgit/qt/qtwebkit.git/ > > Right, thanks, I'd seen that one too (there's also a clone on github but it > isn't clear how recent/unmodified that one is). > > What I didn't yet see is if there's a way to

Re: Review Request 127100: Remove unused dependencies in kactivities

2016-03-01 Thread Michael Palimaka
marked as submitted. Review request for KDE Frameworks and Ivan Čukić. Changes --- Submitted with commit efc193d9de78d5bf208733ad12151e8ba758ee14 by Michael Palimaka to branch master. Repository: kactivities Description --- Appears to be unused since the repo split. Diffs

Review Request 127100: Remove unused dependencies in kactivities

2016-02-17 Thread Michael Palimaka
://git.reviewboard.kde.org/r/127100/diff/ Testing --- Inspected source, builds. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126868: Update docs for KCrash::Initialize.

2016-01-24 Thread Michael Palimaka
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 63b4394d97a7478da095c52356d7b16b8798824b by Michael Palimaka to branch master. Repository: kcrash Description --- Currently the platform plugin makes no such call so

Review Request 126868: Update docs for KCrash::Initialize.

2016-01-24 Thread Michael Palimaka
Diff: https://git.reviewboard.kde.org/r/126868/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Icons missing

2015-12-07 Thread Michael Palimaka
On 06/12/15 23:56, Thorsten Zachmann wrote: > Hello all, > > I use a separate user for running calligra. I use ssh -X to login from my > normal desktop user to my kde running user. However when I start any > kde application I have no icons. With strace I can see it searches for icons > in the

Re: Review Request 126054: Missed doctool usage.

2015-11-13 Thread Michael Palimaka
marked as submitted. Review request for KDE Frameworks and Christoph Cullmann. Changes --- Submitted with commit 0d22a5f5bc1d0c5842ba13e979ebdd13036e5e36 by Michael Palimaka to branch master. Repository: kconfigwidgets Description --- kdoctools_install fails if KF5DocTools

Re: Review Request 124043: Remove unused dependency.

2015-06-09 Thread Michael Palimaka
marked as submitted. Review request for KDE Frameworks and Laurent Montel. Changes --- Submitted with commit c4be53bbcd233d3392bb01f8e0da5f9bb3ad9731 by Michael Palimaka to branch master. Repository: ktextwidgets Description --- It is no longer required since

Review Request 124043: Remove unused dependency.

2015-06-08 Thread Michael Palimaka
078ab83fefb30e6a3888d8c7f3167ffeea1344b5 Diff: https://git.reviewboard.kde.org/r/124043/diff/ Testing --- Builds. Inspected source and binary links. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file

2015-05-13 Thread Michael Palimaka
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b87835cc7bdf869624b77fea7e6b7b0526c33ec6 by Michael Palimaka to branch master. Repository: kdelibs4support Description --- Hardcoding files like this seems like a bad idea. Also updates

Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file

2015-05-13 Thread Michael Palimaka
a06b49d015fe420fd0293292041caa988422f521 Diff: https://git.reviewboard.kde.org/r/123737/diff/ Testing --- Test still passes on Linux. Can't test on Windows. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Review Request 123737: Update URL to something that's fetchable.

2015-05-12 Thread Michael Palimaka
--- Test still passes on Linux. Can't test on Windows. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123737: Use QTemporaryFile instead of hardcoding a temporary file

2015-05-12 Thread Michael Palimaka
/netaccesstest.cpp a06b49d015fe420fd0293292041caa988422f521 Diff: https://git.reviewboard.kde.org/r/123737/diff/ Testing --- Test still passes on Linux. Can't test on Windows. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

2015-05-12 Thread Michael Palimaka
marked as submitted. Review request for KDE Frameworks and KDEPIM. Changes --- Submitted with commit 0c71246a330946333b7c95ab78eac80bf4f5641d by Michael Palimaka to branch master. Repository: kpeople Description --- Hardcoding files like this seems like a bad idea. Diffs

Re: Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

2015-05-12 Thread Michael Palimaka
--- On May 12, 2015, 12:49 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123724/ --- (Updated

Review Request 123724: Use QTemporaryFile instead of hardcoding /tmp.

2015-05-11 Thread Michael Palimaka
autotests/personsmodeltest.cpp b19d1baf8a2c2e617d4b6128df29fbab3b8e61a7 Diff: https://git.reviewboard.kde.org/r/123724/diff/ Testing --- Tests still pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 123630: Remove unused dependency.

2015-05-05 Thread Michael Palimaka
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 87099296158ae3a8807b93fedd9dcfdeb5642085 by Michael Palimaka to branch master. Repository: kross Description --- Nothing references it, so remove it. Diffs - CMakeLists.txt

Review Request 123630: Remove unused dependency.

2015-05-04 Thread Michael Palimaka
--- Nothing references it, so remove it. Diffs - CMakeLists.txt 215d753bc1a86eab0aa875e20ba677a056c3bd95 Diff: https://git.reviewboard.kde.org/r/123630/diff/ Testing --- Builds, tests pass, inspected source and output binaries. Thanks, Michael Palimaka

Re: Review Request 123265: Remove unused dependency.

2015-04-06 Thread Michael Palimaka
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 6c27a4f33467b8da91243d2890a3e06f0823182f by Michael Palimaka to branch master. Repository: knotifyconfig Description --- It's no longer used since 3155bb05a88ea60b7d388231ffdfe9497773bf2e

Re: Syncing ECM release number with KF5

2015-04-05 Thread Michael Palimaka
On 04/04/15 19:44, David Faure wrote: On Saturday 28 March 2015 05:49:01 Michael Palimaka wrote: On 28/03/15 03:48, Alex Merry wrote: On Wednesday 25 March 2015 22:35:24 Stephen Kelly wrote: Hello, ECM release numbers are in sync with KF5 release numbers, except for the major component

Review Request 123265: Remove unused dependency.

2015-04-05 Thread Michael Palimaka
--- Inspected source, builds. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Syncing ECM release number with KF5

2015-03-27 Thread Michael Palimaka
On 28/03/15 03:48, Alex Merry wrote: On Wednesday 25 March 2015 22:35:24 Stephen Kelly wrote: Hello, ECM release numbers are in sync with KF5 release numbers, except for the major component. This means that if you want to build the 5.x.y release you have to download the 1.x.y release of

Re: Review Request 122206: [kio] Make tests optional

2015-03-17 Thread Michael Palimaka
On March 17, 2015, 3:37 a.m., Albert Vaca Cintora wrote: I know this is merged already but this patch is being applied to every KDE package and I want to keep the discussion in a single place. We already have a toggle option in CMake that is BUILD_TESTING. If Gentoo wants to not

Re: Review Request 122843: Remove redundant build interface.

2015-03-06 Thread Michael Palimaka
it. Diffs (updated) - src/quickaddons/CMakeLists.txt 3c7a34b89a77e09221e2b44688a6bd9123f8aec5 Diff: https://git.reviewboard.kde.org/r/122843/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks

Review Request 122843: Mark QuickAddons as its own project.

2015-03-06 Thread Michael Palimaka
--- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122843: Mark QuickAddons as its own project.

2015-03-06 Thread Michael Palimaka
otherwise. - Michael --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122843/#review77117 --- On March 6, 2015, 4:07 p.m., Michael Palimaka

Re: Review Request 122843: Remove redundant build interface.

2015-03-06 Thread Michael Palimaka
/quickaddons/CMakeLists.txt 3c7a34b89a77e09221e2b44688a6bd9123f8aec5 Diff: https://git.reviewboard.kde.org/r/122843/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 121773: Fix build without X.

2015-01-02 Thread Michael Palimaka
for OSX for the aforementioned breakage. Diffs - src/kdesud/kdesud.cpp 337e37a50b9d10ae8c0839f6d26e67de6a9418d9 Diff: https://git.reviewboard.kde.org/r/121773/diff/ Testing --- Build passes again, both with and without X. Thanks, Michael Palimaka

Review Request 121773: Fix build without X.

2014-12-31 Thread Michael Palimaka
337e37a50b9d10ae8c0839f6d26e67de6a9418d9 Diff: https://git.reviewboard.kde.org/r/121773/diff/ Testing --- Build passes again, both with and without X. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 121773: Fix build without X.

2014-12-31 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121773/#review72841 --- On Dec. 31, 2014, 10:23 a.m., Michael Palimaka wrote

Re: qca-qt5 package name

2014-12-17 Thread Michael Palimaka
On 17/12/14 22:47, Harald Sitter wrote: alohas. recently the QCA maintainer and I got into a discussion [1] whether a qca-qt5 library should be a different config inside the same cmake package or an independent one (detailed discussion in the longest comment thread of the review).

Split kde-baseapps?

2014-09-24 Thread Michael Palimaka
Hi, Are there any plans to split frameworks-based kde-baseapps? Best regards, Michael ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119410: Document KDED dependency.

2014-07-23 Thread Michael Palimaka
available. Diffs - metainfo.yaml 102380eca8c77a34f4ab5c687a51952168b34225 Diff: https://git.reviewboard.kde.org/r/119410/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 119410: Document KDED dependency.

2014-07-22 Thread Michael Palimaka
://git.reviewboard.kde.org/r/119410/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119198: Don't search default paths when finding lconvert.

2014-07-13 Thread Michael Palimaka
building solid-5.0.0, Qt5 lconvert from lrelease_path is now correctly used. Previously Qt4 version was used as it exists in /usr/bin. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Review Request 119198: Don't search default paths when finding lconvert.

2014-07-09 Thread Michael Palimaka
version was used as it exists in /usr/bin. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

2014-07-08 Thread Michael Palimaka
on. - Michael Palimaka On July 7, 2014, 7:28 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043

Re: kcrash test failure

2014-05-04 Thread Michael Palimaka
On 05/04/2014 06:48 PM, David Faure wrote: On Monday 31 March 2014 17:21:44 Jonathan Riddell wrote: Anyone seen this test failure in kcrash? I only get it on i386 http://paste.kde.org/pccpojfwd Is this still an issue? The pastebin expired so I don't know what it was about. It is still

Review Request 117792: Rename kreadconfig and kwriteconfig for coinstallability

2014-04-26 Thread Michael Palimaka
3505ac3eca9d2ce2152801f29a87d8bf689ad6f1 Diff: https://git.reviewboard.kde.org/r/117792/diff/ Testing --- Builds, installs, tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 117792: Rename kreadconfig and kwriteconfig for coinstallability

2014-04-26 Thread Michael Palimaka
/CMakeLists.txt 434f33a1fb62c5429fe60c5cb4458a804cba7fdd src/kreadconfig/kreadconfig.cpp 3505ac3eca9d2ce2152801f29a87d8bf689ad6f1 Diff: https://git.reviewboard.kde.org/r/117792/diff/ Testing --- Builds, installs, tests pass. Thanks, Michael Palimaka

Re: Review Request 117602: Remove more UPnP stuff

2014-04-25 Thread Michael Palimaka
/networkshare.h 6d8ab1e914d0f2fc570a48b4959aed99f3859c15 Diff: https://git.reviewboard.kde.org/r/117602/diff/ Testing --- Builds, tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 117599: Improve tests

2014-04-17 Thread Michael Palimaka
/autotests/packageurlinterceptortest.cpp d39a89aaba811b1ab1045be2b5dbe0d279a39235 Diff: https://git.reviewboard.kde.org/r/117599/diff/ Testing --- Builds, tests still pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks

Review Request 117599: Improve tests

2014-04-16 Thread Michael Palimaka
://git.reviewboard.kde.org/r/117599/diff/ Testing --- Builds, tests still pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117602: Remove more UPnP stuff

2014-04-16 Thread Michael Palimaka
/diff/ Testing --- Builds, tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kdeinit5 binary and man page in different repos

2014-04-09 Thread Michael Palimaka
Hi, I noticed that kdeinit5 is in kinit, and its man page appears to be in kservice. I guess the man page should be moved, but I'm not sure of the best procedure with regards to preserving history etc. Best regards, Michael ___ Kde-frameworks-devel

Re: Review Request 117392: Rename kdebugdialog to avoid collision

2014-04-07 Thread Michael Palimaka
://git.reviewboard.kde.org/r/117392/diff/ Testing --- Installs. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117391: Remove unused dependencies

2014-04-07 Thread Michael Palimaka
/CMakeLists.txt 99ef4cef9e03130356db82dc06b2797c14857c9c Diff: https://git.reviewboard.kde.org/r/117391/diff/ Testing --- Inspected source. Builds. Tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Review Request 117391: Remove unused dependencies

2014-04-05 Thread Michael Palimaka
/ Testing --- Inspected source. Builds. Tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117190: Improve tests

2014-03-31 Thread Michael Palimaka
91e3db469cfa508be9659f0f977d03454a2144dd Diff: https://git.reviewboard.kde.org/r/117190/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: kcrash test failure

2014-03-31 Thread Michael Palimaka
On 04/01/2014 03:21 AM, Jonathan Riddell wrote: Anyone seen this test failure in kcrash? I only get it on i386 http://paste.kde.org/pccpojfwd Jonathan I can reproduce consistently on amd64. ___ Kde-frameworks-devel mailing list

Re: Review Request 117146: Remove unused dependencies

2014-03-30 Thread Michael Palimaka
--- Builds. Inspected source. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117190: Improve tests

2014-03-30 Thread Michael Palimaka
--- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117146: Remove unused dependencies

2014-03-29 Thread Michael Palimaka
--- On March 28, 2014, 6:55 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117146/ --- (Updated March 28

Re: Review Request 117019: Remove fake defaultMimetype entries from protocols files

2014-03-28 Thread Michael Palimaka
/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117135: Remove fake MIME types

2014-03-28 Thread Michael Palimaka
-stream+inode/directory. Diffs - src/mimetypes/kde5.xml 778cf4e01c07c948b5c11bd9c3cdacd9edef8835 Diff: https://git.reviewboard.kde.org/r/117135/diff/ Testing --- I couldn't find left-over references to these MIME types in frameworks-ported stuff using lxr. Thanks, Michael Palimaka

Review Request 117145: Make ItemViews a public dependency

2014-03-28 Thread Michael Palimaka
/ Testing --- kde4support builds against it without needing to explicitly try to link against ItemViews which is otherwise not needed there. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 117135: Remove fake MIME types

2014-03-28 Thread Michael Palimaka
references to these MIME types in frameworks-ported stuff using lxr. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 117146: Remove unused dependencies

2014-03-28 Thread Michael Palimaka
/CMakeLists.txt f21e7ddfb20337337bef344f877ac8b8f68640fe src/kdeui/kglobalsettings.cpp 8de898639e4236659291fc2297dab312a0db7357 Diff: https://git.reviewboard.kde.org/r/117146/diff/ Testing --- Builds. Inspected source. Thanks, Michael Palimaka

Re: Review Request 116958: Update comment referencing fake MIME types

2014-03-24 Thread Michael Palimaka
4dbb44b7db1a8bc4182899485db9c45c063c9b52 src/services/kservicetypeprofile.h d14955d112e973d45a1387ee6db79b0c09949b23 Diff: https://git.reviewboard.kde.org/r/116958/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 116957: Replace fake MIME type all/allfiles with application/octet-stream

2014-03-24 Thread Michael Palimaka
ccf327fe78acf71918578bbb72578c83f7dacd92 tests/kfstest.cpp b85b5372afe6106568c26c73f1eab97bfa90c9ce Diff: https://git.reviewboard.kde.org/r/116957/diff/ Testing --- kfstest still behaves as expected. Thanks, Michael Palimaka ___ Kde-frameworks-devel

Review Request 117019: Remove fake defaultMimetype entries from protocols files

2014-03-24 Thread Michael Palimaka
/protocols/mmst.protocol 1f0f7636b7647b0853a10e50d51ecf4b33be441e src/ioslaves/protocols/mms.protocol 79599ead181c9e6ee90eca08f09a097caee98c21 Diff: https://git.reviewboard.kde.org/r/117019/diff/ Testing --- Thanks, Michael Palimaka ___ Kde

Re: Review Request 116961: Replace fake MIME type

2014-03-22 Thread Michael Palimaka
/116961/diff/ Testing --- Played with some consumers of filewidgets which seems to behave normally, but again I'm not particularly familiar with what's happening here. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Unknown media types

2014-03-22 Thread Michael Palimaka
On 03/16/2014 09:46 PM, David Faure wrote: On Saturday 15 March 2014 19:24:08 Michael Palimaka wrote: Hi, kcoreaddons installs /usr/share/mime/packages/kde5.xml which causes the following warnings when update-mime-database is executed: Unknown media type in type 'all/all' Unknown media

Review Request 116957: Replace fake MIME type all/allfiles with application/octet-stream

2014-03-21 Thread Michael Palimaka
--- kfstest still behaves as expected. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116957: Replace fake MIME type all/allfiles with application/octet-stream

2014-03-21 Thread Michael Palimaka
ccf327fe78acf71918578bbb72578c83f7dacd92 tests/kfstest.cpp b85b5372afe6106568c26c73f1eab97bfa90c9ce Diff: https://git.reviewboard.kde.org/r/116957/diff/ Testing --- kfstest still behaves as expected. Thanks, Michael Palimaka ___ Kde-frameworks

Review Request 116958: Update comment referencing fake MIME types

2014-03-21 Thread Michael Palimaka
d14955d112e973d45a1387ee6db79b0c09949b23 Diff: https://git.reviewboard.kde.org/r/116958/diff/ Testing --- Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116961: Replace fake MIME type

2014-03-21 Thread Michael Palimaka
normally, but again I'm not particularly familiar with what's happening here. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116899: Remove unused QtWidgets dependency

2014-03-20 Thread Michael Palimaka
--- Inspected source. A build test is difficult since some of kinit's dependencies have QtWidgets as a public dependency. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 116899: Remove unused QtWidgets dependency

2014-03-19 Thread Michael Palimaka
as a public dependency. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Unknown media types

2014-03-15 Thread Michael Palimaka
Hi, kcoreaddons installs /usr/share/mime/packages/kde5.xml which causes the following warnings when update-mime-database is executed: Unknown media type in type 'all/all' Unknown media type in type 'all/allfiles' Unknown media type in type 'uri/mms' Unknown media type in type 'uri/mmst' Unknown

Review Request 116079: Be more explicit with QFile include

2014-02-26 Thread Michael Palimaka
/diff/ Testing --- Builds. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KDNSSD merge

2014-02-26 Thread Michael Palimaka
On 02/27/2014 12:36 AM, Nicolas Lécureuil wrote: Le mercredi 26 février 2014 11:54:16 Alex Merry a écrit : On 26/02/14 10:01, Alex Merry wrote: Actually, having slept on it, my suggestion is: - rename kdnssd to zeroconf-ioslave - rename kdnssd-framework to kdnssd - merge the frameworks

Re: Review Request 116079: Be more explicit with QFile include

2014-02-26 Thread Michael Palimaka
7814a52c9656719d301ebd012434a53491ffe159 Diff: https://git.reviewboard.kde.org/r/116079/diff/ Testing --- Builds. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Runtime conflict with KF5Plasma and KDE 4 in same prefix

2014-02-24 Thread Michael Palimaka
On 02/24/2014 05:41 AM, Martin Graesslin wrote: On Monday 24 February 2014 05:33:37 Michael Palimaka wrote: Hi, I have run into a strange issue when KDE 4 and KF5Plasma are installed into the same prefix (I can reliably reproduce the issue by installing/uninstalling KF5Plasma and restarting

Runtime conflict with KF5Plasma and KDE 4 in same prefix

2014-02-23 Thread Michael Palimaka
Hi, I have run into a strange issue when KDE 4 and KF5Plasma are installed into the same prefix (I can reliably reproduce the issue by installing/uninstalling KF5Plasma and restarting KDE). Simply, the vertical bar key | does not work - it prints nothing. If I run xev from konsole it detects the

Re: Review Request 115485: Porting KTranscript from KJS to QtScript

2014-02-22 Thread Michael Palimaka
and the yaml file. - Michael Palimaka On Feb. 22, 2014, 2:15 p.m., Kevin Krammer wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485

Re: Review Request 115909: Remove unused dependency from krunner

2014-02-22 Thread Michael Palimaka
. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115863: Improve khtml dependencies

2014-02-20 Thread Michael Palimaka
: we're already depending on them being bought in by other libraries. Michael Palimaka wrote: The listed frameworks are directly used. I don't see how linking or not makes a difference - khtml will fail to build without them. If we trust that one dependency will always bring in some

Re: Review Request 115863: Improve khtml dependencies

2014-02-20 Thread Michael Palimaka
: we're already depending on them being bought in by other libraries. Michael Palimaka wrote: The listed frameworks are directly used. I don't see how linking or not makes a difference - khtml will fail to build without them. If we trust that one dependency will always bring in some

Re: Review Request 115863: Improve khtml dependencies

2014-02-20 Thread Michael Palimaka
: we're already depending on them being bought in by other libraries. Michael Palimaka wrote: The listed frameworks are directly used. I don't see how linking or not makes a difference - khtml will fail to build without them. If we trust that one dependency will always bring in some

Review Request 115909: Remove unused dependency from krunner

2014-02-20 Thread Michael Palimaka
/abstractrunner.h cee292812075db59c13703de37dc1e983c3d8968 src/runnercontext.h c6441b7a1bb92df5549d26f45183c1ff7ce157e6 Diff: https://git.reviewboard.kde.org/r/115909/diff/ Testing --- Builds. Tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel

Re: Review Request 115863: Improve khtml dependencies

2014-02-20 Thread Michael Palimaka
33f1ecb7ba65f223baef242eb21cd34457b020da tests/CMakeLists.txt 8fc438fa932ec43492b6c2a8e5bc8f0337550d1a Diff: https://git.reviewboard.kde.org/r/115863/diff/ Testing --- Builds. Tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 115863: Improve khtml dependencies

2014-02-20 Thread Michael Palimaka
--- Builds. Tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115863: Improve khtml dependencies

2014-02-18 Thread Michael Palimaka
3a3dbab90e6572cf953ba5edc1fcb60a7e30b493 autotests/CMakeLists.txt 33f1ecb7ba65f223baef242eb21cd34457b020da tests/CMakeLists.txt 8fc438fa932ec43492b6c2a8e5bc8f0337550d1a Diff: https://git.reviewboard.kde.org/r/115863/diff/ Testing --- Builds. Tests pass. Thanks, Michael Palimaka

Re: Review Request 115584: Remove kfileaudiopreview transitive dependencies

2014-02-18 Thread Michael Palimaka
/ Testing --- Builds. Inspected source. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115839: Remove kio transitive dependencies

2014-02-17 Thread Michael Palimaka
Description --- This removes KCrash, KGuiAddons, and KTextWidgets as there is no reference to them. Diffs - CMakeLists.txt 0e675178b023483f06cbf96321cad3f3d3bd42f8 Diff: https://git.reviewboard.kde.org/r/115839/diff/ Testing --- Builds. Inspected source. Thanks, Michael

  1   2   3   >