D17816: Support for xattrs on kio copy/move

2020-10-29 Thread Nathaniel Graham
ngraham added a comment.


  Phabricator didn't actually close the revision after I landed it because 
@bruns forgot to change his status to accepted. You can close this now, 
@arrowd. Great work!

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh


D17816: Support for xattrs on kio copy/move

2020-10-29 Thread Nathaniel Graham
ngraham added a comment.


  After almost two years, I'm so happy to see this land!

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh


D17816: Support for xattrs on kio copy/move

2020-10-28 Thread Nathaniel Graham
ngraham added a comment.


  Can you change your status to approved? @dfaure, one final look maybe?

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh


D17816: Support for xattrs on kio copy/move

2020-10-18 Thread Nathaniel Graham
ngraham added a comment.


  @bruns?

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh


T8349: Improve Places panel usability and presentation

2020-10-18 Thread Nathaniel Graham
ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham
Cc: ahmadsamir, sitter, #frameworks, tomsk, bruns, michaelh, acrouthamel, 
sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, 
azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, aprcela, 
fprice, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, Codezela, feverfew, 
trickyricky26, meven, crozbo, spoorun, ndavis, navarromorales, firef, 
andrebarros, skadinna, emmanuelp, rdieter, mikesomov, aaronhoneycutt, mbohlender


T8349: Improve Places panel usability and presentation

2020-10-18 Thread Nathaniel Graham
ngraham added a comment.


  Yeah, that's weird. Let's throw it on the pile.

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham
Cc: ahmadsamir, sitter, #frameworks, tomsk, bruns, michaelh, acrouthamel, 
sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, 
azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage, aprcela, 
fprice, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, GB_2, Codezela, feverfew, 
trickyricky26, meven, crozbo, spoorun, ndavis, navarromorales, firef, 
andrebarros, skadinna, emmanuelp, rdieter, mikesomov, aaronhoneycutt, mbohlender


T8349: Improve Places panel usability and presentation

2020-10-18 Thread Nathaniel Graham
ngraham updated the task description.

TASK DETAIL
  https://phabricator.kde.org/T8349

To: ngraham
Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, 
jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, azyx, dmenig, 
nikolaik, pberestov, manueljlin, iasensio, Orage, aprcela, fprice, cblack, 
konkinartem, ian, jguidon, Ghost6, jraleigh, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, Codezela, feverfew, trickyricky26, meven, crozbo, 
spoorun, ndavis, navarromorales, firef, andrebarros, skadinna, emmanuelp, 
rdieter, mikesomov, aaronhoneycutt, mbohlender


D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

2020-09-17 Thread Nathaniel Graham
ngraham abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10305

To: ngraham, #plasma, #plasma_accessibility, mart, aacid, lshoravi
Cc: davidedmundson, kde-frameworks-devel, aacid, cfeck, ngraham, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28745: Skip caching thumbnails on encrypted filesystems

2020-08-29 Thread Nathaniel Graham
ngraham added a comment.


  @bruns and @meven?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns, dfaure
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov


D17816: Support for xattrs on kio copy/move

2020-08-26 Thread Nathaniel Graham
ngraham added a comment.


  Good now, @bruns?

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh


D28745: Skip caching thumbnails on encrypted filesystems

2020-08-17 Thread Nathaniel Graham
ngraham added a subscriber: dfaure.
ngraham added a comment.


  @dfaure, what do you think here?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D28745

To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns
Cc: dfaure, thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, 
waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, 
cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov


D26067: [KFilePlacesView] Add missing functionality required in order to be used by Dolphin again

2020-08-08 Thread Nathaniel Graham
ngraham added a task: T9795: Use Places Panel code from KIO instead of private 
implementation.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D26067

To: broulik, #frameworks, #vdg, #dolphin, elvisangelaccio
Cc: elvisangelaccio, meven, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns


D7563: Add privilegeExecution field to file protocol description

2020-08-07 Thread Nathaniel Graham
ngraham added a comment.


  Oh and thanks for taking this over, @cblack. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham
Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, 
ngraham, elvisangelaccio, LeGast00n, michaelh, bruns


D7563: Add privilegeExecution field to file protocol description

2020-08-07 Thread Nathaniel Graham
ngraham added inline comments.

INLINE COMMENTS

> file_unix.cpp:1349
> +case ActionType::UTIME:   return QStringLiteral("Authentication is 
> required to modify this file's last updated time.");
> +case ActionType::UNKNOWN: return QStringLiteral("Authentication is 
> required to perform this action.");
> +}

Shouldn't these be localized?

Also can you change "directory" to "folder"?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham
Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, 
ngraham, elvisangelaccio, LeGast00n, michaelh, bruns


D29872: Provide methods to register SecretAgent to NetworkManager with capabilities, specifically with NM_SECRET_AGENT_CAPABILITY_VPN_HINTS

2020-08-02 Thread Nathaniel Graham
ngraham added a comment.


  I did too, but time marches on. :)
  
  You can Abandon this patch now.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D29872

To: enriquem, jgrulich
Cc: ngraham, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D24895: [RFC] Drop implicit size from PC buttons

2020-07-29 Thread Nathaniel Graham
ngraham commandeered this revision.
ngraham added a reviewer: nicolasfella.
ngraham added a comment.


  Let's continue in 
https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/57.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24895

To: ngraham, #plasma, mart, #vdg, davidedmundson, nicolasfella
Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, mart, LeGast00n, 
cblack, michaelh, bruns


D24895: [RFC] Drop implicit size from PC buttons

2020-07-29 Thread Nathaniel Graham
ngraham abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24895

To: ngraham, #plasma, mart, #vdg, davidedmundson, nicolasfella
Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, mart, LeGast00n, 
cblack, michaelh, bruns


D20026: Go up in folder hierachy when in "edit mode"

2020-07-11 Thread Nathaniel Graham
ngraham added a comment.


  Great! Can you Abandon this?

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D20026: Go up in folder hierachy when in "edit mode"

2020-07-11 Thread Nathaniel Graham
ngraham added a comment.


  Thanks for resuming the work on this!
  
  We've since moved to GitLab; could you open this up as a merge request at 
https://invent.kde.org/system/dolphin/-/merge_requests/?  Thanks!

REVISION DETAIL
  https://phabricator.kde.org/D20026

To: krutovmikhail, ngraham, #dolphin
Cc: meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D27197: Add symbolic screenshot icons

2020-06-30 Thread Nathaniel Graham
ngraham added a comment.


  Thanks, that's better now. However the camera silhouette still doesn't match 
that of other monochrome camera images we have. I'd like to stick to standard 
iconography if possible. Do you think we should switch the other related icons 
to use your new camera icon, or would you like to use the one from, for 
example, `preferences-system-windows-effect-screenshot`?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27197

To: mbruchert, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D17816: Support for xattrs on kio copy/move

2020-06-22 Thread Nathaniel Graham
ngraham added a comment.


  @bruns?

REVISION DETAIL
  https://phabricator.kde.org/D17816

To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise
Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, 
funkybomber, abika, pino, davidedmundson, ngraham, atha.kane, spoorun, 
nicolasfella, kde-frameworks-devel, LeGast00n, cblack, michaelh


D24476: [KPropertiesDialog] Only show volume-related info for volumes

2020-06-13 Thread Nathaniel Graham
ngraham abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24476

To: ngraham, #vdg, #frameworks, broulik, ndavis
Cc: pino, ndavis, Zren, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D26898: expose an id for the wallpaper

2020-06-12 Thread Nathaniel Graham
ngraham added a task: T10495: wallpaper cache.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D26898

To: mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29207: [Indexers] Ignore name-based mimetype for initial indexing decisions

2020-06-10 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Shipit!

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D29207

To: bruns, #baloo, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

2020-06-09 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29463

To: Zren, #kirigami, mart
Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29397: KPreviewJob : Support for DeviceRatioPixel

2020-06-08 Thread Nathaniel Graham
ngraham added a comment.


  The proposed additions to the spec are non-controversial IMO. Let's push that 
forward. I left a supportive comment in the email thread, so maybe it's time to 
put together a patch that people can comment on.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns


D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

2020-06-01 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29815

To: mthw, #frameworks, davidedmundson, anthonyfieroni
Cc: ngraham, anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns


D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

2020-06-01 Thread Nathaniel Graham
ngraham added a comment.


  Fair enough.

REPOSITORY
  R297 KDED

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29815

To: mthw, #frameworks, davidedmundson, anthonyfieroni
Cc: ngraham, anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns


D29815: Fix blurry icons in titlebar appmenu by adding UseHighDpiPixmaps flag

2020-06-01 Thread Nathaniel Graham
ngraham added a comment.


  You might have more luck migrating this to https://invent.kde.org.
  
  https://community.kde.org/Infrastructure/GitLab

REPOSITORY
  R297 KDED

REVISION DETAIL
  https://phabricator.kde.org/D29815

To: mthw, #frameworks, davidedmundson
Cc: ngraham, anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns


D29774: Add X-KDE-DBUS-Restricted-Interfaces to Application desktop entry fields

2020-05-31 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R309 KService

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29774

To: meven, davidedmundson, zzag, #frameworks, #kwin, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-25 Thread Nathaniel Graham
ngraham added a comment.


  Here's where the spec lives, FWIW: 
https://gitlab.freedesktop.org/xdg/xdg-specs
  
  Expanding it is mostly just a matter of writing up a reasonable proposal in 
the form of a merge request and getting enough people to agree. Discussing on 
the mailing list first can help, to gauge people's opinions.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns


D29832: Fix Endianness issue during wallet decryption

2020-05-25 Thread Nathaniel Graham
ngraham added a reviewer: aacid.
ngraham added a comment.


  Thanks for the patch! FWIW we have moved patch review to GitLab; consider 
abandoning this and re-submitting it as a merge request at 
https://invent.kde.org/frameworks/kwallet/-/merge_requests
  
  Here's some documentation: https://community.kde.org/Infrastructure/GitLab

REPOSITORY
  R311 KWallet

REVISION DETAIL
  https://phabricator.kde.org/D29832

To: chriscz, dfaure, aacid
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-25 Thread Nathaniel Graham
ngraham added a comment.


  The approach makes sense then. I agree that making high DPI a part of the FDO 
spec would be nice, but IMO that shouldn't block this. The approach currently 
taken is logical and it could be submitted as an extension to the spec later.

INLINE COMMENTS

> ngraham wrote in previewjob.cpp:401
> Is this @2x suffix standardized? What happens if I'm using 125% scaling, 
> generate some previews, and then switch back to 100% (no scaling?)

What about if I'm using a 250% scale factor? Maybe there should be an `@3x` 
folder too.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns


D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

2020-05-24 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.


  LGTM. @bruns?

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D28590

To: meven, #frameworks, bruns, sitter, dfaure, ngraham
Cc: ngraham, dfaure, broulik, ervin, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns


D29525: Make Previews devicePixelRatio aware

2020-05-24 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  (once the dependent patches have landed)

REPOSITORY
  R318 Dolphin

BRANCH
  arcpatch-D29525

REVISION DETAIL
  https://phabricator.kde.org/D29525

To: meven, #dolphin, #frameworks, dfaure, ngraham, elvisangelaccio
Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, 
fprice, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, 
navarromorales, firef, ngraham, andrebarros, emmanuelp, rdieter, mikesomov


D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-24 Thread Nathaniel Graham
ngraham added a comment.


  Overall seems sane. Two questions though:

INLINE COMMENTS

> previewjob.cpp:401
> +thumbPath = thumbRoot + QLatin1String(cacheWidth == 128 ? "normal" : 
> "large");
> +thumbPath.append(qFuzzyCompare(devicePixelRatio, 2) ? 
> QStringLiteral("@2x/") : QStringLiteral("/"));
> +

Is this @2x suffix standardized? What happens if I'm using 125% scaling, 
generate some previews, and then switch back to 100% (no scaling?)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29397

To: meven, dfaure, broulik, #frameworks, ngraham
Cc: elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns


D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-20 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma, ahiemstra
Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns


D29436: Use font: instead of font.pointSize: where possible

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29436

To: ngraham, #plasma, cblack
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-19 Thread Nathaniel Graham
ngraham added a comment.


  @ahiemstra #frameworks  #plasma 
 ping.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns


D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-19 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

2020-05-18 Thread Nathaniel Graham
ngraham closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29483

To: ngraham, #frameworks, #vdg, cfeck, cblack
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29806: Thumbnail folders: scale down sub image when their height is too big

2020-05-18 Thread Nathaniel Graham
ngraham added a comment.


  Haha the "before" image is hilarious!

INLINE COMMENTS

> thumbnail.cpp:415
> +} else
> +if ((image.size().height() > imageTargetSize.height()) && 
> (imageTargetSize.height() != 0)) {
> +scaling = float(imageTargetSize.height()) / 
> float(image.size().height());

Is this an `else if (...) {` or an `else { if (...) {`

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D29806

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, 
iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde, Codezela, 
feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, rdieter, mikesomov


D29802: Require out-of-source builds

2020-05-17 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:7abe60d96609: Require in-source build (authored by 
ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29802?vs=83008=83021

REVISION DETAIL
  https://phabricator.kde.org/D29802

AFFECTED FILES
  CMakeLists.txt

To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella, ndavis, 
tfella, filipf, cblack
Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29802: Require out-of-source builds

2020-05-17 Thread Nathaniel Graham
ngraham added a comment.


  I think this patch meets the world record for number of acceptances!

REPOSITORY
  R266 Breeze Icons

BRANCH
  require-in-source-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29802

To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella, ndavis, 
tfella, filipf, cblack
Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29802: Require out-of-source builds

2020-05-16 Thread Nathaniel Graham
ngraham retitled this revision from "Require in-source build" to "Require 
out-of-source builds".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29802

To: ngraham, #frameworks, #vdg, ognarb, davidre
Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29802: Require in-source build

2020-05-16 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: Frameworks, VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  In addition to just being a good idea in general, the dynamic icon
  generation bit doesn't work properly with in-source builds. Let's
  formally require out-of-source builds.
  
  BUG: 421637
  FIXED-IN: 5.71

TEST PLAN
  Try out of source build, get yelled at

REPOSITORY
  R266 Breeze Icons

BRANCH
  require-in-source-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29802

AFFECTED FILES
  CMakeLists.txt

To: ngraham, #frameworks, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-15 Thread Nathaniel Graham
ngraham updated this revision to Diff 82971.
ngraham added a comment.


  Only open in System Settings or Info Center if systemsettings is installed

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29711?vs=82751=82971

BRANCH
  create-kcmshell-openSystemSettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29711

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt
  src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp
  src/qmlcontrols/kquickcontrolsaddons/kcmshell.h

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-15 Thread Nathaniel Graham
ngraham added a comment.


  In D29711#671616 , @mart wrote:
  
  > hmm, should probably check before whether systemsettings5 and kinfocenter 
exist beforehand and fallback to kcmshell if not?
  
  
  Yeah Christoph and Luigi brought that up too. Will do.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-14 Thread Nathaniel Graham
ngraham added a comment.


  In D29711#670503 , @ltoscano wrote:
  
  > If the scope of this change is just about Plasma applet, of course 
systemsettings is going to be around.
  
  
  Yes the scope of this change is purely for Plasma applets; look at the 
dependent patches.
  
  > But are you sure you want to kill kcmshell? KCMs are not for Plasma only. 
Opening them outside Plasma would still require a minimal shell.
  > 
  > Regarding this change, I guess you may have discussed it already, but 
wouldn't it be possible to find out whether systemsettings is available (and 
then kinfocenter) and use it, without adding a new function?
  
  We didn't kill kcmshell, it's explicitly still around.
  
  I can't add new behaviors to the existing function because of the reasons 
listed in the description section of this patch.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: ltoscano, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

2020-05-14 Thread Nathaniel Graham
ngraham added a comment.


  Ping.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29483

To: ngraham, #frameworks, #vdg, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28902: CopyJob: when stat'ing the dest, use StatBasic.

2020-05-14 Thread Nathaniel Graham
ngraham added a comment.


  @dfaure git bisect says this caused 
https://bugs.kde.org/show_bug.cgi?id=421213.
  
  After fixing, maybe we should get a test for that use case?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D28902

To: dfaure, meven
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29739: Add 48px places icons

2020-05-14 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks fantastic to me. All good now, @ndavis?

REPOSITORY
  R266 Breeze Icons

BRANCH
  48px-places (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29738: Fix service file specifying 'Run in terminal' giving an error code 100

2020-05-14 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29738

To: marten, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29739: Add 48px places icons

2020-05-14 Thread Nathaniel Graham
ngraham added a comment.


  Nice work!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29740: [PC3 Button] Don't remain in a pressed state after press

2020-05-14 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dont-remain-pressed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29740

To: filipf, davidedmundson, mart, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29745: look for kded as runtime dep

2020-05-14 Thread Nathaniel Graham
ngraham accepted this revision.

REPOSITORY
  R241 KIO

BRANCH
  kded

REVISION DETAIL
  https://phabricator.kde.org/D29745

To: sitter, dfaure, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29739: Add 48px places icons

2020-05-14 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-13 Thread Nathaniel Graham
ngraham updated this revision to Diff 82786.
ngraham marked an inline comment as done.
ngraham added a comment.


  Address review comment

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29534?vs=82311=82786

BRANCH
  implement-spinbox-wheel-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29534

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/SpinBox.qml

To: ngraham, #vdg, #plasma
Cc: ahiemstra, abetts, ndavis, cblack, kde-frameworks-devel, LeGast00n, 
michaelh, ngraham, bruns


D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a comment.


  In D29711#670458 , @cfeck wrote:
  
  > Sorry if I don't understand the scope, but does this mean I am forced to 
install systemsettings to be able to use KCMs?
  
  
  Why, is the "I'm using Plasma but I don't have System Settings installed" use 
case something that you think we should handle?
  
  The context is that users were requesting for KCMs to be opened in System 
Settings, not KCMShell (https://bugs.kde.org/show_bug.cgi?id=402790) and we 
implemented that for the KCM runner for Plasma 5.19. The issue fixed here is an 
inconsistency in that opening KCMs from Plasma applet context menu would still 
open it in KCMShell, not System Settings or Info Center (which in 5.19 is now 
just System Settings; the same app shows both).

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29678: Fix incorrect colours in the KNS Quick messagebox

2020-05-13 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-colour-issue-for-messagebox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29678

To: leinir, #frameworks, #knewstuff, #plasma, bugseforuns, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29634: sftp: break large writes into multiple requests

2020-05-13 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.


  Nice work.
  
  In D29634#670159 , @feverfew wrote:
  
  > I imagine something similar should be done for FileJob::write?
  
  
  Yeah.

REPOSITORY
  R320 KIO Extras

BRANCH
  release/20.04

REVISION DETAIL
  https://phabricator.kde.org/D29634

To: sitter, ngraham, meven, feverfew
Cc: meven, feverfew, kde-frameworks-devel, kfm-devel, waitquietly, azyx, 
nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, 
fbampaloukas, alexde, Codezela, michaelh, spoorun, navarromorales, firef, 
ngraham, andrebarros, bruns, emmanuelp, rdieter, mikesomov


D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29716: [applet] Show KCM in System 
Settings.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29715: [applet] Show KCM in System 
Settings.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29714: [applets] Show KCMs in System 
Settings.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29713: [applets] Show KCMs in System 
Settings.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham added a dependent revision: D29712: [applets] Show KCMs in System 
Settings or Info Center, as appropriate.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29711

To: ngraham, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Many Plasma applets use `kcmshell.open` to open the appropriate KCM. However
  now that we're de-emphasizing kcmshell, we want these to open in System
  Settings or Info Center instead.
  
  We can't just change the existing function for a few reasons:
  
  1. This is a frameworks; changing functionality like that isn't nice.
  2. The existing function takes a string list, which KCMShell supports to open 
multiple KCMs, but System Settings does not support this.
  3. There's still an occasional need to open KCMs in KCMShell (e.g. from 
another KCM open in System Settings).
  4. We need to distinguish between opening in System Settings and opening in 
Info Center
  
  Accordingly, two new functions are created: one to open a KCM in System
  Settings, and another to open in Info Center. Applets will be ported to
  use these.

TEST PLAN
  Test dependent patches (see Stack)

REPOSITORY
  R296 KDeclarative

BRANCH
  create-kcmshell-openSystemSettings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29711

AFFECTED FILES
  src/qmlcontrols/kquickcontrolsaddons/kcmshell.cpp
  src/qmlcontrols/kquickcontrolsaddons/kcmshell.h

To: ngraham, #plasma, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29678: Fix incorrect colours in the KNS Quick messagebox

2020-05-13 Thread Nathaniel Graham
ngraham added a comment.


  Does this even need to be a TextEdit? Or is that to get mouse-selectability 
for the error text? If so, +1 but please add comments indicating this reason.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D29678

To: leinir, #frameworks, #knewstuff, #plasma, bugseforuns
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


T13144: Remove deprecated code from Kirigami example

2020-05-12 Thread Nathaniel Graham
ngraham closed this task as "Resolved".
ngraham claimed this task.
ngraham added a comment.


  Phabricator is used for task tracking, not bug reporting. Since this is a 
simple documentation fix, can you submit a patch? That would be lovely. :)

TASK DETAIL
  https://phabricator.kde.org/T13144

To: ngraham
Cc: ngraham, bcooksley, kde-frameworks-devel, sanecito, LeGast00n, cblack, 
michaelh, bruns


D7563: Add privilegeExecution field to file protocol description

2020-05-12 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: ngraham, #frameworks, dfaure, chinmoyr
Cc: kkong, kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, 
elvisangelaccio, LeGast00n, cblack, michaelh, bruns


D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-05-12 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, 
chinmoyr
Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, 
LeGast00n, cblack, michaelh, bruns


D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-05-12 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D21795

To: feverfew, apol, bruns, davidedmundson, #frameworks, dfaure, cfeck, sitter, 
chinmoyr
Cc: elvisangelaccio, bcooksley, ngraham, sitter, mreeves, kde-frameworks-devel, 
LeGast00n, cblack, michaelh, bruns


D29680: Fix modified line marker in kate minimap

2020-05-12 Thread Nathaniel Graham
ngraham added a comment.


  Ah right, that's still here.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D29680

To: davidedmundson, #kate
Cc: ngraham, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
domson, michaelh, bruns, demsking, cullmann, sars, dhaumann


D29680: Fix modified line marker in kate minimap

2020-05-12 Thread Nathaniel Graham
ngraham added a comment.


  Kate patches are at https://invent.kde.org/kde/kate/-/merge_requests, BTW.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D29680

To: davidedmundson, #kate
Cc: ngraham, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
domson, michaelh, bruns, demsking, cullmann, sars, dhaumann


D27203: Don't try to open files we can't figure out where they are

2020-05-11 Thread Nathaniel Graham
ngraham added a comment.


  Does this fix https://bugs.kde.org/show_bug.cgi?id=408174?

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27203: Don't try to open files we can't figure out where they are

2020-05-11 Thread Nathaniel Graham
ngraham added reviewers: meven, ahmadsamir.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks, #plasma, dfaure, meven, ahmadsamir
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27203: Don't try to open files we can't figure out where they are

2020-05-11 Thread Nathaniel Graham
ngraham added a reviewer: dfaure.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D27203

To: apol, #frameworks, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D18883: Add PDF thumbnailer

2020-05-11 Thread Nathaniel Graham
ngraham added a comment.


  Yeah, seems like this got bikeshedded to death but I think it would still be 
quite worthwhile to have.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D18883

To: broulik, dfaure, aacid, jtamate
Cc: meven, bruns, dhaumann, ngraham, pino, ltoscano, kde-frameworks-devel, 
kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, 
LeGast00n, cblack, fbampaloukas, alexde, Codezela, feverfew, michaelh, spoorun, 
navarromorales, firef, andrebarros, emmanuelp, rdieter, mikesomov


D29511: Label: Add ping-pong logic

2020-05-10 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added a comment.


  Yeah, This should be a new component, or at most enabled by an off-by-default 
property. The default behavior should not change.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg, ognarb, davidedmundson, ngraham
Cc: ngraham, apol, davidedmundson, ognarb, cblack, kde-frameworks-devel, 
LeGast00n, michaelh, bruns


D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham added a comment.


  In D29534#666554 , @ndavis wrote:
  
  > I don't like the look of those +/- buttons. I think this makes it harder to 
know that you can drag the panel height up and down.
  
  
  That would be a comment for D29535 , but 
I will repeat my argument here: I think that drag is the least important 
interaction method for panel thickness adjustment since you typically want to 
make fine adjustments or arrive at a specific value, both of which are unsuited 
for drag-based interactions. Nevertheless, I have implemented drag-adjustment 
in the spinbox control here to not lose it, which also yields the advantage 
that other potential Plasma components that use a spinbox will benefit from it.
  
  We can improve the look of this control in another patch. To my knowledge it 
hasn't been used at all so it wouldn't surprise me if it's a bit unpolished.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham retitled this revision from "Implement wheel/touchpad scrolling for 
SpinBox control" to "Implement scroll and drag adjustment of values for SpinBox 
control".
ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham added a task: T9460: Consider a more user-friendly SpinBox control.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham updated this revision to Diff 82311.
ngraham added a comment.


  Implement click-and-drag (along both the X and Y axes) to modify the value

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29534?vs=82276=82311

BRANCH
  implement-spinbox-wheel-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29534

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/SpinBox.qml

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29536: Adds a missing LibreOffice icon shortcut

2020-05-08 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fixlo16px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29536

To: manueljlin, #vdg, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham updated this revision to Diff 82276.
ngraham marked 4 inline comments as done.
ngraham added a comment.


  More control, less parseInt

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29534?vs=82274=82276

BRANCH
  implement-spinbox-wheel-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29534

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/SpinBox.qml

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham updated this revision to Diff 82274.
ngraham added a comment.


  Mark the value has having been modified after adjusting by scrolling

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29534?vs=82273=82274

BRANCH
  implement-spinbox-wheel-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29534

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/SpinBox.qml

To: ngraham, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently adjusting the value by scrolling is not implemented. This patch 
implements it.

TEST PLAN
  [Coming soon]

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  implement-spinbox-wheel-adjustment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29534

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/SpinBox.qml

To: ngraham, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29513: [kcm trash] Change kcm trash size percent to 2 decimal places

2020-05-07 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  trash

REVISION DETAIL
  https://phabricator.kde.org/D29513

To: shubham, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-05-07 Thread Nathaniel Graham
ngraham added a comment.


  I like #2 the best!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns


D29503: Pixel align children of GridViewInternal

2020-05-07 Thread Nathaniel Graham
ngraham added a comment.


  I can't reproduce it, but I wonder if this could fix or help 
https://bugs.kde.org/show_bug.cgi?id=417488?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29503

To: fvogt, #frameworks, broulik, mart, davidedmundson
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-05-07 Thread Nathaniel Graham
ngraham accepted this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D29123_1

REVISION DETAIL
  https://phabricator.kde.org/D29123

To: alex, #knewstuff, meven, ngraham, leinir
Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

2020-05-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:f9f3f6ca260a: Use Standard Show/Hide Hidden 
files shortcuts in directory chooser dialog (authored by ngraham).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29238?vs=81378=82151

REVISION DETAIL
  https://phabricator.kde.org/D29238

AFFECTED FILES
  CMakeLists.txt
  src/platformtheme/kdirselectdialog.cpp

To: ngraham, #plasma, #frameworks, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-06 Thread Nathaniel Graham
ngraham added a comment.


  In D29485#664977 , @ahmadsamir 
wrote:
  
  > I couldn't seem to test the m_privilegeExecutionEnabled stuff, i.e. using 
dolphin, the paste action is disabled if the dir isn't owned by me.
  
  
  See D7563  (assistance would be 
appreciated if you have any idea how to make that work).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D29485

To: ahmadsamir, #frameworks, dfaure, meven, sitter
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

2020-05-06 Thread Nathaniel Graham
ngraham added a comment.


  Ping.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D29238

To: ngraham, #plasma, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D29434: Use small font for ExpandableListItem subtitle

2020-05-06 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:416f82f8f7f5: Use small font for ExpandableListItem 
subtitle (authored by ngraham).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29434?vs=81956=82110

REVISION DETAIL
  https://phabricator.kde.org/D29434

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/ExpandableListItem.qml

To: ngraham, #plasma, #vdg, broulik, ndavis
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

2020-05-06 Thread Nathaniel Graham
ngraham updated this revision to Diff 82102.
ngraham added a comment.


  Spell "oddities" correctly

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29483?vs=82101=82102

BRANCH
  
show-warnings-for-leading-and-trailing-spaces-when-creating-files-or-folders-and-wow-this-is-a-long-branch-name-at-this-point
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29483

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: ngraham, #frameworks, #vdg, cfeck
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


  1   2   3   4   5   6   7   8   9   10   >