Re: Gitlab CI - Inbound

2021-09-05 Thread Nicolas Fella
On 05.09.21 08:13, Ben Cooksley wrote: Hi all, This morning after much work i'm happy to announce that the new generation CI scripts intended for use with Gitlab CI successfully completed their first build (of ECM, and then subsequently of KCoreAddons). This begins our first steps towards

Re: KService as a platform abstraction framework?

2021-07-03 Thread Nicolas Fella
On 03.07.21 10:25, Volker Krause wrote: Hi, while looking at implementing a pretty straightforward KApplicationTrader/ KIO::ApplicationLauncherJob use ([1]) for Android, I found myself wondering whether we should have an Android backend for KService. KService conceptually matches

T14621: [RFC] Consider deprecating PlasmaExtras.PlasmoidHeading in favor of PC3.ToolBar

2021-06-24 Thread Nicolas Fella
nicolasfella removed a project: KF6. TASK DETAIL https://phabricator.kde.org/T14621 To: nicolasfella Cc: nicolasfella, niccolove, mart, kde-frameworks-devel, mikeljohnson, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

T14621: [RFC] Consider deprecating PlasmaExtras.PlasmoidHeading in favor of PC3.ToolBar

2021-06-24 Thread Nicolas Fella
nicolasfella added a comment. I'm not sure this makes sense on a semantic level. The current PlasmoidHeading happens to be very similar to a toolbar, but is that always going to be the case? I don't want us to be locked into a situation where we can't change things later on because they

Re: dark theme on windows in KF 5.83

2021-06-17 Thread Nicolas Fella
On 17.06.21 10:18, Alexander Semke wrote: Hi, with the last nighly build for LabPlot we observed a big regression on Windows. Attached are two files. The first one is based on KF 5.82, the second one on 5.83. In both cases the default color scheme is used in LabPlot which is Window's dark theme

Re: Notice of withdrawal of CI services: KDevelop and KDE Connect

2021-06-16 Thread Nicolas Fella
Hi Ben, On 16.06.21 20:28, Ben Cooksley wrote: Hi all, The following is notice that I intend to withdraw CI services from the following two KDE projects due to faults in their code or build system which are having a significant adverse impact on the CI system and negatively impacting on other

Respin request for qqc2-desktop-style

2021-06-07 Thread Nicolas Fella
Hi David, can we please get a respin for the qqc2-desktop-style tarball with https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/73 inside? Cheers Nico

T14471: Make Qt 5.15.0 to 5.15.2 for frameworks

2021-05-19 Thread Nicolas Fella
nicolasfella added a comment. Do we actually *want* to use the API that has been introduced in production? From QStringView:: toInt: Note: This method has been added in 5.15.2 to simplify writing code that is portable between Qt 5.15 and Qt 6. The implementation is not tuned for

Re: KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.15 - Build # 58 - Still Unstable!

2021-05-01 Thread Nicolas Fella
Hi David, this should be fixed with https://invent.kde.org/frameworks/ki18n/-/merge_requests/15 Cheers Nico On 1 May 2021 11:20:31 CEST, David Faure wrote: >Hi Nicolas, > >It looks like the ki18n commit > >Backport FindIntl.cmake from CMake 3.20 > >might have broken the lookup of

Re: KGlobalAccel on non-Plasma systems

2021-04-06 Thread Nicolas Fella
set to KDE, so it is safe in that regard. On Tue, 2021-04-06 at 17:29 +0200, Nicolas Fella wrote: Hi, we received a few reports [1] [2] from people using non-Plasma systems that the kglobalaccel5 process was started, leading to clashes with the native global shortcut system. This seems to happen

KGlobalAccel on non-Plasma systems

2021-04-06 Thread Nicolas Fella
Hi, we received a few reports [1] [2] from people using non-Plasma systems that the kglobalaccel5 process was started, leading to clashes with the native global shortcut system. This seems to happen when apps call some API of KGlobalAccel which results in the kglobalaccel5 process to be

D26449: [PoC] Port to KRecentFileMenu

2021-04-06 Thread Nicolas Fella
nicolasfella abandoned this revision. nicolasfella added a comment. https://invent.kde.org/utilities/ark/-/merge_requests/39 REPOSITORY R36 Ark REVISION DETAIL https://phabricator.kde.org/D26449 To: nicolasfella, #ark, #frameworks Cc: meven, mlaurent, kde-utils-devel, fbampaloukas,

Re: KDE review for KWeatherCore

2020-12-21 Thread Nicolas Fella
On 12/21/20 3:19 PM, Friedrich W. H. Kossebau wrote: Am Montag, 21. Dezember 2020, 07:16:09 CET schrieb hanyoung: KWeatherCore: https://invent.kde.org/libraries/kweathercore is a library for querying weather forecast data. During the development of KWeather, we found the need to have a

D22544: [RFC] Deprecate KPassivePopup

2020-12-07 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22544 To: nicolasfella, #frameworks, broulik Cc: ngraham, davidedmundson, aspotashev, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D22093: Don't show progress window for jobs that don't report progress

2020-12-06 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D22093 To: nicolasfella, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D23835: Add TabKCM

2020-12-06 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23835 To: nicolasfella, mart Cc: broulik, onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

Re: Would distributions have an issue if KF 5.77+ would require Qt >= 5.14 (instead of >= 5.13 as of now)?

2020-12-01 Thread Nicolas Fella
Hi, with my KDE Android hat on this would be fine, we use Qt 5.15. For KDE's own Windows/Mac builds I'd expect it to be similar. What most/all not-traditional-Linux-distro users have in common is that they are not bound to the specific Qt version decided and shipped by a vendor and instead

PSA: Frameworks depends on Qt 5.13 now

2020-11-26 Thread Nicolas Fella
Hi, per our Qt dependency policy [0] Frameworks depends on Qt 5.13 6 months after the release of Qt 5.15, which is now. Have fun with the new stuff. Nico [0] https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements

D24443: Add a plugin system

2020-11-18 Thread Nicolas Fella
nicolasfella abandoned this revision. nicolasfella added a comment. Moving to invent: https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/20 REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim

D28834: Add metadata properties to calendar

2020-11-18 Thread Nicolas Fella
nicolasfella abandoned this revision. nicolasfella added a comment. moving to invent: https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/19 REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause,

D29020: Add example/test application

2020-11-02 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29020 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29391: Introduce setWindow and CloseWhenWindowActivated

2020-11-02 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29391 To: nicolasfella, #frameworks, broulik Cc: anthonyfieroni, kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Stepping down as KRunner maintainer

2020-10-08 Thread Nicolas Fella
Thanks for all your work Kai and congratulations Alexander, this is well deserved! Cheers Nico On 08.10.20 19:17, Kai Uwe Broulik wrote: Hi everyone, you might not even have known this but officially I have been KRunner's maintainer for several years at this point :-) However, I have

D25705: Deprecate KIO::pixmapForUrl

2020-09-20 Thread Nicolas Fella
nicolasfella abandoned this revision. nicolasfella added a comment. Moved to https://invent.kde.org/frameworks/kio/-/merge_requests/144 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel,

T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

2020-08-31 Thread Nicolas Fella
nicolasfella added a subtask: T13555: Create replacement for KPluginInfo::kcmServices. TASK DETAIL https://phabricator.kde.org/T12173 To: nicolasfella Cc: #frameworks, nicolasfella, dfaure, mart, davidre, GB_2, ekasprzak, ahmadsamir, ngraham, kpiwowarski, usta, asturmlechner, jucato, cfeck,

D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-17 Thread Nicolas Fella
nicolasfella closed this revision. REVISION DETAIL https://phabricator.kde.org/D26448 To: nicolasfella, #frameworks, dfaure Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-13 Thread Nicolas Fella
nicolasfella updated this revision to Diff 83348. nicolasfella added a comment. - Use menus font metric CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=83346=83348 BRANCH recentfilemenu REVISION DETAIL https://phabricator.kde.org/D26448 AFFECTED FILES

D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-11 Thread Nicolas Fella
nicolasfella updated this revision to Diff 83346. nicolasfella added a comment. - Use widgets font metrics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=83338=83346 BRANCH recentfilemenu REVISION DETAIL https://phabricator.kde.org/D26448 AFFECTED FILES

D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-03 Thread Nicolas Fella
nicolasfella marked an inline comment as done. nicolasfella added inline comments. INLINE COMMENTS > dfaure wrote in krecentfilesmenu.cpp:150 > Depending on QtConcurrent is just fine. However QtConcurrent::filtered is for > CPU-intensive operations, not for I/O operations. 1) you don't want to

D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-03 Thread Nicolas Fella
nicolasfella updated this revision to Diff 83338. nicolasfella marked an inline comment as done. nicolasfella added a comment. - Fix @since - Add underscore to filename - Reserve vector CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=83337=83338 BRANCH recentfilemenu

D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-03 Thread Nicolas Fella
nicolasfella marked 6 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D26448 To: nicolasfella, #frameworks, dfaure Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-08-03 Thread Nicolas Fella
nicolasfella updated this revision to Diff 83337. nicolasfella marked an inline comment as done. nicolasfella added a comment. - Make findEntry return non-const iterator - Use std::vector - Truncate entries when setting maximum CHANGES SINCE LAST UPDATE

D26448: Add KRecentFilesMenu to replace KRecentFileAction

2020-07-28 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in krecentfilesmenu.cpp:150 > If we're rewriting this thing anyway, can we please make sure it does not > block application startup checking if those files exist, as can happen if you > had opened files on an NFS mount before.

Frameworks support for Qt 5.12

2020-07-15 Thread Nicolas Fella
Hi, I received a question on how long KF5 will continue to support Qt 5.12. Given that 5.12 is an LTS release according to our policy it would be supported "until the next Qt release after the next Qt release", which would be 5.16, which will never exist. Our policy states "With Qt6 this

D29020: Add example/test application

2020-07-02 Thread Nicolas Fella
nicolasfella added a comment. Ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29020 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26918: Improve KNotification API docs

2020-07-02 Thread Nicolas Fella
nicolasfella updated this revision to Diff 83322. nicolasfella marked 8 inline comments as done. nicolasfella added a comment. - Address comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26918?vs=78423=83322 BRANCH arcpatch-D26918 REVISION DETAIL

D29390: Respect QIcon::fallbackSearchpaths()

2020-06-13 Thread Nicolas Fella
nicolasfella closed this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29390 To: nicolasfella, #plasma, #frameworks, mart Cc: mart, kossebau, aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29358: Implement lock-screen visibility control on Android

2020-05-22 Thread Nicolas Fella
nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25551: Mark KXmlRpcClient as porting aid

2020-05-21 Thread Nicolas Fella
nicolasfella closed this revision. REPOSITORY R312 KXmlRpcClient REVISION DETAIL https://phabricator.kde.org/D25551 To: nicolasfella, #frameworks, dvratil Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29358: Implement lock-screen visibility control on Android

2020-05-20 Thread Nicolas Fella
nicolasfella requested changes to this revision. nicolasfella added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > notifybyandroid.cpp:110 > n.setField("urgency", (jint)(notification->urgency() == > KNotification::DefaultUrgency ?

D29358: Implement lock-screen visibility control on Android

2020-05-20 Thread Nicolas Fella
nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29420: Generate DBus interface

2020-05-20 Thread Nicolas Fella
nicolasfella closed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29420 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29391: Introduce setWindow and CloseWhenWindowActivated

2020-05-18 Thread Nicolas Fella
nicolasfella edited the test plan for this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29391 To: nicolasfella, #frameworks, broulik Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29391: Introduce setWindow and CloseWhenWindowActivated

2020-05-18 Thread Nicolas Fella
nicolasfella updated this revision to Diff 83051. nicolasfella added a comment. - Address APIdocs issues - Remove timer REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29391?vs=81822=83051 BRANCH closewin REVISION DETAIL

D24025: Don't use KCrash on Android

2020-05-18 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: vkrause, apol, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22868: Revamp Kirigami.AboutPage

2020-05-18 Thread Nicolas Fella
nicolasfella added a comment. can this be closed? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir, nicolasfella Cc: nicolasfella, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol,

D25551: Mark KXmlRpcClient as porting aid

2020-05-18 Thread Nicolas Fella
nicolasfella added a comment. ping? Only kblog is using it, but according to T12157 that is supposed to go away too REPOSITORY R312 KXmlRpcClient REVISION DETAIL https://phabricator.kde.org/D25551 To: nicolasfella, #frameworks, dvratil Cc:

D23968: Use app specific location for DB on Android

2020-05-18 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D23968 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28312: Implement urls using hints

2020-05-18 Thread Nicolas Fella
nicolasfella closed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28312 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29802: Require out-of-source builds

2020-05-17 Thread Nicolas Fella
nicolasfella accepted this revision. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella Cc: ltoscano, davidre, kde-frameworks-devel,

D29390: Respect QIcon::fallbackSearchpaths()

2020-05-11 Thread Nicolas Fella
nicolasfella updated this revision to Diff 82600. nicolasfella added a comment. - Use array REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29390?vs=81821=82600 BRANCH fallback REVISION DETAIL https://phabricator.kde.org/D29390 AFFECTED FILES

D29390: Respect QIcon::fallbackSearchpaths()

2020-05-11 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > aacid wrote in kiconloader.cpp:1142 > I just realized that function is private, not really easy to use :/ > > anyhow do you think we should remove svgz? > > Also i think using > > const QStringList extensions = { QStringLiteral(".png"), >

D29631: [android] Allow specifying APK install location

2020-05-11 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R240:a70e9a0162f7: [android] Allow specifying APK install location (authored by nicolasfella). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D29631: [android] Allow specifying APK install location

2020-05-11 Thread Nicolas Fella
nicolasfella updated this revision to Diff 82531. nicolasfella added a comment. - Rename variable REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29631?vs=82527=82531 BRANCH androinstall REVISION DETAIL https://phabricator.kde.org/D29631

D29631: [android] Allow specifying APK install location

2020-05-11 Thread Nicolas Fella
nicolasfella marked 2 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29631 To: nicolasfella, #frameworks, #android, apol, vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns

D29631: [android] Allow specifying APK install location

2020-05-11 Thread Nicolas Fella
nicolasfella added a comment. This is used in https://invent.kde.org/sysadmin/ci-tooling/-/merge_requests/68 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29631 To: nicolasfella, #frameworks, #android, apol, vkrause Cc: kde-frameworks-devel,

D29631: [android] Allow specifying APK install location

2020-05-11 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, Android, apol, vkrause. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This allows

D29420: Generate DBus interface

2020-05-07 Thread Nicolas Fella
nicolasfella updated this revision to Diff 82237. nicolasfella added a comment. - Use q as parent - Change reply type - Use ranged-for REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29420?vs=81920=82237 BRANCH geninterface REVISION DETAIL

D29420: Generate DBus interface

2020-05-07 Thread Nicolas Fella
nicolasfella marked 3 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29420 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29420: Generate DBus interface

2020-05-05 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in notifybypopup.cpp:115 > Previously it would accept the signal from any service which I find odd, > though. Could you maybe check git logs to see if there was a reason for this? > It should survive restarts anyway and the

D29420: Generate DBus interface

2020-05-04 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We already use a generated interface in

D29336: Remove galago from method/variable naming

2020-05-04 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R289:2012f675aed2: Remove galago from method/variable naming (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29336?vs=81680=81892

D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Nicolas Fella
nicolasfella added a comment. In D29405#662963 , @apol wrote: > Won't this make it harder to put together the notifications kcm? Good point, we use the notifyrc file to know which apps send notifications ahead of time. Maybe we need

D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Nicolas Fella
nicolasfella added a comment. We want to phase out notifyrc files for several reasons: - They are an overkill for many simple use cases - A common pitfall when using KNotifications are missing or incorrect notifyrc files - Most of the information in there is duplicate/overridden at

D29405: [PoC] Make notifications work without a notifyrc file

2020-05-04 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY In KNotificationManager when reading the actions

D29391: Introduce setWindow and CloseWhenWindowActivated

2020-05-03 Thread Nicolas Fella
nicolasfella added a comment. In D29391#662471 , @broulik wrote: > The `QWidget` one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful? lol, turns out that

D29391: Introduce setWindow and CloseWhenWindowActivated

2020-05-03 Thread Nicolas Fella
nicolasfella added a comment. In D29391#662471 , @broulik wrote: > Generally +1 > The `QWidget` one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful? I'll

D29021: Remove checks for notification service and fallback to KPassivePopup

2020-05-03 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R289:a5f0b1f7c812: Remove checks for notification service and fallback to KPassivePopup (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D29391: Introduce setWindow and CloseWhenWindowActivated

2020-05-03 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This is a replacement for CloseOnWidgetActivated that

D29390: Respect QIcon::fallbackSearchpaths()

2020-05-03 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY When an icon isn't found within a theme we are supposed to

D29339: Implement updating of notifications on Android

2020-05-01 Thread Nicolas Fella
nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29339 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29342: Implement support for notification urgency on Android

2020-05-01 Thread Nicolas Fella
nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29342 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29335: Implement notification grouping on Android

2020-05-01 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > vkrause wrote in NotifyByAndroid.java:171 > That seems counter-productive to me, as the Android API documentation always > speaks about API level numbers, so you'd need to do an additional translation > to/from the letters in your head. So

D29335: Implement notification grouping on Android

2020-05-01 Thread Nicolas Fella
nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Haven't tested it, but the code looks sensible INLINE COMMENTS > NotifyByAndroid.java:171 > +Notification.Builder builder; > +if (Build.VERSION.SDK_INT >= 26) {

D29021: Remove checks for notification service and fallback to KPassivePopup

2020-05-01 Thread Nicolas Fella
nicolasfella added a dependent revision: D29336: Remove galago from method/variable naming. REPOSITORY R289 KNotifications BRANCH nofallback2 REVISION DETAIL https://phabricator.kde.org/D29021 To: nicolasfella, #frameworks, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, cblack,

D29336: Remove galago from method/variable naming

2020-05-01 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY With D29021 the

D29323: Handle multi-line and rich-text notifications on Android

2020-05-01 Thread Nicolas Fella
nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29323 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26604: Check if there is an activatable service when notification service owner changes

2020-04-29 Thread Nicolas Fella
nicolasfella abandoned this revision. nicolasfella added a comment. I favor of D29021 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26604 To: nicolasfella, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, cblack,

D26605: Remove fallback to KPassivePopup

2020-04-29 Thread Nicolas Fella
nicolasfella abandoned this revision. nicolasfella added a comment. In favor of D29021 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26605 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n,

D29269: Consistently use knotify-config.h to pass in flags about Canberra/Phonon

2020-04-28 Thread Nicolas Fella
nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R305 KNotifyConfig BRANCH useconsistentlyconfigfile REVISION DETAIL https://phabricator.kde.org/D29269 To: kossebau, #frameworks, broulik, nicolasfella Cc: kde-frameworks-devel, LeGast00n,

D29079: android: include the architecture on the apk name

2020-04-28 Thread Nicolas Fella
nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D29079 To: apol, #android, #frameworks, nicolasfella Cc: vkrause, kde-frameworks-devel, kde-buildsystem,

D29021: Remove checks for notification service and fallback to KPassivePopup

2020-04-20 Thread Nicolas Fella
nicolasfella edited the summary of this revision. nicolasfella edited the test plan for this revision. nicolasfella added reviewers: Frameworks, Plasma, broulik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29021 To: nicolasfella, #frameworks, #plasma, broulik

D29021: Remove checks for notification service and fallback to KPassivePopup

2020-04-20 Thread Nicolas Fella
nicolasfella created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R289 KNotifications BRANCH nofallback2 REVISION DETAIL https://phabricator.kde.org/D29021 AFFECTED FILES

D29020: Add example/test application

2020-04-20 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80685. nicolasfella added a comment. - Add license header REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29020?vs=80684=80685 BRANCH example REVISION DETAIL https://phabricator.kde.org/D29020

D29020: Add example/test application

2020-04-20 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The purpose of this is twofold. It serves as a code

D28805: Tweak kcmcontrols docs

2020-04-20 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R296:b8accaad1eda: Tweak kcmcontrols docs (authored by nicolasfella). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28805?vs=80044=80640 REVISION DETAIL

D22701: [kfileutils] Add isExecutableFile from KRun

2020-04-20 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D22701 To: nicolasfella, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28020: New class ProcessLauncherJob in KIOGui

2020-04-18 Thread Nicolas Fella
nicolasfella added a comment. IIRC startup notification is still a big question mark in Wayland, but other Plasma devs know better REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28020 To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik Cc: jbbgameich,

Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 - Build # 10 - Still Failing!

2020-04-16 Thread Nicolas Fella
Hi, this looks like a simple prison build failure to me. However, I cannot reprocuce this with the binary factory container and the current Prison Android CI builds is blue. There is a single red Android build in the Prison CI history (https://build.kde.org/job/Frameworks/

D28851: Mark KStatusBarOfflineIndicator as deprecated

2020-04-15 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R241:cd53f10cad27: Mark KStatusBarOfflineIndicator as deprecated (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28851?vs=80190=80201 REVISION

D25705: Deprecate KIO::pixmapForUrl

2020-04-15 Thread Nicolas Fella
nicolasfella planned changes to this revision. nicolasfella added a comment. Seems like I missed some usages REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack,

D25705: Deprecate KIO::pixmapForUrl

2020-04-15 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80199. nicolasfella added a comment. - Fix update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25705?vs=80197=80199 BRANCH arcpatch-D25705_1 REVISION DETAIL https://phabricator.kde.org/D25705 AFFECTED FILES

D25705: Deprecate KIO::pixmapForUrl

2020-04-15 Thread Nicolas Fella
nicolasfella added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25705: Deprecate KIO::pixmapForUrl

2020-04-15 Thread Nicolas Fella
nicolasfella updated this revision to Diff 80197. nicolasfella added a comment. - Update REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25705?vs=72413=80197 BRANCH arcpatch-D25705_1 REVISION DETAIL https://phabricator.kde.org/D25705 AFFECTED FILES

D17805: Allow specifying multiple mimetypes as constraints

2020-04-15 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17805 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28851: Mark KStatusBarOfflineIndicator as deprecated

2020-04-15 Thread Nicolas Fella
nicolasfella added a task: T12373: Move or kill KStatusBarOfflineIndicator. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28851 To: nicolasfella, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28851: Mark KStatusBarOfflineIndicator as deprecated

2020-04-15 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Conceptually it doesn't really belong to KIO and KTorrent

D26034: Replace KLocalSocket with QLocalSocket

2020-04-15 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R241:28da79f2119e: Replace KLocalSocket with QLocalSocket (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26034?vs=71642=80188 REVISION DETAIL

D28831: Add note about porting loadMimeTypeIcon

2020-04-15 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R302:fe3f59b27dcf: Add note about porting loadMimeTypeIcon (authored by nicolasfella). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28831?vs=80128=80186 REVISION

D25443: [chmodjob] Port away from QLinkedList

2020-04-15 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e18ae3ea52dc: [chmodjob] Port away from QLinkedList (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25443?vs=80139=80187 REVISION DETAIL

  1   2   3   4   5   6   7   8   9   >