Re: Frameworks 6.0.0 is out!

On 2/28/24 14:26, Luigi Toscano wrote: Jonathan Riddell ha scritto: Frameworks 6.0.0 is out!  Congrats everyone. At the meeting yesterday we decided to keep with the 1 monthly schedule.  I'll try to nudge people into creating a release team so it's not all dependent on 1 person. David Faure:

Re: KDE Frameworks with failing CI (master) (24 December 2023)

On 12/24/23 12:22, Albert Astals Cid wrote: Please work on fixing them, otherwise i will remove the failing CI jobs on their 4th failing week, it is very important that CI is passing for multiple reasons. Bad news: 1 repository is still failing = FAILING TESTS ON WINDOWS = kwallet: (2nd week)

Re: plasma-framework

On 11/7/23 12:22, Jonathan Esk-Riddell wrote: On Sun, Nov 05, 2023 at 12:59:28PM +0100, Friedrich W. H. Kossebau wrote: kactivities and kactivities-stats: please consider proper de-KF-ication now Hi, with plasma-framework, kactivities and kactivities entering the Plasma product bundle, I

New(ish) Framework review: kstatusnotifieritem

Hi, at the last meeting we decided to extract KStatusNotifierItem from KNotifications into a separate Framework. Reasons are: - They are rather distinct in scope/concept - They negatively affect each other's dependencies I've now created https://invent.kde.org/frameworks/kstatusnotifieritem

KF6/Plasma 6 packaging notes

Hi, I'm happy that more and more distros are looking into packaging an experimental KF6/Plasma 6 session. Since there are some non-obvious things to keep in mind while doing that I started collecting some packaging notes/information in https://community.kde.org/Plasma/Plasma_6#Packaging_notes.

Porting aid place for Plasma stuff?

Hi, on several occasions we found API in Frameworks that we would like to remove, but is still used in more than one place in Plasma and it may not be feasible to port all of these usages in time for (Frameworks) 6.0. There's a few things that fall in this category that come to my mind: -

Re: These frameworks need new maintainers

Am 01.08.23 um 15:48 schrieb David Faure: In order to reflect reality, I have removed my name as maintainer for the following frameworks (in master). Don't hesitate to step up and write yours instead. kapidox karchive kcrash kdbusaddons kded kinit - but that's dead I think kio kitemmodels

Re: Remaining plasma-framework KF6 tasks

Am 09.07.23 um 12:56 schrieb Nicolas Fella: Hi, on the KF6 workboard there's a number of plasma-framework related tasks that are still open. Some of them are actionable, others probably not or need discussion. I would appreciate if someone could go over the open tasks and triage them, i.e

Remaining plasma-framework KF6 tasks

Hi, on the KF6 workboard there's a number of plasma-framework related tasks that are still open. Some of them are actionable, others probably not or need discussion. I would appreciate if someone could go over the open tasks and triage them, i.e. determine whether we consider them done, whether

Re: kio-extras and the KF5/KF6 period

Hi, Am 17.05.23 um 00:02 schrieb Albert Astals Cid: kio-extras provides plugins for kio. So KF5 applications want a KF5 kio-extras and KF6 applications want a KF6 kio- extras. This is also the case in more places, e.g. Breeze/Oxygen and plasma-integration, so having a unified approach would

Re: kf6 vs. kf5 conflict report

On 3/8/23 14:02, Harald Sitter wrote: with kf6 progressing nicely here's a first conflict report of files that appear in both kf6 and kf5 under the same name. this largely affects translations and docs it seems. this list may not be entirely comprehensive, I've only thrown together a script in a

Re: Preparation for KF6, temporary stop of scripty on trunk/l10n-kf5

Am 05.03.23 um 14:23 schrieb Luigi Toscano: Karl Ove Hufthammer ha scritto: Luigi Toscano skreiv 02.03.2023 14:24: it seems that after a bunch of fixes, the master branch of scripty was able to deal with both trunk/l10n-kf5 and trunk/l10n-kf6. As announced, now trunk/l10n-kf6 tracks the master

Splitting KGlobalAccel interface and runtime

Hi, the kglobalaccel framework currently contains two pieces: kglobalacceld, the runtime component that manages global shortcuts, and an application-side library to interact with it. The two communicate with each other via DBus. On X11 there is a standalone kglobalacceld5 process providing the

Re: Frameworks master is Qt6 now

Am 23.01.23 um 17:23 schrieb Nicolas Fella: Am 19.01.23 um 13:44 schrieb Nicolas Fella: Am 18.01.23 um 23:58 schrieb Nicolas Fella: Hi, the master branch of frameworks repositories now required Qt6 to build. Maintenance of KF5 continues in the "kf5" branch. Those using kdesrc-build

Re: portings aids in kf6?

On 1/25/23 16:56, Jonathan Riddell wrote: Can the team say which, if any, porting aids will continue in kf6? KDELibs4Support KDesignerPlugin KDEWebKit KHtml KJS KJsEmbed KMediaPlayer Kross KXmlRpcClient None of those will exist in KF6

Re: Frameworks master is Qt6 now

Am 19.01.23 um 13:44 schrieb Nicolas Fella: Am 18.01.23 um 23:58 schrieb Nicolas Fella: Hi, the master branch of frameworks repositories now required Qt6 to build. Maintenance of KF5 continues in the "kf5" branch. Those using kdesrc-build make sure your kdesrc-builrc contains &qu

Re: kquickcharts

I'd recommend you don't try to build frameworks master for the moment. Things are still in flux and some breakage is expected. I'll announce once things have settled down a bit Am 23.01.23 um 17:06 schrieb Jonathan Riddell: *What might need doing for me to compile kquickcharts master branch? *

Re: Frameworks master is Qt6 now

Am 18.01.23 um 23:58 schrieb Nicolas Fella: Hi, the master branch of frameworks repositories now required Qt6 to build. Maintenance of KF5 continues in the "kf5" branch. Those using kdesrc-build make sure your kdesrc-builrc contains "branch-group kf5-qt5", then it will s

Frameworks master is Qt6 now

Hi, the master branch of frameworks repositories now required Qt6 to build. Maintenance of KF5 continues in the "kf5" branch. Those using kdesrc-build make sure your kdesrc-builrc contains "branch-group kf5-qt5", then it will switch to the correct branch automatically. Those building manually

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

nicolasfella abandoned this revision. nicolasfella added a comment. Continuing in https://invent.kde.org/frameworks/kio/-/merge_requests/997 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: meven, dhaumann, aacid,

Re: KF 5.95-rc1 delayed

On 6/5/22 20:53, David Faure wrote: Hi everyone, I'm delaying the tagging of KF 5.95 rc1 until: - the regression in kirigami is fixed https://invent.kde.org/frameworks/kirigami/-/merge_requests/548#note_462793 - the regression in kio (trash) is fixed

Re: smart pointers

On 17/05/2022 14:34, Xaver Hugl wrote: Hello, I noticed that in KWin we use a lot of smart pointers and we mix Qt and C++ standard library ones quite a lot. Judging by a few searches in frameworks repositories, it's a similar mix there. I'd like to propose that going forwards we use C++

Re: KStars on Windows

On 09/03/2022 13:26, Nicolas Fella wrote: On 09/03/2022 08:30, Ben Cooksley wrote: Hi Jasem, Recently some changes were introduced to Frameworks which means that they now enforce more rigorously the platforms on which they build. This means that KAuth is no longer available on Windows

Re: KStars on Windows

On 09/03/2022 08:30, Ben Cooksley wrote: Hi Jasem, Recently some changes were introduced to Frameworks which means that they now enforce more rigorously the platforms on which they build. This means that KAuth is no longer available on Windows - unfortunately though it looks like KStars has a

D7700: Show list of tags in PlacesView

nicolasfella added inline comments. INLINE COMMENTS > kossebau wrote in kfileplacesitem.cpp:351 > @nicolasfella Hi. this is passing the tag string both as translation context > as well as the string to translate as well. Is this on purpose? Even more as > the context parameter is ignored

Re: Gitlab CI - Inbound

On 05.09.21 08:13, Ben Cooksley wrote: Hi all, This morning after much work i'm happy to announce that the new generation CI scripts intended for use with Gitlab CI successfully completed their first build (of ECM, and then subsequently of KCoreAddons). This begins our first steps towards

Re: KService as a platform abstraction framework?

On 03.07.21 10:25, Volker Krause wrote: Hi, while looking at implementing a pretty straightforward KApplicationTrader/ KIO::ApplicationLauncherJob use ([1]) for Android, I found myself wondering whether we should have an Android backend for KService. KService conceptually matches

T14621: [RFC] Consider deprecating PlasmaExtras.PlasmoidHeading in favor of PC3.ToolBar

nicolasfella removed a project: KF6. TASK DETAIL https://phabricator.kde.org/T14621 To: nicolasfella Cc: nicolasfella, niccolove, mart, kde-frameworks-devel, mikeljohnson, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf,

T14621: [RFC] Consider deprecating PlasmaExtras.PlasmoidHeading in favor of PC3.ToolBar

nicolasfella added a comment. I'm not sure this makes sense on a semantic level. The current PlasmoidHeading happens to be very similar to a toolbar, but is that always going to be the case? I don't want us to be locked into a situation where we can't change things later on because they

Re: dark theme on windows in KF 5.83

On 17.06.21 10:18, Alexander Semke wrote: Hi, with the last nighly build for LabPlot we observed a big regression on Windows. Attached are two files. The first one is based on KF 5.82, the second one on 5.83. In both cases the default color scheme is used in LabPlot which is Window's dark theme

Re: Notice of withdrawal of CI services: KDevelop and KDE Connect

Hi Ben, On 16.06.21 20:28, Ben Cooksley wrote: Hi all, The following is notice that I intend to withdraw CI services from the following two KDE projects due to faults in their code or build system which are having a significant adverse impact on the CI system and negatively impacting on other

Respin request for qqc2-desktop-style

Hi David, can we please get a respin for the qqc2-desktop-style tarball with https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/73 inside? Cheers Nico

T14471: Make Qt 5.15.0 to 5.15.2 for frameworks

nicolasfella added a comment. Do we actually *want* to use the API that has been introduced in production? From QStringView:: toInt: Note: This method has been added in 5.15.2 to simplify writing code that is portable between Qt 5.15 and Qt 6. The implementation is not tuned for

Re: KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.15 - Build # 58 - Still Unstable!

Hi David, this should be fixed with https://invent.kde.org/frameworks/ki18n/-/merge_requests/15 Cheers Nico On 1 May 2021 11:20:31 CEST, David Faure wrote: >Hi Nicolas, > >It looks like the ki18n commit > >Backport FindIntl.cmake from CMake 3.20 > >might have broken the lookup of

Re: KGlobalAccel on non-Plasma systems

set to KDE, so it is safe in that regard. On Tue, 2021-04-06 at 17:29 +0200, Nicolas Fella wrote: Hi, we received a few reports [1] [2] from people using non-Plasma systems that the kglobalaccel5 process was started, leading to clashes with the native global shortcut system. This seems to happen

KGlobalAccel on non-Plasma systems

Hi, we received a few reports [1] [2] from people using non-Plasma systems that the kglobalaccel5 process was started, leading to clashes with the native global shortcut system. This seems to happen when apps call some API of KGlobalAccel which results in the kglobalaccel5 process to be

D26449: [PoC] Port to KRecentFileMenu

nicolasfella abandoned this revision. nicolasfella added a comment. https://invent.kde.org/utilities/ark/-/merge_requests/39 REPOSITORY R36 Ark REVISION DETAIL https://phabricator.kde.org/D26449 To: nicolasfella, #ark, #frameworks Cc: meven, mlaurent, kde-utils-devel, fbampaloukas,

Re: KDE review for KWeatherCore

On 12/21/20 3:19 PM, Friedrich W. H. Kossebau wrote: Am Montag, 21. Dezember 2020, 07:16:09 CET schrieb hanyoung: KWeatherCore: https://invent.kde.org/libraries/kweathercore is a library for querying weather forecast data. During the development of KWeather, we found the need to have a

D22544: [RFC] Deprecate KPassivePopup

nicolasfella abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22544 To: nicolasfella, #frameworks, broulik Cc: ngraham, davidedmundson, aspotashev, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D22093: Don't show progress window for jobs that don't report progress

nicolasfella abandoned this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D22093 To: nicolasfella, apol, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D23835: Add TabKCM

nicolasfella abandoned this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D23835 To: nicolasfella, mart Cc: broulik, onvitaik, zzag, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

Re: Would distributions have an issue if KF 5.77+ would require Qt >= 5.14 (instead of >= 5.13 as of now)?

Hi, with my KDE Android hat on this would be fine, we use Qt 5.15. For KDE's own Windows/Mac builds I'd expect it to be similar. What most/all not-traditional-Linux-distro users have in common is that they are not bound to the specific Qt version decided and shipped by a vendor and instead

PSA: Frameworks depends on Qt 5.13 now

Hi, per our Qt dependency policy [0] Frameworks depends on Qt 5.13 6 months after the release of Qt 5.15, which is now. Have fun with the new stuff. Nico [0] https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements

D24443: Add a plugin system

nicolasfella abandoned this revision. nicolasfella added a comment. Moving to invent: https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/20 REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D24443 To: nicolasfella, #frameworks, #plasma, #kde_pim

D28834: Add metadata properties to calendar

nicolasfella abandoned this revision. nicolasfella added a comment. moving to invent: https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/19 REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause,

D29020: Add example/test application

nicolasfella abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29020 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29391 To: nicolasfella, #frameworks, broulik Cc: anthonyfieroni, kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Stepping down as KRunner maintainer

Thanks for all your work Kai and congratulations Alexander, this is well deserved! Cheers Nico On 08.10.20 19:17, Kai Uwe Broulik wrote: Hi everyone, you might not even have known this but officially I have been KRunner's maintainer for several years at this point :-) However, I have

D25705: Deprecate KIO::pixmapForUrl

nicolasfella abandoned this revision. nicolasfella added a comment. Moved to https://invent.kde.org/frameworks/kio/-/merge_requests/144 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25705 To: nicolasfella, #frameworks, dfaure Cc: kossebau, apol, kde-frameworks-devel,

T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

nicolasfella added a subtask: T13555: Create replacement for KPluginInfo::kcmServices. TASK DETAIL https://phabricator.kde.org/T12173 To: nicolasfella Cc: #frameworks, nicolasfella, dfaure, mart, davidre, GB_2, ekasprzak, ahmadsamir, ngraham, kpiwowarski, usta, asturmlechner, jucato, cfeck,

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella closed this revision. REVISION DETAIL https://phabricator.kde.org/D26448 To: nicolasfella, #frameworks, dfaure Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella updated this revision to Diff 83348. nicolasfella added a comment. - Use menus font metric CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=83346=83348 BRANCH recentfilemenu REVISION DETAIL https://phabricator.kde.org/D26448 AFFECTED FILES

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella updated this revision to Diff 83346. nicolasfella added a comment. - Use widgets font metrics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=83338=83346 BRANCH recentfilemenu REVISION DETAIL https://phabricator.kde.org/D26448 AFFECTED FILES

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella marked an inline comment as done. nicolasfella added inline comments. INLINE COMMENTS > dfaure wrote in krecentfilesmenu.cpp:150 > Depending on QtConcurrent is just fine. However QtConcurrent::filtered is for > CPU-intensive operations, not for I/O operations. 1) you don't want to

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella updated this revision to Diff 83338. nicolasfella marked an inline comment as done. nicolasfella added a comment. - Fix @since - Add underscore to filename - Reserve vector CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26448?vs=83337=83338 BRANCH recentfilemenu

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella marked 6 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D26448 To: nicolasfella, #frameworks, dfaure Cc: broulik, elvisangelaccio, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella updated this revision to Diff 83337. nicolasfella marked an inline comment as done. nicolasfella added a comment. - Make findEntry return non-const iterator - Use std::vector - Truncate entries when setting maximum CHANGES SINCE LAST UPDATE

D26448: Add KRecentFilesMenu to replace KRecentFileAction

nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in krecentfilesmenu.cpp:150 > If we're rewriting this thing anyway, can we please make sure it does not > block application startup checking if those files exist, as can happen if you > had opened files on an NFS mount before.

Frameworks support for Qt 5.12

Hi, I received a question on how long KF5 will continue to support Qt 5.12. Given that 5.12 is an LTS release according to our policy it would be supported "until the next Qt release after the next Qt release", which would be 5.16, which will never exist. Our policy states "With Qt6 this

D29020: Add example/test application

nicolasfella added a comment. Ping? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29020 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26918: Improve KNotification API docs

nicolasfella updated this revision to Diff 83322. nicolasfella marked 8 inline comments as done. nicolasfella added a comment. - Address comments CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26918?vs=78423=83322 BRANCH arcpatch-D26918 REVISION DETAIL

D29390: Respect QIcon::fallbackSearchpaths()

nicolasfella closed this revision. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29390 To: nicolasfella, #plasma, #frameworks, mart Cc: mart, kossebau, aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29358: Implement lock-screen visibility control on Android

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25551: Mark KXmlRpcClient as porting aid

nicolasfella closed this revision. REPOSITORY R312 KXmlRpcClient REVISION DETAIL https://phabricator.kde.org/D25551 To: nicolasfella, #frameworks, dvratil Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29358: Implement lock-screen visibility control on Android

nicolasfella requested changes to this revision. nicolasfella added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > notifybyandroid.cpp:110 > n.setField("urgency", (jint)(notification->urgency() == > KNotification::DefaultUrgency ?

D29358: Implement lock-screen visibility control on Android

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29358 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29420: Generate DBus interface

nicolasfella closed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29420 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella edited the test plan for this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29391 To: nicolasfella, #frameworks, broulik Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella updated this revision to Diff 83051. nicolasfella added a comment. - Address APIdocs issues - Remove timer REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29391?vs=81822=83051 BRANCH closewin REVISION DETAIL

D24025: Don't use KCrash on Android

nicolasfella abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: vkrause, apol, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22868: Revamp Kirigami.AboutPage

nicolasfella added a comment. can this be closed? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D22868 To: hein, #frameworks, #vdg, mart, apol, ngraham, leinir, nicolasfella Cc: nicolasfella, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol,

D25551: Mark KXmlRpcClient as porting aid

nicolasfella added a comment. ping? Only kblog is using it, but according to T12157 that is supposed to go away too REPOSITORY R312 KXmlRpcClient REVISION DETAIL https://phabricator.kde.org/D25551 To: nicolasfella, #frameworks, dvratil Cc:

D23968: Use app specific location for DB on Android

nicolasfella abandoned this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D23968 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28312: Implement urls using hints

nicolasfella closed this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D28312 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29802: Require out-of-source builds

nicolasfella accepted this revision. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella Cc: ltoscano, davidre, kde-frameworks-devel,

D29390: Respect QIcon::fallbackSearchpaths()

nicolasfella updated this revision to Diff 82600. nicolasfella added a comment. - Use array REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29390?vs=81821=82600 BRANCH fallback REVISION DETAIL https://phabricator.kde.org/D29390 AFFECTED FILES

D29390: Respect QIcon::fallbackSearchpaths()

nicolasfella added inline comments. INLINE COMMENTS > aacid wrote in kiconloader.cpp:1142 > I just realized that function is private, not really easy to use :/ > > anyhow do you think we should remove svgz? > > Also i think using > > const QStringList extensions = { QStringLiteral(".png"), >

D29631: [android] Allow specifying APK install location

This revision was automatically updated to reflect the committed changes. Closed by commit R240:a70e9a0162f7: [android] Allow specifying APK install location (authored by nicolasfella). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D29631: [android] Allow specifying APK install location

nicolasfella updated this revision to Diff 82531. nicolasfella added a comment. - Rename variable REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29631?vs=82527=82531 BRANCH androinstall REVISION DETAIL https://phabricator.kde.org/D29631

D29631: [android] Allow specifying APK install location

nicolasfella marked 2 inline comments as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29631 To: nicolasfella, #frameworks, #android, apol, vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns

D29631: [android] Allow specifying APK install location

nicolasfella added a comment. This is used in https://invent.kde.org/sysadmin/ci-tooling/-/merge_requests/68 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29631 To: nicolasfella, #frameworks, #android, apol, vkrause Cc: kde-frameworks-devel,

D29631: [android] Allow specifying APK install location

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, Android, apol, vkrause. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This allows

D29420: Generate DBus interface

nicolasfella updated this revision to Diff 82237. nicolasfella added a comment. - Use q as parent - Change reply type - Use ranged-for REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29420?vs=81920=82237 BRANCH geninterface REVISION DETAIL

D29420: Generate DBus interface

nicolasfella marked 3 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29420 To: nicolasfella, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29420: Generate DBus interface

nicolasfella added inline comments. INLINE COMMENTS > broulik wrote in notifybypopup.cpp:115 > Previously it would accept the signal from any service which I find odd, > though. Could you maybe check git logs to see if there was a reason for this? > It should survive restarts anyway and the

D29420: Generate DBus interface

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY We already use a generated interface in

D29336: Remove galago from method/variable naming

This revision was automatically updated to reflect the committed changes. Closed by commit R289:2012f675aed2: Remove galago from method/variable naming (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29336?vs=81680=81892

D29405: [PoC] Make notifications work without a notifyrc file

nicolasfella added a comment. In D29405#662963 , @apol wrote: > Won't this make it harder to put together the notifications kcm? Good point, we use the notifyrc file to know which apps send notifications ahead of time. Maybe we need

D29405: [PoC] Make notifications work without a notifyrc file

nicolasfella added a comment. We want to phase out notifyrc files for several reasons: - They are an overkill for many simple use cases - A common pitfall when using KNotifications are missing or incorrect notifyrc files - Most of the information in there is duplicate/overridden at

D29405: [PoC] Make notifications work without a notifyrc file

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY In KNotificationManager when reading the actions

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella added a comment. In D29391#662471 , @broulik wrote: > The `QWidget` one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful? lol, turns out that

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella added a comment. In D29391#662471 , @broulik wrote: > Generally +1 > The `QWidget` one has some additional features, like closing the notification when the window is destroyed (cf. its docs), which would be useful? I'll

D29021: Remove checks for notification service and fallback to KPassivePopup

This revision was automatically updated to reflect the committed changes. Closed by commit R289:a5f0b1f7c812: Remove checks for notification service and fallback to KPassivePopup (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D29391: Introduce setWindow and CloseWhenWindowActivated

nicolasfella created this revision. nicolasfella added reviewers: Frameworks, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This is a replacement for CloseOnWidgetActivated that

D29390: Respect QIcon::fallbackSearchpaths()

nicolasfella created this revision. nicolasfella added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY When an icon isn't found within a theme we are supposed to

D29339: Implement updating of notifications on Android

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29339 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29342: Implement support for notification urgency on Android

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D29342 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29335: Implement notification grouping on Android

nicolasfella added inline comments. INLINE COMMENTS > vkrause wrote in NotifyByAndroid.java:171 > That seems counter-productive to me, as the Android API documentation always > speaks about API level numbers, so you'd need to do an additional translation > to/from the letters in your head. So

D29335: Implement notification grouping on Android

nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Haven't tested it, but the code looks sensible INLINE COMMENTS > NotifyByAndroid.java:171 > +Notification.Builder builder; > +if (Build.VERSION.SDK_INT >= 26) {

D29021: Remove checks for notification service and fallback to KPassivePopup

nicolasfella added a dependent revision: D29336: Remove galago from method/variable naming. REPOSITORY R289 KNotifications BRANCH nofallback2 REVISION DETAIL https://phabricator.kde.org/D29021 To: nicolasfella, #frameworks, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, cblack,

  1   2   3   4   5   6   7   8   9   >