Re: How is that border color defined? (system color schemes)

[Noah Davis]

KColorUtils::mix( palette.color( QPalette::Window ), palette.color(
QPalette::WindowText ), 0.25 )

On Tue, Oct 13, 2020 at 2:25 PM chiasa.men  wrote:
>
> https://pasteboard.co/JvupDV3.png
>
> Per trial and error I assumed the line (border of list view (vertical right
> under the cursor)) color: #bcbebf is defined by a combination of Window Text
> and Window Background (at least it changes if one of the colors is changed) -
> but how is it determined exactly?
>
>
>
>
>

D27223: add kirigami-gallery icon

[Noah Davis]

ndavis abandoned this revision.
ndavis added a comment.


  I've committed the icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: ndavis, mart, #vdg, ngraham, mbruchert
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D27223: add kirigami-gallery icon

[Noah Davis]

ndavis commandeered this revision.
ndavis edited reviewers, added: mbruchert; removed: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: ndavis, mart, #vdg, ngraham, mbruchert
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D27223: add kirigami-gallery icon

[Noah Davis]

ndavis added a comment.


  I think I'd prefer to keep this similar to the original Kirigami icon. Do you 
mind if I commandeer this? I've already made the changes.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis, ngraham
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D27223: add kirigami-gallery icon

[Noah Davis]

ndavis added a comment.


  I noticed that the lighting in this version of the Kirigami is flipped. Is 
that intentional? I don't think it makes sense for the top of the K popout to 
be darker than the bottom. Since the light in Breeze icons comes from the top 
left, the top should be light, like in the original Kirigami icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis, ngraham
Cc: ngraham, ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D19952: Added 2 icons (1 16px and 1 22px) named "input-num-on" that shows a num-lock key

[Noah Davis]

ndavis abandoned this revision.
ndavis added a comment.


  will move to invent.kde.org

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19952

To: ndavis, #vdg, arvidhansson
Cc: ngraham, t-ask, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D17253: Fix colors for vector image mimetypes

[Noah Davis]

ndavis abandoned this revision.
ndavis added a comment.


  will move to invent.kde.org

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17253

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a comment.


  How would we add the separator role to color scheme files if separator color 
was added to upstream Qt? Wouldn't we still need to add a separator role to 
KColorScheme so that we could map the color in the color scheme file to the 
equivalent QPalette ColorRole?

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: ahiemstra, broulik, manueljlin, alexde, ngraham, davidedmundson, filipf, 
cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29232: Introduce the Header color set

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  arcpatch-D29232

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack, ndavis
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29232: [WIP][RFC]Introduce the Header color set

[Noah Davis]

ndavis added a comment.


  Suggested colors are based on 
https://invent.kde.org/plasma/breeze/-/merge_requests/2

INLINE COMMENTS

> kcolorscheme.cpp:258
> +static const SetDefaultColors defaultHeaderColors = {
> +{  49,  54,  59 }, // Background
> +{  59,  64,  69 }, // Alternate

` 227, 229, 231 `

> kcolorscheme.cpp:259
> +{  49,  54,  59 }, // Background
> +{  59,  64,  69 }, // Alternate
> +{ 239, 240, 241 }, // Normal

` 239, 240, 241 `

> kcolorscheme.cpp:260
> +{  59,  64,  69 }, // Alternate
> +{ 239, 240, 241 }, // Normal
> +{ 175, 176, 179 }, // Inactive

`  35,  38,  41 `

> kcolorscheme.cpp:261
> +{ 239, 240, 241 }, // Normal
> +{ 175, 176, 179 }, // Inactive
> +{ 147, 206, 233 }, // Active

` 112, 125, 138 `

> kcolorscheme.cpp:262
> +{ 175, 176, 179 }, // Inactive
> +{ 147, 206, 233 }, // Active
> +{  61, 174, 230 }, // Link

`  61, 174, 233 `

> kcolorscheme.cpp:263
> +{ 147, 206, 233 }, // Active
> +{  61, 174, 230 }, // Link
> +{  61, 174, 230 }, // Visited

`  41, 128, 185 `

> kcolorscheme.cpp:264
> +{  61, 174, 230 }, // Link
> +{  61, 174, 230 }, // Visited
> +{ 231,  76,  60 }, // Negative

` 155,  89, 182 `

> kcolorscheme.cpp:265
> +{  61, 174, 230 }, // Visited
> +{ 231,  76,  60 }, // Negative
> +{ 253, 188,  75 }, // Neutral

` 218,  68,  83 `

> kcolorscheme.cpp:266
> +{ 231,  76,  60 }, // Negative
> +{ 253, 188,  75 }, // Neutral
> +{  46, 174, 230 }  // Positive

` 246, 116,   0 `

> kcolorscheme.cpp:267
> +{ 253, 188,  75 }, // Neutral
> +{  46, 174, 230 }  // Positive
> +};

`  39, 174,  96 `

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29095: Change mouse icon to have better dark theme contrast

[Noah Davis]

ndavis closed this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: ndavis, #vdg, saligari, ngraham
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D24975: Change some 32px action icons to color style

[Noah Davis]

ndavis abandoned this revision.
ndavis added a comment.


  Saving this for later on invent.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24975

To: ndavis, #vdg, ngraham
Cc: ngraham, mglb, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis abandoned this revision.
ndavis added a comment.


  Abandoning this since others would rather have this in QPalette

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: ahiemstra, broulik, manueljlin, alexde, ngraham, davidedmundson, filipf, 
cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29802: Require out-of-source builds

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  require-in-source-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29802

To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella, ndavis
Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

D29739: Add 48px places icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  48px-places (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29739: Add 48px places icons

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I have to say, I'm very impressed overall. There are a few things I'd like to 
see changed though:
  
  folder-documents should use a single page, not the copy icon F8320517: 
Screenshot_20200514_153157.png  I suppose 
they should all have the corner at the top right, but that can be done another 
time.
  
  folder-network is using a different style F8320527: 
Screenshot_20200514_153705.png 
  
  folder-scripts is using a different style F8320536: 
Screenshot_20200514_154402.png 
  
  panel elements in user-desktop should be more like the 32px version F8320540: 
Screenshot_20200514_154711.png  The 64px 
version should be changed too, but that can be done another time.
  
  Other observations (not required, just documenting them so they aren't 
forgotten)
  
=
  
  folder-games inner symbol looks a bit small, but that's going to be extra 
work, so I won't fault you if you'd rather do that later. The 16px version that 
you reused for the 48px symbol is a bit too small at 16px anyway, so that can 
be done another time.
  F8320524: Screenshot_20200514_153422.png 

  
  Interestingly, document-print uses a different style for the smallest printer 
icon size. I think I prefer the document-print version, but that change can be 
done another time.
  F8320530: Screenshot_20200514_153936.png 
 F8320532: Screenshot_20200514_154148.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg, ngraham, ndavis
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29740: [PC3 Button] Don't remain in a pressed state after press

[Noah Davis]

ndavis added a comment.


  In D29740#671221 , @filipf wrote:
  
  > The more I think about this the more it feels like a workaround. Presuming 
QQC2's behavior of leaving a pressed button focused after press is correct, 
perhaps we are at fault for providing the same svg for `focus-background` and 
`pressed`.
  
  
  That was one of the issues I was trying to fix while working on a new style 
for buttons in the QStyle.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dont-remain-pressed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29740

To: filipf, davidedmundson, mart, #plasma, ngraham
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29739: Add 48px places icons

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> index.theme:477
>  
>  #32x32 - Scalable - For folder icons >!!!ONLY!!!< - Scalable to the 
> following sizes: 64x64 (default), 32x32, 128x128, 256x256 - 
> DO_NOT_USE_ANYWHERE_ELSE - Color
>  [places/32]

This and the other comments should probably be changed, but I don't actually 
understand the original purpose anyway.

> index.theme:493
>  Context=Places
> -Type=Scalable
> -MinSize=32
> -MaxSize=256
> +Type=Fixed
>  

This should be put back the way it was since phabricator mislead you.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29739: Add 48px places icons

[Noah Davis]

ndavis added a comment.


  In D29739#671163 , @manueljlin 
wrote:
  
  > should line 495 "## Status" actually be removed?
  
  
  No. Phabricator doesn't keep the original context for those comments if you 
change the code they were referring to. I think GitLab doesn't have that 
problem.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29739: Add 48px places icons

[Noah Davis]

ndavis added a comment.


  I just noticed, the new auto-generated 24px places icons aren't being used 
because the places/24 folder isn't in the index.theme files, but that's outside 
the scope of this patch.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29739: Add 48px places icons

[Noah Davis]

ndavis added a comment.


  comments apply to both files

INLINE COMMENTS

> index.theme:105
>  
>  
> Directories=actions/12,actions/16,actions/22,actions/24,actions/32,actions/64,animations/16,animations/22,apps/16,apps/22,apps/32,apps/48,preferences/32,applets/22,applets/48,applets/64,applets/128,applets/256,categories/32,devices/16,devices/22,devices/64,emblems/8,emblems/16,emblems/22,emotes/22,mimetypes/16,mimetypes/22,mimetypes/32,mimetypes/64,places/16,places/22,places/32,places/64,status/16,status/22,status/24,status/32,status/64,actions/symbolic,devices/symbolic,emblems/symbolic,places/symbolic,status/symbolic
>  
> ScaledDirectories=actions/16@2x,actions/22@2x,actions/24@2x,actions/32@2x,animations/16@2x,apps/16@2x,apps/22@2x,devices/16@2x,devices/22@2x,emblems/16@2x,emblems/22@2x,emotes/22@2x,mimetypes/16@2x,mimetypes/22@2x,places/16@2x,places/22@2x,status/16@2x,status/22@2x

You also need to add the new folder here

> index.theme:481
>  Context=Places
>  Type=Scalable
>  MinSize=24

This should be changed to Fixed

> index.theme:482
>  Type=Scalable
>  MinSize=24
>  MaxSize=48

Delete

> index.theme:483
>  MinSize=24
>  MaxSize=48
>  

Delete

> index.theme:489
> +Context=Places
> +Type=Scalable
> +MinSize=32

Scalable -> Fixed

> index.theme:490
> +Type=Scalable
> +MinSize=32
> +MaxSize=256

Delete

> index.theme:491
> +MinSize=32
> +MaxSize=256
> +

Delete

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29739: Add 48px places icons

[Noah Davis]

ndavis added a comment.


  You'll also need to update the index.theme files to include places/48

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29739

To: manueljlin, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29534: Implement scroll and drag adjustment of values for SpinBox control

[Noah Davis]

ndavis added a comment.


  I don't like the look of those +/- buttons. I think this makes it harder to 
know that you can drag the height up and down.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

[Noah Davis]

ndavis added a comment.


  I generally prefer type 1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: ndavis, filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  use-standard-show-hide-files-shortcuts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29238

To: ngraham, #plasma, #frameworks, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a comment.


  OK, I can agree with contributing upstream. I'll try talking on that bug 
report.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: ahiemstra, broulik, manueljlin, alexde, ngraham, davidedmundson, filipf, 
cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29434: Use small font for ExpandableListItem subtitle

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ExpandableListItem-small-subtitle-font (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29434

To: ngraham, #plasma, #vdg, broulik, ndavis
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

[Noah Davis]

ndavis added a comment.


  In D25814#598380 , @cfeck wrote:
  
  > > Why don't focus and hover colors belong?
  >
  > Because an application cannot know if and how a style does indicate focus 
or hovering.
  
  
  I don't understand this objection. What would allow an application to know 
about the button background from the QStyle? It could be a PNG, and yet setting 
the button background color is perfectly fine.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: broulik, manueljlin, alexde, ngraham, davidedmundson, filipf, cfeck, 
hpereiradacosta, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29232: [WIP][RFC]Introduce the Header color set

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> davidre wrote in kcolorscheme.cpp:271
> I would have expected at least of one the new colors to have the same value 
> as this one.

Why is that? The only one that might is Active, but that's not really used much 
right now.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: davidre, ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns

D29095: Change mouse icon to have better dark theme contrast

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: ndavis, #vdg, saligari
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29095: Change mouse icon to have better dark theme contrast

[Noah Davis]

ndavis updated this revision to Diff 81374.
ndavis added a comment.


  - Change kmousetool and preferences-desktop-mouse to symlinks

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29095?vs=81211=81374

BRANCH
  arcpatch-D29095

REVISION DETAIL
  https://phabricator.kde.org/D29095

AFFECTED FILES
  icons-dark/apps/48/kmousetool.svg
  icons-dark/devices/64/input-mouse.svg
  icons-dark/preferences/32/preferences-desktop-mouse.svg
  icons/apps/48/kmousetool.svg
  icons/devices/64/input-mouse.svg
  icons/preferences/32/preferences-desktop-mouse.svg

To: ndavis, #vdg, saligari
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29095: Change mouse icon to have better dark theme contrast

[Noah Davis]

ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: ndavis, #vdg, saligari
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29232: [WIP][RFC]Introduce the Tools color set

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> kcolorscheme.h:133
>   * Number of color sets.
> + * Note: don't use this
>   * @since 5.65

I think it would be good to explain the issue about enums being converted into 
plain integers here so that people know why they shouldn't depend on it. Also, 
is there a way to hide this from the api.kde.org page for kcolorscheme?

REPOSITORY
  R265 KConfigWidgets

BRANCH
  phab/toolsSet

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29232: [WIP][RFC]Introduce the Tools color set

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> kcolorscheme.h:127
> +/**
> + * Colors for header areas that thould be used both by the top 
> toolbar and the titlebar titlebar.
> + * @since 5.69

- `thould`
- `titlebar titlebar`

REPOSITORY
  R265 KConfigWidgets

BRANCH
  phab/toolsSet

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29232: [WIP][RFC]Introduce the Tools color set

[Noah Davis]

ndavis added a comment.


  I personally think it should be Header since Tools sound ambiguous and oddly 
limited to anyone unfamiliar with the context behind this patch

REPOSITORY
  R265 KConfigWidgets

BRANCH
  phab/toolsSet

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29095: Change mouse icon to have better dark theme contrast

[Noah Davis]

ndavis retitled this revision from "Change mouse icon to have better dark theme 
contrast." to "Change mouse icon to have better dark theme contrast".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: ndavis, #vdg, saligari
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29095: Change mouse icon to have better dark theme contrast.

[Noah Davis]

ndavis updated this revision to Diff 81211.
ndavis added a comment.


  - Change style

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29095?vs=81156=81211

BRANCH
  arcpatch-D29095

REVISION DETAIL
  https://phabricator.kde.org/D29095

AFFECTED FILES
  icons-dark/devices/64/input-mouse.svg
  icons-dark/preferences/32/preferences-desktop-mouse.svg
  icons/devices/64/input-mouse.svg
  icons/preferences/32/preferences-desktop-mouse.svg

To: ndavis, #vdg, saligari
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29095: Change mouse icon to have better dark theme contrast.

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: ndavis, #vdg, saligari
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29095: Change mouse icon to have better dark theme contrast.

[Noah Davis]

ndavis retitled this revision from "New much simpler mouse icon that works in 
both light and dark breeze" to "Change mouse icon to have better dark theme 
contrast.".
ndavis edited the summary of this revision.
ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: ndavis, #vdg, saligari
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29095: New much simpler mouse icon that works in both light and dark breeze

[Noah Davis]

ndavis commandeered this revision.
ndavis added a reviewer: saligari.
ndavis added a comment.


  Saligari is Ok with me taking over this patch.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: ndavis, #vdg, saligari
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29095: New much simpler mouse icon that works in both light and dark breeze

[Noah Davis]

ndavis added a comment.


  In D29095#656819 , @saligari wrote:
  
  > Oh the shame! I had forgotten to center it (and I do know how to)!
  >
  > One thing I don't know is: since I centered it and used the guidelines my 
1px line centered sits on a 0,5 to 0,5 line. I don't know if that's bad or how 
to change it.
  
  
  That means you need to widen it to 2px. It's between pixels, so it's 2px 
thick when you look at it at the normal size anyway. F8260081: 
Screenshot_20200425_133013.png F8260078: 
Screenshot_20200425_133033.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29171: Add 16px konversation icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  konversation16px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29171

To: manueljlin, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29095: New much simpler mouse icon that works in both light and dark breeze

[Noah Davis]

ndavis added a comment.


  It's a bit off center and I'd prefer if lines were more aligned with pixels. 
That way the icon doesn't change in how it looks when you scale it up. You may 
need to lighten the colors of your lines to maintain the original appearance.
  
  You see what I'm seeing? Do you know how to enable a grid with 1px spacing? 
F8258844: Screenshot_20200424_223530.png 
  
  This has some tips: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips
  
  Do check out the Inkscape manual as well. It's actually useful and not very 
difficult to read through.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh

D29072: Optimize SVG

[Noah Davis]

ndavis added a comment.


  In D29072#654363 , @guoyunhe wrote:
  
  > I do try scour but the result is disappointing. I get 16 times the 
following error:
  >
  >   hge difference of 123 in ./icons-dark/apps/48/hwinfo.svg
  >
  >
  > which means 16 icons are unacceptable after scour optimization
  
  
  That's not true. Huge difference means you should make sure you know what the 
difference is, but most of the time it's perfectly fine.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D27252: add maui index icon in pm style

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> ndavis wrote in index.svg:35
> This one can't be seen, so get rid of it.

Just realized this comment could be easily mistaken for me saying to get rid of 
the shadow because of how the phabricator UI looks. I'm talking about a blue 
rectangle.

REPOSITORY
  R266 Breeze Icons

BRANCH
  index (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27252

To: mbruchert, camiloh, #vdg, ndavis
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D27252: add maui index icon in pm style

[Noah Davis]

ndavis added a comment.


  @cblack is right, breeze icons tend to be sharper, but there's no rule 
requiring sharpness and I've accepted similar icons recently (maybe I should 
edit those a bit, but they're still good). However, I'm not sure how we'll 
differentiate this from Dolphin if we make the corners sharper. For now, remove 
the dark blue bit in the top right.

INLINE COMMENTS

> index.svg:29
> +  
> +   y1="10.5268" y2="15" gradientTransform="translate(-391.5697,-499.8)" 
> gradientUnits="userSpaceOnUse">
> +   

The shadow gradient here got moved way out of place: F8257499: 
Screenshot_20200424_074454.png 

That happens sometimes when you use SVG cleaner.

> index.svg:35
> + 
> +  
> +  

This one can't be seen, so get rid of it.

REPOSITORY
  R266 Breeze Icons

BRANCH
  index (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27252

To: mbruchert, camiloh, #vdg, ndavis
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29095: New much simpler mouse icon that works in both light and dark breeze

[Noah Davis]

ndavis added a comment.


  Yes, I agree that the mouse should have fairly realistic and modern 
proportions. My favorite icons in Breeze are the ones that look pretty 
realistic while still maintaining the soft gradients and shadows.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
michaelh, bruns

D29098: Removed kde logo from sd and memory stick (/devices/64)

[Noah Davis]

ndavis added a comment.


  yes, I agree with @ngraham

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29098

To: saligari, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29095: New much simpler mouse icon that works in both light and dark breeze

[Noah Davis]

ndavis added a comment.


  Regarding SVG optimization, the main point of it these days is to make the 
code easier to read, not to get the smallest size possible. Use the settings on 
this page for your SVG optimizer: 
https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29095

To: saligari, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29072: Optimize SVG

[Noah Davis]

ndavis added a comment.


  The Scour settings I recommend are `--set-precision=8 --enable-viewboxing 
--enable-comment-stripping --remove-descriptive-elements --create-groups 
--strip-xml-space --strip-xml-prolog --nindent=4`

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29070: add alligator icon

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  alligator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29070

To: mbruchert, tfella, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29072: Optimize SVG

[Noah Davis]

ndavis added a comment.


  If we're going to actually use the optimization script, we should use `scour` 
instead of SVGO. Scour is the SVG optimizer that is least likely to screw up 
and SVG. These days, the purpose of SVG optimization is to make the code 
readable.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29072: Optimize SVG

[Noah Davis]

ndavis added a comment.


  > You can check pixel diff in Git Cola.
  
  How do I do this? I was not aware of that feature.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29072

To: guoyunhe, #breeze, ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29032: Add 16px Vvave icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  vvave16px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29032

To: manueljlin, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29049: add telephant icon

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  telephant (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29049

To: mbruchert, muesli, #vdg, ndavis
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29069: Falkon icon - Removing circle & adding outline

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I don't think this is necessary.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29069

To: saligari, #vdg, abetts, #falkon, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29032: Add 16px Vvave icon

[Noah Davis]

ndavis added a comment.


  There is already a newer vvave icon with a different style, but not at 16px.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29032

To: manueljlin, #vdg
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29027: Move document corner fold to top right in two icons

[Noah Davis]

ndavis accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  update-document-close

REVISION DETAIL
  https://phabricator.kde.org/D29027

To: davidhurka, ndavis, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

[Noah Davis]

ndavis added a comment.


  I'm sorry this happened. I was working with what I could see. For what it's 
worth, I would have accepted it if you said it could not be done well. I know I 
don't know as much about the technical side of this as you do.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27540

To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik
Cc: abetts, bam, GB_2, alexde, ndavis, iasensio, davidre, kde-frameworks-devel, 
LeGast00n, cblack, michaelh, ngraham, bruns

D27220: add pix icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  pix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27220

To: mbruchert, camiloh, #vdg, ndavis
Cc: ngraham, IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
bruns

D28923: Update links in README.md

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:e5dfa14b64a6: Update links in README.md (authored by 
ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28923?vs=80414=80423

REVISION DETAIL
  https://phabricator.kde.org/D28923

AFFECTED FILES
  README.md

To: ndavis, #vdg, ngraham
Cc: alex-l, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28923: Update links in README.md

[Noah Davis]

ndavis added a subscriber: alex-l.
ndavis added inline comments.

INLINE COMMENTS

> ngraham wrote in README.md:22
> Should we mention this? Is it still a thing?

It hasn't been used much for quite a while, but I don't think @alex-l would 
like it if we didn't include it. I'm in there, so at least anyone who joins 
won't be completely alone.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28923

To: ndavis, #vdg
Cc: alex-l, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28923: Update links in README.md

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  - Change the HIG link to hig.kde.org
  - Changed the bugtracker link to include the icons component
  - Changed the contact links to include all VDG chat rooms
  - Slightly changed the wording

REPOSITORY
  R266 Breeze Icons

BRANCH
  readme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28923

AFFECTED FILES
  README.md

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28766: Add auth-sim-locked and auth-sim-missing

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:169b438c9fc1: Add auth-sim-locked and auth-sim-missing 
(authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28766?vs=79895=79896

REVISION DETAIL
  https://phabricator.kde.org/D28766

AFFECTED FILES
  icons-dark/status/16/auth-sim-locked.svg
  icons-dark/status/16/auth-sim-missing.svg
  icons-dark/status/22/auth-sim-locked.svg
  icons-dark/status/22/auth-sim-missing.svg
  icons-dark/status/symbolic/auth-sim-locked-symbolic.svg
  icons-dark/status/symbolic/auth-sim-missing-symbolic.svg
  icons/status/16/auth-sim-locked.svg
  icons/status/16/auth-sim-missing.svg
  icons/status/22/auth-sim-locked.svg
  icons/status/22/auth-sim-missing.svg
  icons/status/symbolic/auth-sim-locked-symbolic.svg
  icons/status/symbolic/auth-sim-missing-symbolic.svg

To: ndavis, #vdg, cblack
Cc: kde-frameworks-devel, salvahg, Orage, LeGast00n, cblack, hannahk, 
frmdstryr, fbampaloukas, emrek, mkraemer, cahfofpai, asghaier, michaelh, 
tbalzer, dkardarakos, ndavis, PureTryOut, lnj, neofytosk, ngraham, bruns, 
alexeymin, jbbgameich, IlyaBizyaev, dvasin, jucato, jessep, Sergobot, sebas

D28766: Add auth-sim-locked and auth-sim-missing

[Noah Davis]

ndavis edited the test plan for this revision.
ndavis added a project: Plasma: Mobile.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28766

To: ndavis, #vdg
Cc: kde-frameworks-devel, salvahg, Orage, LeGast00n, cblack, hannahk, 
frmdstryr, fbampaloukas, emrek, mkraemer, cahfofpai, asghaier, michaelh, 
tbalzer, dkardarakos, ndavis, PureTryOut, lnj, neofytosk, ngraham, bruns, 
alexeymin, jbbgameich, IlyaBizyaev, dvasin, jucato, jessep, Sergobot, sebas

D28766: Add auth-sim-locked and auth-sim-missing

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  For Plasma Mobile

REPOSITORY
  R266 Breeze Icons

BRANCH
  sim-card (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28766

AFFECTED FILES
  icons-dark/status/16/auth-sim-locked.svg
  icons-dark/status/16/auth-sim-missing.svg
  icons-dark/status/22/auth-sim-locked.svg
  icons-dark/status/22/auth-sim-missing.svg
  icons-dark/status/symbolic/auth-sim-locked-symbolic.svg
  icons-dark/status/symbolic/auth-sim-missing-symbolic.svg
  icons/status/16/auth-sim-locked.svg
  icons/status/16/auth-sim-missing.svg
  icons/status/22/auth-sim-locked.svg
  icons/status/22/auth-sim-missing.svg
  icons/status/symbolic/auth-sim-locked-symbolic.svg
  icons/status/symbolic/auth-sim-missing-symbolic.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28737: Add sim card device icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:95ebf0c1d3ea: Add sim card device icons (authored by 
ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28737?vs=79800=79839

REVISION DETAIL
  https://phabricator.kde.org/D28737

AFFECTED FILES
  icons-dark/devices/16/auth-sim.svg
  icons-dark/devices/22/auth-sim.svg
  icons-dark/devices/64/auth-sim.svg
  icons-dark/devices/symbolic/auth-sim-symbolic.svg
  icons/devices/16/auth-sim.svg
  icons/devices/22/auth-sim.svg
  icons/devices/64/auth-sim.svg
  icons/devices/symbolic/auth-sim-symbolic.svg

To: ndavis, #vdg, cblack
Cc: kde-frameworks-devel, salvahg, Orage, LeGast00n, cblack, hannahk, 
frmdstryr, fbampaloukas, GB_2, emrek, mkraemer, cahfofpai, asghaier, michaelh, 
tbalzer, dkardarakos, ndavis, PureTryOut, lnj, neofytosk, ngraham, bruns, 
alexeymin, jbbgameich, IlyaBizyaev, dvasin, jucato, jessep, Sergobot, sebas

D28737: Add sim card device icons

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28737

To: ndavis, #vdg
Cc: kde-frameworks-devel, Orage, LeGast00n, cblack, hannahk, frmdstryr, 
fbampaloukas, GB_2, emrek, mkraemer, cahfofpai, asghaier, michaelh, tbalzer, 
dkardarakos, ndavis, PureTryOut, lnj, neofytosk, ngraham, bruns, alexeymin, 
jbbgameich, IlyaBizyaev, dvasin, jucato, jessep, Sergobot, sebas

D28737: Add sim card device icons

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  For Plasma Mobile

REPOSITORY
  R266 Breeze Icons

BRANCH
  sim-card (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28737

AFFECTED FILES
  icons-dark/devices/16/auth-sim.svg
  icons-dark/devices/22/auth-sim.svg
  icons-dark/devices/64/auth-sim.svg
  icons-dark/devices/symbolic/auth-sim-symbolic.svg
  icons/devices/16/auth-sim.svg
  icons/devices/22/auth-sim.svg
  icons/devices/64/auth-sim.svg
  icons/devices/symbolic/auth-sim-symbolic.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28737: Add sim card device icons

[Noah Davis]

ndavis added a project: Plasma: Mobile.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28737

To: ndavis, #vdg
Cc: kde-frameworks-devel, Orage, LeGast00n, cblack, hannahk, frmdstryr, 
fbampaloukas, GB_2, emrek, mkraemer, cahfofpai, asghaier, michaelh, tbalzer, 
dkardarakos, ndavis, PureTryOut, lnj, neofytosk, ngraham, bruns, alexeymin, 
jbbgameich, IlyaBizyaev, dvasin, jucato, jessep, Sergobot, sebas

D19736: Add rotation icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:48a112fb64dc: Add rotation icons (authored by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19736?vs=79765=79791

REVISION DETAIL
  https://phabricator.kde.org/D19736

AFFECTED FILES
  icons-dark/actions/16/screen-rotate-auto-off.svg
  icons-dark/actions/16/screen-rotate-auto-on.svg
  icons-dark/actions/22/screen-rotate-auto-off.svg
  icons-dark/actions/22/screen-rotate-auto-on.svg
  icons-dark/actions/32/screen-rotate-auto-off.svg
  icons-dark/actions/32/screen-rotate-auto-on.svg
  icons-dark/actions/symbolic/screen-rotate-auto-off-symbolic.svg
  icons-dark/actions/symbolic/screen-rotate-auto-on-symbolic.svg
  icons-dark/status/16/rotation-allowed.svg
  icons-dark/status/16/rotation-locked-landscape.svg
  icons-dark/status/16/rotation-locked-portrait.svg
  icons-dark/status/22/rotation-allowed.svg
  icons-dark/status/22/rotation-locked-landscape.svg
  icons-dark/status/22/rotation-locked-portrait.svg
  icons-dark/status/32/rotation-allowed.svg
  icons-dark/status/32/rotation-locked-landscape.svg
  icons-dark/status/32/rotation-locked-portrait.svg
  icons-dark/status/symbolic/rotation-allowed-symbolic.svg
  icons-dark/status/symbolic/rotation-locked-landscape-symbolic.svg
  icons-dark/status/symbolic/rotation-locked-portrait-symbolic.svg
  icons-dark/status/symbolic/rotation-locked-symbolic.svg
  icons/status/16/rotation-allowed.svg
  icons/status/16/rotation-locked-landscape.svg
  icons/status/16/rotation-locked-portrait.svg
  icons/status/22/rotation-allowed.svg
  icons/status/22/rotation-locked-landscape.svg
  icons/status/22/rotation-locked-portrait.svg
  icons/status/32/rotation-allowed.svg
  icons/status/32/rotation-locked-landscape.svg
  icons/status/32/rotation-locked-portrait.svg
  icons/status/symbolic/rotation-allowed-symbolic.svg
  icons/status/symbolic/rotation-locked-landscape-symbolic.svg
  icons/status/symbolic/rotation-locked-portrait-symbolic.svg
  icons/status/symbolic/rotation-locked-symbolic.svg

To: ndavis, #vdg, apol, ngraham
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D19736: Add rotation icons

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D19736: Add rotation icons

[Noah Davis]

ndavis retitled this revision from "Add 
view-orientation-auto/landscape/portrait" to "Add rotation icons".
ndavis edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D19736: Add view-orientation-auto/landscape/portrait

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19736

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D19736: Add view-orientation-auto/landscape/portrait

[Noah Davis]

ndavis updated this revision to Diff 79765.
ndavis added a comment.


  - Update style

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19736?vs=55804=79765

BRANCH
  rotate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19736

AFFECTED FILES
  icons-dark/actions/16/screen-rotate-auto-off.svg
  icons-dark/actions/16/screen-rotate-auto-on.svg
  icons-dark/actions/22/screen-rotate-auto-off.svg
  icons-dark/actions/22/screen-rotate-auto-on.svg
  icons-dark/actions/32/screen-rotate-auto-off.svg
  icons-dark/actions/32/screen-rotate-auto-on.svg
  icons-dark/actions/symbolic/screen-rotate-auto-off-symbolic.svg
  icons-dark/actions/symbolic/screen-rotate-auto-on-symbolic.svg
  icons-dark/status/16/rotation-allowed.svg
  icons-dark/status/16/rotation-locked-landscape.svg
  icons-dark/status/16/rotation-locked-portrait.svg
  icons-dark/status/22/rotation-allowed.svg
  icons-dark/status/22/rotation-locked-landscape.svg
  icons-dark/status/22/rotation-locked-portrait.svg
  icons-dark/status/32/rotation-allowed.svg
  icons-dark/status/32/rotation-locked-landscape.svg
  icons-dark/status/32/rotation-locked-portrait.svg
  icons-dark/status/symbolic/rotation-allowed-symbolic.svg
  icons-dark/status/symbolic/rotation-locked-landscape-symbolic.svg
  icons-dark/status/symbolic/rotation-locked-portrait-symbolic.svg
  icons-dark/status/symbolic/rotation-locked-symbolic.svg
  icons/status/16/rotation-allowed.svg
  icons/status/16/rotation-locked-landscape.svg
  icons/status/16/rotation-locked-portrait.svg
  icons/status/22/rotation-allowed.svg
  icons/status/22/rotation-locked-landscape.svg
  icons/status/22/rotation-locked-portrait.svg
  icons/status/32/rotation-allowed.svg
  icons/status/32/rotation-locked-landscape.svg
  icons/status/32/rotation-locked-portrait.svg
  icons/status/symbolic/rotation-allowed-symbolic.svg
  icons/status/symbolic/rotation-locked-landscape-symbolic.svg
  icons/status/symbolic/rotation-locked-portrait-symbolic.svg
  icons/status/symbolic/rotation-locked-symbolic.svg

To: ndavis, #vdg, apol
Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

[Noah Davis]

ndavis added a comment.


  I could probably make the python script instead, but I'm in the same spot 
when it comes to writing CMake.

TASK DETAIL
  https://phabricator.kde.org/T12855

To: ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, davidhurka, dmenig, manueljlin, 
Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, 
fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, 
michaelh, crozbo, firef, bruns, skadinna, aaronhoneycutt, mbohlender

D28606: Add iconSize property to PC2 ToolButton

[Noah Davis]

ndavis abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28606

To: ndavis, #plasma, mart
Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, 
GB_2, michaelh, bruns

D28606: Add iconSize property to PC2 ToolButton

[Noah Davis]

ndavis added a comment.


  In D28606#642513 , @ngraham wrote:
  
  > Darn. Maybe we should fix the PC3 tooltips though? :)
  
  
  Maybe, but I don't know what that would entail.
  For more context: I asked Kai about porting notifications to PC3 so that I 
could fix the size of icons with larger fonts. He said he wouldn't accept 
patches that do that for notifications or KRunner because of the issues with 
PC3, so I figured it would be easier to just add icon sizes to PC2.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28606

To: ndavis, #plasma, mart
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28606: Add iconSize property to PC2 ToolButton

[Noah Davis]

ndavis added a comment.


  In D28606#642514 , @ngraham wrote:
  
  > Adding Marco as a reviewer since I know he just lves 
ToolButton sizing. :)
  
  
  This doesn't actually affect toolbutton sizing, just icon sizing. Although, 
if you make the icon size too big, it'll bleed out of the button.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28606

To: ndavis, #plasma, mart
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28606: Add iconSize property to PC2 ToolButton

[Noah Davis]

ndavis added a subscriber: broulik.
ndavis added a comment.


  In D28606#642509 , @ngraham wrote:
  
  > If the developer has these needs, why not port to the PC3 version, which 
has this feature already?
  
  
  @broulik said we can't do that for some things like notifications and KRunner 
because of how the tooltips work.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28606

To: ndavis, #plasma
Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns

D28606: Add iconSize property to PC2 ToolButton

[Noah Davis]

ndavis added a comment.


  I'm getting a binding loop: : QML QQuickLayoutAttached: Binding 
loop detected for property "minimumWidth"
  I'm guessing that's `Layout.minimumWidth` inside the `ToolButtonStyle` 
`IconItem`

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28606

To: ndavis, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28606: Add iconSize property to PC2 ToolButton

[Noah Davis]

ndavis edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28606

To: ndavis, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28606: Add iconSize to PC2 ToolButton

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  iconSize sets the size of the ToolButton's icon if it is set to a value.
  If no value is set, the ToolButtonStyle IconItem's minimumWidth is bound to 
buttonContent.height like it was before this patch and iconSize is bound to the 
paintedWidth of the icon.
  
  Usecase: In places where a custom icon size is wanted, a developer must 
create an IconItem nested in the ToolButton. This makes it so a developer only 
needs to change a single property.

TEST PLAN
  1. Set iconSize for a PC2 ToolButton and see if the icon size is changed.
  2. Bind the width of a component to a ToolButton's iconSize and see if it 
works.3. Do step 2, but don't do step 1 and see if it works

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  pc2-toolbutton-iconSize (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28606

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/ToolButton.qml
  src/declarativeimports/plasmastyle/ToolButtonStyle.qml

To: ndavis, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28606: Add iconSize property to PC2 ToolButton

[Noah Davis]

ndavis retitled this revision from "Add iconSize to PC2 ToolButton" to "Add 
iconSize property to PC2 ToolButton".

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28606

To: ndavis, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

[Noah Davis]

ndavis added a comment.


  @davidhurka Actually, I'm using Highlight. I still can't get ButtonFocus to 
work reliably and Highlight in icons now changes to white when a UI element 
gets highlighted, which is good. BTW, join the VDG chat if you haven't already.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28553

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28579: Improve the look of kcachegrind

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:0e3911c84d37: Improve the look of kcachegrind (authored 
by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28579?vs=79359=79428

REVISION DETAIL
  https://phabricator.kde.org/D28579

AFFECTED FILES
  icons-dark/apps/48/kcachegrind.svg
  icons/apps/48/kcachegrind.svg

To: ndavis, #vdg, cblack, ngraham
Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D28561: Remove border from format-border-set-* icons

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  simplify-format-border

REVISION DETAIL
  https://phabricator.kde.org/D28561

To: davidhurka, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28561: Remove border from format-border-set-* icons

[Noah Davis]

ndavis added a comment.


  Remove the border. I don't think it makes any sense to use different styled 
borders to show a lack of borders in certain places.

REPOSITORY
  R266 Breeze Icons

BRANCH
  simplify-format-border

REVISION DETAIL
  https://phabricator.kde.org/D28561

To: davidhurka, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28561: Remove border from format-border-set-* icons

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  simplify-format-border

REVISION DETAIL
  https://phabricator.kde.org/D28561

To: davidhurka, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28573: Add 16px System Settings icon

[Noah Davis]

ndavis accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28573

To: manueljlin, #vdg, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28579: Improve the look of kcachegrind

[Noah Davis]

ndavis updated this revision to Diff 79359.
ndavis added a comment.


  Update breeze dark version

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28579?vs=79358=79359

BRANCH
  kcachegrind (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28579

AFFECTED FILES
  icons-dark/apps/48/kcachegrind.svg
  icons/apps/48/kcachegrind.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28579: Improve the look of kcachegrind

[Noah Davis]

ndavis updated this revision to Diff 79358.
ndavis added a comment.


  Remove unused element

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28579?vs=79357=79358

BRANCH
  kcachegrind (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28579

AFFECTED FILES
  icons-dark/apps/48/kcachegrind.svg
  icons/apps/48/kcachegrind.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28579: Improve the look of kcachegrind

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28579

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28579: Improve the look of kcachegrind

[Noah Davis]

ndavis updated this revision to Diff 79357.
ndavis added a comment.


  Improve gear contrast with UIs

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28579?vs=79356=79357

BRANCH
  kcachegrind (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28579

AFFECTED FILES
  icons-dark/apps/48/kcachegrind.svg
  icons/apps/48/kcachegrind.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28579: Improve the look of kcachegrind

[Noah Davis]

ndavis edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28579

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28579: Improve the look of kcachegrind

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ndavis requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  kcachegrind (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28579

AFFECTED FILES
  icons-dark/apps/48/kcachegrind.svg
  icons/apps/48/kcachegrind.svg

To: ndavis, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

[Noah Davis]

ndavis added a comment.


  In D28553#641271 , @davidhurka 
wrote:
  
  > Cuttlefish (Ubuntu release)?
  >
  > So that means all icons should be changed from Highlight to ButtonFocus? 
That would also affect colorful icons. Some of them have Highlight and 
ButtonFocus in the stylesheet, fortunately with the same color.
  
  
  Don't worry about it. I'll do a pass once KF5.69 is released.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28553

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28553: Rename stylesheet color ButtonFocus -> Highlight

[Noah Davis]

ndavis added a comment.


  Actually, I just tested the icons in Cuttlefish and apparently ButtonFocus 
works now, so it's preferred to Highlight. Sorry to give you the run around.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28553

To: davidhurka, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28203: Move corner fold to top right in 24 icons

[Noah Davis]

ndavis added a comment.


  Fixed it. I missed a few more symlinks that weren't relative in the review. I 
couldn't test it locally during review because `arc` can't download patches 
that convert a file into a symlink or vice versa.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28203

To: davidhurka, #vdg, ndavis, ngraham, davidre
Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, bruns

D28542: Add 16px LibreOffice icons

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:4cdcd11c07da: Add 16px LibreOffice icons (authored by 
ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28542?vs=79232=79251

REVISION DETAIL
  https://phabricator.kde.org/D28542

AFFECTED FILES
  icons-dark/apps/16/libreoffice-base.svg
  icons-dark/apps/16/libreoffice-calc.svg
  icons-dark/apps/16/libreoffice-draw.svg
  icons-dark/apps/16/libreoffice-impress.svg
  icons-dark/apps/16/libreoffice-main.svg
  icons-dark/apps/16/libreoffice-math.svg
  icons-dark/apps/16/libreoffice-writer.svg
  icons/apps/16/libreoffice-base.svg
  icons/apps/16/libreoffice-calc.svg
  icons/apps/16/libreoffice-draw.svg
  icons/apps/16/libreoffice-impress.svg
  icons/apps/16/libreoffice-main.svg
  icons/apps/16/libreoffice-math.svg
  icons/apps/16/libreoffice-writer.svg

To: manueljlin, #vdg, ngraham, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
bruns