org/r/129560/
> ---
>
> (Updated Nov. 25, 2016, 10:04 p.m.)
>
>
> Review request for KDE Frameworks and Rohan Garg.
>
>
> Repository: kpty
>
>
> Description
> ---
>
> Debian stable still has it in /usr/lib/utempter/ so search there
>
> Also
that those lines are already
present and shouldn't be new lines. Apart from that, LGTM if it builds fine.
- Rohan Garg
On Nov. 25, 2016, 10:04 p.m., Jonathan Riddell wrote:
>
> ---
> This is an automatically generated e-mail.
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit dbc2f83cd264fc1bfbb3321bb0f1ec8e2df1cef1 by Rohan Garg to
branch master.
Repository: kcmutils
Description
---
This reverts commit 5432c3edf5e074f1e951e6ecc682f7a400e2818f.
kcmutils now
---
Thanks,
Rohan Garg
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129090/#review100118
---
Ship it!
Ship It!
- Rohan Garg
On Oct. 18, 2016, 6:25
utempter still ships the
library in ${CMAKE_PREFIX_PATH}/lib/utempter.
Ref https://packages.debian.org/jessie/amd64/libutempter0/filelist
- Rohan Garg
On Oct. 4, 2016, 3:50 p.m., Jonathan Riddell wrote:
>
> ---
> This is an auto
---
This reverts commit 5432c3edf5e074f1e951e6ecc682f7a400e2818f.
kcmutils now depends on Qt 5.5 so it should be fine to go in.
Diffs
-
src/kcmoduleqml.cpp 1165c61
Diff: https://git.reviewboard.kde.org/r/128773/diff/
Testing
---
Thanks,
Rohan Garg
n time.
> I didn't, so this missed 5.23.
>
I ... uhmm .. was too busy gobbling up the cookies I was going to
bribe you with :(
Cheers
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> On June 7, 2016, 3:03 a.m., Rohan Garg wrote:
> > Hi
> > Could we get a shipit on these? I'd really appreciate it if we could have
> > these in Frameworks 5.23
>
> Martin Gräßlin wrote:
> I don't want to disappoint you, but it's too late for 5.23
>
>
it if we could have these
in Frameworks 5.23
- Rohan Garg
On June 3, 2016, 5:45 p.m., David Edmundson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
it if we could have these
in Frameworks 5.23
- Rohan Garg
On June 3, 2016, 5:45 p.m., David Edmundson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
it if we could have these
in Frameworks 5.23
- Rohan Garg
On June 3, 2016, 5:45 p.m., David Edmundson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
On July 15, 2015, 8:49 p.m., Rohan Garg wrote:
Ship It!
Compiles fine on my board, tests run fine too.
- Rohan
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124150/#review82543
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124150/#review82543
---
Ship it!
Ship It!
- Rohan Garg
On June 22, 2015, 10:43
is here [1]
Cheers
Rohan Garg
[1] http://paste.ubuntu.com/11741695/
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121712/#review73531
---
Ship it!
Ship It!
- Rohan Garg
On Dec. 30, 2014, 6:38 p.m
/ECMGeneratePriFile.cmake 34001d6
modules/ECMQueryQmake.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/119901/diff/
Testing
---
Seems to work on my system.
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
/ECMGeneratePriFile.cmake 34001d6
modules/ECMQueryQmake.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/119901/diff/
Testing
---
Seems to work on my system.
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
in
ECM.
Diffs (updated)
-
modules/ECMQueryQmake.cmake PRE-CREATION
kde-modules/KDEInstallDirs.cmake 880539b
modules/ECMGeneratePriFile.cmake 34001d6
Diff: https://git.reviewboard.kde.org/r/119901/diff/
Testing
---
Seems to work on my system.
Thanks,
Rohan Garg
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65074
---
On Aug. 22, 2014, 6:10 p.m., Rohan Garg wrote
://git.reviewboard.kde.org/r/119901/diff/
Testing
---
Seems to work on my system.
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119901/#review65234
---
On Aug. 25, 2014, 9:14 p.m., Rohan Garg wrote
---
Seems to work on my system.
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/ECMGeneratePriFile.cmake 34001d6
modules/ECMQueryQmake.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/119901/diff/
Testing
---
Seems to work on my system.
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel
/ECMGeneratePriFile.cmake 34001d6
modules/ECMQueryQmake.cmake PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/119901/diff/
Testing
---
Seems to work on my system.
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
enough? I thought you had to use option() to make the
option available on the cmake command-line, but maybe I'm missing something.
Rohan Garg wrote:
I think ECM_INSTALL_PLUGINS_IN_QT_DIR would be wrong since it's used for
both plugins and QtQuick imports.
David Faure wrote:
Yeah
-cmake-modules
Description
---
Use qmake to query dirs for plugins and imports instead of hardcoding them in
ECM.
Diffs
-
kde-modules/KDEInstallDirs.cmake 880539b
Diff: https://git.reviewboard.kde.org/r/119901/diff/
Testing
---
Seems to work on my system.
Thanks,
Rohan Garg
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119736/#review64464
---
Ship it!
\o/
Thanks Nicolas :)
- Rohan Garg
On Aug. 12
On Aug. 13, 2014, 6:24 p.m., Rohan Garg wrote:
\o/
Thanks Nicolas :)
Albert Astals Cid wrote:
Is doxygen smart enough to read the .md?
Yep, atleast the version I have can read .md, @Nicolas does the doxygen version
on api.kde.org handle .md files?
- Rohan
on Denis's machine, awesome work! :D
- Rohan Garg
On Aug. 13, 2014, 12:51 a.m., Denis Steckelmacher wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119740
for downstream to just override the
desktop file as part of their customization package.
- Rohan Garg
On July 17, 2014, 3:20 p.m., Marco Martin wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/diff/
Testing
---
The fixed tests pass, however kiocore-listdirtest seems to be going on forever,
not sure why ( it keeps going on forever regardless of this patch on my machine
though ).
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing
75ad12f
Diff: https://git.reviewboard.kde.org/r/118116/diff/
Testing
---
Everything still compiles, tests still pass
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
SSL still works
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
still works
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
src/widgets/org.kde.kuiserver.xml 75ad12f
Diff: https://git.reviewboard.kde.org/r/118116/diff/
Testing
---
Everything still compiles, tests still pass
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
---
Rename DBus interfaces to use the new Qt namespace.
Diffs
-
src/core/org.kde.KPasswdServer.xml fbb590e
Diff: https://git.reviewboard.kde.org/r/118116/diff/
Testing
---
Everything still compiles, tests still pass
Thanks,
Rohan Garg
://git.reviewboard.kde.org/r/118098/diff/
Testing
---
SSL KCM starts as opposed to crashing earlier.
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
.
Diffs
-
src/kssl/kcm/cacertificatespage.cpp 90c757f
Diff: https://git.reviewboard.kde.org/r/118098/diff/
Testing
---
SSL KCM starts as opposed to crashing earlier.
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde
-
src/widgets/ksslinfodialog.h 5280242
src/widgets/ksslinfodialog.cpp 33001f4
src/widgets/ksslcertificatebox.cpp 576acd0
Diff: https://git.reviewboard.kde.org/r/118102/diff/
Testing
---
KCM SSL still works
Thanks,
Rohan Garg
___
Kde
on forever,
not sure why ( it keeps going on forever regardless of this patch on my machine
though ).
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/113158/diff/
Testing
---
Tested by writing a application that uses KIO to fetch an invalid site url.
Dialog pops up just fine.
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
KIO to fetch an invalid site url.
Dialog pops up just fine.
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
and
only compile stuff that I work on ( kdelibs and Qt5 )
Even Project Neon 5 doesn't use kdesrc-build itself, so I disagree on raising
the cmake requirement, at least before the final release is out.
Regards
Rohan Garg
signature.asc
Description: This is a digitally signed message part
so I disagree on raising the cmake requirement, at least before the final
release is out.
Which cmake release do you use in Project Neon 5? Is it part of your
packaging effort or you assume whatever comes from the distro?
We currently build for 2 releases last stable (Raring) and
---
After patching, the frameworks branch compiles fine in a i386 lxc container.
Thanks,
Rohan Garg
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
kdecore/CMakeLists.txt says
target_compile_definitions(kdecore PUBLIC -D_FILE_OFFSET_BITS=64)
Maybe you want to move that to kioslave/file? It's the only user of off_t.
Moving it to kioslave/file/CMakeLists.txt did indeed fix this issue.
Should I go ahead and commit the patch [1] ? Maybe
47 matches
Mail list logo
