D9712: balooctl status: produce parseable output

vhanda added a comment. In https://phabricator.kde.org/D9712#191746, @ltoscano wrote: > May I observe that relying on the command line output is fragile in the best case? > Unless the command can produce the output in some formatted way (like the openstack CLI, which can enable a

D8007: popplerextractor: don't try to guess the title if there isn't one.

vhanda added a comment. To give some history - Strigi used to do this guessing, and when I implemented KFileMetaData, I decided to do the same. I don't have an opinion on whether it is a good idea or not. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D8007

D8007: popplerextractor: don't try to guess the title if there isn't one.

vhanda added a comment. > @vhanda do you know if there is something to do to update Baloo database when metadata returned by KFileMetaData are changed even if the file itself did not change ? I'm starting to forget the code base and what all I implemented. But I don't think such a

D8527: Display "Downloaded From" by default, if file supports it

vhanda accepted this revision. vhanda added a comment. This revision is now accepted and ready to land. Looks good. Maybe we should wait and see if someone who works on Dolphin has an opinion. This widget is only used in Dolphin. REPOSITORY R824 Baloo Widgets BRANCH

D8528: Consider DjVu files to be documents

vhanda added a comment. Since I was added as a reviewer, I thought I'll comment. I am not currently maintaining Baloo or using it, so I don't want to really discuss the specifics. Though from a technical point of view this change will work. If nobody has any objections, I would say go

D4995: Fix DB inconsistency due to some docterms appearing with uppercase symbols

vhanda accepted this revision. vhanda added a comment. This revision is now accepted and ready to land. This is awesome. Good work. Ship it! (If you don't have commit access, please ask for it, you can add me as a reference) (Optionally, one could even add a unit test) REPOSITORY

D4911: add Baloo DBus signals for moved or removed files

vhanda added a comment. I'm not the maintainer of Baloo any more, so I don't want to give it a clear Yes / No. This patch is going to be a big CPU hog. For files this will barely have an impact, but for folders of a large enough size, it's going to result in tons of dbus signals, and

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

w.r.t the EventLoop. Diffs - autotests/convertertest.h 8129a48 autotests/convertertest.cpp ae4298e src/currency.cpp 715233c Diff: https://git.reviewboard.kde.org/r/122183/diff/ Testing --- Test now passes. Thanks, Vishesh Handa

Re: Scrap Baloo Thread Feedback

oing to be very involved with this. I've already expressed my opinion. You all are free to make a decision. -- Vishesh Handa

Re: Scrap Baloo Thread Feedback

On Fri, Oct 7, 2016 at 8:08 PM, Christoph Cullmann wrote: > > I did experiments and search works with tracker, but yes, a problem is > tagging,+ > which ATM doesn't work. Nor do I say that is a ready solution now, just a > possibility > to avoid having to maintain low level

Re: Scrap Baloo Thread Feedback

> and we want instant feedback. This was an integral requirement. > I doubt e.g. tracker has different requirements, as it is used in similar > places by GNOME. > > But all that left besides, have you an proposal how to fixup the current > situation? > Are you willing to invest some work to fix the current issues or an idea what > would be a good way to tackle them? > I probably will not work more in Baloo. I'll have to investigate the problems a bit more. From the cursory look of this thread, it doesn't seem that the problems are that dire. But I may not be reading into it correctly. -- Vishesh Handa

Re: Scrap Baloo Thread Feedback

iom. An analogy could be that we get commit emails, but we get to choose which projects we are interested in. We don't make everyone subscribe to kde-commits, and then put their own complex filters on top. -- Vishesh Handa

Re: Scrap Baloo Thread Feedback

he review requests. It was just too much noise for me, and I found the noise/signal ratio way lower in kde-devel. Baloo-devel was specifically not chosen as it would just an another silo in kde. Nepomuk used to suffer from that. -- Vishesh Handa

Re: Scrap Baloo Thread Feedback

On Fri, Oct 7, 2016 at 5:57 PM, Kevin Funk <kf...@kde.org> wrote: > On Friday, 7 October 2016 17:24:26 CEST Vishesh Handa wrote: >> Hey guys >> >> I was told there is a thread about scrapping Baloo. All Baloo >> discussion used to happen on kde-devel and that'

Scrap Baloo Thread Feedback

requirements such as resource consumption, ease of integration, search speed are taken into consideration? Come on guys. We're engineers over here. (If the discussion continues on kde-frameworks-devel, I probably won't see it) -- Vishesh Handa

Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128892/#review99115 --- Ship it! This is awesome. Ship it. - Vishesh Handa

Re: Find out whether a file is a remote file or not

On Sun, May 1, 2016 at 6:28 PM, Dominik Haumann <dhaum...@kde.org> wrote: > > CC: Vishesh, since maybe baloo also had to solve these issues We mostly just use Solid to query the list of mount points and ignore non local stuff. baloo/src/file/storagedevices.h -- V

Re: Please add new versions on bugs.kde.org products on KF5 releases

the > maintainer? > (the yaml file points to Vishesh). Whatever is easier. I am the maintainer, but I haven't been doing anything, so someone else should take over. I'll write an email announcing that soon. -- Vishesh Handa ___ Kde-frameworks-devel mai

Re: Review Request 127023: [KFileMetadata] Support Origin Email subject/sender/id

e find amazing creative uses for the data. It did not end well. - Vishesh Handa On Feb. 9, 2016, 9:09 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 125762: External extractor plugin support for KFileMetaData

other plugins will suffer. Perhaps the list of mimetypes supported could be in a desktop file? - Vishesh Handa On Oct. 24, 2015, 12:19 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 126110: Clean up and armour Baloo::Database::open()

tps://git.reviewboard.kde.org/r/126110/#comment60854> Please remove the comment. It's not longer valid. src/engine/database.cpp (line 192) <https://git.reviewboard.kde.org/r/126110/#comment60855> Perhaps you want to close the env here as well? The assert can fail in production. - V

Re: Review Request 126105: Fix yet another crash in Dolphin when Baloo isn't running

use case that I focussed on was searching. Over there the db is only opened once per application. - Vishesh Handa On Nov. 18, 2015, 7:40 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 125762: External extractor plugin support for KFileMetaData

s case. - Vishesh Handa On Oct. 24, 2015, 12:19 p.m., Boudhayan Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 120393: [kdelibs4support] Kill dead code

automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120393/ > --- > > (Updated March 18, 2015, 6:24 p.m.) > > > Review request for KDE Frameworks, David Faure and Vishe

Re: Review Request 124876: KSycoca: check timestamps and run kbuildsycoca if needed. No kded needed anymore.

://git.reviewboard.kde.org/r/124876/#comment58543 Does the added `(void)` disable some kind of warning? src/sycoca/ksycoca.cpp (line 592) https://git.reviewboard.kde.org/r/124876/#comment58544 random thought: Is the return value given by kbuildsyscoca useful? - Vishesh Handa On Aug. 28, 2015, 9:41 a.m

Re: Review Request 124610: do not install namelink for private library

it a ShipIt. Also, you probably want to get this in today before the tagging. - Vishesh Handa On Aug. 4, 2015, 8:04 a.m., Harald Sitter wrote: --- This is an automatically generated e-mail. To reply, visit: https

Making Baloo and KFileMetaData a framework

replaced Xapian with a custom full-text-engine, so Baloo is now finally LGPL, and meets the frameworks criteria. The public API hasn't really changed since the last time. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

marked as submitted. Review request for KDE Frameworks and David Edmundson. Changes --- Submitted with commit 9319a163b7f8360949bdd1cde12aaf3d7b033132 by Vishesh Handa to branch master. Repository: kcoreaddons Description --- KDirWatch by default initializes a connection to both

Re: Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

) - src/lib/io/kdirwatch.cpp 246be82 Diff: https://git.reviewboard.kde.org/r/124128/diff/ Testing --- Unit tests pass Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

for a while on running FAMOpen. Diffs (updated) - src/lib/io/kdirwatch.cpp 246be82 Diff: https://git.reviewboard.kde.org/r/124128/diff/ Testing --- Unit tests pass Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 124134: Fixing KDED string references

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124134/#review81598 --- Ship it! Looks good. - Vishesh Handa On June 20, 2015, 5

Review Request 124128: KDirWatch: Only establish a connection to FAM if requested

246be82929cc08e40bd9eceec017036ec4686c26 Diff: https://git.reviewboard.kde.org/r/124128/diff/ Testing --- Unit tests pass Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 124065: KMimeType mimeTypeForNameAndData() - mimeTypeForFileNameAndData()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124065/#review81372 --- Ship it! - Vishesh Handa On June 10, 2015, 7:51 p.m

Re: Review Request 123735: version of QmlObject with a static engine

to it. - Vishesh Handa On May 21, 2015, 10:52 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123735

Re: Review Request 123735: version of QmlObject with a static engine

://git.reviewboard.kde.org/r/123735/#comment55306 It would be awesome if we could have some tests for this class. Maybe we can just try and copy the QQuickView tests? http://code.qt.io/cgit/qt/qtdeclarative.git/tree/tests/auto/quick/qquickview/tst_qquickview.cpp - Vishesh Handa On May

Re: Review Request 123735: version of QmlObject with a static engine

. Could you please explain why this needs to be static? Also, you could just combine the QSharedPointer and the normal pointer. - Vishesh Handa On May 18, 2015, 8 p.m., Marco Martin wrote: --- This is an automatically generated

Re: Review Request 123735: version of QmlObject with a static engine

On May 19, 2015, 3:04 p.m., Vishesh Handa wrote: src/kdeclarative/qmlobjectsharedengine.cpp, line 60 https://git.reviewboard.kde.org/r/123735/diff/8/?file=370102#file370102line60 I'm probably missing some parts of the picture. Could you please explain why this needs to be static

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

://git.reviewboard.kde.org/r/123341/#comment55282 Minor thing, which is up to you. In this test you're allocating the `Speller` off the heap and having to delete it. In the other test you're allocating it off the stack. - Vishesh Handa On May 12, 2015, 6:03 p.m., Kåre Särs wrote

Re: Kross module loading is broken since KF5.0.0

again. What do you think? Ok. Though I was hoping someone else would answer. We currently don't have a maintainer for Kross. So please make a review request with the changes, you can wait a week or so for someone to object, and then just ship it. -- Vishesh Handa

Re: Kross module loading is broken since KF5.0.0

to me. I would go for this one. It's trivial to implement and the speed difference would be minuscule. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

'. - Vishesh Handa On April 15, 2015, 3:38 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367

Re: Review Request 123367: Generate Q_PROPERTY entries out of KConfigSkeleton classes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123367/#review79347 --- Ship it! - Vishesh Handa On April 22, 2015, 2:51 p.m

Re: Review Request 123402: Moves away from KService

://git.reviewboard.kde.org/r/123402/#comment54080 If you want you can also change this to the new for syntax. - Vishesh Handa On April 17, 2015, 3:45 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 120393: [kdelibs4support] Kill dead code

On March 18, 2015, 11:23 p.m., Vishesh Handa wrote: I'm all for getting rid of the Nepomuk code. However, I'm not too sure about the strigi part. That should still work. Hrvoje Senjan wrote: It does not ;-) Originally, this review added back the find_package(Strigi) call which

Re: Review Request 120393: [kdelibs4support] Kill dead code

On March 18, 2015, 11:23 p.m., Vishesh Handa wrote: I'm all for getting rid of the Nepomuk code. However, I'm not too sure about the strigi part. That should still work. Hrvoje Senjan wrote: It does not ;-) Originally, this review added back the find_package(Strigi) call which

Re: Review Request 120393: [kdelibs4support] Kill dead code

not too sure about the strigi part. That should still work. - Vishesh Handa On March 18, 2015, 6:24 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393

Re: Review Request 122621: Implemented SlaveBase::GetFileSystemFreeSpace in sftp ioslave

On Feb. 25, 2015, 10:24 a.m., Vishesh Handa wrote: sftp/kio_sftp.cpp, line 247 https://git.reviewboard.kde.org/r/122621/diff/1/?file=350141#file350141line247 The code indentation seems wrong. Emmanuel Pescosta wrote: Just followed the coding style (1 tab - 2 spaces) from

Re: KDE Telepathy has an unreleased dependency

. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

/#comment52534 I'm really not sure what to do if we cannot open the file. Abort? Print out an error message? Or just silently ignore it like right now. - Vishesh Handa On Feb. 17, 2015, 11:22 a.m., Vishesh Handa wrote

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

) - src/currency.cpp 715233c autotests/convertertest.h 8129a48 autotests/convertertest.cpp ae4298e Diff: https://git.reviewboard.kde.org/r/122183/diff/ Testing --- Test now passes. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list

Re: Review Request 122562: Add method for converting from QVariant to base64

://git.reviewboard.kde.org/r/122562/#comment52519 Coding style src/qmlcontrols/kquickcontrolsaddons/clipboard.cpp https://git.reviewboard.kde.org/r/122562/#comment52520 huh? The `case QVariant::String` does not matter. - Vishesh Handa On Feb. 13, 2015, 6:16 p.m., Aleix Pol

Re: Review Request 122453: Improve KPeople documentation, in order to become a Framework

/#comment52234 Perhaps you want to add your name over here? - Vishesh Handa On Feb. 6, 2015, 2:14 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122453

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

the EventLoop. Diffs (updated) - autotests/convertertest.h 8129a48 autotests/convertertest.cpp ae4298e src/currency.cpp 715233c Diff: https://git.reviewboard.kde.org/r/122183/diff/ Testing --- Test now passes. Thanks, Vishesh Handa

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183/ --- (Updated Jan. 23, 2015, 2:17 p.m.) Review

Re: Build failed in Jenkins: kde-baseapps_master_qt5 #213

error? Missing dependency maybe? Yes. I moved the file from baloo to baloo-widgets. Let me try to fix it. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122206: [kio] Make tests optional

certainly consistent. (see e.g. kcoreaddons - the find_package(Qt5Test) is being done in the autotests subfolder, the same could be done here). Vishesh Handa wrote: It's not about users, it's about developers/packagers. We're not forcing them to run the tests, we're telling them

Re: Review Request 122206: [kio] Make tests optional

On Jan. 23, 2015, 8:58 p.m., David Faure wrote: Not sure why this is suddenly triggering many philosophical discussions about what users should be doing (IMHO, give them choice, this is opensource). Similar changes have been done in most other frameworks long ago, this is most

Re: backwards compatibility how namespacing might help or not

. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122206: [kio] Make tests optional

On Jan. 23, 2015, 1:43 p.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

On Jan. 23, 2015, 1:43 p.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

On Jan. 23, 2015, 1:43 p.m., Vishesh Handa wrote: I'm not against this, but I am curious as to why this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all

Re: Review Request 122206: [kio] Make tests optional

this is being done. I would think that packagers should be building the tests and running them on their platform and make sure everything passes. We have a strict policy that all tests must always pass. - Vishesh Handa On Jan. 22, 2015, 7:48 p.m., Andreas Sturmlechner wrote

Re: Review Request 122180: [KUnitConversion] Unit::setUnitMultiplier: Do not call oneself

case in another patch. We no longer crash. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122181: [KUnitConversion] UnitCategory convert: Call UnitCategoryPrivate instead of duplicating it

/ Testing --- Fixes a test in another patch. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

--- Test now passes. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122182: [KUnitConversion] Currency: Give default values for various currencies

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122182/#review74531 --- On Jan. 21, 2015, 2:47 p.m., Vishesh Handa wrote

Re: Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

--- On Jan. 21, 2015, 2:47 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122183

Review Request 122183: [KUnitConversion] Currency: Fetch the currency file properly

/convertertest.cpp ae4298e src/currency.cpp 715233c src/unit.cpp 013b5d7 src/unitcategory.cpp c34217e Diff: https://git.reviewboard.kde.org/r/122183/diff/ Testing --- Test now passes. Thanks, Vishesh Handa ___ Kde-frameworks-devel

Review Request 122180: [KUnitConversion] Unit::setUnitMultiplier: Do not call oneself

Description --- KUnitConversion: Unit::setUnitMultiplier: Do not call oneself Diffs - src/unit.cpp 013b5d7 Diff: https://git.reviewboard.kde.org/r/122180/diff/ Testing --- Created a test case in another patch. We no longer crash. Thanks, Vishesh Handa

Review Request 122181: [KUnitConversion] UnitCategory convert: Call UnitCategoryPrivate instead of duplicating it

. This was caught while trying to debug the currency converter. It has its own custom convert function. Diffs - src/unitcategory.cpp c34217e Diff: https://git.reviewboard.kde.org/r/122181/diff/ Testing --- Fixes a test in another patch. Thanks, Vishesh Handa

Review Request 122182: [KUnitConversion] Currency: Give default values for various currencies

. This patch updates it to the current values as reflected in the file. Diffs - src/currency.cpp 715233c Diff: https://git.reviewboard.kde.org/r/122182/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde

Re: Baloo Framework - License Exception

), but it will not be released with frameworks. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Baloo Framework - License Exception

that is required. I'll also add a disclaimer that Baloo is effectively GPL. I also started hacking on the Xapian replacement, and I have a student experimenting with Lucene, so Baloo will eventually become LGPL. -- Vishesh Handa ___ Kde-frameworks-devel

Re: Baloo Framework - License Exception

to Plasma. * I like the 1 month cycles that Frameworks follows. * It isn't required for KMail any more. It's purely for file searching + indexing. Anyway, I guess I could possibly just move Baloo to extragear and start doing 1 month releases on my own. But it would be taxing. -- Vishesh Handa

Re: Re: Baloo Framework - License Exception

swap out Xapian by something different I would say it's not derived work. But if Xapian is deeply wired into Baloo I would say it's derived work. It's not deeply wired but it is a very important component. We can easily replace Xapian if we want to / find something nicer. -- Vishesh Handa

Re: Re: Baloo Framework - License Exception

to make it GPL. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Baloo Framework - License Exception

of problems with Xapian [1]. But this will take time, I'm not too keen on switching to something on a whim without proper testing. Plus, it would be a substantially large change. -- Vishesh Handa [1] https://community.kde.org/Baloo/XapianProblems ___ Kde

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: src/quickaddons/managedtexturenode.h, line 52 https://git.reviewboard.kde.org/r/120550/diff/2/?file=318205#file318205line52 even if will always remain just this member, just to me sure, it should be in a dpointer Aleix Pol

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

://git.reviewboard.kde.org/r/120550/#comment47668 Strange indentation. - Vishesh Handa On Oct. 13, 2014, 5:54 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550

Re: Review Request 120049: KDirNotify: Use QUrl::toStringList

/r/120049/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119796: Add a --run-env option

does not work as I could not figure out how to get the kdedir and qtdir configuration values from Module.pm. Could someone help? Diffs - modules/ksb/Application.pm 0324002 Diff: https://git.reviewboard.kde.org/r/119796/diff/ Testing --- Thanks, Vishesh Handa

Re: Initial standalone Plasma::Package repository

and deprecated would clash) Just to confirm - With this, the package class in plasma-framework will now be deprecated? -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 120049: KDirNotify: Use QUrl::toStringList

Description --- Instead of a custom function. QUrl::toStringList reserves the size of the new list before hand. Diffs - src/core/kdirnotify.cpp 14f4c9c Diff: https://git.reviewboard.kde.org/r/120049/diff/ Testing --- Thanks, Vishesh Handa

Re: split kdepimlibs

library that is also used by kpeople. It seems like a good candidate for an individual framework. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119796: Add a --run-env option

configuration values from Module.pm. Could someone help? Diffs - modules/ksb/Application.pm 0324002 Diff: https://git.reviewboard.kde.org/r/119796/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Making KFileMetaData a framework

static so you don't load the plugins every time (which can be a bit expensive) Hmm, Possibly. dump.cpp should check there's at least one arg. (I know it's a test, but you explicitly check for =2 but not 1) Fixed Thanks for reviewing the code. -- Vishesh Handa

Re: Making KFileMetaData a framework

On Tuesday, August 05, 2014 11:19:16 PM Kevin Ottens wrote: Hello, On Tuesday 05 August 2014 18:36:24 Vishesh Handa wrote: I would appreciate it if everyone could review the code once before it gets into frameworks. metainfo.yaml should have release: false until it's part of a KF

Making KFileMetaData a framework

a certain number of unit tests. It's currently only used by Baloo. I would appreciate it if everyone could review the code once before it gets into frameworks. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 119155: Make the desktop containment respect minimum sizes

/desktop/package/contents/ui/main.qml https://git.reviewboard.kde.org/r/119155/#comment43026 ? - Vishesh Handa On July 7, 2014, 12:51 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

` in knewstuff/tests/. Without this patch it just blocks. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

/ Testing --- This can be tested by running `khotnewstuff plasmoids.knsrc` in knewstuff/tests/. Without this patch it just blocks. Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119110/#review61614 --- On July 4, 2014, 9:58 p.m., Vishesh Handa wrote

Re: Review Request 118960: Add a test to print out KLauncher's autostart files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118960/#review61258 --- ping? It's just a test. - Vishesh Handa On June 26, 2014

Re: qt5 polkit-qt-1 and kdesrc-build

On Sat, Jun 28, 2014 at 5:09 PM, Sune Vuorela nos...@vuorela.dk wrote: On 2014-06-27, David Faure fa...@kde.org wrote: This question is still open. We're releasing kauth as part of KF5 but polkit-qt-1 isn't getting released. Is there any maintainer for polkit-qt-1? For that matter,

Re: Review Request 118960: Add a test to print out KLauncher's autostart files

: https://git.reviewboard.kde.org/r/118960/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118970: libkeduvocdocument: Remove KDELibs4Support dependency.

/tests/converter.cpp https://git.reviewboard.kde.org/r/118970/#comment42532 I'm slightly confused. You're using i18n everywhere else, but here you use translate? - Vishesh Handa On June 27, 2014, 4:55 a.m., Jeremy Whiting wrote

Review Request 118960: Add a test to print out KLauncher's autostart files

--- Added it in order to debug something. Seemed like a useful things have. Diffs - CMakeLists.txt 631b9d0 tests/CMakeLists.txt PRE-CREATION tests/autostarttest.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/118960/diff/ Testing --- Thanks, Vishesh Handa

Re: Review Request 118783: Set the normal shortcut when setting the default shortcut as well

/118783/diff/ Testing --- Thanks, Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118844: Introduce convenient methods to set active and default shortcut

On June 20, 2014, 11:17 a.m., Vishesh Handa wrote: I approve. The only problem I have is with the documentation, but we can improve that in another patch. Martin Gräßlin wrote: well let's improve directly. What do you think is missing with these new methods or is that more

KGlobalAccel Problems

minor Issues - KXmlGui - KShortcutEditor seems to have some fixmes for KDE5. Do we want to do fix those? Perhaps someone should go through all the frameworks and make these changes or remove the comments? -- Vishesh Handa ___ Kde-frameworks-devel

  1   2   >