D14457: Forward-declare X509 structure

dfaure closed this revision. dfaure added a comment. Fix pushed as https://commits.kde.org/kdelibs4support/c3fe9344a8e7be1347e97523da19b5395ce9b3db REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D14457 To: luc4, #frameworks, cfeck, dfaure Cc: dfaure,

D14457: Forward-declare X509 structure

luc4 edited the summary of this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D14457 To: luc4, #frameworks, cfeck, dfaure Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14457: Forward-declare X509 structure

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK, now we're getting somewhere. If ssl-dev isn't installed, this code is compiled without SSL support, and fails ksslcertificate.h:387:18: error: ‘X509’ has not been declared

D14457: Forward-declare X509 structure

luc4 added a comment. When QT_NO_OPENSSL is defined, I see that X509 was declared as a class, so I used the same instruction. In ksslconfig.h I have `#define KSSL_HAVE_SSL 0`. I don't know if I can recovery much more output, the build succeeded days ago. Unfortunately I'm not an expert

D14457: Forward-declare X509 structure

dfaure added a comment. The reason I don't like it, is that X509 isn't a class ;-) Here in ksslconfig.h (generated file) I have `#define KSSL_HAVE_SSL 1`. Why is `find_package(OpenSSL)` failing for you? Any output from cmake? REPOSITORY R239 KDELibs4Support REVISION DETAIL

D14457: Forward-declare X509 structure

luc4 added a comment. In D14457#304135 , @dfaure wrote: > Can you explain why in the commit log, not just what? The diff tells us what already, but why? I assume this fixes a compilation error? Which one, on which platform? Thanks.

D14457: Forward-declare X509 structure

luc4 edited the summary of this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D14457 To: luc4, #frameworks, cfeck, dfaure Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14457: Forward-declare X509 structure

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Can you explain why in the commit log, not just what? The diff tells us what already, but why? I assume this fixes a compilation error? Which one, on which platform? Thanks.

D14457: Forward-declare X509 structure

ngraham added reviewers: Frameworks, cfeck. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D14457 To: luc4, #frameworks, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14457: Forward-declare X509 structure

luc4 retitled this revision from "Forward-define X509 structure" to "Forward-declare X509 structure". luc4 edited the summary of this revision. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D14457 To: luc4 Cc: kde-frameworks-devel, michaelh, ngraham, bruns