D14457: Forward-declare X509 structure

[David Faure]

dfaure closed this revision.
dfaure added a comment.


  Fix pushed as 
https://commits.kde.org/kdelibs4support/c3fe9344a8e7be1347e97523da19b5395ce9b3db

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D14457

To: luc4, #frameworks, cfeck, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14457: Forward-declare X509 structure

[Luca Carlon]

luc4 edited the summary of this revision.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D14457

To: luc4, #frameworks, cfeck, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14457: Forward-declare X509 structure

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  OK, now we're getting somewhere.
  If ssl-dev isn't installed, this code is compiled without SSL support, and 
fails
  
ksslcertificate.h:387:18: error: ‘X509’ has not been declared
 void setCert(X509 *c);
  ^~~~
  
  The implementation uses KSSL_HAVE_SSL around any use of X509, so the forward 
declaration is just for the headers to compile.
  
  Can you just add a note in the commit log that this is for the case where the 
openssl headers are missing.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D14457

To: luc4, #frameworks, cfeck, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14457: Forward-declare X509 structure

[Luca Carlon]

luc4 added a comment.


  When QT_NO_OPENSSL is defined, I see that X509 was declared as a class, so I 
used the same instruction.
  In ksslconfig.h I have `#define KSSL_HAVE_SSL 0`. I don't know if I can 
recovery much more output, the build succeeded days ago.
  Unfortunately I'm not an expert of this section, but I see that libssl-dev is 
not installed. Maybe that made find() fail?
  In any case, if that dep is optional, I guess the build is not supposed to 
fail, is it?

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D14457

To: luc4, #frameworks, cfeck, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14457: Forward-declare X509 structure

[David Faure]

dfaure added a comment.


  The reason I don't like it, is that X509 isn't a class ;-)
  
  Here in ksslconfig.h (generated file) I have `#define KSSL_HAVE_SSL 1`. Why 
is `find_package(OpenSSL)` failing for you? Any output from cmake?

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D14457

To: luc4, #frameworks, cfeck, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14457: Forward-declare X509 structure

[Luca Carlon]

luc4 added a comment.


  In D14457#304135 , @dfaure wrote:
  
  > Can you explain why in the commit log, not just what? The diff tells us 
what already, but why? I assume this fixes a compilation error? Which one, on 
which platform? Thanks.
  
  
  Unfortunately it would take some time to determine what changed that made 
this mandatory for me. Maybe some header changed in the hierarchy and the 
declaration is no more included anymore? Anyway, I cannot build it without 
declaring it. I'm building in docker using kdeneon/plasma:dev-unstable.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D14457

To: luc4, #frameworks, cfeck, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14457: Forward-declare X509 structure

[Luca Carlon]

luc4 edited the summary of this revision.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D14457

To: luc4, #frameworks, cfeck, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14457: Forward-declare X509 structure

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Can you explain why in the commit log, not just what? The diff tells us what 
already, but why? I assume this fixes a compilation error? Which one, on which 
platform? Thanks.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D14457

To: luc4, #frameworks, cfeck, dfaure
Cc: dfaure, kde-frameworks-devel, michaelh, ngraham, bruns

D14457: Forward-declare X509 structure

[Nathaniel Graham]

ngraham added reviewers: Frameworks, cfeck.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D14457

To: luc4, #frameworks, cfeck
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14457: Forward-declare X509 structure

[Luca Carlon]

luc4 retitled this revision from "Forward-define X509 structure" to 
"Forward-declare X509 structure".
luc4 edited the summary of this revision.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D14457

To: luc4
Cc: kde-frameworks-devel, michaelh, ngraham, bruns