D24663: Use ECMGenerateExportHeader to manage deprecated API better

zzag added a comment. In D24663#549764 , @kossebau wrote: > @zzag Hi. Any chance you can have time to review this today/the WE? One of the last ECMGenerateExportHeader patches. Hi, sorry for the late response. Yes, I think this change

D24663: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. In D24663#550883 , @romangg wrote: > It's ok that you pushed. Can you give a link to your preferred resource for me to read up on ECMGenerateExportHeader? Not too comprehensive if possible. For one there are the

D24663: Use ECMGenerateExportHeader to manage deprecated API better

romangg added a comment. It's ok that you pushed. Can you give a link to your preferred resource for me to read up on ECMGenerateExportHeader? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24663 To: kossebau, #kwin Cc: romangg, zzag, kde-frameworks-devel,

D24663: Use ECMGenerateExportHeader to manage deprecated API better

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:1fb1906ac5c2: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO

D24663: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. Reviewed myself once more and will be pushing now, given this is fairly straightforward after all, so the KF_* flags can be enabled next. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24663 To: kossebau, #kwin Cc: zzag,

D24663: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. @zzag Hi. Any chance you can have time to review this today/the WE? One of the last ECMGenerateExportHeader patches. I would be happy if we could have all in ASAP so we can enable the KF_* macros and test them in git master for two weeks before 5.64 gets tagged

D24663: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > zzag wrote in plasmawindowmanagement_interface.cpp:741 > Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in > KWAYLANDSERVER_ENABLE_DEPRECATED_SINCE in the header file. > > Is there a reason not to use

D24663: Use ECMGenerateExportHeader to manage deprecated API better

zzag edited reviewers, added: KWin; removed: Plasma. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24663 To: kossebau, #kwin, #plasma Cc: zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24663: Use ECMGenerateExportHeader to manage deprecated API better

zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement_interface.cpp:741 > > -#ifndef KWAYLANDSERVER_NO_DEPRECATED > void PlasmaWindowInterface::setVirtualDesktop(quint32 desktop) Hmm, PlasmaWindowInterface::setVirtualDesktop is wrapped in

D24663: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KWayland to hide deprecated API up to a given