davidedmundson added a comment.
The component changes seem unrelated
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D27200
To: mart, bshah, #plasma
Cc: davidedmundson, apol, kde-frameworks-devel, LeGast00n, cblack, GB_2,
michaelh, ngraham, bruns
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:68a273aef6c1: Make the attached property a simple QObject
(authored by mart).
CHANGED PRIOR TO COMMIT
apol added a comment.
LGTM otherwise
INLINE COMMENTS
> colorscope.cpp:57
> +connect(parentItem, ::windowChanged,
> this, [this]() {
> findParentScope();
let's make this a proper method? it's used twice here and a normal method
should be quicker to use
nicolasfella retitled this revision from "Make the attached proeprty a simple
QObject" to "Make the attached property a simple QObject".
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D27200
To: mart, bshah, #plasma
Cc: kde-frameworks-devel,
