D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness

2017-08-08 Thread Aleix Pol Gonzalez 
apol added inline comments.

INLINE COMMENTS

> CMakeLists.txt:15
>  if(APPLE)
> -target_link_libraries(testtrash "-framework DiskArbitration -framework 
> CoreFoundation")
> +set(testtrash_APPLE_LIBS "-framework DiskArbitration -framework 
> CoreFoundation")
>  endif(APPLE)

Note that `target_link_libraries` can still be used with ecm_add_test.
I'd say it's better for readability to use the commands rather than passing 
cmake variables around.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7213

To: asturmlechner, #frameworks, kfunk
Cc: apol, kfunk

D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness

2017-08-08 Thread Andreas Sturmlechner 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:dec4afb4145b: Use ecm_add_test and benefit from 
BUILD_TESTING awareness (authored by asturmlechner).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7213?vs=17908=17909

REVISION DETAIL
  https://phabricator.kde.org/D7213

AFFECTED FILES
  src/ioslaves/trash/tests/CMakeLists.txt

To: asturmlechner, #frameworks, kfunk
Cc: kfunk

D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness

2017-08-08 Thread Kevin Funk 
kfunk accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7213

To: asturmlechner, #frameworks, kfunk
Cc: kfunk

D7213: Use ecm_add_test and benefit from BUILD_TESTING awareness

2017-08-08 Thread Andreas Sturmlechner 
asturmlechner created this revision.
Restricted Application added a project: Frameworks.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7213

AFFECTED FILES
  src/ioslaves/trash/tests/CMakeLists.txt

To: asturmlechner, #frameworks
Cc: kfunk