Re: Review Request 116650: Remove unused targets from KDocToolsMacros.cmake

2014-03-10 Thread Aleix Pol Gonzalez

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116650/
---

(Updated March 10, 2014, 4:16 p.m.)


Review request for Build System and KDE Frameworks.


Changes
---

My patch was indeed very wrong. Attempt 2:

Use the full path to create the targets, rather than just the directory name.


Repository: kdoctools


Description
---

While porting the documentation in kde-runtime I realized there was an error 
because when running cmake it would try to create different targets and some of 
them would have the same name (e.g. there is kcm/bookmarks and kio/bookmarks, 
and it uses the directory name to figure out the filename).

I would have fixed that, but then I realised it was not running any command and 
nothing depended on it. Am I missing something?


Diffs (updated)
-

  KF5DocToolsMacros.cmake 6567b67 

Diff: https://git.reviewboard.kde.org/r/116650/diff/


Testing
---

Now kde-runtime documentation builds.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 116650: Remove unused targets from KDocToolsMacros.cmake

2014-03-08 Thread Luigi Toscano

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116650/#review52420
---


 I would have fixed that, but then I realised it was not running any command 
 and nothing depended on it. Am I missing something?

It is added to the all target; without this new target, docbooks (and 
manpages) are not generated at all. Could you please send me the log of the 
successfull compilation of kde-runtime?  

In fact, when I apply the patch to kdoctools I get:
[...]
[ 61%] Automoc for target meinproc5
[ 61%] Built target meinproc5_automoc
[100%] Built target meinproc5
Install the project...
-- Install configuration: debug
-- Installing: 
/opt/kf5/lib/x86_64-linux-gnu/cmake/KF5DocTools/KF5DocToolsTargets.cmake
-- Installing: 
/opt/kf5/lib/x86_64-linux-gnu/cmake/KF5DocTools/KF5DocToolsTargets-debug.cmake
-- Installing: 
/opt/kf5/lib/x86_64-linux-gnu/cmake/KF5DocTools/KF5DocToolsConfig.cmake
-- Installing: 
/opt/kf5/lib/x86_64-linux-gnu/cmake/KF5DocTools/KF5DocToolsConfigVersion.cmake
-- Installing: /opt/kf5/bin/checkXML5
-- Up-to-date: 
/opt/kf5/lib/x86_64-linux-gnu/cmake/KF5DocTools/KF5DocToolsMacros.cmake
CMake Error at docs/checkXML5/cmake_install.cmake:36 (FILE):
  file INSTALL cannot find
  /opt/build-kf5/frameworks/kdoctools/docs/checkXML5/checkXML5.1.
Call Stack (most recent call first):
  docs/cmake_install.cmake:37 (INCLUDE)
  cmake_install.cmake:71 (INCLUDE)


make: *** [install] Error 1

It seems that in the past multiple targets were allowed (thanks Pino for the 
hint). 
If this analysis is true, I guess ${_targ} should be fixed by adding the parent 
directory too.


KF5DocToolsMacros.cmake
https://git.reviewboard.kde.org/r/116650/#comment37094

It is needed indeed...


- Luigi Toscano


On March 7, 2014, 3:05 p.m., Aleix Pol Gonzalez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/116650/
 ---
 
 (Updated March 7, 2014, 3:05 p.m.)
 
 
 Review request for Build System and KDE Frameworks.
 
 
 Repository: kdoctools
 
 
 Description
 ---
 
 While porting the documentation in kde-runtime I realized there was an error 
 because when running cmake it would try to create different targets and some 
 of them would have the same name (e.g. there is kcm/bookmarks and 
 kio/bookmarks, and it uses the directory name to figure out the filename).
 
 I would have fixed that, but then I realised it was not running any command 
 and nothing depended on it. Am I missing something?
 
 
 Diffs
 -
 
   KF5DocToolsMacros.cmake 6567b67 
 
 Diff: https://git.reviewboard.kde.org/r/116650/diff/
 
 
 Testing
 ---
 
 Now kde-runtime documentation builds.
 
 
 Thanks,
 
 Aleix Pol Gonzalez
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel