Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: knotifications Description --- [StatusNotifier] Don't set custom window flags on ContextMenu A QMenu has proper default flags with BypassWindowManagerHint. Thus all the setting of hints and force activate is not needed. Also it takes care of grabbing keyboard and pointer in this case resulting in the popup being closed when clicked outside. This fixes interaction problems with Klipper. Diffs - src/kstatusnotifieritemdbus_p.cpp 0073afacfc3c0a5b6164e0e777471e1d5ea3cb43 Diff: https://git.reviewboard.kde.org/r/118200/diff/ Testing --- Klipper properly grabs the pointer and clicking outside Klipper's context menu, ends it. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58139 --- looks fine. can you try it also on an item that uses dbusmenu for menus, like kmix? - Marco Martin On May 19, 2014, 10:56 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/ --- (Updated May 19, 2014, 10:56 a.m.) Review request for KDE Frameworks, Plasma and Marco Martin. Repository: knotifications Description --- [StatusNotifier] Don't set custom window flags on ContextMenu A QMenu has proper default flags with BypassWindowManagerHint. Thus all the setting of hints and force activate is not needed. Also it takes care of grabbing keyboard and pointer in this case resulting in the popup being closed when clicked outside. This fixes interaction problems with Klipper. Diffs - src/kstatusnotifieritemdbus_p.cpp 0073afacfc3c0a5b6164e0e777471e1d5ea3cb43 Diff: https://git.reviewboard.kde.org/r/118200/diff/ Testing --- Klipper properly grabs the pointer and clicking outside Klipper's context menu, ends it. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu
On May 19, 2014, 1:06 p.m., Marco Martin wrote: looks fine. can you try it also on an item that uses dbusmenu for menus, like kmix? I just tried kmix and it looks fine to me on both left and right click. Both menus behave like I would expect (override redirect, grabbing pointer/keyboard). - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58139 --- On May 19, 2014, 12:56 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/ --- (Updated May 19, 2014, 12:56 p.m.) Review request for KDE Frameworks, Plasma and Marco Martin. Repository: knotifications Description --- [StatusNotifier] Don't set custom window flags on ContextMenu A QMenu has proper default flags with BypassWindowManagerHint. Thus all the setting of hints and force activate is not needed. Also it takes care of grabbing keyboard and pointer in this case resulting in the popup being closed when clicked outside. This fixes interaction problems with Klipper. Diffs - src/kstatusnotifieritemdbus_p.cpp 0073afacfc3c0a5b6164e0e777471e1d5ea3cb43 Diff: https://git.reviewboard.kde.org/r/118200/diff/ Testing --- Klipper properly grabs the pointer and clicking outside Klipper's context menu, ends it. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58142 --- Ship it! Ship It! - Marco Martin On May 19, 2014, 10:56 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/ --- (Updated May 19, 2014, 10:56 a.m.) Review request for KDE Frameworks, Plasma and Marco Martin. Repository: knotifications Description --- [StatusNotifier] Don't set custom window flags on ContextMenu A QMenu has proper default flags with BypassWindowManagerHint. Thus all the setting of hints and force activate is not needed. Also it takes care of grabbing keyboard and pointer in this case resulting in the popup being closed when clicked outside. This fixes interaction problems with Klipper. Diffs - src/kstatusnotifieritemdbus_p.cpp 0073afacfc3c0a5b6164e0e777471e1d5ea3cb43 Diff: https://git.reviewboard.kde.org/r/118200/diff/ Testing --- Klipper properly grabs the pointer and clicking outside Klipper's context menu, ends it. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58144 --- This review has been submitted with commit c5c34851dc410aa14663cf3d8d0ea14fd061d31b by Martin Gräßlin to branch master. - Commit Hook On May 19, 2014, 10:56 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/ --- (Updated May 19, 2014, 10:56 a.m.) Review request for KDE Frameworks, Plasma and Marco Martin. Repository: knotifications Description --- [StatusNotifier] Don't set custom window flags on ContextMenu A QMenu has proper default flags with BypassWindowManagerHint. Thus all the setting of hints and force activate is not needed. Also it takes care of grabbing keyboard and pointer in this case resulting in the popup being closed when clicked outside. This fixes interaction problems with Klipper. Diffs - src/kstatusnotifieritemdbus_p.cpp 0073afacfc3c0a5b6164e0e777471e1d5ea3cb43 Diff: https://git.reviewboard.kde.org/r/118200/diff/ Testing --- Klipper properly grabs the pointer and clicking outside Klipper's context menu, ends it. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
