[Differential] [Commented On] D4142: Support "default actions", as specified in [1].

2017-01-16 Thread Thomas Pfeiffer
colomar added a comment. >>>! In https://phabricator.kde.org/D4142#77861, @colomar wrote: >> Hm, that's not easy to decide. Whether one likes the "click to make go away" behavior or not is highly subjective. I, for one, find it very annoying on e.g. OS when a notification covers

[Differential] [Commented On] D4142: Support "default actions", as specified in [1].

2017-01-16 Thread Albert Vaca Cintora
albertvaka added a comment. In https://phabricator.kde.org/D4142#77834, @broulik wrote: > Care needs to be taken that existing notifications don't suddenly behave differently but that moving from actions() to defaultAction() is a conscious and explicit choice in the application that

[Differential] [Commented On] D4142: Support "default actions", as specified in [1].

2017-01-16 Thread Kai Uwe Broulik
broulik added a comment. > and there is no way to make it go away other than waiting. There's still the (x) button in the corner. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D4142 EMAIL PREFERENCES

[Differential] [Commented On] D4142: Support "default actions", as specified in [1].

2017-01-16 Thread Thomas Pfeiffer
colomar added a comment. Hm, that's not easy to decide. Whether one likes the "click to make go away" behavior or not is highly subjective. I, for one, find it very annoying on e.g. OS when a notification covers something I want to see on the screen and there is no way to make it go away

[Differential] [Commented On] D4142: Support "default actions", as specified in [1].

2017-01-16 Thread Kai Uwe Broulik
broulik added a comment. I always hated that clicking the notification popup just closed the popup without doing anything. While our users are probably used to always having a visible "Open" or similar button, I think this makes sense to have. Care needs to be taken that existing

[Differential] [Commented On] D4142: Support "default actions", as specified in [1].

2017-01-16 Thread Marco Martin
mart added a comment. code wise the change makes sense.. that said, this assumes we do an important behavior change in our ui, which i don't think is a good thing, as is disregards completely how our users are used to, in the name of "other platforms do things differently". so OK for the