D10075: Make pacakge usefull for cross compilation

2018-04-21 Thread Sandro Knauß
knauss added inline comments. INLINE COMMENTS > cgiboudeaux wrote in CMakeLists.txt:45 > the 3rd parameter is a bool. This change won't do what you expect. > > (https://cmake.org/cmake/help/v3.0/command/option.html) well it compiles like I expected it... but yeah I see this is a bug not a feat

D10075: Make pacakge usefull for cross compilation

2018-01-24 Thread Christophe Giboudeaux
cgiboudeaux added inline comments. INLINE COMMENTS > CMakeLists.txt:45 > > -set(KAUTH_HELPER_INSTALL_DIR "${KDE_INSTALL_LIBEXECDIR}/kauth") > +option(KAUTH_HELPER_INSTALL_DIR "Set directory for kauth helper tool" > "${KDE_INSTALL_LIBEXECDIR}/kauth") > the 3rd parameter is a bool. This chang

D10075: Make pacakge usefull for cross compilation

2018-01-24 Thread Sandro Knauß
knauss added a comment. @skelly: IMO it makes sense to discuss also the needed change in ECM, to solve the issue popperly. Just a side note - me personally is not very deep into the cross compilation topic. That's why I can understand, if you have many questions and do not get it, why t

D10075: Make pacakge usefull for cross compilation

2018-01-24 Thread Sandro Knauß
knauss added reviewers: Frameworks, skelly. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D10075 To: knauss, #frameworks, skelly Cc: #frameworks

D10075: Make pacakge usefull for cross compilation

2018-01-24 Thread Sandro Knauß
knauss created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. knauss requested review of this revision. REVISION SUMMARY kauth-gen-policy appears to be a tool for turning a text file in qsettings format (similar to .ini