D10617: Fix "ambiguous shortcut" issue introduced with D10314

markg added a comment. In D10617#208703 , @elvisangelaccio wrote: > In D10617#208513 , @ngraham wrote: > > > The shortcut won't affect other apps since the file dialog its its own context. Even if

D10617: Fix "ambiguous shortcut" issue introduced with D10314

elvisangelaccio added a comment. In D10617#208513 , @ngraham wrote: > The shortcut won't affect other apps since the file dialog its its own context. Even if the host app uses F12 for something, the file dialog will grab the key first, so there'

D10617: Fix "ambiguous shortcut" issue introduced with D10314

ngraham added a comment. The shortcut won't affect other apps since the file dialog its its own context. Even if the host app uses F12 for something, the file dialog will grab the key first, so there's no "ambiguous shortcut" issue. That said, I'm not wedded to F12 by any stretch of the

D10617: Fix "ambiguous shortcut" issue introduced with D10314

elvisangelaccio added a comment. Would be nice to get more feedback before choosing a shortcut that affects many applications. I don't think that F12 is a good choice. The F keys are few and some of them are already taken (Help, Rename, Reload, Fullscreen - and yes, it's bad that dolphi

D10617: Fix "ambiguous shortcut" issue introduced with D10314

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c2a80e71b39d: Fix "ambiguous shortcut" issue introduced with D10314 (authored by ngraham). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10617?vs=27428&id=27430 REVIS

D10617: Fix "ambiguous shortcut" issue introduced with D10314

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY R241 KIO BRANCH solve-file-dialog-ambiguous-shortcut-issue (branched from master) REVISION DETAIL https://phabricator.kde.org/D10617 To: ngraham, #framewo

D10617: Fix "ambiguous shortcut" issue introduced with D10314

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10617 To: ngraham, #frameworks, #dolphin, markg, elvisangelaccio Cc: michaelh

D10617: Fix "ambiguous shortcut" issue introduced with D10314

ngraham created this revision. ngraham added reviewers: Frameworks, Dolphin, markg, elvisangelaccio. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY My patch D10314 was insufficiently tested (so