D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven abandoned this revision. meven added a comment. Abandoned in favor of D24962 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, dfaure, ngraham, #dolphin, jtamate Cc: kde-frameworks-devel, jtamate, mar

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven added a comment. Here is the script I have been using : https://gist.github.com/meven/f0b2a36c61240e1d6e19753afd1d3d68 My benchmark logic is : Create a folder with x files of k sizes. Copy this folder. Delete this folder using kfmclient, measuring the elapsed time I have

D10702: Always use a job to delete files to avoid freezing process waiting on IO

markg added a comment. In D10702#273040 , @meven wrote: > Great suggestion Mark ! > > I am a C++ beginner, I did not consider this neat C++ 14 feature. > > This will necessitate a c++ compiler dependency change though. > Like Kwin did l

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven added a comment. Great suggestion Mark ! I am a C++ beginner, I did not consider this neat C++ 14 feature. This will necessitate a c++ compiler dependency change though. Like Kwin did last July https://github.com/KDE/kwin/commit/ea5d611de1bc33869c13c27d75a7827201a5139d >

D10702: Always use a job to delete files to avoid freezing process waiting on IO

markg added a comment. In D10702#272901 , @meven wrote: > Here is the script I have been using : https://gist.github.com/meven/f0b2a36c61240e1d6e19753afd1d3d68 > > My benchmark logic is : > Create a folder with x files of k sizes. > Cop

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven added a comment. Restricted Application added a subscriber: kde-frameworks-devel. In D10702#242143 , @dfaure wrote: > s/thread/process/. It's not about threads it's about two processes: the (GUI) application, and the kioslave. > > But y

D10702: Always use a job to delete files to avoid freezing process waiting on IO

jtamate added a comment. > The current state is that it freezes as long as the file deletion (unlink) lasts. Ok, let's go for it. Another use case when this could be useful is when the filesystem is slow, one possible way to know if this is the case is using something like bo

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven added a comment. In D10702#243605 , @jtamate wrote: > This freezing process happens for me in ktorrent the first time in a day I delete a file, but not the files after, even if they are iso images (>4GiB). > Are we sure the problem is he

D10702: Always use a job to delete files to avoid freezing process waiting on IO

jtamate added a comment. This freezing process happens for me in ktorrent the first time in a day I delete a file, but not the files after, even if they are iso images (>4GiB). Are we sure the problem is here and not in the notification step, for example loading the sound data and starting

D10702: Always use a job to delete files to avoid freezing process waiting on IO

dfaure added a comment. s/thread/process/. It's not about threads it's about two processes: the (GUI) application, and the kioslave. But you present all this in a rather convoluted way, it's much simpler. The SimpleJob for asking a kioslave to delete a file is KIO::file_delete which exa

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven added a comment. In term of comparison to the FileCopyJob for instance, the difference I can spot with the DeleteJob implementation, is that the FileCopyJobPrivate itselft instanciates a subJob in this case a DirectCopyJob that will do the work, using internally SimpleJobPrivate. Thi

D10702: Always use a job to delete files to avoid freezing process waiting on IO

markg added a comment. In D10702#213845 , @dfaure wrote: > "unlink() in most of the modern filesystems is not affected by the size of the file" doesn't match my experience, I have seen konqueror/dolphin freeze for 10s while deleting a 8GB file (

D10702: Always use a job to delete files to avoid freezing process waiting on IO

dfaure requested changes to this revision. dfaure added a comment. "unlink() in most of the modern filesystems is not affected by the size of the file" doesn't match my experience, I have seen konqueror/dolphin freeze for 10s while deleting a 8GB file (on a somewhat old system, no SSD). And t

D10702: Always use a job to delete files to avoid freezing process waiting on IO

markg added a comment. In D10702#212753 , @meven wrote: > In D10702#211236 , @markg wrote: > > > While this might give you the expected result, it feels like a workaround. > > > > I'm assuming the

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven added a comment. In D10702#211236 , @markg wrote: > While this might give you the expected result, it feels like a workaround. > > I'm assuming the fast path is there for a reason and is really substantially faster then going through th

D10702: Always use a job to delete files to avoid freezing process waiting on IO

jtamate requested changes to this revision. jtamate added a comment. This revision now requires changes to proceed. My guess is that the problem is not in the direct delete of local files. In fact, unlink() in most of the modern filesystems is not affected by the size of the file and is quit

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, dfaure, ngraham, #dolphin Cc: markg, ngraham, #frameworks, michaelh

D10702: Always use a job to delete files to avoid freezing process waiting on IO

markg added a comment. While this might give you the expected result, it feels like a workaround. I'm assuming the fast path is there for a reason and is really substantially faster then going through the job route. If that is the case then the proper fix would be to make that code part

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, dfaure, ngraham, #dolphin Cc: ngraham, #frameworks, michaelh

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven updated this revision to Diff 27716. meven added a comment. Always use a job to delete files to avoid freezing process waiting on IOX REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10702?vs=27648&id=27716 BRANCH bug-390748-make-kio-delete-asynchronous

D10702: Always use a job to delete files to avoid freezing process waiting on IO

meven retitled this revision from "BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO" to "Always use a job to delete files to avoid freezing process waiting on IO". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #framewo