This revision was automatically updated to reflect the committed changes.
Closed by commit R242:98e64e01a611: Templates: consistent naming, fix
translation catalog names more (authored by kossebau).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
kossebau updated this revision to Diff 34574.
kossebau added a comment.
add comment about the need to adapt org.kde.plasma namespace
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10848?vs=28085=34574
BRANCH
brushovertemplates
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
Restricted Application edited subscribers, added: kde-frameworks-devel;
removed: Frameworks.
good to go, modulo that possible little code comment more
INLINE COMMENTS
> kossebau wrote in
kossebau added inline comments.
INLINE COMMENTS
> apol wrote in metadata.desktop:88
> I'm not sure, if a 3rd party makes a plasmoid they would call it otherwise.
> Are we assuming these templates are only for KDE?
Ideally the kapptemplate system would have support for an organization domain
apol added inline comments.
INLINE COMMENTS
> metadata.desktop:88
> X-KDE-PluginInfo-Email=%{EMAIL}
> -X-KDE-PluginInfo-Name=%{APPNAMELC}
> +X-KDE-PluginInfo-Name=org.kde.plasma.%{APPNAMELC}
> X-KDE-PluginInfo-Version=1.0
I'm not sure, if a 3rd party makes a plasmoid they would call it
kossebau created this revision.
kossebau added a reviewer: mart.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.
REVISION SUMMARY
- remove unneeded cmake includes
- consistently use
