D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D11176#291740 , @bcooksley 
wrote:
  
  > This change has broken the build of all projects that make use of pmap 
resources on Windows, as the Python path at build time is not necessarily the 
path at install time (and it definitely not on the Binary Factory nodes)
  >  In particular it breaks KGeography - see 
https://binary-factory.kde.org/job/KGeography_Nightly_win32/112/console
  
  
  FTR, this should be fixed by 
https://cgit.kde.org/ki18n.git/commit/?id=c5b721dc1753f8ca3c5af06169425751379f635f
  
  Tests ran successfully:
  
  - Building ki18n, running ctest,
  - Applying the change to ki18n 5.48.0, building, running ctest

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11176

To: cgiboudeaux
Cc: bcooksley, kde-frameworks-devel, sitter, dfaure, #build_system, michaelh, 
ngraham, bruns

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[Ben Cooksley]

bcooksley added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  This change has broken the build of all projects that make use of pmap 
resources on Windows, as the Python path at build time is not necessarily the 
path at install time (and it definitely not on the Binary Factory nodes)
  In particular it breaks KGeography - see 
https://binary-factory.kde.org/job/KGeography_Nightly_win32/112/console

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11176

To: cgiboudeaux
Cc: bcooksley, kde-frameworks-devel, sitter, dfaure, #build_system, michaelh, 
ngraham, bruns, #frameworks

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D11176#241716 , @dfaure wrote:
  
  > Reference: 
https://build.kde.org/view/Frameworks/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/24/testReport/(root)/TestSuite/ki18n_install/
 but also reproducible locally.
  
  
  Thanks for the report. *Fixed*

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11176

To: cgiboudeaux
Cc: sitter, dfaure, #build_system, #frameworks, michaelh, ngraham, bruns

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[David Faure]

dfaure added a comment.


  Reference: 
https://build.kde.org/view/Frameworks/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/24/testReport/(root)/TestSuite/ki18n_install/
 but also reproducible locally.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11176

To: cgiboudeaux
Cc: sitter, dfaure, #build_system, #frameworks, michaelh, ngraham, bruns

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[David Faure]

dfaure added a comment.


  This broke the unittest :
  
  c
  Internal cmake changing into directory: 
/d/kde/build/5/frameworks/ki18n/autotests/ki18n_install
  Error: cmake execution failed
  The C compiler identification is GNU 4.8.5
  The CXX compiler identification is GNU 5.3.1
  Check for working C compiler: /home/dfaure/bin/cc
  Configuring
  Check for working C compiler: /home/dfaure/bin/cc -- works
  Detecting C compiler ABI info
  Configuring
  Detecting C compiler ABI info - done
  Detecting C compile features
  Configuring
  Configuring
  Configuring
  Detecting C compile features - done
  Check for working CXX compiler: /home/dfaure/bin/c++
  Configuring
  Check for working CXX compiler: /home/dfaure/bin/c++ -- works
  Detecting CXX compiler ABI info
  Configuring
  Detecting CXX compiler ABI info - done
  Detecting CXX compile features
  Configuring
  Configuring
  Configuring
  Configuring
  Detecting CXX compile features - done
  CMake Error at CMakeLists.txt:4 (include):
  
include could not find load file:

  KF5I18NMacros
  
  CMake Error at CMakeLists.txt:6 (ki18n_install):
  
Unknown CMake command "ki18n_install".
  
  Configuring
  
  Thanks for having a look.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11176

To: cgiboudeaux
Cc: sitter, dfaure, #build_system, #frameworks, michaelh, ngraham, bruns

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In D11176#235843 , @sitter wrote:
  
  > @cgiboudeaux @dfaure
  
  
  [...]
  
  > This is gonna cause trouble major trouble for the next release.
  
  No, it's a very minor issue that's already fixed.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11176

To: cgiboudeaux
Cc: sitter, dfaure, #build_system, #frameworks, michaelh, ngraham

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[Harald Sitter]

sitter added subscribers: dfaure, sitter.
sitter added a comment.


  @cgiboudeaux @dfaure
  
  I am almost entirely certain this broke building of ki18n itself when *it* 
contains translations. Neon packs translations into git builds, so here's the 
failure:
  
https://build.neon.kde.org/job/xenial_unstable_kde_ki18n_bin_amd64/135/consoleText
  
  At a glance I'd say the change of `include(cmake/KF5I18NMacros.cmake)` to 
include `KI18n_BINARY_DIR` is to blame. Latter being the installation target 
directory it'd not be available at build time.
  
  This is gonna cause trouble major trouble for the next release.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11176

To: cgiboudeaux
Cc: sitter, dfaure, #build_system, #frameworks, michaelh, ngraham

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[Christophe Giboudeaux]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R249:6c1db934e648: Dont call PythonInterp.cmake in 
KF5I18NMacros. (authored by cgiboudeaux).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11176?vs=29074=30724

REVISION DETAIL
  https://phabricator.kde.org/D11176

AFFECTED FILES
  CMakeLists.txt
  cmake/KF5I18NMacros.cmake
  cmake/KF5I18NMacros.cmake.in

To: cgiboudeaux
Cc: #build_system, #frameworks, michaelh, ngraham

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  ping. Unless someone objects, I will push this change in a couple days.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11176

To: cgiboudeaux
Cc: #build_system, #frameworks, michaelh, ngraham

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  Disclaimer: I'm not really happy with this solution.
  
  The alternative is to call find_program(KI18N_PYTHON_EXECUTABLE) with a list 
of known names (python3.7 python3.6 python2.7 ...) and remove the 
find_package(PythonInterp) line.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11176

To: cgiboudeaux
Cc: #build_system, #frameworks, michaelh

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[Christophe Giboudeaux]

cgiboudeaux edited the test plan for this revision.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11176

To: cgiboudeaux
Cc: #build_system, #frameworks, michaelh

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[Christophe Giboudeaux]

cgiboudeaux added a project: Build System.
cgiboudeaux added a subscriber: Build System.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D11176

To: cgiboudeaux
Cc: #build_system, #frameworks, michaelh

D11176: Don't call PythonInterp.cmake in KF5I18NMacros.

[Christophe Giboudeaux]

cgiboudeaux created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
cgiboudeaux requested review of this revision.

REVISION SUMMARY
  Due to CMake caching the variables, anything depending on ki18n would be
  unable to call find_package(PythonInterp) with a specific version.
  
  Instead we just hardcode the python executable path.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11176

AFFECTED FILES
  CMakeLists.txt
  cmake/KF5I18NMacros.cmake
  cmake/KF5I18NMacros.cmake.in

To: cgiboudeaux
Cc: #frameworks, michaelh