kossebau added inline comments.
INLINE COMMENTS
> graesslin wrote in netwm.cpp:2845-2847
> I guess we need to fix this
Thanks for having done that :)
REPOSITORY
R278 KWindowSystem
REVISION DETAIL
https://phabricator.kde.org/D11414
To: graesslin, #frameworks, #kwin, #plasma,
graesslin added inline comments.
INLINE COMMENTS
> kossebau wrote in netwm.cpp:2845-2847
> Seems clang (at least as of FreeBSD with -Wc++11-narrowing) does not like
> this narrowing from the int topology properties to the uint32_t array one:
>
> 00:37:23
kossebau added inline comments.
INLINE COMMENTS
> netwm.cpp:2845-2847
> +const uint32_t data[5] = {
> +topology.top, topology.bottom, topology.left, topology.right, 1
> +};
Seems clang (at least as of FreeBSD with -Wc++11-narrowing) does not like this
narrowing from
This revision was automatically updated to reflect the committed changes.
Closed by commit R278:cc5d6fde1aba: [xcb] Fix implementation of
_NET_WM_FULLSCREEN_MONITORS (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D11414?vs=29760=30083#toc
REPOSITORY
R278
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R278 KWindowSystem
BRANCH
fix-fullscreen-monitors
REVISION DETAIL
https://phabricator.kde.org/D11414
To: graesslin, #frameworks, #kwin, #plasma, davidedmundson
Cc: michaelh, ngraham
graesslin created this revision.
graesslin added reviewers: Frameworks, KWin, Plasma.
Restricted Application added a project: Frameworks.
graesslin requested review of this revision.
REVISION SUMMARY
According to NETWM spec the client "wishing to change this list MUST send
a
