This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f1ab805c4ebc: Fix build on FreeBSD broken by
d7cce9937d5e9af2753fadb82d11f308b58bb8fa (authored by rominf).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
fix-ntfs-hidden-files-on-freebsd
REVISION DETAIL
https://phabricator.kde.org/D11716
To: rominf, #dolphin, kossebau, dfaure
Cc: ngraham, bcooksley, #frameworks, michaelh
ngraham added a comment.
@dfaure, is this good now?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D11716
To: rominf, #dolphin, kossebau, dfaure
Cc: ngraham, bcooksley, #frameworks, michaelh
bcooksley added a comment.
This change or an equivalent fix needs to be merged in relatively urgently as
it is now creating a maintainability issue for the CI system.
As a consequence of the breakage the Dependency Builds are failing and they
need to complete a successful run in order to
rominf updated this revision to Diff 30696.
rominf added a comment.
- Replace #ifdef with #if
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11716?vs=30629=30696
BRANCH
fix-ntfs-hidden-files-on-freebsd
REVISION DETAIL
https://phabricator.kde.org/D11716
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> file_unix.cpp:416
>
> -#ifdef Q_OS_LINUX
> +#ifdef HAVE_SYS_XATTR_H
> static bool isNtfsHidden(const QString )
should be #if, not #ifdef.
It's always
kossebau added a comment.
From quick pure code reading this looks fine to me. +1
Have not tested though right now, so have to leave the ship-it to actual
Dolphin/KIO maintainers.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D11716
To: rominf, #dolphin, kossebau,
rominf updated this revision to Diff 30629.
rominf added a comment.
- Consider criticism
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11716?vs=30627=30629
BRANCH
fix-ntfs-hidden-files-on-freebsd
REVISION DETAIL
https://phabricator.kde.org/D11716
kossebau added inline comments.
INLINE COMMENTS
> config-kioslave-file.h.cmake:14
> +/* Defined if system has extended file attributes support. */
> +#cmakedefine01 HAVE_SYS_XATTR_H
While FindACL.cmake sets internally the cmake variable HAVE_SYS_XATTR_H, it is
not part of the officially set
rominf updated this revision to Diff 30627.
rominf added a comment.
- Add a trailing newline to the end of the file
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11716?vs=30626=30627
BRANCH
fix-ntfs-hidden-files-on-freebsd
REVISION DETAIL
rominf updated this revision to Diff 30626.
rominf added a comment.
- Actualy fixing build
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11716?vs=30625=30626
BRANCH
fix-ntfs-hidden-files-on-freebsd
REVISION DETAIL
https://phabricator.kde.org/D11716
kossebau added a comment.
Thanks for coming up so quick with a fix :)
You surely wanted to also wrap the include of the "sys/xattr.h" header in the
new condition? Missing from the patch.
INLINE COMMENTS
> config-kioslave-file.h.cmake:15
> +#cmakedefine01 HAVE_SYS_XATTR_H
> \ No newline
rominf created this revision.
rominf added reviewers: Dolphin, kossebau, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
rominf requested review of this revision.
REVISION SUMMARY
Support hidden NTFS files only on OS that
13 matches
Mail list logo
