D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

2018-04-11 Thread Henrik Fehlauer
rkflx added a comment. In D12077#244313 , @ngraham wrote: > So the size is remembered per app, but the settings are global. That's... interesting. Not only that, but they are remembered per screen size, which means you can have different

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

2018-04-11 Thread Nathaniel Graham
ngraham updated this revision to Diff 31884. ngraham added a comment. Remove sorting menu button; will do that in a separate commit REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12077?vs=31848&id=31884 BRANCH show-view-mode-toggles-on-open-save-dialog-toolb

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

2018-04-11 Thread Nathaniel Graham
ngraham added a comment. In D12077#244309 , @rkflx wrote: > In D12077#244307 , @ngraham wrote: > > > Actually, the file is `~/.config/kdeglobals`, and the pertinent information is in the under the

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

2018-04-11 Thread Henrik Fehlauer
rkflx added a comment. In D12077#244307 , @ngraham wrote: > Actually, the file is `~/.config/kdeglobals`, and the pertinent information is in the under the `[KFileDialog Settings]` section. No, that's wrong: > cat ~/.config/katerc

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

2018-04-11 Thread Nathaniel Graham
ngraham added a comment. In D12077#244140 , @rkflx wrote: > I brought this up before, but let me repeat: It is of utmost importance to test with the default settings, i.e. default font size and default dialog size (remove `~/.config/kate*` for t

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

2018-04-11 Thread Henrik Fehlauer
rkflx added a comment. I brought this up before, but let me repeat: It is of utmost importance to test with the default settings, i.e. default font size and default dialog size (remove `~/.config/kate*` for that). Your current version does not look good, despite what you show in your screens

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

2018-04-10 Thread Nathaniel Graham
ngraham added a comment. I'm not thrilled about the dropdown menu button losing its an arrow when you make it activate-able with a regular click, but that's a Breeze issue (that I plan to fix soon...). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham,

D12077: Show view mode buttons and a sort menu in the open/save dialog's toolbar

2018-04-10 Thread Nathaniel Graham
ngraham retitled this revision from "Show toggle buttons in the toolbar for the two most commonly-used view modes in the file open/save dialogs" to "Show view mode buttons and a sort menu in the open/save dialog's toolbar". ngraham edited the summary of this revision. ngraham edited the test plan