ngraham added a comment.
It's not too hard to make the label and the "What's this?" text differ for
open vs save mode, which I've done here.
There's still the issue that the text doesn't quite fit in save mode, where
there's a filter but it's somewhat useless. I wonder: what good is the
ngraham updated this revision to Diff 32015.
ngraham added a comment.
Change the text only when saving (it really is a filter bar in open mode)
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12130?vs=31936=32015
BRANCH
file-format-label (branched from
ngraham planned changes to this revision.
ngraham added a comment.
Let's see if I can make this patch more intelligent, because the root of the
issue is that the same text field is used for different things in different
modes.
REPOSITORY
R241 KIO
REVISION DETAIL
ngraham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D12130
To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx
Cc: rkflx, alexeymin, abetts, bruns, michaelh, ngraham
rkflx requested changes to this revision.
rkflx added a comment.
This revision now requires changes to proceed.
> BUG: 79904
@bruns @alexeymin I'm not sure you have reviewed this change properly? This
bug is about "MacOS styled menus and remote X sessions". If you "Accept" a
revision,
alexeymin accepted this revision.
alexeymin added a comment.
+1, looks better
REPOSITORY
R241 KIO
BRANCH
file-format-label (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D12130
To: ngraham, #frameworks, #vdg, bruns, alexeymin
Cc: alexeymin, abetts, bruns,
abetts added a comment.
+1
REPOSITORY
R241 KIO
BRANCH
file-format-label (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D12130
To: ngraham, #frameworks, #vdg, bruns
Cc: abetts, bruns, michaelh, ngraham
bruns accepted this revision.
bruns added a comment.
This revision is now accepted and ready to land.
+1
REPOSITORY
R241 KIO
BRANCH
file-format-label (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D12130
To: ngraham, #frameworks, #vdg, bruns
Cc: bruns, michaelh,
ngraham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D12130
To: ngraham, #frameworks, #vdg
Cc: michaelh, ngraham, bruns
ngraham created this revision.
ngraham added reviewers: Frameworks, VDG.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.
REVISION SUMMARY
Time to fix a 14-year old wishlist bug! This patch uses the more
user-friendly string "File format" to
10 matches
Mail list logo
