D14137: CSS: update syntax and fix some errors
dhaumann added a comment. Thanks for pushing. Could you have a quick look at https://build.kde.org and search for "syntax-highlighting"? It seems the unit tests do not pass since this change, probably a minor issue: https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/57/ REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14137 To: jpoelen, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14137: CSS: update syntax and fix some errors
jpoelen added a comment. It is done. So much emotion :') REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14137 To: jpoelen, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14137: CSS: update syntax and fix some errors
This revision was automatically updated to reflect the committed changes. Closed by commit R216:423239c45ec5: CSS: update syntax and fix some errors (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14137?vs=37815=37912 REVISION DETAIL https://phabricator.kde.org/D14137 AFFECTED FILES autotests/folding/highlight.css.fold autotests/html/highlight.css.html autotests/html/review128925-1.css.html autotests/html/review128925-2.css.html autotests/html/test.htm.html autotests/input/highlight.css autotests/reference/highlight.css.ref autotests/reference/review128925-1.css.ref autotests/reference/review128925-2.css.ref autotests/reference/test.css.ref autotests/reference/test.htm.ref data/syntax/css.xml To: jpoelen, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14137: CSS: update syntax and fix some errors
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks like a nice update - thanks for your work. Can you 'arc land' yourself? :-) REPOSITORY R216 Syntax Highlighting BRANCH css REVISION DETAIL https://phabricator.kde.org/D14137 To: jpoelen, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann
D14137: CSS: update syntax and fix some errors
jpoelen created this revision. jpoelen added a reviewer: dhaumann. jpoelen added projects: Frameworks, Framework: Syntax Highlighting. Restricted Application added a project: Kate. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - fix tag followed by a pseudo-class in a nested rule (@media, ...) - fix constraint in a rule - fix Kate auto-completion for properties and rules New highlighting categories - Keyword - Operator - Separator Symbol - SpecialChar - Variable - Value Keyword - Color - Number - Unit - Selector Tag REPOSITORY R216 Syntax Highlighting BRANCH css REVISION DETAIL https://phabricator.kde.org/D14137 AFFECTED FILES autotests/folding/highlight.css.fold autotests/html/highlight.css.html autotests/html/review128925-1.css.html autotests/html/review128925-2.css.html autotests/html/test.htm.html autotests/input/highlight.css autotests/reference/highlight.css.ref autotests/reference/review128925-1.css.ref autotests/reference/review128925-2.css.ref autotests/reference/test.css.ref autotests/reference/test.htm.ref data/syntax/css.xml To: jpoelen, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars, dhaumann