chinmoyr closed this revision.
chinmoyr added a comment.
https://commits.kde.org/kio/14b29cf64611f91f0bc1f5828e4c86392510f0e6
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14464
To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: kde-frameworks-de
chinmoyr updated this revision to Diff 59748.
chinmoyr added a comment.
Updated frameworks version.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14464?vs=38714&id=59748
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14464
AFFECTED FILES
s
ngraham added a comment.
@chinmoyr can you address @dfaure's remaining comments so we can get this in?
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14464
To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: kde-frameworks-devel, L
dfaure added inline comments.
INLINE COMMENTS
> ngraham wrote in global.h:248
> 5.59 now
no, not that one, it was already there ;)
The line was only modified to add a comma.
> ngraham wrote in global.h:250
> 5.59 now
and a trailing comma (as allowed by C++11) so that it doesn't need to be
mod
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Needs a rebase on master and the @since strings adjusted, but otherwise looks
good to me.
INLINE COMMENTS
> global.h:248
> ERR_PASSWD_SERVER = KJob::UserDefinedError + 72, ///< retu
ngraham added reviewers: elvisangelaccio, Frameworks, Dolphin.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D14464
To: chinmoyr, dfaure, ngraham, elvisangelaccio, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
chinmoyr created this revision.
chinmoyr added reviewers: dfaure, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.
REVISION SUMMARY
If the target file (in case of chown, chmod
