kossebau added inline comments.
INLINE COMMENTS
> kfilterproxysearchline.h:48
>
> -class KITEMVIEWS_EXPORT KFilterProxySearchLine
> +class KITEMVIEWS_EXPORT KITEMVIEWS_DEPRECATED KFilterProxySearchLine
> : public QWidget
Why not KITEMVIEWS_DEPRECATED_EXPORT?
While being defined as `KITEM
This revision was automatically updated to reflect the committed changes.
Closed by commit R276:f5fef035e5a2: Deprecate KFilterProxySearchLine (authored
by svuorela).
REPOSITORY
R276 KItemViews
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14772?vs=39579&id=39580
REVISION DETAIL
dfaure accepted this revision.
REPOSITORY
R276 KItemViews
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14772
To: svuorela, kossebau, dfaure
Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns
svuorela updated this revision to Diff 39579.
svuorela added a comment.
Improve deprecation documentation
REPOSITORY
R276 KItemViews
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14772?vs=39528&id=39579
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14772
AFFEC
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
This class was doing it with a timer, I wonder if that should be part of the
recommendation ("use QLineEdit with a timer"), or if we don't recommend
delaying the searching as a general solu
vkrause added a comment.
+1, and also too narrow regarding being specific to QLineEdit and QSFPM. If
at all this should be just the logic, and be independent of the UI.
REPOSITORY
R276 KItemViews
REVISION DETAIL
https://phabricator.kde.org/D14772
To: svuorela, kossebau, dfaure
Cc: vkrau
svuorela created this revision.
svuorela added reviewers: kossebau, dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
svuorela requested review of this revision.
REVISION SUMMARY
It is too primitive and simple for anythin
