This revision was automatically updated to reflect the committed changes.
Closed by commit R241:518a7496c5c5: Warn user before copy/move job if the file
size exceeds the maximum possible… (authored by shubham).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D16249?vs=46490&id=46783#toc
RE
ngraham added a comment.
This can land now!
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: davidedmundson, elvisangelaccio, dfaure, cfeck, bruns,
kde-frameworks-devel, michaelh, ngraham
ngraham added a comment.
Awesome, can't wait to have this in!
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: davidedmundson, elvisangelaccio, dfaure, cfeck, bruns,
kde-frameworks-devel, michaelh, ngraham
shubham updated this revision to Diff 46490.
shubham added a comment.
Change to KF 5.54
Will land it after saturday. This patch actually missed 2 tagging (5.52 and
5.53)
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16249?vs=46235&id=46490
REVISION DETAIL
ngraham added a comment.
I agree. Because this contains new strings and we're so close to the 5.53
release, let's land this for Frameworks 5.54 after tagging.
@shubham I'm afraid this means you'll now need to change all the instances of
`5.53` to `5.54`! 😛 I know it's taken a long time,
davidedmundson added a comment.
Also +1 from me.
However, I would strongly suggest waiting till after Saturday when frameworks
is tagged.
Then you'll have a month for translators and for some testing.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shu
bruns accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh,
ngraham
shubham added a comment.
Waiting for green flags.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh,
ngraham
ngraham accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh,
ngraham
shubham added a comment.
"transferred" done
request @ngraham @dfaure @bruns to give thumbs up again.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel,
shubham marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh,
ngraham
shubham updated this revision to Diff 46235.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16249?vs=46174&id=46235
REVISION DETAIL
https://phabricator.kde.org/D16249
AFFECTED FILES
src/core/copyjob.cpp
src/core/global.h
src/core/job_error.cpp
To: shubha
bruns added inline comments.
INLINE COMMENTS
> bruns wrote in job_error.cpp:1079
> "transeferred"
"transeferred"? - not done ...
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, brun
shubham added a comment.
@bruns is it good to go?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh,
ngraham
ngraham accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh,
ngraham
dfaure accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh,
ngraham
shubham marked 2 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh,
ngraham
shubham updated this revision to Diff 46174.
shubham added a comment.
@since 5.53
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16249?vs=45951&id=46174
REVISION DETAIL
https://phabricator.kde.org/D16249
AFFECTED FILES
src/core/copyjob.cpp
src/core/glob
ngraham added a comment.
Sorry for the extended review time; I've found myself super busy with family
stuff during this vacation. :)
Please address Elvis' inline comment and then this will look good to me.
INLINE COMMENTS
> global.h:249
> +ERR_CANNOT_CREATE_SLAVE = KJob::UserDefined
shubham added a comment.
@ngraham @bruns do you have any objections?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: elvisangelaccio, dfaure, cfeck, bruns, kde-frameworks-devel, michaelh,
ngraham
elvisangelaccio added inline comments.
INLINE COMMENTS
> global.h:249
> +ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by
> Slave::createSlave, @since 5.30
> +ERR_FILE_TOO_LARGE_FOR_FAT32 = KJob::UserDefinedError + 74 ///< @since
> 5.52
> };
Should be bumped to 5.53
shubham added a comment.
@bruns @ngraham what's your view on this? Did you tested it out?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
dfaure accepted this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
shubham marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: dfaure, cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
shubham updated this revision to Diff 45951.
shubham added a comment.
- a
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16249?vs=45470&id=45951
BRANCH
fat
REVISION DETAIL
https://phabricator.kde.org/D16249
AFFECTED FILES
src/core/copyjob.cpp
src/cor
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> copyjob.cpp:1602
> QList::Iterator it = files.begin();
> +const auto fileSystem =
> KFileSystemType::fileSystemType(m_globalDest.toString());
>
shubham marked 3 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
shubham updated this revision to Diff 45470.
shubham retitled this revision from "Warn user before copy/move job if the file
size exceeds the maximum possible file size in FAT32 filesystem(4 GB) " to
"Warn user before copy/move job if the file size exceeds the maximum possible
file size in FAT32
shubham removed a reviewer: elvisangelaccio.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D16249
To: shubham, ngraham, #frameworks, bruns, elvisangelaccio
Cc: cfeck, bruns, kde-frameworks-devel, michaelh, ngraham
ngraham added a comment.
Uh-oh, now the patch doesn't apply for me anymore:
$ arc patch D16249
INFO Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D16249.
Checking patch src/core/job_error.cpp...
error: while searching f
shubham updated this revision to Diff 44712.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16249?vs=44710&id=44712
REVISION DETAIL
https://phabricator.kde.org/D16249
AFFECTED FILES
src/core/copyjob.cpp
src/core/global.h
src/core/job_error.cpp
To: shubha
ngraham added a comment.
Uh-oh, I think the latest update to this diff isn't quite correct. I see
unrelated changes that you didn't make being marked as additions.
You might try using `arc` in the future. It makes this process much simpler.
See
https://community.kde.org/Infrastructure/P
shubham retitled this revision from "Warn user before copy/move job if the file
size exceeds the maximum possible file size in FAT32 file system(4 GB) " to
"Warn user before copy/move job if the file size exceeds the maximum possible
file size in FAT32 filesystem(4 GB) ".
REPOSITORY
R241 KIO
33 matches
Mail list logo
