D16733: Capture package metadata before install start
joselema removed a commit: R242:ed1724c63e9f: Summary: After this commit https://cgit.kde.org/plasma-framework.git/commit/?. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D16733 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
D16733: Capture package metadata before install start
This revision was automatically updated to reflect the committed changes. Closed by commit R290:451b1785e8d0: Capture package metadata before install start (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D16733?vs=45026&id=45028#toc REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16733?vs=45026&id=45028 REVISION DETAIL https://phabricator.kde.org/D16733 AFFECTED FILES src/kpackage/private/packagejob.cpp To: davidedmundson, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
D16733: Capture package metadata before install start
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. I would add a comment saying "please don't call d->package from the lambda because it breaks". REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D16733 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
D16733: Capture package metadata before install start
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY KPackage (despite being supposedly internally shared) is not kept as a strong reference inside PackageJob. Potentially it could go out of scope before a job ends. The signals to emit changes relied on the package. This patch captures relevant metadata at the start of the install. noCrashOnAsyncInstall test now passes again TEST PLAN Ran test REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D16733 AFFECTED FILES src/kpackage/private/packagejob.cpp To: davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns