dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R244 KCoreAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16798
To: elvisangelaccio, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
elvisangelaccio marked an inline comment as done.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D16798
To: elvisangelaccio, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
elvisangelaccio edited the summary of this revision.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D16798
To: elvisangelaccio, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
elvisangelaccio updated this revision to Diff 45232.
elvisangelaccio added a comment.
- Address comment
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D16798?vs=45222&id=45232
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D16798
AFFECT
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kpluginfactory.h:347
> * Use this method to create an object. It will try to create an object
> which inherits
> - * \p T. If it has multiple choice
elvisangelaccio added a comment.
Note: I'm not 100% the code actually returns `nullptr`, so someone please
double check.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D16798
To: elvisangelaccio, dfaure, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
elvisangelaccio created this revision.
elvisangelaccio added reviewers: dfaure, apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
elvisangelaccio requested review of this revision.
REVISION SUMMARY
`kFatal()` is long gone and was not ported to `qFatal()`.
