D16815: Rename Sublime Text icon to ensure it works

[Noah Davis]

ndavis added a comment.


  In D16815#357570 , @ngraham wrote:
  
  > I know this is a bugfix, but...
  >
  > IMHO it's really bad form to design a Breeze version of an app icon that 
has a totally different visual style from the original--especially if it 
completely eliminates all the branding elements from the original. This icon 
should be a Breezey version of the original icon, not something totally 
different that erases the Sublime Text brand. This is obviously not your fault, 
but I'd like to see the icon improved before we fix this bug, or else IMHO it 
will actually be a visual regression for Sublime Text users.
  >
  > Really, the original mostly looks fine. A Breeze version should just 
harmonize the size with other square icons, reduce or eliminate the rounded 
corners, and maybe make some other very subtle changes. If we want to keep the 
parts of the current icon that depict a tabbed view, we could replace the lines 
of text with the orange S logo, or overlay it on top of them or something. I'm 
not sure if the tabbed view iconography is even necessary though.
  >
  > All of this could be done in the same patch if you have icon design skills 
and want to tackle that, or in a separate one if not.
  >
  > Oh, and thanks for the patch, and thanks for using `arc` to submit it! :)
  
  
  I'm guessing it was meant to make the Sublime Text icon look similar in style 
to the Kate and KWrite icons, but you're probably right that using an icon 
completely different from the official one isn't a good idea.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16815

To: trickyricky26, #vdg, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D16815: Rename Sublime Text icon to ensure it works

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.


  I know this is a bugfix, but...
  
  IMHO it's really bad form to design a Breeze version of an app icon that has 
a totally different visual style from the original--especially if it completely 
eliminates all the branding elements from the original. This icon should be a 
Breezey version of the original icon, not something totally different that 
erases the Sublime Text brand. This is obviously not your fault, but I'd like 
to see the icon improved before we fix this bug, or else IMHO it will actually 
be a visual regression for Sublime Text users.
  
  Really, the original mostly looks fine. A Breeze version should just 
harmonize the size with other square icons, reduce or eliminate the rounded 
corners, and maybe make some other very subtle changes. If we want to keep the 
parts of the current icon that depict a tabbed view, we could replace the lines 
of text with the orange S logo, or overlay it on top of them or something. I'm 
not sure if the tabbed view iconography is even necessary though.
  
  All of this could be done in the same patch if you have icon design skills 
and want to tackle that, or in a separate one if not.
  
  Oh, and thanks for the patch, and thanks for using `arc` to submit it! :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16815

To: trickyricky26, #vdg, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D16815: Rename Sublime Text icon to ensure it works

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  I got an error when I tried to land this patch:
  
remote: Audit failure - Commit 5fa9283264f511edf5678cfd09185a16296c7e71 - 
Non-full name: Rafael
  
  I know it might seem silly, but please change your name to a full name so 
that your patch can pass the audit.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16815

To: trickyricky26, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D16815: Rename Sublime Text icon to ensure it works

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  Looks good to me!

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-sublime

REVISION DETAIL
  https://phabricator.kde.org/D16815

To: trickyricky26, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D16815: Rename Sublime Text icon to ensure it works

[TrickyRicky]

trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D16815

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16815: Rename Sublime Text icon to ensure it works

[TrickyRicky]

trickyricky26 created this revision.
trickyricky26 added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REVISION SUMMARY
  Renamed the Sublime Text icon from sublime.svg to sublime-text.svg to ensure 
it is used correctly in docks and everywhere else.

REPOSITORY
  R266 Breeze Icons

BRANCH
  fix-sublime

REVISION DETAIL
  https://phabricator.kde.org/D16815

AFFECTED FILES
  icons-dark/apps/48/sublime-text.svg
  icons-dark/apps/48/sublime.svg
  icons/apps/48/sublime-text.svg
  icons/apps/48/sublime.svg

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns