D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-27 Thread loh tar
loh.tar added a comment. @cullmann wrote: > Actually, if there is a astyle commandline that enforces the right style, could you paste it here? Um (?) I had in mind it was on the Kate HP but couln'd find it now. But it's there

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-26 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:5dde33b16bca: KateStatusBar: Reformatted by astyle command to follow coding style (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-26 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I am fine with that. Actually, if there is a astyle commandline that enforces the right style, could you paste it here? I am in favor of some script that runs that over the repo and

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-24 Thread Dominik Haumann
dhaumann added a subscriber: cullmann. dhaumann added a comment. I am fine with this change. @cullmann? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17729 To: loh.tar, #ktexteditor, dhaumann Cc: cullmann, sars, kwrite-devel, kde-frameworks-devel, #ktexteditor,

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-23 Thread loh tar
loh.tar updated this revision to Diff 48054. loh.tar added a comment. - Run astyle again, this time with "--align-pointer=name" - Omit changes done in the signal/slot connect code because these need a port to the new style. Well, was somehow pointless because these code is changed anyway

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-23 Thread loh tar
loh.tar added a comment. - It's a prearrangement for more changes D17730 - In the meantime I noticed that these astyle command did not move/fix to place "*&" to the right. I will update/fix this before someone like to commit REPOSITORY R39

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-23 Thread Kåre Särs
sars added a comment. +1 I think this is fine, but let Christoph and Dominik decide if we want style fixing commits. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17729 To: loh.tar, #ktexteditor, dhaumann Cc: sars, kwrite-devel, kde-frameworks-devel,

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-22 Thread loh tar
loh.tar added a comment. Nothing else was done REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17729 To: loh.tar, #ktexteditor, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-22 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL