This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0532047f8b97: [CopyJob] Report results after finishing
copy (authored by broulik).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D19585?vs=53345=61004
REVISION DETAIL
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
OK I see what you mean, after looking more at slotReport().
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19585
To: broulik, dfaure, chinmoyr
Cc:
broulik edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19585
To: broulik, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
It makes more sense to me to do the final report when we're fully done.
How about adding a case statement for STATE_SETTING_DIR_ATTRIBUTES to the
switch in slotReport?
This
chinmoyr added a comment.
> Opened Dolphin, Ctrl+C on a file, Ctrl+V it into the same folder, let it
sit at the "Override?" prompt until the job view in Plasma showed up. >Chose a
different filename and continued.
> [...]
> The URL isn't updated in case of a rename but I bet it just
broulik added a dependent revision: D19588: [Notifications] Improve finished
notification.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D19585
To: broulik, dfaure, chinmoyr
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
broulik created this revision.
broulik added reviewers: dfaure, chinmoyr.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Currently, `slotReport` is called all the way at the end when in
