D20959: Allow to change the Mode, after changing the Highlighting

[Christoph Cullmann]

cullmann closed this revision.
cullmann added a comment.


  Ok, regression taken care of in D21331 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20959

To: nibags, #ktexteditor, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D20959: Allow to change the Mode, after changing the Highlighting

[Nibaldo González]

nibags added a comment.


  errata: the `setDontChangeHlOnSave()` function has nothing to do here.
  more time I upload a patch.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20959

To: nibags, #ktexteditor, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D20959: Allow to change the Mode, after changing the Highlighting

[Nibaldo González]

nibags added a comment.


  The function `setDontChangeHlOnSave()` uses the `m_hlSetByUser` variable to 
avoid resetting the syntax highlighting, which I removed in `updateFileType()`.
  I could use another binary for this.

INLINE COMMENTS

> katedocument.cpp:1893
>  
>  void KTextEditor::DocumentPrivate::setDontChangeHlOnSave()
>  {

Apparently, the problem is here. "m_hlSetByUser" is used to avoid resetting the 
hl. I should create another binary varible for this.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20959

To: nibags, #ktexteditor, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D20959: Allow to change the Mode, after changing the Highlighting

[Christoph Cullmann]

cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Hi,
  could this lead to the following regression:
  
  https://bugs.kde.org/show_bug.cgi?id=407763

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D20959

To: nibags, #ktexteditor, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D20959: Allow to change the Mode, after changing the Highlighting

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:0a6ea0624228: Allow to change the Mode, after changing the 
Highlighting (authored by nibags).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20959?vs=57373&id=57455

REVISION DETAIL
  https://phabricator.kde.org/D20959

AFFECTED FILES
  src/document/katedocument.cpp

To: nibags, #ktexteditor, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D20959: Allow to change the Mode, after changing the Highlighting

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Sounds reasonable.

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-mode-highlight-menu

REVISION DETAIL
  https://phabricator.kde.org/D20959

To: nibags, #ktexteditor, #kate, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, 
bruns, demsking, sars, dhaumann

D20959: Allow to change the Mode, after changing the Highlighting

[Nibaldo González]

nibags created this revision.
nibags added reviewers: KTextEditor, Kate.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Currently, when selecting a language in the "Highlighting" menu, the "Mode" 
menu stops working. 
  This happens because, the Modes don't apply if `m_hlSetByUser` is true (if 
the user has chosen a Highlight in the menu). 
  This is swelling and I think it's better to change it. 
  Now when selecting a Mode, the "Highlighting" menu is also updated (but, when 
choosing an item in the Highlighting menu, the "Mode" menus don't change).

REPOSITORY
  R39 KTextEditor

BRANCH
  fix-mode-highlight-menu

REVISION DETAIL
  https://phabricator.kde.org/D20959

AFFECTED FILES
  src/document/katedocument.cpp

To: nibags, #ktexteditor, #kate
Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann