D21287: Try to find always an unique visible document name without a number suffix

2019-05-22 Thread loh tar
loh.tar added a comment. > the path is appended behind the document name. What about this solution? Don't like that idea. And fit not well to the shown "Document List" problem. > to be efficient one could hash all documents I'm always in favor for such. But here I had no idea how

D21287: Try to find always an unique visible document name without a number suffix

2019-05-22 Thread Christoph Cullmann
cullmann added a comment. I think for 2 one still needs a clever way to compute the "short" path. I think the document list tries to create shortest unique "suffixes". For 1) to be efficient one could hash all documents with "filename" => documents with that if file names changes, that woul

D21287: Try to find always an unique visible document name without a number suffix

2019-05-21 Thread Dominik Haumann
dhaumann added a comment. There even is a bug report about this: https://bugs.kde.org/show_bug.cgi?id=381532 In this bug report, there is also an example of how sublime text handles this, namely "Document name - path/bla", i.e. the path is appended behind the document name. What about this

D21287: Try to find always an unique visible document name without a number suffix

2019-05-19 Thread loh tar
loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21287 To: loh.tar, #ktexteditor Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, domson, michaelh, ngraham, bruns, demsking, sars

D21287: Try to find always an unique visible document name without a number suffix

2019-05-19 Thread loh tar
loh.tar added a comment. > PS: The tab switcher also has something similar to make a distiction between files with the same name D16054 I noticed this patch. It's more a workaround for the core issue. > besides that the quick open already sh

D21287: Try to find always an unique visible document name without a number suffix

2019-05-19 Thread Dominik Haumann
dhaumann added a comment. Looking at the screenshots, I find it rather intransparent which document gets what name, besides that the quick open already shows the path to distinguish the files -> is this really an improvement? And: I have the feeling this patch should pay attention to per

D21287: Try to find always an unique visible document name without a number suffix

2019-05-19 Thread Christoph Cullmann
cullmann added a comment. I like the idea of having better short document names without numbers. The algo looks a bit like what the document list tries to do with the shortest paths differentiating two files. I think the documents stuff ignores the changed doc names as it looks for file n

D21287: Try to find always an unique visible document name without a number suffix

2019-05-19 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY When you e.g. work on multiple projects at the same time you ha