D22717: Add Date term to KActivities Stats to filter on resource event date

meven added inline comments. INLINE COMMENTS > resultset.cpp:399 > +AND from_table.usedActivity = rsc.usedActivity > AND rl.initiatingAgent = rsc.initiatingAgent > Missing table name update fix in D26798

D22717: Add Date term to KActivities Stats to filter on resource event date

This revision was automatically updated to reflect the committed changes. Closed by commit R159:bdba31fac999: Add Date term to KActivities Stats to filter on resource event date (authored by meven). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D22717: Add Date term to KActivities Stats to filter on resource event date

meven edited the summary of this revision. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D22717 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

ivan accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D22717 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

meven marked 2 inline comments as done. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22717 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

meven marked 3 inline comments as done. meven added inline comments. INLINE COMMENTS > ivan wrote in resultset.cpp:293 > Any reason for the rename? It is so that the ResourceEvent join in resourceEventJoinClause works with every sql request. Other wise I would have needed a parameter or multip

D22717: Add Date term to KActivities Stats to filter on resource event date

ivan added inline comments. INLINE COMMENTS > resultset.cpp:293 > SELECT > -rl.targettedResource as resource > - , SUM(rsc.cachedScore) as score > - , MIN(rsc.firstUpdate) as firstUpdate > - , MAX(rsc.lastUpdate) as lastUpdate >

D22717: Add Date term to KActivities Stats to filter on resource event date

meven marked an inline comment as done. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22717 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

meven edited the test plan for this revision. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22717 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

meven updated this revision to Diff 62522. meven added a comment. Add an automated test on date filtering REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22717?vs=62520&id=62522 BRANCH master REVISION DETAIL https://phabricator.kde.org/D

D22717: Add Date term to KActivities Stats to filter on resource event date

meven marked 2 inline comments as done. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D22717 To: meven, ivan, #frameworks Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22717: Add Date term to KActivities Stats to filter on resource event date

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > ivan wrote in resultset.cpp:182 > setDate above is by value, here it is const-ref. Check for the size of the > type and decide on one of these. QDate size is 8 byte, so on most systems nowadays it will equal

D22717: Add Date term to KActivities Stats to filter on resource event date

meven updated this revision to Diff 62520. meven added a comment. Optionaly join with ResourceEvent when date filtering is being used, review feedback REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22717?vs=62473&id=62520 BRANCH master R

D22717: Add Date term to KActivities Stats to filter on resource event date

ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. Joining with `ResourceEvent` is a problem. At least make it not get joined if the date filter is not present. INLINE COMMENTS > QueryTest.h:53 > void testFancySyntaxOrderingDefi

D22717: Add Date term to KActivities Stats to filter on resource event date

meven updated this revision to Diff 62473. meven added a comment. Improve sql padding REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22717?vs=62472&id=62473 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22717 AFFECTED FILE

D22717: Add Date term to KActivities Stats to filter on resource event date

meven created this revision. meven added reviewers: ivan, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Add a Term Date to Query to filter on ResourceEvent start column when querying for