D23119: Fix dates being on the wrong locale when setting an application language individually

asemke added a comment. In D23119#519676 , @asemke wrote: > The original problem in LabPlot was reported by a windows user. The proposed fix won't fix the problem on windows. I think the only way to get the proper strings on Windows is to get

D23119: Fix dates being on the wrong locale when setting an application language individually

asemke added a comment. In D23119#524720 , @aacid wrote: > In D23119#519676 , @asemke wrote: > > > The original problem in LabPlot was reported by a windows user. The proposed fix won't fix the

D23119: Fix dates being on the wrong locale when setting an application language individually

aacid added a comment. In D23119#519676 , @asemke wrote: > The original problem in LabPlot was reported by a windows user. The proposed fix won't fix the problem on windows. I think the only way to get the proper strings on Windows is to get

D23119: Fix dates being on the wrong locale when setting an application language individually

asemke added a comment. The original problem in LabPlot was reported by a windows user. The proposed fix won't fix the problem on windows. I think the only way to get the proper strings on Windows is to get the current language of the application, to create a QLocale with the proper

D23119: Fix dates being on the wrong locale when setting an application language individually

asemke added inline comments. INLINE COMMENTS > asemke wrote in kxmlgui_unittest.cpp:1089 > This is maybe not Qt but the locale defintion files which are probably distro > specific. I just checked on SLES and on openSuse. > > for ukrainian: > > LC_TIME=uk_UA.UTF-8 locale mon > >

D23119: Fix dates being on the wrong locale when setting an application language individually

asemke added inline comments. INLINE COMMENTS > yurchor wrote in kxmlgui_unittest.cpp:1089 > AFAIK this is broken on Qt level. Cf. calendar widget in KOrganizer > (Ukrainian) > > F7273188: cal.png > > https://bugs.kde.org/show_bug.cgi?id=256952 > >

D23119: Fix dates being on the wrong locale when setting an application language individually

yurchor added inline comments. INLINE COMMENTS > asemke wrote in kxmlgui_unittest.cpp:1089 > there is no declension in Russian for the nominative case. The name of the > month is январь and not января, but it is первого января (on January 1st) and > not первого январь. > >

D23119: Fix dates being on the wrong locale when setting an application language individually

asemke added inline comments. INLINE COMMENTS > ltoscano wrote in kxmlgui_unittest.cpp:1089 > Declensions: > https://en.wiktionary.org/wiki/%D1%8F%D0%BD%D0%B2%D0%B0%D1%80%D1%8C#Declension there is no declension in Russian for the nominative case. The name of the month is январь and not

D23119: Fix dates being on the wrong locale when setting an application language individually

aacid updated this revision to Diff 64176. aacid edited the summary of this revision. aacid removed a subscriber: ltoscano. aacid added a comment. update commit log REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23119?vs=63633=64176 BRANCH

D23119: Fix dates being on the wrong locale when setting an application language individually

ltoscano added inline comments. INLINE COMMENTS > asemke wrote in kxmlgui_unittest.cpp:1089 > does this test work? The name of the month is "январь" in russian, not > "января". Declensions: https://en.wiktionary.org/wiki/%D1%8F%D0%BD%D0%B2%D0%B0%D1%80%D1%8C#Declension REPOSITORY R263

D23119: Fix dates being on the wrong locale when setting an application language individually

aacid added inline comments. INLINE COMMENTS > asemke wrote in kxmlgui_unittest.cpp:1089 > does this test work? The name of the month is "январь" in russian, not > "января". Yes, it may surprise you, but i did actually run the tests before submitting this code change. REPOSITORY R263

D23119: Fix dates being on the wrong locale when setting an application language individually

asemke added inline comments. INLINE COMMENTS > kxmlgui_unittest.cpp:1089 > QCOMPARE(QLocale::system().language(), QLocale::Russian); > +QCOMPARE(QLocale::system().monthName(1), QString::fromUtf8("января")); > does this test work? The name of the month is "январь" in russian, not

D23119: Fix dates being on the wrong locale when setting an application language individually

apol added a comment. LGTM +1 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D23119 To: aacid Cc: apol, kde-frameworks-devel, asemke, LeGast00n, michaelh, ngraham, bruns

D23119: Fix dates being on the wrong locale when setting an application language individually

aacid added a comment. hmmm, now that i think about it LC_ALL probably needs a .UTF-8 suffix or something to be correct But OTOH this is working fine for me. comments? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D23119 To: aacid Cc:

D23119: Fix dates being on the wrong locale when setting an application language individually

aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY We were only setting LANGUAGE, but that does not set LC_TIME so the time was still set to the "system" locale, we now