dhaumann added a comment.
Oh, in that case can you or @cullmann simply revert this part or #ifdef it? I
currently cannot at least until the weekend (sorry!).
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D23385
To: dhaumann, cullmann
Cc: dvratil, kwrite-devel, k
dvratil added inline comments.
INLINE COMMENTS
> katedocument.cpp:4676
> foreach (const QString &pattern, wildcards) {
> -QRegExp wildcard(pattern, Qt::CaseSensitive, QRegExp::Wildcard);
> +QRegularExpression wildcard(QLatin1Char('^') +
> QRegularExpression::wild
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:b5c37d88de4e: More porting from QRegExp to
QRegularExpression (authored by dhaumann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23385?vs=64443&id=64509
REVI
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Thanks!
REPOSITORY
R39 KTextEditor
BRANCH
port-qregexp
REVISION DETAIL
https://phabricator.kde.org/D23385
To: dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00
dhaumann updated this revision to Diff 64443.
dhaumann added a comment.
- Add static and const where applicable
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23385?vs=64441&id=64443
BRANCH
port-qregexp
REVISION DETAIL
https://phabricator.kde.org/D
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.
I would tend to make more stuff "static const QRegularExpression", given
QRegularExpression unlike QRegExp has not the issue of storing matches inside
itself.
REPOSITORY
R3
dhaumann created this revision.
dhaumann added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dhaumann requested review of this revision.
REVISION SUMMARY
Less deprecated QRegExp usage.
TEST PLAN
- KTextEditor::Comm
