D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

This revision was automatically updated to reflect the committed changes. Closed by commit R241:14c6c0007c42: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24928?vs=68836&id=

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Let's get this in now that 5.64 is out. REPOSITORY R241 KIO BRANCH ahmad/tcpslavebase (branched from master) REVISION DETAIL https://phabricator.kde.org/D24928 To: ahmadsamir, dfa

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a comment. In D24928#554731 , @vkrause wrote: > In D24928#554720 , @ahmadsamir wrote: > > > So, we ditch digestMethod but keep the rest? ecryptionMethod/authenticationMethod/keyExch

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir updated this revision to Diff 68836. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24928?vs=68834&id=68836 BRANCH ahmad/tcpslavebase (branched from master) REVI

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir updated this revision to Diff 68834. ahmadsamir added a comment. cipher.name() is deemed sufficient when setting the ssl MetaData REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24928?vs=68701&id=68834 BRANCH ahmad/tcpslavebase (branched from maste

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

vkrause added a comment. In D24928#554720 , @ahmadsamir wrote: > So, we ditch digestMethod but keep the rest? ecryptionMethod/authenticationMethod/keyExchangeMethod can be deduced from the name() sometimes, but some others, not so obvious:

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a comment. So, we ditch digestMethod but keep the rest? ecryptionMethod/authenticationMethod/keyExchangeMethod can be deduced from the name() sometimes, but some others, not so obvious: Name: "TLS_AES_256_GCM_SHA384" Encryption method: "AESGCM(256)" Auth meth

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

vkrause added a comment. In D24928#554514 , @ahmadsamir wrote: > In D24928#553952 , @vkrause wrote: > > > The cipher naming stuff looks very fishy though, that's not due to your changes though but

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a comment. In D24928#553952 , @vkrause wrote: > The cipher naming stuff looks very fishy though, that's not due to your changes though but coming from old KSslCipher code. I'm wondering where the ssl_cipher meta data is being co

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

vkrause added a comment. In general I think this looks very good already! The cipher naming stuff looks very fishy though, that's not due to your changes though but coming from old KSslCipher code. I'm wondering where the ssl_cipher meta data is being consumed? If this is purely used for di

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a comment. Is cipherDigestMethod() (method @ line 96) needed? the cipher name is inserted in sslMetaData a couple of lines after that. Using some test code: QList list = QSslConfiguration::supportedCiphers(); for (QSslCipher c : list) { qInfo() << c.name();

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a dependent revision: D24929: [pop3 kioslave] Port KTcpSocket (deprecated) to QSslSocket. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24928 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a dependent revision: D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24928 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, vkrause. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Also add a method similar to KSslCipher::digestMethod() to TcpSlaveBase. REPOSITORY R241 KIO BRANCH ahmad/tcpsla