D26133: Enable Auto Save

apol added a comment. In D26133#603118 , @tcanabrava wrote: > > That's why personally I think it's fine to assume people need to opt-in for GenerateProperties if they want the feature, it's closely related after all. > > I disagree here.

D26133: Enable Auto Save

tcanabrava added a comment. > That's why personally I think it's fine to assume people need to opt-in for GenerateProperties if they want the feature, it's closely related after all. I disagree here. my application can be a simple QWidget based and have a KConfigXT enabled

D26133: Enable Auto Save

ervin added a comment. Maybe look at KConfigCompilerSignallingItem? But I don't see another way of doing it than a wrapper approach like KConfigCompilerSignallingItem does... but then that's why ManagedConfigModule assumes GenerateProperties=true in the kcfgc, otherwise we'd have hacked the

D26133: Enable Auto Save

tcanabrava added a comment. I agree with the comments, but I'm a bit lost on how to implement that in KCoreConfigSkeleton: the isSaveNeeded reads the value of the variable and return if it's different from the reference variable. (that I tougth it was a reference *value*, to find out that

D26133: Enable Auto Save

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > apol wrote in test_signal.h.ref:137 > How about having `isSaveNeededChanged(bool)`? It could be in > KCoreConfigSkeleton. Damn, and I was wondering which

D26133: Enable Auto Save

apol added inline comments. INLINE COMMENTS > test_signal.h.ref:137 > +/** Triggered whenever a setting changes */ > +void configurationChanged(); > + How about having `isSaveNeededChanged(bool)`? It could be in KCoreConfigSkeleton. > kconfig_compiler.cpp:2121 > } > -

D26133: Enable Auto Save

tcanabrava updated this revision to Diff 72110. tcanabrava added a comment. - Use a timer of 1s to trigger the save REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26133?vs=71920=72110 BRANCH enableAutoSave REVISION DETAIL

D26133: Enable Auto Save

tcanabrava updated this revision to Diff 72111. tcanabrava added a comment. - Emit `configurationChanged()` when any configuration changes REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26133?vs=72110=72111 BRANCH enableAutoSave REVISION DETAIL

D26133: Enable Auto Save

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. In D26133#581832 , @tcanabrava wrote: > Because not all apps that use KConfigXT use a KCM, and I don't want to make > it necessary

Re: D26133: Enable Auto Save

Because not all apps that use KConfigXT use a KCM, and I don't want to make it necessary to do so. This particular change is done with Kirogi in mind (that does not uses a KCM, and it's a pure QtQuick / Kirigami app, but uses KConfigXT) I'll add the testcase. On Mon, 23 Dec 2019 at 03:02 Aleix

D26133: Enable Auto Save

apol added a comment. It could make sense to add a test. Also for an application (system settings or kconfig dialogs) it's already possible to just trigger save when the kcm has changed (we already have signals for this). Why do you think it's needed? REPOSITORY R237 KConfig

D26133: Enable Auto Save

tcanabrava updated this revision to Diff 71920. tcanabrava added a comment. - Use a timer of 1s to trigger the save REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26133?vs=71916=71920 BRANCH enableAutoSave REVISION DETAIL

D26133: Enable Auto Save

ngraham edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26133 To: tcanabrava Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26133: Enable Auto Save

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY Some applications don't want the `wait for apply / ok / cancel` and prefer to automatically save the settings